Whamcloud - gitweb
git://git.whamcloud.com / tools / e2fsprogs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6dd8354) | patch
e2fsck: avoid memory corruption on ext2fs_open2 failure
authorNickolai Zeldovich <nickolai@csail.mit.edu>
Tue, 8 Jan 2013 20:45:31 +0000 (15:45 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 9 Jan 2013 01:42:26 +0000 (20:42 -0500)
commita046da5963649663933cf16d54ca2a892cc1a560
tree763f0f4fbe1a9db3b025c37c801a3d9701c86d49tree | snapshot
parent6dd83548f4193f8bfd7983240471db0d0c7af626commit | diff
e2fsck: avoid memory corruption on ext2fs_open2 failure

In try_open_fs(), if ext2fs_open2() returns an error, do not try to
access the struct ext2_filesys.  The previous check 'if (ret_fs)' was
always true, but even 'if (*ret_fs)' might be incorrect in some cases,
so check 'retval==0' instead.

Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
e2fsck/unix.c diff | blob | history
Mirror of git://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git