Whamcloud - gitweb
filefrag: fix an off by one error in when printing the next expected block
[tools/e2fsprogs.git] / misc / tune2fs.c
index d0d44c8..e2fdb4a 100644 (file)
@@ -73,6 +73,7 @@ char *io_options;
 static int c_flag, C_flag, e_flag, f_flag, g_flag, i_flag, l_flag, L_flag;
 static int m_flag, M_flag, Q_flag, r_flag, s_flag = -1, u_flag, U_flag, T_flag;
 static int I_flag;
+static int clear_mmp;
 static time_t last_check_time;
 static int print_label;
 static int max_mount_count, mount_count, mount_flags;
@@ -116,7 +117,7 @@ static void usage(void)
                  "[-g group]\n"
                  "\t[-i interval[d|m|w]] [-j] [-J journal_options] [-l]\n"
                  "\t[-m reserved_blocks_percent] "
-                 "[-o [^]mount_options[,...]] \n"
+                 "[-o [^]mount_options[,...]] [-p mmp_update_interval]\n"
                  "\t[-r reserved_blocks_count] [-u user] [-C mount_count] "
                  "[-L volume_label]\n"
                  "\t[-M last_mounted_dir] [-O [^]feature[,...]]\n"
@@ -132,7 +133,8 @@ static __u32 ok_features[3] = {
        /* Incompat */
        EXT2_FEATURE_INCOMPAT_FILETYPE |
                EXT3_FEATURE_INCOMPAT_EXTENTS |
-               EXT4_FEATURE_INCOMPAT_FLEX_BG,
+               EXT4_FEATURE_INCOMPAT_FLEX_BG |
+               EXT4_FEATURE_INCOMPAT_MMP,
        /* R/O compat */
        EXT2_FEATURE_RO_COMPAT_LARGE_FILE |
                EXT4_FEATURE_RO_COMPAT_HUGE_FILE|
@@ -150,7 +152,8 @@ static __u32 clear_ok_features[3] = {
                EXT2_FEATURE_COMPAT_DIR_INDEX,
        /* Incompat */
        EXT2_FEATURE_INCOMPAT_FILETYPE |
-               EXT4_FEATURE_INCOMPAT_FLEX_BG,
+               EXT4_FEATURE_INCOMPAT_FLEX_BG |
+               EXT4_FEATURE_INCOMPAT_MMP,
        /* R/O compat */
        EXT2_FEATURE_RO_COMPAT_LARGE_FILE |
                EXT4_FEATURE_RO_COMPAT_HUGE_FILE|
@@ -163,7 +166,7 @@ static __u32 clear_ok_features[3] = {
 /*
  * Remove an external journal from the filesystem
  */
-static void remove_journal_device(ext2_filsys fs)
+static int remove_journal_device(ext2_filsys fs)
 {
        char            *journal_path;
        ext2_filsys     jfs;
@@ -202,7 +205,8 @@ static void remove_journal_device(ext2_filsys fs)
                        _("while trying to open external journal"));
                goto no_valid_journal;
        }
-       if (!(jfs->super->s_feature_incompat & EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)) {
+       if (!(jfs->super->s_feature_incompat &
+             EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)) {
                fprintf(stderr, _("%s is not a journal device.\n"),
                        journal_path);
                goto no_valid_journal;
@@ -216,8 +220,8 @@ static void remove_journal_device(ext2_filsys fs)
        }
 
        jsb = (journal_superblock_t *) buf;
-       if ((jsb->s_header.h_magic != (unsigned) ntohl(JFS_MAGIC_NUMBER)) ||
-           (jsb->s_header.h_blocktype != (unsigned) ntohl(JFS_SUPERBLOCK_V2))) {
+       if ((jsb->s_header.h_magic != (unsigned)ntohl(JFS_MAGIC_NUMBER)) ||
+           (jsb->s_header.h_blocktype != (unsigned)ntohl(JFS_SUPERBLOCK_V2))) {
                fputs(_("Journal superblock not found!\n"), stderr);
                goto no_valid_journal;
        }
@@ -225,8 +229,7 @@ static void remove_journal_device(ext2_filsys fs)
        /* Find the filesystem UUID */
        nr_users = ntohl(jsb->s_nr_users);
        for (i = 0; i < nr_users; i++) {
-               if (memcmp(fs->super->s_uuid,
-                          &jsb->s_users[i*16], 16) == 0)
+               if (memcmp(fs->super->s_uuid, &jsb->s_users[i * 16], 16) == 0)
                        break;
        }
        if (i >= nr_users) {
@@ -237,7 +240,7 @@ static void remove_journal_device(ext2_filsys fs)
        }
        nr_users--;
        for (i = 0; i < nr_users; i++)
-               memcpy(&jsb->s_users[i*16], &jsb->s_users[(i+1)*16], 16);
+               memcpy(&jsb->s_users[i * 16], &jsb->s_users[(i + 1) * 16], 16);
        jsb->s_nr_users = htonl(nr_users);
 
        /* Write back the journal superblock */
@@ -254,13 +257,15 @@ no_valid_journal:
                fputs(_("Cannot locate journal device. It was NOT removed\n"
                        "Use -f option to remove missing journal device.\n"),
                      stderr);
-               exit(1);
+               return 1;
        }
        fs->super->s_journal_dev = 0;
        uuid_clear(fs->super->s_journal_uuid);
        ext2fs_mark_super_dirty(fs);
        fputs(_("Journal removed\n"), stdout);
        free(journal_path);
+
+       return 0;
 }
 
 /* Helper function for remove_journal_inode */
@@ -285,7 +290,7 @@ static int release_blocks_proc(ext2_filsys fs, blk64_t *blocknr,
 /*
  * Remove the journal inode from the filesystem
  */
-static void remove_journal_inode(ext2_filsys fs)
+static errcode_t remove_journal_inode(ext2_filsys fs)
 {
        struct ext2_inode       inode;
        errcode_t               retval;
@@ -295,14 +300,14 @@ static void remove_journal_inode(ext2_filsys fs)
        if (retval) {
                com_err(program_name, retval,
                        _("while reading journal inode"));
-               exit(1);
+               return retval;
        }
        if (ino == EXT2_JOURNAL_INO) {
                retval = ext2fs_read_bitmaps(fs);
                if (retval) {
                        com_err(program_name, retval,
                                _("while reading bitmaps"));
-                       exit(1);
+                       return retval;
                }
                retval = ext2fs_block_iterate3(fs, ino,
                                               BLOCK_FLAG_READ_ONLY, NULL,
@@ -310,7 +315,7 @@ static void remove_journal_inode(ext2_filsys fs)
                if (retval) {
                        com_err(program_name, retval,
                                _("while clearing journal inode"));
-                       exit(1);
+                       return retval;
                }
                memset(&inode, 0, sizeof(inode));
                ext2fs_mark_bb_dirty(fs);
@@ -321,25 +326,29 @@ static void remove_journal_inode(ext2_filsys fs)
        if (retval) {
                com_err(program_name, retval,
                        _("while writing journal inode"));
-               exit(1);
+               return retval;
        }
        fs->super->s_journal_inum = 0;
        ext2fs_mark_super_dirty(fs);
+
+       return 0;
 }
 
 /*
  * Update the default mount options
  */
-static void update_mntopts(ext2_filsys fs, char *mntopts)
+static int update_mntopts(ext2_filsys fs, char *mntopts)
 {
        struct ext2_super_block *sb = fs->super;
 
        if (e2p_edit_mntopts(mntopts, &sb->s_default_mount_opts, ~0)) {
                fprintf(stderr, _("Invalid mount option set: %s\n"),
                        mntopts);
-               exit(1);
+               return 1;
        }
        ext2fs_mark_super_dirty(fs);
+
+       return 0;
 }
 
 static void request_fsck_afterwards(ext2_filsys fs)
@@ -357,7 +366,7 @@ static void request_fsck_afterwards(ext2_filsys fs)
 /*
  * Update the feature set as provided by the user.
  */
-static void update_feature_set(ext2_filsys fs, char *features)
+static int update_feature_set(ext2_filsys fs, char *features)
 {
        struct ext2_super_block *sb = fs->super;
        struct ext2_group_desc *gd;
@@ -393,7 +402,7 @@ static void update_feature_set(ext2_filsys fs, char *features)
                        fprintf(stderr, _("Setting filesystem feature '%s' "
                                          "not supported.\n"),
                                e2p_feature2string(type_err, mask_err));
-               exit(1);
+               return 1;
        }
 
        if (FEATURE_OFF(E2P_FEATURE_COMPAT, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) {
@@ -403,22 +412,89 @@ static void update_feature_set(ext2_filsys fs, char *features)
                                "cleared when the filesystem is\n"
                                "unmounted or mounted "
                                "read-only.\n"), stderr);
-                       exit(1);
+                       return 1;
                }
                if (sb->s_feature_incompat &
                    EXT3_FEATURE_INCOMPAT_RECOVER) {
                        fputs(_("The needs_recovery flag is set.  "
                                "Please run e2fsck before clearing\n"
                                "the has_journal flag.\n"), stderr);
-                       exit(1);
+                       return 1;
                }
                if (sb->s_journal_inum) {
-                       remove_journal_inode(fs);
+                       if (remove_journal_inode(fs))
+                               return 1;
                }
                if (sb->s_journal_dev) {
-                       remove_journal_device(fs);
+                       if (remove_journal_device(fs))
+                               return 1;
                }
        }
+       if (FEATURE_ON(E2P_FEATURE_INCOMPAT, EXT4_FEATURE_INCOMPAT_MMP)) {
+               int error;
+
+               if ((mount_flags & EXT2_MF_MOUNTED) ||
+                   (mount_flags & EXT2_MF_READONLY)) {
+                       fputs(_("The multiple mount protection feature can't\n"
+                               "be set if the filesystem is mounted or\n"
+                               "read-only.\n"), stderr);
+                       return 1;
+               }
+
+               error = ext2fs_mmp_init(fs);
+               if (error) {
+                       fputs(_("\nError while enabling multiple mount "
+                               "protection feature."), stderr);
+                       return 1;
+               }
+
+               /*
+                * We want to update group desc with the new free blocks count
+                */
+               fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
+
+               printf(_("Multiple mount protection has been enabled "
+                        "with update interval %ds.\n"),
+                      sb->s_mmp_update_interval);
+       }
+
+       if (FEATURE_OFF(E2P_FEATURE_INCOMPAT, EXT4_FEATURE_INCOMPAT_MMP)) {
+               int error;
+
+               if (mount_flags & EXT2_MF_READONLY) {
+                       fputs(_("The multiple mount protection feature cannot\n"
+                               "be disabled if the filesystem is readonly.\n"),
+                               stderr);
+                       return 1;
+               }
+
+               error = ext2fs_read_bitmaps(fs);
+               if (error) {
+                       fputs(_("Error while reading bitmaps\n"), stderr);
+                       return 1;
+               }
+
+               error = ext2fs_mmp_read(fs, sb->s_mmp_block, NULL);
+               if (error) {
+                       struct mmp_struct *mmp_cmp = fs->mmp_cmp;
+
+                       if (error == EXT2_ET_MMP_MAGIC_INVALID)
+                               printf(_("Magic number in MMP block does not "
+                                        "match. expected: %x, actual: %x\n"),
+                                        EXT4_MMP_MAGIC, mmp_cmp->mmp_magic);
+                       else
+                               com_err(program_name, error,
+                                       _("while reading MMP block."));
+                       goto mmp_error;
+               }
+
+               /* We need to force out the group descriptors as well */
+               fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
+               ext2fs_block_alloc_stats(fs, sb->s_mmp_block, -1);
+mmp_error:
+               sb->s_mmp_block = 0;
+               sb->s_mmp_update_interval = 0;
+       }
 
        if (FEATURE_ON(E2P_FEATURE_COMPAT, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) {
                /*
@@ -443,7 +519,7 @@ static void update_feature_set(ext2_filsys fs, char *features)
                        fputs(_("Clearing the flex_bg flag would "
                                "cause the the filesystem to be\n"
                                "inconsistent.\n"), stderr);
-                       exit(1);
+                       return 1;
                }
        }
 
@@ -455,7 +531,7 @@ static void update_feature_set(ext2_filsys fs, char *features)
                                "cleared when the filesystem is\n"
                                "unmounted or mounted "
                                "read-only.\n"), stderr);
-                       exit(1);
+                       return 1;
                }
        }
 
@@ -540,12 +616,14 @@ static void update_feature_set(ext2_filsys fs, char *features)
            (old_features[E2P_FEATURE_INCOMPAT] != sb->s_feature_incompat) ||
            (old_features[E2P_FEATURE_RO_INCOMPAT] != sb->s_feature_ro_compat))
                ext2fs_mark_super_dirty(fs);
+
+       return 0;
 }
 
 /*
  * Add a journal to the filesystem.
  */
-static void add_journal(ext2_filsys fs)
+static int add_journal(ext2_filsys fs)
 {
        unsigned long journal_blocks;
        errcode_t       retval;
@@ -600,7 +678,7 @@ static void add_journal(ext2_filsys fs)
                        fprintf(stderr, "\n");
                        com_err(program_name, retval,
                                _("\n\twhile trying to create journal file"));
-                       exit(1);
+                       return retval;
                } else
                        fputs(_("done\n"), stdout);
                /*
@@ -612,11 +690,11 @@ static void add_journal(ext2_filsys fs)
        }
        print_check_message(fs->super->s_max_mnt_count,
                            fs->super->s_checkinterval);
-       return;
+       return 0;
 
 err:
        free(journal_device);
-       exit(1);
+       return 1;
 }
 
 void handle_quota_options(ext2_filsys fs)
@@ -916,7 +994,6 @@ static void parse_tune2fs_options(int argc, char **argv)
                        mntopts_cmd = optarg;
                        open_flag = EXT2_FLAG_RW;
                        break;
-                       
                case 'O':
                        if (features_cmd) {
                                com_err(program_name, 0,
@@ -1035,7 +1112,7 @@ void do_findfs(int argc, char **argv)
 }
 #endif
 
-static void parse_extended_opts(ext2_filsys fs, const char *opts)
+static int parse_extended_opts(ext2_filsys fs, const char *opts)
 {
        char    *buf, *token, *next, *p, *arg;
        int     len, hash_alg;
@@ -1046,7 +1123,7 @@ static void parse_extended_opts(ext2_filsys fs, const char *opts)
        if (!buf) {
                fprintf(stderr,
                        _("Couldn't allocate memory to parse options!\n"));
-               exit(1);
+               return 1;
        }
        strcpy(buf, opts);
        for (token = buf; token && *token; token = next) {
@@ -1061,7 +1138,37 @@ static void parse_extended_opts(ext2_filsys fs, const char *opts)
                        *arg = 0;
                        arg++;
                }
-               if (!strcmp(token, "test_fs")) {
+               if (strcmp(token, "clear-mmp") == 0 ||
+                   strcmp(token, "clear_mmp") == 0) {
+                       clear_mmp = 1;
+               } else if (strcmp(token, "mmp_update_interval") == 0) {
+                       unsigned long interval;
+                       if (!arg) {
+                               r_usage++;
+                               continue;
+                       }
+                       interval = strtoul(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr,
+                                       _("Invalid mmp_update_interval: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
+                       if (interval == 0) {
+                               interval = EXT4_MMP_UPDATE_INTERVAL;
+                       } else if (interval > EXT4_MMP_MAX_UPDATE_INTERVAL) {
+                               fprintf(stderr,
+                                       _("mmp_update_interval too big: %lu\n"),
+                                       interval);
+                               r_usage++;
+                               continue;
+                       }
+                       printf(_("Setting multiple mount protection update "
+                                "interval to %lu seconds\n"), interval);
+                       fs->super->s_mmp_update_interval = interval;
+                       ext2fs_mark_super_dirty(fs);
+               } else if (!strcmp(token, "test_fs")) {
                        fs->super->s_flags |= EXT2_FLAGS_TEST_FILESYS;
                        printf("Setting test filesystem flag\n");
                        ext2fs_mark_super_dirty(fs);
@@ -1077,7 +1184,7 @@ static void parse_extended_opts(ext2_filsys fs, const char *opts)
                        stride = strtoul(arg, &p, 0);
                        if (*p) {
                                fprintf(stderr,
-                                      _("Invalid RAID stride: %s\n"),
+                                       _("Invalid RAID stride: %s\n"),
                                        arg);
                                r_usage++;
                                continue;
@@ -1137,6 +1244,7 @@ static void parse_extended_opts(ext2_filsys fs, const char *opts)
                        "and may take an argument which\n"
                        "\tis set off by an equals ('=') sign.\n\n"
                        "Valid extended options are:\n"
+                       "\tclear_mmp\n"
                        "\thash_alg=<hash algorithm>\n"
                        "\tmount_opts=<extended default mount options>\n"
                        "\tstride=<RAID per-disk chunk size in blocks>\n"
@@ -1144,9 +1252,11 @@ static void parse_extended_opts(ext2_filsys fs, const char *opts)
                        "\ttest_fs\n"
                        "\t^test_fs\n"));
                free(buf);
-               exit(1);
+               return 1;
        }
        free(buf);
+
+       return 0;
 }
 
 /*
@@ -1735,6 +1845,7 @@ int main(int argc, char **argv)
        ext2_filsys fs;
        struct ext2_super_block *sb;
        io_manager io_ptr, io_ptr_orig = NULL;
+       int rc = 0;
 
 #ifdef ENABLE_NLS
        setlocale(LC_MESSAGES, "");
@@ -1764,14 +1875,37 @@ int main(int argc, char **argv)
                io_ptr = unix_io_manager;
 
 retry_open:
+       if ((open_flag & EXT2_FLAG_RW) == 0 || f_flag)
+               open_flag |= EXT2_FLAG_SKIP_MMP;
+
+       open_flag |= EXT2_FLAG_64BITS;
+
+       /* keep the filesystem struct around to dump MMP data */
+       open_flag |= EXT2_FLAG_NOFREE_ON_ERROR;
+
        retval = ext2fs_open2(device_name, io_options, open_flag,
                              0, 0, io_ptr, &fs);
        if (retval) {
-                       com_err(program_name, retval,
-                               _("while trying to open %s"),
+               com_err(program_name, retval,
+                       _("while trying to open %s"),
                        device_name);
-               fprintf(stderr,
-                       _("Couldn't find valid filesystem superblock.\n"));
+               if (retval == EXT2_ET_MMP_FSCK_ON ||
+                   retval == EXT2_ET_MMP_UNKNOWN_SEQ)
+                       dump_mmp_msg(fs->mmp_buf,
+                                    _("If you are sure the filesystem "
+                                      "is not in use on any node, run:\n"
+                                      "'tune2fs -f -E clear_mmp {device}'\n"));
+               else if (retval == EXT2_ET_MMP_FAILED)
+                       dump_mmp_msg(fs->mmp_buf, NULL);
+               else if (retval == EXT2_ET_MMP_MAGIC_INVALID)
+                       fprintf(stderr,
+                               _("MMP block magic is bad. Try to fix it by "
+                                 "running:\n'e2fsck -f %s'\n"), device_name);
+               else if (retval != EXT2_ET_MMP_FAILED)
+                       fprintf(stderr,
+                            _("Couldn't find valid filesystem superblock.\n"));
+
+               ext2fs_free(fs);
                exit(1);
        }
 
@@ -1784,12 +1918,14 @@ retry_open:
                if (new_inode_size == EXT2_INODE_SIZE(fs->super)) {
                        fprintf(stderr, _("The inode size is already %lu\n"),
                                new_inode_size);
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
                if (new_inode_size < EXT2_INODE_SIZE(fs->super)) {
                        fprintf(stderr, _("Shrinking the inode size is "
                                          "not supported\n"));
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
 
                /*
@@ -1798,8 +1934,10 @@ retry_open:
                 */
                io_ptr_orig = io_ptr;
                retval = tune2fs_setup_tdb(device_name, &io_ptr);
-               if (retval)
-                       exit(1);
+               if (retval) {
+                       rc = 1;
+                       goto closefs;
+               }
                if (io_ptr != io_ptr_orig) {
                        ext2fs_close(fs);
                        goto retry_open;
@@ -1814,7 +1952,7 @@ retry_open:
                printf("%.*s\n", (int) sizeof(sb->s_volume_name),
                       sb->s_volume_name);
                remove_error_table(&et_ext2_error_table);
-               exit(0);
+               goto closefs;
        }
 
        retval = ext2fs_check_if_mounted(device_name, &mount_flags);
@@ -1822,7 +1960,8 @@ retry_open:
                com_err("ext2fs_check_if_mount", retval,
                        _("while determining whether %s is mounted."),
                        device_name);
-               exit(1);
+               rc = 1;
+               goto closefs;
        }
        /* Normally we only need to write out the superblock */
        fs->flags |= EXT2_FLAG_SUPER_ONLY;
@@ -1853,7 +1992,8 @@ retry_open:
                        com_err(program_name, 0,
                                _("interval between checks is too big (%lu)"),
                                interval);
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
                sb->s_checkinterval = interval;
                ext2fs_mark_super_dirty(fs);
@@ -1872,7 +2012,8 @@ retry_open:
                        com_err(program_name, 0,
                                _("reserved blocks count is too big (%llu)"),
                                reserved_blocks);
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
                ext2fs_r_blocks_count_set(sb, reserved_blocks);
                ext2fs_mark_super_dirty(fs);
@@ -1896,7 +2037,8 @@ retry_open:
        if (s_flag == 0) {
                fputs(_("\nClearing the sparse superflag not supported.\n"),
                      stderr);
-               exit(1);
+               rc = 1;
+               goto closefs;
        }
        if (T_flag) {
                sb->s_lastcheck = last_check_time;
@@ -1924,20 +2066,43 @@ retry_open:
                        sizeof(sb->s_last_mounted));
                ext2fs_mark_super_dirty(fs);
        }
-       if (mntopts_cmd)
-               update_mntopts(fs, mntopts_cmd);
-       if (features_cmd)
-               update_feature_set(fs, features_cmd);
-       if (extended_cmd)
-               parse_extended_opts(fs, extended_cmd);
-       if (journal_size || journal_device)
-               add_journal(fs);
+       if (mntopts_cmd) {
+               rc = update_mntopts(fs, mntopts_cmd);
+               if (rc)
+                       goto closefs;
+       }
+       if (features_cmd) {
+               rc = update_feature_set(fs, features_cmd);
+               if (rc)
+                       goto closefs;
+       }
+       if (extended_cmd) {
+               rc = parse_extended_opts(fs, extended_cmd);
+               if (rc)
+                       goto closefs;
+               if (clear_mmp && !f_flag) {
+                       fputs(_("Error in using clear_mmp. "
+                               "It must be used with -f\n"),
+                             stderr);
+                       goto closefs;
+               }
+       }
+       if (clear_mmp) {
+               rc = ext2fs_mmp_clear(fs);
+               goto closefs;
+       }
+       if (journal_size || journal_device) {
+               rc = add_journal(fs);
+               if (rc)
+                       goto closefs;
+       }
 
        if (Q_flag) {
                if (mount_flags & EXT2_MF_MOUNTED) {
                        fputs(_("The quota feature may only be changed when "
                                "the filesystem is unmounted.\n"), stderr);
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
                handle_quota_options(fs);
        }
@@ -1968,7 +2133,8 @@ retry_open:
                        uuid_generate(sb->s_uuid);
                } else if (uuid_parse(new_UUID, sb->s_uuid)) {
                        com_err(program_name, 0, _("Invalid UUID format\n"));
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
                if (set_csum) {
                        for (i = 0; i < fs->group_desc_count; i++)
@@ -1982,7 +2148,8 @@ retry_open:
                        fputs(_("The inode size may only be "
                                "changed when the filesystem is "
                                "unmounted.\n"), stderr);
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
                if (fs->super->s_feature_incompat &
                    EXT4_FEATURE_INCOMPAT_FLEX_BG) {
@@ -1990,7 +2157,8 @@ retry_open:
                                "filesystems with the flex_bg\n"
                                "feature enabled.\n"),
                              stderr);
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
                /*
                 * We want to update group descriptor also
@@ -2002,7 +2170,8 @@ retry_open:
                                                        new_inode_size);
                } else {
                        printf(_("Failed to change inode size\n"));
-                       exit(1);
+                       rc = 1;
+                       goto closefs;
                }
        }
 
@@ -2029,5 +2198,12 @@ retry_open:
        }
        free(device_name);
        remove_error_table(&et_ext2_error_table);
+
+closefs:
+       if (rc) {
+               ext2fs_mmp_stop(fs);
+               exit(1);
+       }
+
        return (ext2fs_close(fs) ? 1 : 0);
 }