Whamcloud - gitweb
ChangeLog:
[tools/e2fsprogs.git] / misc / tune2fs.c
index 196a6fe..7e2be5b 100644 (file)
@@ -1,12 +1,11 @@
 /*
- * tune2fs.c           - Change the file system parameters on
- *                       an unmounted second extended file system
+ * tune2fs.c - Change the file system parameters on an ext2 file system
  *
  * Copyright (C) 1992, 1993, 1994  Remy Card <card@masi.ibp.fr>
  *                                 Laboratoire MASI, Institut Blaise Pascal
  *                                 Universite Pierre et Marie Curie (Paris VI)
  *
- * Copyright 1995, 1996, 1997 by Theodore Ts'o.
+ * Copyright 1995, 1996, 1997, 1998, 1999, 2000 by Theodore Ts'o.
  *
  * %Begin-Header%
  * This file may be redistributed under the terms of the GNU Public
@@ -48,96 +47,336 @@ extern int optind;
 #include "et/com_err.h"
 #include "uuid/uuid.h"
 #include "e2p/e2p.h"
+#include "jfs_user.h"
+#include "util.h"
 
 #include "../version.h"
 #include "nls-enable.h"
 
 const char * program_name = "tune2fs";
-char * device_name = NULL;
-char * new_label = NULL;
-char * new_last_mounted = NULL;
-char * new_UUID = NULL;
-int c_flag = 0;
-int C_flag = 0;
-int e_flag = 0;
-int g_flag = 0;
-int i_flag = 0;
-int l_flag = 0;
-int L_flag = 0;
-int m_flag = 0;
-int M_flag = 0;
-int r_flag = 0;
-int s_flag = -1;
-int u_flag = 0;
-int U_flag = 0;
-int max_mount_count, mount_count;
-unsigned long interval;
-unsigned long reserved_ratio = 0;
-unsigned long reserved_blocks = 0;
-unsigned short errors;
-unsigned long resgid = 0;
-unsigned long resuid = 0;
-
-#ifndef HAVE_STRCASECMP
-static int strcasecmp (char *s1, char *s2)
-{
-       while (*s1 && *s2) {
-               int ch1 = *s1++, ch2 = *s2++;
-               if (isupper (ch1))
-                       ch1 = tolower (ch1);
-               if (isupper (ch2))
-                       ch2 = tolower (ch2);
-               if (ch1 != ch2)
-                       return ch1 - ch2;
-       }
-       return *s1 ? 1 : *s2 ? -1 : 0;
-}
-#endif
+char * device_name;
+char * new_label, *new_last_mounted, *new_UUID;
+static int c_flag, C_flag, e_flag, f_flag, g_flag, i_flag, l_flag, L_flag;
+static int m_flag, M_flag, r_flag, s_flag = -1, u_flag, U_flag;
+static int print_label;
+static int max_mount_count, mount_count, mount_flags;
+static unsigned long interval, reserved_ratio, reserved_blocks;
+static unsigned long resgid, resuid;
+static unsigned short errors;
+static int open_flag;
+static char *features_cmd;
+
+int journal_size, journal_flags;
+char *journal_device;
+
+static const char *please_fsck = N_("Please run e2fsck on the filesystem.\n");
 
 static void usage(void)
 {
-       fprintf(stderr, _("Usage: %s [-c max-mounts-count] [-e errors-behavior] "
-                "[-g group]\n"
-                "\t[-i interval[d|m|w]] [-l] [-s sparse-flag] "
-               "[-m reserved-blocks-percent]\n"
-                "\t[-r reserved-blocks-count] [-u user] [-C mount-count]\n"
-                "\t[-L volume-label] [-M last-mounted-dir] [-U UUID]\n"
-                "\t[-O [^]feature[,...]] device\n"), program_name);
+       fprintf(stderr,
+               _("Usage: %s [-c max-mounts-count] [-e errors-behavior] "
+                 "[-g group]\n"
+                "\t[-i interval[d|m|w]] [-j] [-J journal-options]\n"
+                "\t[-l] [-s sparse-flag] [-m reserved-blocks-percent]\n"
+                 "\t[-r reserved-blocks-count] [-u user] [-C mount-count]\n"
+                 "\t[-L volume-label] [-M last-mounted-dir] [-U UUID]\n"
+                 "\t[-O [^]feature[,...]] device\n"), program_name);
        exit (1);
 }
 
 static __u32 ok_features[3] = {
-       0,                                      /* Compat */
+       EXT3_FEATURE_COMPAT_HAS_JOURNAL,        /* Compat */
        EXT2_FEATURE_INCOMPAT_FILETYPE,         /* Incompat */
        EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER     /* R/O compat */
 };
 
-static const char *please_fsck = N_("Please run e2fsck on the filesystem.\n");
+/*
+ * Remove an external journal from the filesystem
+ */
+static void remove_journal_device(ext2_filsys fs)
+{
+       char            *journal_device;
+       ext2_filsys     jfs;
+       char            buf[1024];
+       journal_superblock_t    *jsb;
+       int             i, nr_users;
+       errcode_t       retval;
+       int             commit_remove_journal = 0;
 
-int main (int argc, char ** argv)
+       if (f_flag)
+               commit_remove_journal = 1; /* force removal even if error */
+
+       journal_device = ext2fs_find_block_device(fs->super->s_journal_dev);
+       if (!journal_device)
+               return;
+
+       retval = ext2fs_open(journal_device, EXT2_FLAG_RW|
+                            EXT2_FLAG_JOURNAL_DEV_OK, 0,
+                            fs->blocksize, unix_io_manager, &jfs);
+       if (retval) {
+               com_err(program_name, retval,
+                       _("while trying to open external journal"));
+               goto no_valid_journal;
+       }
+       if (!(jfs->super->s_feature_incompat & EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)) {
+               fprintf(stderr, "%s is not a journal device.\n",
+                       journal_device);
+               goto no_valid_journal;
+       }
+
+       /* Get the journal superblock */
+       if ((retval = io_channel_read_blk(jfs->io, 1, -1024, buf))) {
+               com_err(program_name, retval,
+                       _("while reading journal superblock"));
+               goto no_valid_journal;
+       }
+
+       jsb = (journal_superblock_t *) buf;
+       if ((jsb->s_header.h_magic != (unsigned) ntohl(JFS_MAGIC_NUMBER)) ||
+           (jsb->s_header.h_blocktype != (unsigned) ntohl(JFS_SUPERBLOCK_V2))) {
+               fprintf(stderr, _("Journal superblock not found!\n"));
+               goto no_valid_journal;
+       }
+
+       /* Find the filesystem UUID */
+       nr_users = ntohl(jsb->s_nr_users);
+       for (i=0; i < nr_users; i++) {
+               if (memcmp(fs->super->s_uuid,
+                          &jsb->s_users[i*16], 16) == 0)
+                       break;
+       }
+       if (i >= nr_users) {
+               fprintf(stderr, "Filesystem's UUID not found on journal device.\n");
+               commit_remove_journal = 1;
+               goto no_valid_journal;
+       }
+       nr_users--;
+       for (i=0; i < nr_users; i++)
+               memcpy(&jsb->s_users[i*16], &jsb->s_users[(i+1)*16], 16);
+       jsb->s_nr_users = htonl(nr_users);
+
+       /* Write back the journal superblock */
+       if ((retval = io_channel_write_blk(jfs->io, 1, -1024, buf))) {
+               com_err(program_name, retval,
+                       "while writing journal superblock.");
+               goto no_valid_journal;
+       }
+
+       commit_remove_journal = 1;
+
+no_valid_journal:
+       if (commit_remove_journal == 0) {
+               printf(_("Journal NOT removed\n"));
+               exit(1);
+       }
+       fs->super->s_journal_dev = 0;
+       memset(fs->super->s_journal_uuid, 0,
+              sizeof(fs->super->s_journal_uuid));
+       ext2fs_mark_super_dirty(fs);
+       printf(_("Journal removed\n"));
+}
+
+
+/*
+ * Update the feature set as provided by the user.
+ */
+static void update_feature_set(ext2_filsys fs, char *features)
+{
+       int sparse, old_sparse, filetype, old_filetype;
+       int journal, old_journal;
+       struct ext2_inode       inode;
+       struct ext2_super_block *sb= fs->super;
+       errcode_t               retval;
+
+       old_sparse = sb->s_feature_ro_compat &
+               EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
+       old_filetype = sb->s_feature_incompat &
+               EXT2_FEATURE_INCOMPAT_FILETYPE;
+       old_journal = sb->s_feature_compat &
+               EXT3_FEATURE_COMPAT_HAS_JOURNAL;
+       if (e2p_edit_feature(features, &sb->s_feature_compat,
+                            ok_features)) {
+               fprintf(stderr, _("Invalid filesystem option set: %s\n"),
+                       features);
+               exit(1);
+       }
+       sparse = sb->s_feature_ro_compat &
+               EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
+       filetype = sb->s_feature_incompat &
+               EXT2_FEATURE_INCOMPAT_FILETYPE;
+       journal = sb->s_feature_compat &
+               EXT3_FEATURE_COMPAT_HAS_JOURNAL;
+       if (old_journal && !journal) {
+               if ((mount_flags & EXT2_MF_MOUNTED) &&
+                   !(mount_flags & EXT2_MF_READONLY)) {
+                       fprintf(stderr,
+                               _("The has_journal flag may only be "
+                                 "cleared when the filesystem is\n"
+                                 "unmounted or mounted "
+                                 "read-only.\n"));
+                       exit(1);
+               }
+               if (sb->s_feature_incompat &
+                   EXT3_FEATURE_INCOMPAT_RECOVER) {
+                       fprintf(stderr,
+                               _("The needs_recovery flag is set.  "
+                                 "Please run e2fsck before clearing\n"
+                                 "the HAS_JOURNAL flag.\n"));
+                       exit(1);
+               }
+               /*
+                * Remove the immutable flag on the journal inode
+                */
+               if (sb->s_journal_inum) {
+                       retval = ext2fs_read_inode(fs, sb->s_journal_inum, 
+                                                  &inode);
+                       if (retval) {
+                               com_err(program_name, retval,
+                                       "while reading journal inode");
+                               exit(1);
+                       }
+                       inode.i_flags &= ~EXT2_IMMUTABLE_FL;
+                       retval = ext2fs_write_inode(fs, sb->s_journal_inum, 
+                                                   &inode);
+                       if (retval) {
+                               com_err(program_name, retval,
+                                       "while writing journal inode");
+                               exit(1);
+                       }
+               }
+               if (sb->s_journal_dev)
+                       remove_journal_device(fs);
+       }
+       if (journal && !old_journal) {
+               /*
+                * If adding a journal flag, let the create journal
+                * code below handle creating setting the flag and
+                * creating the journal.  We supply a default size if
+                * necessary.
+                */
+               if (!journal_size)
+                       journal_size = -1;
+               sb->s_feature_compat &= ~EXT3_FEATURE_COMPAT_HAS_JOURNAL;
+               journal = old_journal;
+       }
+
+       if (sb->s_rev_level == EXT2_GOOD_OLD_REV &&
+           (sb->s_feature_compat || sb->s_feature_ro_compat ||
+            sb->s_feature_incompat))
+               ext2fs_update_dynamic_rev(fs);
+       if ((sparse != old_sparse) ||
+           (filetype != old_filetype) ||
+           (journal != old_journal)) {
+               sb->s_state &= ~EXT2_VALID_FS;
+               printf("\n%s\n", _(please_fsck));
+       }
+       ext2fs_mark_super_dirty(fs);
+}
+
+/*
+ * Add a journal to the filesystem.
+ */
+static void add_journal(ext2_filsys fs)
+{
+       unsigned long journal_blocks;
+       errcode_t       retval;
+       ext2_filsys     jfs;
+
+       if (fs->super->s_feature_compat &
+           EXT3_FEATURE_COMPAT_HAS_JOURNAL) {
+               fprintf(stderr, _("The filesystem already has a journal.\n"));
+               exit(1);
+       }
+       if (journal_device) {
+               check_plausibility(journal_device);
+               check_mount(journal_device, 0, _("journal"));
+               retval = ext2fs_open(journal_device, EXT2_FLAG_RW|
+                                    EXT2_FLAG_JOURNAL_DEV_OK, 0,
+                                    fs->blocksize, unix_io_manager, &jfs);
+               if (retval) {
+                       com_err(program_name, retval,
+                               _("\n\twhile trying to open journal on %s\n"),
+                               journal_device);
+                       exit(1);
+               }
+               printf(_("Creating journal on device %s: "),
+                      journal_device);
+               fflush(stdout);
+               
+               retval = ext2fs_add_journal_device(fs, jfs);
+               if (retval) {
+                       com_err (program_name, retval,
+                                _("while adding filesystem to journal on %s"),
+                                journal_device);
+                       exit(1);
+               }
+               printf(_("done\n"));
+               ext2fs_close(jfs);
+       } else if (journal_size) {
+               printf(_("Creating journal inode: "));
+               fflush(stdout);
+               journal_blocks = figure_journal_size(journal_size, fs);
+
+               retval = ext2fs_add_journal_inode(fs, journal_blocks,
+                                                 journal_flags);
+               if (retval) {
+                       printf("\n");
+                       com_err(program_name, retval,
+                               _("\n\twhile trying to create journal file"));
+                       exit(1);
+               } else
+                       printf(_("done\n"));
+               /*
+                * If the filesystem wasn't mounted, we need to force
+                * the block group descriptors out.
+                */
+               if ((mount_flags & EXT2_MF_MOUNTED) == 0)
+                       fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
+       }
+}
+
+/*
+ * Given argv[0], return the program name.
+ */
+static char *get_progname(char *argv_zero)
+{
+       char    *cp;
+
+       cp = strrchr(argv_zero, '/');
+       if (!cp )
+               return argv_zero;
+       else
+               return cp+1;
+}
+
+
+static void parse_e2label_options(int argc, char ** argv)
+{
+       if ((argc < 2) || (argc > 3)) {
+               fprintf(stderr, _("Usage: e2label device [newlabel]\n"));
+               exit(1);
+       }
+       device_name = argv[1];
+       if (argc == 3) {
+               open_flag = EXT2_FLAG_RW;
+               L_flag = 1;
+               new_label = argv[2];
+       } else 
+               print_label++;
+}
+
+
+static void parse_tune2fs_options(int argc, char **argv)
 {
        int c;
        char * tmp;
-       errcode_t retval;
-       ext2_filsys fs;
-       struct ext2fs_sb *sb;
        struct group * gr;
        struct passwd * pw;
-       int open_flag = 0;
-       char *features_cmd = 0;
 
-#ifdef ENABLE_NLS
-       setlocale(LC_MESSAGES, "");
-       bindtextdomain(NLS_CAT_NAME, LOCALEDIR);
-       textdomain(NLS_CAT_NAME);
-#endif
        fprintf (stderr, _("tune2fs %s, %s for EXT2 FS %s, %s\n"),
                 E2FSPROGS_VERSION, E2FSPROGS_DATE,
                 EXT2FS_VERSION, EXT2FS_DATE);
-       if (argc && *argv)
-               program_name = *argv;
-       initialize_ext2_error_table();
-       while ((c = getopt (argc, argv, "c:e:g:i:lm:r:s:u:C:L:M:O:U:")) != EOF)
+       while ((c = getopt (argc, argv, "c:e:fg:i:jlm:r:s:u:C:J:L:M:O:U:")) != EOF)
                switch (c)
                {
                        case 'c':
@@ -148,6 +387,8 @@ int main (int argc, char ** argv)
                                                 optarg);
                                        usage();
                                }
+                               if (max_mount_count == 0)
+                                       max_mount_count = -1;
                                c_flag = 1;
                                open_flag = EXT2_FLAG_RW;
                                break;
@@ -178,6 +419,9 @@ int main (int argc, char ** argv)
                                e_flag = 1;
                                open_flag = EXT2_FLAG_RW;
                                break;
+                       case 'f': /* Force */
+                               f_flag = 1;
+                               break;
                        case 'g':
                                resgid = strtoul (optarg, &tmp, 0);
                                if (*tmp) {
@@ -230,6 +474,15 @@ int main (int argc, char ** argv)
                                i_flag = 1;
                                open_flag = EXT2_FLAG_RW;
                                break;
+                       case 'j':
+                               if (!journal_size)
+                                       journal_size = -1;
+                               open_flag = EXT2_FLAG_RW;
+                               break;
+                       case 'J':
+                               parse_journal_opts(optarg);
+                               open_flag = EXT2_FLAG_RW;
+                               break;
                        case 'l':
                                l_flag = 1;
                                break;
@@ -306,6 +559,30 @@ int main (int argc, char ** argv)
        if (!open_flag && !l_flag)
                usage();
        device_name = argv[optind];
+}      
+
+
+
+int main (int argc, char ** argv)
+{
+       errcode_t retval;
+       ext2_filsys fs;
+       struct ext2_super_block *sb;
+
+#ifdef ENABLE_NLS
+       setlocale(LC_MESSAGES, "");
+       bindtextdomain(NLS_CAT_NAME, LOCALEDIR);
+       textdomain(NLS_CAT_NAME);
+#endif
+       if (argc && *argv)
+               program_name = *argv;
+       initialize_ext2_error_table();
+
+       if (strcmp(get_progname(argv[0]), "e2label") == 0)
+               parse_e2label_options(argc, argv);
+       else
+               parse_tune2fs_options(argc, argv);
+       
        retval = ext2fs_open (device_name, open_flag, 0, 0,
                              unix_io_manager, &fs);
         if (retval) {
@@ -314,62 +591,69 @@ int main (int argc, char ** argv)
                printf(_("Couldn't find valid filesystem superblock.\n"));
                exit(1);
        }
-       sb = (struct ext2fs_sb *) fs->super;
+       sb = fs->super;
+       if (print_label) {
+               /* For e2label emulation */
+               printf("%.*s\n", (int) sizeof(sb->s_volume_name),
+                      sb->s_volume_name);
+               exit(0);
+       }
+       retval = ext2fs_check_if_mounted(device_name, &mount_flags);
+       if (retval) {
+               com_err("ext2fs_check_if_mount", retval,
+                       _("while determining whether %s is mounted."),
+                       device_name);
+               exit(1);
+       }
+       /* Normally we only need to write out the superblock */
+       fs->flags |= EXT2_FLAG_SUPER_ONLY;
 
        if (c_flag) {
-               fs->super->s_max_mnt_count = max_mount_count;
+               sb->s_max_mnt_count = max_mount_count;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting maximal mount count to %d\n"),
                        max_mount_count);
        }
        if (C_flag) {
-               fs->super->s_mnt_count = mount_count;
+               sb->s_mnt_count = mount_count;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting current mount count to %d\n"), mount_count);
        }
        if (e_flag) {
-               fs->super->s_errors = errors;
+               sb->s_errors = errors;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting error behavior to %d\n"), errors);
        }
-       if (g_flag)
-#ifdef EXT2_DEF_RESGID
-       {
-               fs->super->s_def_resgid = resgid;
+       if (g_flag) {
+               sb->s_def_resgid = resgid;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting reserved blocks gid to %lu\n"), resgid);
        }
-#else
-               com_err (program_name, 0,
-                        _("The -g option is not supported by this version -- "
-                        "Recompile with a newer kernel"));
-#endif
        if (i_flag) {
-               fs->super->s_checkinterval = interval;
+               sb->s_checkinterval = interval;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting interval between check %lu seconds\n"), interval);
        }
        if (m_flag) {
-               fs->super->s_r_blocks_count = (fs->super->s_blocks_count / 100)
+               sb->s_r_blocks_count = (sb->s_blocks_count / 100)
                        * reserved_ratio;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting reserved blocks percentage to %lu (%u blocks)\n"),
-                       reserved_ratio, fs->super->s_r_blocks_count);
+                       reserved_ratio, sb->s_r_blocks_count);
        }
        if (r_flag) {
-               if (reserved_blocks >= fs->super->s_blocks_count) {
+               if (reserved_blocks >= sb->s_blocks_count) {
                        com_err (program_name, 0,
                                 _("reserved blocks count is too big (%ul)"),
                                 reserved_blocks);
                        exit (1);
                }
-               fs->super->s_r_blocks_count = reserved_blocks;
+               sb->s_r_blocks_count = reserved_blocks;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting reserved blocks count to %lu\n"),
                        reserved_blocks);
        }
        if (s_flag == 1) {
-#ifdef EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER
                if (sb->s_feature_ro_compat &
                    EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER)
                        fprintf(stderr, _("\nThe filesystem already"
@@ -377,19 +661,13 @@ int main (int argc, char ** argv)
                else {
                        sb->s_feature_ro_compat |=
                                EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
-                       fs->super->s_state &= ~EXT2_VALID_FS;
+                       sb->s_state &= ~EXT2_VALID_FS;
                        ext2fs_mark_super_dirty(fs);
                        printf(_("\nSparse superblock flag set.  %s"),
                               _(please_fsck));
                }
-#else /* !EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER */
-               com_err (program_name, 0,
-                        _("The -s option is not supported by this version -- "
-                        "Recompile with a newer kernel"));
-#endif /* EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER */
        }
        if (s_flag == 0) {
-#ifdef EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER
                if (!(sb->s_feature_ro_compat &
                      EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER))
                        fprintf(stderr, _("\nThe filesystem already"
@@ -397,31 +675,18 @@ int main (int argc, char ** argv)
                else {
                        sb->s_feature_ro_compat &=
                                ~EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
-                       fs->super->s_state &= ~EXT2_VALID_FS;
+                       sb->s_state &= ~EXT2_VALID_FS;
                        fs->flags |= EXT2_FLAG_MASTER_SB_ONLY;
                        ext2fs_mark_super_dirty(fs);
                        printf(_("\nSparse superblock flag cleared.  %s"),
                               _(please_fsck));
                }
-#else /* !EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER */
-               com_err (program_name, 0,
-                        _("The -s option is not supported by this version -- "
-                        "Recompile with a newer kernel"));
-#endif /* EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER */
        }
-       
-       if (u_flag)
-#ifdef EXT2_DEF_RESUID
-       {
-               fs->super->s_def_resuid = resuid;
+       if (u_flag) {
+               sb->s_def_resuid = resuid;
                ext2fs_mark_super_dirty(fs);
                printf (_("Setting reserved blocks uid to %lu\n"), resuid);
        }
-#else
-               com_err (program_name, 0,
-                        _("The -u option is not supported by this version -- "
-                        "Recompile with a newer kernel"));
-#endif
        if (L_flag) {
                if (strlen(new_label) > sizeof(sb->s_volume_name))
                        fprintf(stderr, _("Warning: label too "
@@ -437,34 +702,17 @@ int main (int argc, char ** argv)
                        sizeof(sb->s_last_mounted));
                ext2fs_mark_super_dirty(fs);
        }
-       if (features_cmd) {
-               int sparse, old_sparse, filetype, old_filetype;
-
-               old_sparse = sb->s_feature_ro_compat &
-                       EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
-               old_filetype = sb->s_feature_incompat &
-                       EXT2_FEATURE_INCOMPAT_FILETYPE;
-               if (e2p_edit_feature(features_cmd,
-                                    &sb->s_feature_compat,
-                                    ok_features)) {
-                       fprintf(stderr, _("Invalid filesystem option set: %s\n"),
-                               features_cmd);
-                       exit(1);
-               }
-               sparse = sb->s_feature_ro_compat &
-                       EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
-               filetype = sb->s_feature_incompat &
-                       EXT2_FEATURE_INCOMPAT_FILETYPE;
-               if ((sparse != old_sparse) ||
-                   (filetype != old_filetype)) {
-                       fs->super->s_state &= ~EXT2_VALID_FS;
-                       printf("\n%s\n", _(please_fsck));
-               }
-               ext2fs_mark_super_dirty(fs);
-       }
+       if (features_cmd)
+               update_feature_set(fs, features_cmd);
+       if (journal_size || journal_device)
+               add_journal(fs);
+       
        if (U_flag) {
-               if (strcasecmp(new_UUID, "null") == 0) {
+               if ((strcasecmp(new_UUID, "null") == 0) ||
+                   (strcasecmp(new_UUID, "clear") == 0)) {
                        uuid_clear(sb->s_uuid);
+               } else if (strcasecmp(new_UUID, "time") == 0) {
+                       uuid_generate_time(sb->s_uuid);
                } else if (strcasecmp(new_UUID, "random") == 0) {
                        uuid_generate(sb->s_uuid);
                } else if (uuid_parse(new_UUID, sb->s_uuid)) {
@@ -475,7 +723,7 @@ int main (int argc, char ** argv)
        }
 
        if (l_flag)
-               list_super (fs->super);
+               list_super (sb);
        ext2fs_close (fs);
        exit (0);
 }