Whamcloud - gitweb
LU-4017 e2fsprogs: add project quota support
[tools/e2fsprogs.git] / misc / mke2fs.c
index dd77a00..53c30ce 100644 (file)
@@ -25,9 +25,6 @@
 #include <fcntl.h>
 #include <ctype.h>
 #include <time.h>
-#ifdef __linux__
-#include <sys/utsname.h>
-#endif
 #ifdef HAVE_GETOPT_H
 #include <getopt.h>
 #else
@@ -61,7 +58,8 @@ extern int optind;
 #include "prof_err.h"
 #include "../version.h"
 #include "nls-enable.h"
-#include "quota/mkquota.h"
+#include "quota/quotaio.h"
+#include "mke2fs.h"
 
 #define STRIDE_LENGTH 8
 
@@ -76,28 +74,33 @@ extern int optind;
 extern int isatty(int);
 extern FILE *fpopen(const char *cmd, const char *mode);
 
-static const char * program_name = "mke2fs";
+const char * program_name = "mke2fs";
 static const char * device_name /* = NULL */;
 
 /* Command line options */
 static int     cflag;
-static int     verbose;
-static int     quiet;
+int    verbose;
+int    quiet;
 static int     super_only;
 static int     discard = 1;    /* attempt to discard device before fs creation */
 static int     direct_io;
 static int     force;
 static int     noaction;
+static int     num_backups = 2; /* number of backup bg's for sparse_super2 */
 static uid_t   root_uid;
 static gid_t   root_gid;
 int    journal_size;
 int    journal_flags;
 static int     lazy_itable_init;
+static int     packed_meta_blocks;
 static char    *bad_blocks_filename = NULL;
 static __u32   fs_stride;
-static int     quotatype = -1;  /* Initialize both user and group quotas by default */
+/* Initialize usr/grp quotas by default */
+static unsigned int quotatype_bits = (QUOTA_USR_BIT | QUOTA_GRP_BIT);
 static __u64   offset;
 static blk64_t journal_location = ~0LL;
+static int     proceed_delay = -1;
+static blk64_t dev_size;
 
 static struct ext2_super_block fs_param;
 static char *fs_uuid = NULL;
@@ -106,12 +109,11 @@ static char *volume_label;
 static char *mount_dir;
 char *journal_device;
 static int sync_kludge;        /* Set using the MKE2FS_SYNC env. option */
-static char **fs_types;
+char **fs_types;
 
 static profile_t       profile;
 
 static int sys_page_size = 4096;
-static int linux_version_code = 0;
 
 static void usage(void)
 {
@@ -141,7 +143,7 @@ static int int_log2(unsigned long long arg)
        return l;
 }
 
-static int int_log10(unsigned long long arg)
+int int_log10(unsigned long long arg)
 {
        int     l;
 
@@ -150,30 +152,6 @@ static int int_log10(unsigned long long arg)
        return l;
 }
 
-#ifdef __linux__
-static int parse_version_number(const char *s)
-{
-       int     major, minor, rev;
-       char    *endptr;
-       const char *cp = s;
-
-       if (!s)
-               return 0;
-       major = strtol(cp, &endptr, 10);
-       if (cp == endptr || *endptr != '.')
-               return 0;
-       cp = endptr + 1;
-       minor = strtol(cp, &endptr, 10);
-       if (cp == endptr || *endptr != '.')
-               return 0;
-       cp = endptr + 1;
-       rev = strtol(cp, &endptr, 10);
-       if (cp == endptr)
-               return 0;
-       return ((((major * 256) + minor) * 256) + rev);
-}
-#endif
-
 /*
  * Helper function for read_bb_file and test_disk
  */
@@ -310,6 +288,41 @@ _("Warning: the backup superblock/group descriptors at block %u contain\n"
        ext2fs_badblocks_list_iterate_end(bb_iter);
 }
 
+static errcode_t packed_allocate_tables(ext2_filsys fs)
+{
+       errcode_t       retval;
+       dgrp_t          i;
+       blk64_t         goal = 0;
+
+       for (i = 0; i < fs->group_desc_count; i++) {
+               retval = ext2fs_new_block2(fs, goal, NULL, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats2(fs, goal, +1);
+               ext2fs_block_bitmap_loc_set(fs, i, goal);
+       }
+       for (i = 0; i < fs->group_desc_count; i++) {
+               retval = ext2fs_new_block2(fs, goal, NULL, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats2(fs, goal, +1);
+               ext2fs_inode_bitmap_loc_set(fs, i, goal);
+       }
+       for (i = 0; i < fs->group_desc_count; i++) {
+               blk64_t end = ext2fs_blocks_count(fs->super) - 1;
+               retval = ext2fs_get_free_blocks2(fs, goal, end,
+                                                fs->inode_blocks_per_group,
+                                                fs->block_map, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats_range(fs, goal,
+                                              fs->inode_blocks_per_group, +1);
+               ext2fs_inode_table_loc_set(fs, i, goal);
+               ext2fs_group_desc_csum_set(fs, i);
+       }
+       return 0;
+}
+
 static void write_inode_tables(ext2_filsys fs, int lazy_flag, int itable_zeroed)
 {
        errcode_t       retval;
@@ -558,6 +571,14 @@ static void show_stats(ext2_filsys fs)
        dgrp_t                  i;
        int                     need, col_left;
 
+       if (!verbose) {
+               printf(_("Creating filesystem with %llu %dk blocks and "
+                        "%u inodes\n"),
+                      ext2fs_blocks_count(s), fs->blocksize >> 10,
+                      s->s_inodes_count);
+               goto skip_details;
+       }
+
        if (ext2fs_blocks_count(&fs_param) != ext2fs_blocks_count(s))
                fprintf(stderr, _("warning: %llu blocks unused.\n\n"),
                       ext2fs_blocks_count(&fs_param) - ext2fs_blocks_count(s));
@@ -606,11 +627,14 @@ static void show_stats(ext2_filsys fs)
                       s->s_blocks_per_group, s->s_clusters_per_group);
        printf(_("%u inodes per group\n"), s->s_inodes_per_group);
 
+skip_details:
        if (fs->group_desc_count == 1) {
                printf("\n");
                return;
        }
 
+       if (!e2p_is_null_uuid(s->s_uuid))
+               printf(_("Filesystem UUID: %s\n"), e2p_uuid2str(s->s_uuid));
        printf("%s", _("Superblock backups stored on blocks: "));
        group_block = s->s_first_data_block;
        col_left = 0;
@@ -654,12 +678,30 @@ static int set_os(struct ext2_super_block *sb, char *os)
 
 #define PATH_SET "PATH=/sbin"
 
+static int option_handle_function(char *token, void *data)
+{
+       if (!strncmp(token, "usr", 3)) {
+               quotatype_bits |= QUOTA_USR_BIT;
+       } else if (!strncmp(token, "grp", 3)) {
+               quotatype_bits |= QUOTA_GRP_BIT;
+       } else if (!strncmp(token, "prj", 3)) {
+               quotatype_bits |= QUOTA_PRJ_BIT;
+       } else {
+               fprintf(stderr, _("Invalid quotatype parameter: %s\n"),
+                               token);
+               return 1;
+       }
+       return 0;
+
+}
+
 static void parse_extended_opts(struct ext2_super_block *param,
                                const char *opts)
 {
        char    *buf, *token, *next, *p, *arg, *badopt = 0;
        int     len;
        int     r_usage = 0;
+       int     ret;
 
        len = strlen(opts);
        buf = malloc(len+1);
@@ -739,6 +781,28 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                r_usage++;
                                continue;
                        }
+               } else if (strcmp(token, "num_backup_sb") == 0) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       num_backups = strtoul(arg, &p, 0);
+                       if (*p || num_backups > 2) {
+                               fprintf(stderr,
+                                       _("Invalid # of backup "
+                                         "superblocks: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "packed_meta_blocks") == 0) {
+                       if (arg)
+                               packed_meta_blocks = strtoul(arg, &p, 0);
+                       else
+                               packed_meta_blocks = 1;
+                       if (packed_meta_blocks)
+                               journal_location = 0;
                } else if (strcmp(token, "stride") == 0) {
                        if (!arg) {
                                r_usage++;
@@ -872,14 +936,9 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                badopt = token;
                                continue;
                        }
-                       if (!strncmp(arg, "usr", 3)) {
-                               quotatype = 0;
-                       } else if (!strncmp(arg, "grp", 3)) {
-                               quotatype = 1;
-                       } else {
-                               fprintf(stderr,
-                                       _("Invalid quotatype parameter: %s\n"),
-                                       arg);
+                       ret = parse_quota_opts(arg, option_handle_function,
+                                              NULL);
+                       if (ret) {
                                r_usage++;
                                continue;
                        }
@@ -895,10 +954,12 @@ static void parse_extended_opts(struct ext2_super_block *param,
                        "\tis set off by an equals ('=') sign.\n\n"
                        "Valid extended options are:\n"
                        "\tmmp_update_interval=<interval>\n"
+                       "\tnum_backup_sb=<0|1|2>\n"
                        "\tstride=<RAID per-disk data chunk in blocks>\n"
                        "\tstripe-width=<RAID stride * data disks in blocks>\n"
                        "\toffset=<offset to create the file system>\n"
                        "\tresize=<resize maximum size in blocks>\n"
+                       "\tpacked_meta_blocks=<0 to disable, 1 to enable>\n"
                        "\tlazy_itable_init=<0 to disable, 1 to enable>\n"
                        "\tlazy_journal_init=<0 to disable, 1 to enable>\n"
                        "\troot_uid=<uid of root directory>\n"
@@ -925,14 +986,17 @@ static __u32 ok_features[3] = {
        EXT3_FEATURE_COMPAT_HAS_JOURNAL |
                EXT2_FEATURE_COMPAT_RESIZE_INODE |
                EXT2_FEATURE_COMPAT_DIR_INDEX |
-               EXT2_FEATURE_COMPAT_EXT_ATTR,
+               EXT2_FEATURE_COMPAT_EXT_ATTR |
+               EXT4_FEATURE_COMPAT_SPARSE_SUPER2,
        /* Incompat */
        EXT2_FEATURE_INCOMPAT_FILETYPE|
                EXT3_FEATURE_INCOMPAT_EXTENTS|
                EXT3_FEATURE_INCOMPAT_JOURNAL_DEV|
                EXT2_FEATURE_INCOMPAT_META_BG|
                EXT4_FEATURE_INCOMPAT_FLEX_BG|
+               EXT4_FEATURE_INCOMPAT_EA_INODE|
                EXT4_FEATURE_INCOMPAT_MMP |
+               EXT4_FEATURE_INCOMPAT_DIRDATA|
                EXT4_FEATURE_INCOMPAT_64BIT,
        /* R/O compat */
        EXT2_FEATURE_RO_COMPAT_LARGE_FILE|
@@ -944,6 +1008,7 @@ static __u32 ok_features[3] = {
                EXT4_FEATURE_RO_COMPAT_BIGALLOC|
 #ifdef CONFIG_QUOTA
                EXT4_FEATURE_RO_COMPAT_QUOTA|
+               EXT4_FEATURE_RO_COMPAT_PROJECT|
 #endif
                0
 };
@@ -1182,7 +1247,7 @@ static char **parse_fs_type(const char *fs_type,
        return (list.list);
 }
 
-static char *get_string_from_profile(char **types, const char *opt,
+char *get_string_from_profile(char **types, const char *opt,
                                     const char *def_val)
 {
        char *ret = 0;
@@ -1199,7 +1264,7 @@ static char *get_string_from_profile(char **types, const char *opt,
        return (ret);
 }
 
-static int get_int_from_profile(char **types, const char *opt, int def_val)
+int get_int_from_profile(char **types, const char *opt, int def_val)
 {
        int ret;
        char **cpp;
@@ -1210,6 +1275,18 @@ static int get_int_from_profile(char **types, const char *opt, int def_val)
        return ret;
 }
 
+static unsigned int get_uint_from_profile(char **types, const char *opt,
+                                       unsigned int def_val)
+{
+       unsigned int ret;
+       char **cpp;
+
+       profile_get_uint(profile, "defaults", opt, 0, def_val, &ret);
+       for (cpp = types; *cpp; cpp++)
+               profile_get_uint(profile, "fs_types", *cpp, opt, ret, &ret);
+       return ret;
+}
+
 static double get_double_from_profile(char **types, const char *opt,
                                      double def_val)
 {
@@ -1222,7 +1299,7 @@ static double get_double_from_profile(char **types, const char *opt,
        return ret;
 }
 
-static int get_bool_from_profile(char **types, const char *opt, int def_val)
+int get_bool_from_profile(char **types, const char *opt, int def_val)
 {
        int ret;
        char **cpp;
@@ -1290,7 +1367,7 @@ out:
 
 static void PRS(int argc, char *argv[])
 {
-       int             b, c;
+       int             b, c, flags;
        int             cluster_size = 0;
        char            *tmp, **cpp;
        int             blocksize = 0;
@@ -1299,14 +1376,13 @@ static void PRS(int argc, char *argv[])
        unsigned long   flex_bg_size = 0;
        double          reserved_ratio = -1.0;
        int             lsector_size = 0, psector_size = 0;
-       int             show_version_only = 0;
+       int             show_version_only = 0, is_device = 0;
        unsigned long long num_inodes = 0; /* unsigned long long to catch too-large input */
        errcode_t       retval;
        char *          oldpath = getenv("PATH");
        char *          extended_opts = 0;
        char *          fs_type = 0;
        char *          usage_types = 0;
-       blk64_t         dev_size;
        /*
         * NOTE: A few words about fs_blocks_count and blocksize:
         *
@@ -1323,9 +1399,6 @@ static void PRS(int argc, char *argv[])
         * Finally, we complain about fs_blocks_count > 2^32 on a non-64bit fs.
         */
        blk64_t         fs_blocks_count = 0;
-#ifdef __linux__
-       struct          utsname ut;
-#endif
        long            sysval;
        int             s_opt = -1, r_opt = -1;
        char            *fs_features = 0;
@@ -1391,15 +1464,8 @@ profile_error:
        memset(&fs_param, 0, sizeof(struct ext2_super_block));
        fs_param.s_rev_level = 1;  /* Create revision 1 filesystems now */
 
-#ifdef __linux__
-       if (uname(&ut)) {
-               perror("uname");
-               exit(1);
-       }
-       linux_version_code = parse_version_number(ut.release);
-       if (linux_version_code && linux_version_code < (2*65536 + 2*256))
+       if (ext2fs_is_before_linux_ver(2, 2, 0))
                fs_param.s_rev_level = 0;
-#endif
 
        if (argc && *argv) {
                program_name = get_progname(*argv);
@@ -1483,6 +1549,12 @@ profile_error:
                                        _("flex_bg size must be a power of 2"));
                                exit(1);
                        }
+                       if (flex_bg_size > MAX_32_NUM) {
+                               com_err(program_name, 0,
+                               _("flex_bg size (%lu) must be less than"
+                               " or equal to 2^31"), flex_bg_size);
+                               exit(1);
+                       }
                        break;
                case 'i':
                        inode_ratio = strtoul(optarg, &tmp, 0);
@@ -1572,6 +1644,11 @@ profile_error:
                                        _("bad revision level - %s"), optarg);
                                exit(1);
                        }
+                       if (r_opt > EXT2_MAX_SUPP_REV) {
+                               com_err(program_name, EXT2_ET_REV_TOO_HIGH,
+                                       _("while trying to create revision %d"), r_opt);
+                               exit(1);
+                       }
                        fs_param.s_rev_level = r_opt;
                        break;
                case 's':       /* deprecated */
@@ -1659,7 +1736,7 @@ profile_error:
                printf(_("Using journal device's blocksize: %d\n"), blocksize);
                fs_param.s_log_block_size =
                        int_log2(blocksize >> EXT2_MIN_BLOCK_LOG_SIZE);
-               ext2fs_close(jfs);
+               ext2fs_close_free(&jfs);
        }
 
        if (optind < argc) {
@@ -1675,8 +1752,20 @@ profile_error:
        if (optind < argc)
                usage();
 
-       if (!force)
-               check_plausibility(device_name);
+       profile_get_integer(profile, "options", "proceed_delay", 0, 0,
+                           &proceed_delay);
+
+       /* The isatty() test is so we don't break existing scripts */
+       flags = CREATE_FILE;
+       if (isatty(0) && isatty(1))
+               flags |= CHECK_FS_EXIST;
+       if (!quiet)
+               flags |= VERBOSE_CREATE;
+       if (fs_blocks_count == 0)
+               flags |= NO_SIZE;
+       if (!check_plausibility(device_name, flags, &is_device) && !force)
+               proceed_question(proceed_delay);
+
        check_mount(device_name, force, _("filesystem"));
 
        /* Determine the size of the device (if possible) */
@@ -1718,10 +1807,10 @@ profile_error:
                                fs_blocks_count &= ~((blk64_t) ((sys_page_size /
                                             EXT2_BLOCK_SIZE(&fs_param))-1));
                }
-       } else if (!force && (fs_blocks_count > dev_size)) {
+       } else if (!force && is_device && (fs_blocks_count > dev_size)) {
                com_err(program_name, 0, "%s",
                        _("Filesystem larger than apparent device size."));
-               proceed_question();
+               proceed_question(proceed_delay);
        }
 
        if (!fs_type)
@@ -1749,7 +1838,7 @@ profile_error:
        tmp = NULL;
        if (fs_param.s_rev_level != EXT2_GOOD_OLD_REV) {
                tmp = get_string_from_profile(fs_types, "base_features",
-                     "sparse_super,filetype,resize_inode,dir_index");
+                     "sparse_super,large_file,filetype,resize_inode,dir_index");
                edit_feature(tmp, &fs_param.s_feature_compat);
                free(tmp);
 
@@ -1807,8 +1896,8 @@ profile_error:
 
                if (use_bsize == -1) {
                        use_bsize = sys_page_size;
-                       if ((linux_version_code < (2*65536 + 6*256)) &&
-                           (use_bsize > 4096))
+                       if (ext2fs_is_before_linux_ver(2, 6, 0) &&
+                           use_bsize > 4096)
                                use_bsize = 4096;
                }
                if (lsector_size && use_bsize < lsector_size)
@@ -1839,6 +1928,9 @@ profile_error:
         * 32-bit vs 64-bit block number support.
         */
        if ((fs_blocks_count > MAX_32_NUM) &&
+           (fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT))
+               fs_param.s_feature_compat &= ~EXT2_FEATURE_COMPAT_RESIZE_INODE;
+       if ((fs_blocks_count > MAX_32_NUM) &&
            !(fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT) &&
            get_bool_from_profile(fs_types, "auto_64-bit_support", 0)) {
                fs_param.s_feature_incompat |= EXT4_FEATURE_INCOMPAT_64BIT;
@@ -1975,6 +2067,8 @@ profile_error:
        }
 #endif
 
+       num_backups = get_int_from_profile(fs_types, "num_backup_sb", 2);
+
        blocksize = EXT2_BLOCK_SIZE(&fs_param);
 
        /*
@@ -1991,14 +2085,22 @@ profile_error:
                        com_err(program_name, 0,
                                _("%d-byte blocks too big for system (max %d)"),
                                blocksize, sys_page_size);
-                       proceed_question();
+                       proceed_question(proceed_delay);
                }
                fprintf(stderr, _("Warning: %d-byte blocks too big for system "
                                  "(max %d), forced to continue\n"),
                        blocksize, sys_page_size);
        }
 
-       lazy_itable_init = 0;
+       /*
+        * On newer kernels we do have lazy_itable_init support. So pick the
+        * right default in case ext4 module is not loaded.
+        */
+       if (ext2fs_is_before_linux_ver(2, 6, 37))
+               lazy_itable_init = 0;
+       else
+               lazy_itable_init = 1;
+
        if (access("/sys/fs/ext4/features/lazy_itable_init", R_OK) == 0)
                lazy_itable_init = 1;
 
@@ -2020,6 +2122,11 @@ profile_error:
                                                fs_param.s_log_block_size);
        free(journal_location_string);
 
+       packed_meta_blocks = get_bool_from_profile(fs_types,
+                                                  "packed_meta_blocks", 0);
+       if (packed_meta_blocks)
+               journal_location = 0;
+
        /* Get options from profile */
        for (cpp = fs_types; *cpp; cpp++) {
                tmp = NULL;
@@ -2057,13 +2164,6 @@ profile_error:
                                  "See https://ext4.wiki.kernel.org/"
                                  "index.php/Bigalloc for more information\n\n"));
 
-       if (!quiet &&
-           (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA))
-               fprintf(stderr, "%s", _("\nWarning: the quota feature is "
-                                 "still under development\n"
-                                 "See https://ext4.wiki.kernel.org/"
-                                 "index.php/Quota for more information\n\n"));
-
        /* Since sparse_super is the default, we would only have a problem
         * here if it was explicitly disabled.
         */
@@ -2097,8 +2197,8 @@ profile_error:
                inode_size = get_int_from_profile(fs_types, "inode_size", 0);
        if (!flex_bg_size && (fs_param.s_feature_incompat &
                              EXT4_FEATURE_INCOMPAT_FLEX_BG))
-               flex_bg_size = get_int_from_profile(fs_types,
-                                                   "flex_bg_size", 16);
+               flex_bg_size = get_uint_from_profile(fs_types,
+                                                    "flex_bg_size", 16);
        if (flex_bg_size) {
                if (!(fs_param.s_feature_incompat &
                      EXT4_FEATURE_INCOMPAT_FLEX_BG)) {
@@ -2123,6 +2223,20 @@ profile_error:
                fs_param.s_inode_size = inode_size;
        }
 
+       /*
+        * If inode size is 128 and project quota is enabled, we need
+        * to notify users that project ID will never be useful.
+        */
+       if (fs_param.s_feature_incompat & EXT4_FEATURE_RO_COMPAT_QUOTA &&
+           fs_param.s_feature_incompat & EXT4_FEATURE_RO_COMPAT_PROJECT &&
+           fs_param.s_inode_size == EXT2_GOOD_OLD_INODE_SIZE) {
+               com_err(program_name, 0,
+                       _("%d byte inodes are too small for project quota; "
+                         "specify larger size"),
+                       fs_param.s_inode_size);
+               exit(1);
+       }
+
        /* Make sure number of inodes specified will fit in 32 bits */
        if (num_inodes == 0) {
                unsigned long long n;
@@ -2171,6 +2285,13 @@ profile_error:
        ext2fs_r_blocks_count_set(&fs_param, reserved_ratio *
                                  ext2fs_blocks_count(&fs_param) / 100.0);
 
+       if (fs_param.s_feature_compat & EXT4_FEATURE_COMPAT_SPARSE_SUPER2) {
+               if (num_backups >= 1)
+                       fs_param.s_backup_bgs[0] = 1;
+               if (num_backups >= 2)
+                       fs_param.s_backup_bgs[1] = ~0;
+       }
+
        free(fs_type);
        free(usage_types);
 }
@@ -2385,9 +2506,9 @@ static int create_quota_inodes(ext2_filsys fs)
 {
        quota_ctx_t qctx;
 
-       quota_init_context(&qctx, fs, -1);
+       quota_init_context(&qctx, fs, QUOTA_ALL_BIT);
        quota_compute_usage(qctx);
-       quota_write_inode(qctx, quotatype);
+       quota_write_inode(qctx, quotatype_bits);
        quota_release_context(&qctx);
 
        return 0;
@@ -2398,7 +2519,7 @@ int main (int argc, char *argv[])
        errcode_t       retval = 0;
        ext2_filsys     fs;
        badblocks_list  bb_list = 0;
-       unsigned int    journal_blocks;
+       unsigned int    journal_blocks = 0;
        unsigned int    i, checkinterval;
        int             max_mnt_count;
        int             val, hash_alg;
@@ -2463,7 +2584,7 @@ int main (int argc, char *argv[])
                journal_blocks = figure_journal_size(journal_size, fs);
 
        /* Can't undo discard ... */
-       if (!noaction && discard && (io_ptr != undo_io_manager)) {
+       if (!noaction && discard && dev_size && (io_ptr != undo_io_manager)) {
                retval = mke2fs_discard_device(fs);
                if (!retval && io_channel_discard_zeroes_data(fs->io)) {
                        if (verbose)
@@ -2472,6 +2593,7 @@ int main (int argc, char *argv[])
                                         "0s - skipping inode table wipe\n"));
                        lazy_itable_init = 1;
                        itable_zeroed = 1;
+                       zero_hugefile = 0;
                }
        }
 
@@ -2596,19 +2718,23 @@ int main (int argc, char *argv[])
        if (fs->super->s_feature_incompat &
            EXT3_FEATURE_INCOMPAT_JOURNAL_DEV) {
                create_journal_dev(fs);
-               exit(ext2fs_close(fs) ? 1 : 0);
+               exit(ext2fs_close_free(&fs) ? 1 : 0);
        }
 
        if (bad_blocks_filename)
                read_bb_file(fs, &bb_list, bad_blocks_filename);
        if (cflag)
                test_disk(fs, &bb_list);
-
        handle_bad_blocks(fs, bb_list);
+
        fs->stride = fs_stride = fs->super->s_raid_stride;
        if (!quiet)
                printf("%s", _("Allocating group tables: "));
-       retval = ext2fs_allocate_tables(fs);
+       if ((fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_FLEX_BG) &&
+           packed_meta_blocks)
+               retval = packed_allocate_tables(fs);
+       else
+               retval = ext2fs_allocate_tables(fs);
        if (retval) {
                com_err(program_name, retval, "%s",
                        _("while trying to allocate filesystem tables"));
@@ -2686,8 +2812,9 @@ int main (int argc, char *argv[])
        if (journal_device) {
                ext2_filsys     jfs;
 
-               if (!force)
-                       check_plausibility(journal_device);
+               if (!check_plausibility(journal_device, CHECK_BLOCK_DEV,
+                                       NULL) && !force)
+                       proceed_question(proceed_delay);
                check_mount(journal_device, force, _("journal"));
 
                retval = ext2fs_open(journal_device, EXT2_FLAG_RW|
@@ -2713,7 +2840,7 @@ int main (int argc, char *argv[])
                }
                if (!quiet)
                        printf("%s", _("done\n"));
-               ext2fs_close(jfs);
+               ext2fs_close_free(&jfs);
                free(journal_device);
        } else if ((journal_size) ||
                   (fs_param.s_feature_compat &
@@ -2765,15 +2892,22 @@ no_journal:
                                       EXT4_FEATURE_RO_COMPAT_BIGALLOC))
                fix_cluster_bg_counts(fs);
        if (EXT2_HAS_RO_COMPAT_FEATURE(&fs_param,
+                                      EXT4_FEATURE_RO_COMPAT_PROJECT))
+               quotatype_bits |= QUOTA_PRJ_BIT;
+       if (EXT2_HAS_RO_COMPAT_FEATURE(&fs_param,
                                       EXT4_FEATURE_RO_COMPAT_QUOTA))
                create_quota_inodes(fs);
 
+       retval = mk_hugefiles(fs, device_name);
+       if (retval)
+               com_err(program_name, retval, "while creating huge files");
+
        if (!quiet)
                printf("%s", _("Writing superblocks and "
                       "filesystem accounting information: "));
        checkinterval = fs->super->s_checkinterval;
        max_mnt_count = fs->super->s_max_mnt_count;
-       retval = ext2fs_close(fs);
+       retval = ext2fs_close_free(&fs);
        if (retval) {
                fprintf(stderr, "%s",
                        _("\nWarning, had trouble writing out superblocks."));