Whamcloud - gitweb
create_inode: move debugfs internal state back to debugfs
[tools/e2fsprogs.git] / misc / mke2fs.c
index abcfbf0..1422336 100644 (file)
 
 #define _XOPEN_SOURCE 600 /* for inclusion of PATH_MAX in Solaris */
 
+#include "config.h"
 #include <stdio.h>
 #include <string.h>
 #include <strings.h>
-#include <fcntl.h>
 #include <ctype.h>
 #include <time.h>
 #ifdef __linux__
 #include <sys/utsname.h>
+#include <linux/version.h>
 #endif
 #ifdef HAVE_GETOPT_H
 #include <getopt.h>
@@ -42,28 +43,21 @@ extern int optind;
 #ifdef HAVE_ERRNO_H
 #include <errno.h>
 #endif
-#ifdef HAVE_MNTENT_H
-#include <mntent.h>
-#endif
 #include <sys/ioctl.h>
-#include <sys/types.h>
-#include <sys/stat.h>
 #include <libgen.h>
 #include <limits.h>
 #include <blkid/blkid.h>
 
 #include "ext2fs/ext2_fs.h"
 #include "ext2fs/ext2fsP.h"
-#include "et/com_err.h"
 #include "uuid/uuid.h"
-#include "e2p/e2p.h"
-#include "ext2fs/ext2fs.h"
 #include "util.h"
 #include "profile.h"
 #include "prof_err.h"
 #include "../version.h"
-#include "nls-enable.h"
 #include "quota/mkquota.h"
+#include "mke2fs.h"
+#include "create_inode.h"
 
 #define STRIDE_LENGTH 8
 
@@ -79,47 +73,58 @@ extern int isatty(int);
 extern FILE *fpopen(const char *cmd, const char *mode);
 
 const char * program_name = "mke2fs";
-const char * device_name /* = NULL */;
+static const char * device_name /* = NULL */;
 
 /* Command line options */
-int    cflag;
+static int     cflag;
 int    verbose;
 int    quiet;
-int    super_only;
-int    discard = 1;    /* attempt to discard device before fs creation */
-int    force;
-int    noaction;
+static int     super_only;
+static int     discard = 1;    /* attempt to discard device before fs creation */
+static int     direct_io;
+static int     force;
+static int     noaction;
+static int     num_backups = 2; /* number of backup bg's for sparse_super2 */
+static uid_t   root_uid;
+static gid_t   root_gid;
 int    journal_size;
 int    journal_flags;
-int    lazy_itable_init;
-char   *bad_blocks_filename;
-__u32  fs_stride;
-
-struct ext2_super_block fs_param;
-char *fs_uuid = NULL;
-char *creator_os;
-char *volume_label;
-char *mount_dir;
+static int     lazy_itable_init;
+static int     packed_meta_blocks;
+static char    *bad_blocks_filename = NULL;
+static __u32   fs_stride;
+static int     quotatype = -1;  /* Initialize both user and group quotas by default */
+static __u64   offset;
+static blk64_t journal_location = ~0LL;
+
+static struct ext2_super_block fs_param;
+static char *fs_uuid = NULL;
+static char *creator_os;
+static char *volume_label;
+static char *mount_dir;
 char *journal_device;
-int sync_kludge;       /* Set using the MKE2FS_SYNC env. option */
+static int sync_kludge;        /* Set using the MKE2FS_SYNC env. option */
 char **fs_types;
+const char *root_dir;  /* Copy files from the specified directory */
 
-profile_t      profile;
+static profile_t       profile;
 
-int sys_page_size = 4096;
-int linux_version_code = 0;
+static int sys_page_size = 4096;
+static int linux_version_code = 0;
 
 static void usage(void)
 {
        fprintf(stderr, _("Usage: %s [-c|-l filename] [-b block-size] "
-       "[-f fragment-size]\n\t[-i bytes-per-inode] [-I inode-size] "
+       "[-C cluster-size]\n\t[-i bytes-per-inode] [-I inode-size] "
        "[-J journal-options]\n"
-       "\t[-G meta group size] [-N number-of-inodes]\n"
+       "\t[-G flex-group-size] [-N number-of-inodes] "
+       "[-d root-directory]\n"
        "\t[-m reserved-blocks-percentage] [-o creator-os]\n"
        "\t[-g blocks-per-group] [-L volume-label] "
        "[-M last-mounted-directory]\n\t[-O feature[,...]] "
        "[-r fs-revision] [-E extended-option[,...]]\n"
-       "\t[-T fs-type] [-U UUID] [-jnqvFKSV] device [blocks-count]\n"),
+       "\t[-t fs-type] [-T usage-type ] [-U UUID] "
+       "[-jnqvDFKSV] device [blocks-count]\n"),
                program_name);
        exit(1);
 }
@@ -136,7 +141,7 @@ static int int_log2(unsigned long long arg)
        return l;
 }
 
-static int int_log10(unsigned long long arg)
+int int_log10(unsigned long long arg)
 {
        int     l;
 
@@ -145,6 +150,7 @@ static int int_log10(unsigned long long arg)
        return l;
 }
 
+#ifdef __linux__
 static int parse_version_number(const char *s)
 {
        int     major, minor, rev;
@@ -164,9 +170,32 @@ static int parse_version_number(const char *s)
        rev = strtol(cp, &endptr, 10);
        if (cp == endptr)
                return 0;
-       return ((((major * 256) + minor) * 256) + rev);
+       return KERNEL_VERSION(major, minor, rev);
 }
 
+static int is_before_linux_ver(unsigned int major, unsigned int minor)
+{
+       struct          utsname ut;
+       static int      linux_version_code = -1;
+
+       if (uname(&ut)) {
+               perror("uname");
+               exit(1);
+       }
+       if (linux_version_code < 0)
+               linux_version_code = parse_version_number(ut.release);
+       if (linux_version_code == 0)
+               return 0;
+
+       return linux_version_code < KERNEL_VERSION(major, minor, 0);
+}
+#else
+static int is_before_linux_ver(unsigned int major, unsigned int minor)
+{
+       return 0;
+}
+#endif
+
 /*
  * Helper function for read_bb_file and test_disk
  */
@@ -194,7 +223,7 @@ static void read_bb_file(ext2_filsys fs, badblocks_list *bb_list,
        retval = ext2fs_read_bb_FILE(fs, f, bb_list, invalid_block);
        fclose (f);
        if (retval) {
-               com_err("ext2fs_read_bb_FILE", retval,
+               com_err("ext2fs_read_bb_FILE", retval, "%s",
                        _("while reading in list of bad blocks from file"));
                exit(1);
        }
@@ -223,7 +252,7 @@ static void test_disk(ext2_filsys fs, badblocks_list *bb_list)
        retval = ext2fs_read_bb_FILE(fs, f, bb_list, invalid_block);
        pclose(f);
        if (retval) {
-               com_err("ext2fs_read_bb_FILE", retval,
+               com_err("ext2fs_read_bb_FILE", retval, "%s",
                        _("while processing list of bad blocks from program"));
                exit(1);
        }
@@ -294,7 +323,7 @@ _("Warning: the backup superblock/group descriptors at block %u contain\n"
         */
        retval = ext2fs_badblocks_list_iterate_begin(bb_list, &bb_iter);
        if (retval) {
-               com_err("ext2fs_badblocks_list_iterate_begin", retval,
+               com_err("ext2fs_badblocks_list_iterate_begin", retval, "%s",
                        _("while marking bad blocks as used"));
                exit(1);
        }
@@ -303,6 +332,61 @@ _("Warning: the backup superblock/group descriptors at block %u contain\n"
        ext2fs_badblocks_list_iterate_end(bb_iter);
 }
 
+static void write_reserved_inodes(ext2_filsys fs)
+{
+       errcode_t       retval;
+       ext2_ino_t      ino;
+       struct ext2_inode *inode;
+
+       retval = ext2fs_get_mem(EXT2_INODE_SIZE(fs->super), &inode);
+       if (retval) {
+               com_err("inode_init", retval,
+                       "while allocating memory");
+               exit(1);
+       }
+       bzero(inode, EXT2_INODE_SIZE(fs->super));
+
+       for (ino = 1; ino < EXT2_FIRST_INO(fs->super); ino++)
+               ext2fs_write_inode_full(fs, ino, inode,
+                                       EXT2_INODE_SIZE(fs->super));
+
+       ext2fs_free_mem(&inode);
+}
+
+static errcode_t packed_allocate_tables(ext2_filsys fs)
+{
+       errcode_t       retval;
+       dgrp_t          i;
+       blk64_t         goal = 0;
+
+       for (i = 0; i < fs->group_desc_count; i++) {
+               retval = ext2fs_new_block2(fs, goal, NULL, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats2(fs, goal, +1);
+               ext2fs_block_bitmap_loc_set(fs, i, goal);
+       }
+       for (i = 0; i < fs->group_desc_count; i++) {
+               retval = ext2fs_new_block2(fs, goal, NULL, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats2(fs, goal, +1);
+               ext2fs_inode_bitmap_loc_set(fs, i, goal);
+       }
+       for (i = 0; i < fs->group_desc_count; i++) {
+               blk64_t end = ext2fs_blocks_count(fs->super) - 1;
+               retval = ext2fs_get_free_blocks2(fs, goal, end,
+                                                fs->inode_blocks_per_group,
+                                                fs->block_map, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats_range(fs, goal,
+                                              fs->inode_blocks_per_group, +1);
+               ext2fs_inode_table_loc_set(fs, i, goal);
+       }
+       return 0;
+}
+
 static void write_inode_tables(ext2_filsys fs, int lazy_flag, int itable_zeroed)
 {
        errcode_t       retval;
@@ -348,37 +432,41 @@ static void write_inode_tables(ext2_filsys fs, int lazy_flag, int itable_zeroed)
        ext2fs_zero_blocks2(0, 0, 0, 0, 0);
        ext2fs_numeric_progress_close(fs, &progress,
                                      _("done                            \n"));
+
+       /* Reserved inodes must always have correct checksums */
+       if (fs->super->s_creator_os == EXT2_OS_LINUX &&
+           fs->super->s_feature_ro_compat &
+           EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)
+               write_reserved_inodes(fs);
 }
 
 static void create_root_dir(ext2_filsys fs)
 {
        errcode_t               retval;
        struct ext2_inode       inode;
-       __u32                   uid, gid;
 
        retval = ext2fs_mkdir(fs, EXT2_ROOT_INO, EXT2_ROOT_INO, 0);
        if (retval) {
-               com_err("ext2fs_mkdir", retval, _("while creating root dir"));
+               com_err("ext2fs_mkdir", retval, "%s",
+                       _("while creating root dir"));
                exit(1);
        }
-       if (geteuid()) {
+       if (root_uid != 0 || root_gid != 0) {
                retval = ext2fs_read_inode(fs, EXT2_ROOT_INO, &inode);
                if (retval) {
-                       com_err("ext2fs_read_inode", retval,
+                       com_err("ext2fs_read_inode", retval, "%s",
                                _("while reading root inode"));
                        exit(1);
                }
-               uid = getuid();
-               inode.i_uid = uid;
-               ext2fs_set_i_uid_high(inode, uid >> 16);
-               if (uid) {
-                       gid = getgid();
-                       inode.i_gid = gid;
-                       ext2fs_set_i_gid_high(inode, gid >> 16);
-               }
+
+               inode.i_uid = root_uid;
+               ext2fs_set_i_uid_high(inode, root_uid >> 16);
+               inode.i_gid = root_gid;
+               ext2fs_set_i_gid_high(inode, root_gid >> 16);
+
                retval = ext2fs_write_new_inode(fs, EXT2_ROOT_INO, &inode);
                if (retval) {
-                       com_err("ext2fs_write_inode", retval,
+                       com_err("ext2fs_write_inode", retval, "%s",
                                _("while setting root inode ownership"));
                        exit(1);
                }
@@ -396,14 +484,14 @@ static void create_lost_and_found(ext2_filsys fs)
        fs->umask = 077;
        retval = ext2fs_mkdir(fs, EXT2_ROOT_INO, 0, name);
        if (retval) {
-               com_err("ext2fs_mkdir", retval,
+               com_err("ext2fs_mkdir", retval, "%s",
                        _("while creating /lost+found"));
                exit(1);
        }
 
        retval = ext2fs_lookup(fs, EXT2_ROOT_INO, name, strlen(name), 0, &ino);
        if (retval) {
-               com_err("ext2_lookup", retval,
+               com_err("ext2_lookup", retval, "%s",
                        _("while looking up /lost+found"));
                exit(1);
        }
@@ -416,7 +504,7 @@ static void create_lost_and_found(ext2_filsys fs)
                        break;
                retval = ext2fs_expand_dir(fs, ino);
                if (retval) {
-                       com_err("ext2fs_expand_dir", retval,
+                       com_err("ext2fs_expand_dir", retval, "%s",
                                _("while expanding /lost+found"));
                        exit(1);
                }
@@ -431,7 +519,7 @@ static void create_bad_block_inode(ext2_filsys fs, badblocks_list bb_list)
        ext2fs_inode_alloc_stats2(fs, EXT2_BAD_INO, +1, 0);
        retval = ext2fs_update_bb_inode(fs, bb_list);
        if (retval) {
-               com_err("ext2fs_update_bb_inode", retval,
+               com_err("ext2fs_update_bb_inode", retval, "%s",
                        _("while setting bad block inode"));
                exit(1);
        }
@@ -500,7 +588,7 @@ static void create_journal_dev(ext2_filsys fs)
        retval = ext2fs_create_journal_superblock(fs,
                                  ext2fs_blocks_count(fs->super), 0, &buf);
        if (retval) {
-               com_err("create_journal_dev", retval,
+               com_err("create_journal_dev", retval, "%s",
                        _("while initializing journal superblock"));
                exit(1);
        }
@@ -538,7 +626,7 @@ write_superblock:
                                        fs->super->s_first_data_block+1,
                                        1, buf);
        if (retval) {
-               com_err("create_journal_dev", retval,
+               com_err("create_journal_dev", retval, "%s",
                        _("while writing journal superblock"));
                exit(1);
        }
@@ -582,6 +670,8 @@ static void show_stats(ext2_filsys fs)
                ext2fs_r_blocks_count(s),
               100.0 *  ext2fs_r_blocks_count(s) / ext2fs_blocks_count(s));
        printf(_("First data block=%u\n"), s->s_first_data_block);
+       if (root_uid != 0 || root_gid != 0)
+               printf(_("Root directory owner=%u:%u\n"), root_uid, root_gid);
        if (s->s_reserved_gdt_blocks)
                printf(_("Maximum filesystem blocks=%lu\n"),
                       (s->s_reserved_gdt_blocks + fs->desc_blocks) *
@@ -604,7 +694,7 @@ static void show_stats(ext2_filsys fs)
                return;
        }
 
-       printf(_("Superblock backups stored on blocks: "));
+       printf("%s", _("Superblock backups stored on blocks: "));
        group_block = s->s_first_data_block;
        col_left = 0;
        for (i = 1; i < fs->group_desc_count; i++) {
@@ -625,6 +715,23 @@ static void show_stats(ext2_filsys fs)
 }
 
 /*
+ * Returns true if making a file system for the Hurd, else 0
+ */
+static int for_hurd(const char *os)
+{
+       if (!os) {
+#ifdef __GNU__
+               return 1;
+#else
+               return 0;
+#endif
+       }
+       if (isdigit(*os))
+               return (atoi(os) == EXT2_OS_HURD);
+       return (strcasecmp(os, "GNU") == 0 || strcasecmp(os, "hurd") == 0);
+}
+
+/*
  * Set the S_CREATOR_OS field.  Return true if OS is known,
  * otherwise, 0.
  */
@@ -657,7 +764,7 @@ static void parse_extended_opts(struct ext2_super_block *param,
        len = strlen(opts);
        buf = malloc(len+1);
        if (!buf) {
-               fprintf(stderr,
+               fprintf(stderr, "%s",
                        _("Couldn't allocate memory to parse options!\n"));
                exit(1);
        }
@@ -674,7 +781,87 @@ static void parse_extended_opts(struct ext2_super_block *param,
                        *arg = 0;
                        arg++;
                }
-               if (strcmp(token, "stride") == 0) {
+               if (strcmp(token, "desc-size") == 0 ||
+                   strcmp(token, "desc_size") == 0) {
+                       int desc_size;
+
+                       if (!(fs_param.s_feature_incompat &
+                             EXT4_FEATURE_INCOMPAT_64BIT)) {
+                               fprintf(stderr,
+                                       _("%s requires '-O 64bit'\n"), token);
+                               r_usage++;
+                               continue;
+                       }
+                       if (param->s_reserved_gdt_blocks != 0) {
+                               fprintf(stderr,
+                                       _("'%s' must be before 'resize=%u'\n"),
+                                       token, param->s_reserved_gdt_blocks);
+                               r_usage++;
+                               continue;
+                       }
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       desc_size = strtoul(arg, &p, 0);
+                       if (*p || (desc_size & (desc_size - 1))) {
+                               fprintf(stderr,
+                                       _("Invalid desc_size: '%s'\n"), arg);
+                               r_usage++;
+                               continue;
+                       }
+                       param->s_desc_size = desc_size;
+               } else if (strcmp(token, "offset") == 0) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       offset = strtoull(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr, _("Invalid offset: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "mmp_update_interval") == 0) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       param->s_mmp_update_interval = strtoul(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr,
+                                       _("Invalid mmp_update_interval: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "num_backup_sb") == 0) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       num_backups = strtoul(arg, &p, 0);
+                       if (*p || num_backups > 2) {
+                               fprintf(stderr,
+                                       _("Invalid # of backup "
+                                         "superbocks: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "packed_meta_blocks") == 0) {
+                       if (arg)
+                               packed_meta_blocks = strtoul(arg, &p, 0);
+                       else
+                               packed_meta_blocks = 1;
+                       if (packed_meta_blocks)
+                               journal_location = 0;
+               } else if (strcmp(token, "stride") == 0) {
                        if (!arg) {
                                r_usage++;
                                badopt = token;
@@ -727,7 +914,7 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                continue;
                        }
                        if (resize <= ext2fs_blocks_count(param)) {
-                               fprintf(stderr,
+                               fprintf(stderr, "%s",
                                        _("The resize maximum must be greater "
                                          "than the filesystem size.\n"));
                                r_usage++;
@@ -751,7 +938,7 @@ static void parse_extended_opts(struct ext2_super_block *param,
 
                        if (rsv_gdb > 0) {
                                if (param->s_rev_level == EXT2_GOOD_OLD_REV) {
-                                       fprintf(stderr,
+                                       fprintf(stderr, "%s",
        _("On-line resizing not supported with revision 0 filesystems\n"));
                                        free(buf);
                                        exit(1);
@@ -774,10 +961,50 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                                EXT2_MKJOURNAL_LAZYINIT : 0;
                        else
                                journal_flags |= EXT2_MKJOURNAL_LAZYINIT;
+               } else if (!strcmp(token, "root_owner")) {
+                       if (arg) {
+                               root_uid = strtoul(arg, &p, 0);
+                               if (*p != ':') {
+                                       fprintf(stderr,
+                                               _("Invalid root_owner: '%s'\n"),
+                                               arg);
+                                       r_usage++;
+                                       continue;
+                               }
+                               p++;
+                               root_gid = strtoul(p, &p, 0);
+                               if (*p) {
+                                       fprintf(stderr,
+                                               _("Invalid root_owner: '%s'\n"),
+                                               arg);
+                                       r_usage++;
+                                       continue;
+                               }
+                       } else {
+                               root_uid = getuid();
+                               root_gid = getgid();
+                       }
                } else if (!strcmp(token, "discard")) {
                        discard = 1;
                } else if (!strcmp(token, "nodiscard")) {
                        discard = 0;
+               } else if (!strcmp(token, "quotatype")) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       if (!strncmp(arg, "usr", 3)) {
+                               quotatype = 0;
+                       } else if (!strncmp(arg, "grp", 3)) {
+                               quotatype = 1;
+                       } else {
+                               fprintf(stderr,
+                                       _("Invalid quotatype parameter: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
                } else {
                        r_usage++;
                        badopt = token;
@@ -789,14 +1016,21 @@ static void parse_extended_opts(struct ext2_super_block *param,
                        "and may take an argument which\n"
                        "\tis set off by an equals ('=') sign.\n\n"
                        "Valid extended options are:\n"
+                       "\tmmp_update_interval=<interval>\n"
+                       "\tnum_backup_sb=<0|1|2>\n"
                        "\tstride=<RAID per-disk data chunk in blocks>\n"
                        "\tstripe-width=<RAID stride * data disks in blocks>\n"
+                       "\toffset=<offset to create the file system>\n"
                        "\tresize=<resize maximum size in blocks>\n"
+                       "\tpacked_meta_blocks=<0 to disable, 1 to enable>\n"
                        "\tlazy_itable_init=<0 to disable, 1 to enable>\n"
                        "\tlazy_journal_init=<0 to disable, 1 to enable>\n"
+                       "\troot_uid=<uid of root directory>\n"
+                       "\troot_gid=<gid of root directory>\n"
                        "\ttest_fs\n"
                        "\tdiscard\n"
-                       "\tnodiscard\n\n"),
+                       "\tnodiscard\n"
+                       "\tquotatype=<usr OR grp>\n\n"),
                        badopt ? badopt : "");
                free(buf);
                exit(1);
@@ -815,14 +1049,17 @@ static __u32 ok_features[3] = {
        EXT3_FEATURE_COMPAT_HAS_JOURNAL |
                EXT2_FEATURE_COMPAT_RESIZE_INODE |
                EXT2_FEATURE_COMPAT_DIR_INDEX |
-               EXT2_FEATURE_COMPAT_EXT_ATTR,
+               EXT2_FEATURE_COMPAT_EXT_ATTR |
+               EXT4_FEATURE_COMPAT_SPARSE_SUPER2,
        /* Incompat */
        EXT2_FEATURE_INCOMPAT_FILETYPE|
                EXT3_FEATURE_INCOMPAT_EXTENTS|
                EXT3_FEATURE_INCOMPAT_JOURNAL_DEV|
                EXT2_FEATURE_INCOMPAT_META_BG|
                EXT4_FEATURE_INCOMPAT_FLEX_BG|
-               EXT4_FEATURE_INCOMPAT_64BIT,
+               EXT4_FEATURE_INCOMPAT_MMP |
+               EXT4_FEATURE_INCOMPAT_64BIT|
+               EXT4_FEATURE_INCOMPAT_INLINE_DATA,
        /* R/O compat */
        EXT2_FEATURE_RO_COMPAT_LARGE_FILE|
                EXT4_FEATURE_RO_COMPAT_HUGE_FILE|
@@ -831,7 +1068,10 @@ static __u32 ok_features[3] = {
                EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER|
                EXT4_FEATURE_RO_COMPAT_GDT_CSUM|
                EXT4_FEATURE_RO_COMPAT_BIGALLOC|
-               EXT4_FEATURE_RO_COMPAT_QUOTA
+#ifdef CONFIG_QUOTA
+               EXT4_FEATURE_RO_COMPAT_QUOTA|
+#endif
+               EXT4_FEATURE_RO_COMPAT_METADATA_CSUM
 };
 
 
@@ -921,7 +1161,7 @@ static void print_str_list(char **list)
 /*
  * Return TRUE if the profile has the given subsection
  */
-static int profile_has_subsection(profile_t profile, const char *section,
+static int profile_has_subsection(profile_t prof, const char *section,
                                  const char *subsection)
 {
        void                    *state;
@@ -933,7 +1173,7 @@ static int profile_has_subsection(profile_t profile, const char *section,
        names[1] = subsection;
        names[2] = 0;
 
-       if (profile_iterator_create(profile, names,
+       if (profile_iterator_create(prof, names,
                                    PROFILE_ITER_LIST_SECTION |
                                    PROFILE_ITER_RELATIONS_ONLY, &state))
                return 0;
@@ -949,7 +1189,7 @@ static int profile_has_subsection(profile_t profile, const char *section,
 
 static char **parse_fs_type(const char *fs_type,
                            const char *usage_types,
-                           struct ext2_super_block *fs_param,
+                           struct ext2_super_block *sb,
                            blk64_t fs_blocks_count,
                            char *progname)
 {
@@ -960,21 +1200,19 @@ static char **parse_fs_type(const char *fs_type,
        const char      *size_type;
        struct str_list list;
        unsigned long long meg;
-       int             is_hurd = 0;
+       int             is_hurd = for_hurd(creator_os);
 
        if (init_list(&list))
                return 0;
 
-       if (creator_os && (!strcasecmp(creator_os, "GNU") ||
-                          !strcasecmp(creator_os, "hurd")))
-               is_hurd = 1;
-
        if (fs_type)
                ext_type = fs_type;
        else if (is_hurd)
                ext_type = "ext2";
        else if (!strcmp(program_name, "mke3fs"))
                ext_type = "ext3";
+       else if (!strcmp(program_name, "mke4fs"))
+               ext_type = "ext4";
        else if (progname) {
                ext_type = strrchr(progname, '/');
                if (ext_type)
@@ -1005,16 +1243,16 @@ static char **parse_fs_type(const char *fs_type,
                         "%s filesystem type.\n"), ext_type);
                if (!strcmp(ext_type, "ext3") || !strcmp(ext_type, "ext4") ||
                    !strcmp(ext_type, "ext4dev")) {
-                       printf(_("You probably need to install an updated "
-                                "mke2fs.conf file.\n\n"));
+                       printf("%s", _("You probably need to install an "
+                                      "updated mke2fs.conf file.\n\n"));
                }
                if (!force) {
-                       printf(_("Aborting...\n"));
+                       printf("%s", _("Aborting...\n"));
                        exit(1);
                }
        }
 
-       meg = (1024 * 1024) / EXT2_BLOCK_SIZE(fs_param);
+       meg = (1024 * 1024) / EXT2_BLOCK_SIZE(sb);
        if (fs_blocks_count < 3 * meg)
                size_type = "floppy";
        else if (fs_blocks_count < 512 * meg)
@@ -1029,15 +1267,13 @@ static char **parse_fs_type(const char *fs_type,
        if (!usage_types)
                usage_types = size_type;
 
-       parse_str = malloc(usage_types ? strlen(usage_types)+1 : 1);
+       parse_str = malloc(strlen(usage_types)+1);
        if (!parse_str) {
+               free(profile_type);
                free(list.list);
                return 0;
        }
-       if (usage_types)
-               strcpy(parse_str, usage_types);
-       else
-               *parse_str = '\0';
+       strcpy(parse_str, usage_types);
 
        if (ext_type)
                push_string(&list, ext_type);
@@ -1058,10 +1294,8 @@ static char **parse_fs_type(const char *fs_type,
                }
                if (t)
                        cp = t+1;
-               else {
-                       cp = "";
+               else
                        break;
-               }
        }
        free(parse_str);
        free(profile_type);
@@ -1070,15 +1304,15 @@ static char **parse_fs_type(const char *fs_type,
        return (list.list);
 }
 
-static char *get_string_from_profile(char **fs_types, const char *opt,
+char *get_string_from_profile(char **types, const char *opt,
                                     const char *def_val)
 {
        char *ret = 0;
        int i;
 
-       for (i=0; fs_types[i]; i++);
+       for (i=0; types[i]; i++);
        for (i-=1; i >=0 ; i--) {
-               profile_get_string(profile, "fs_types", fs_types[i],
+               profile_get_string(profile, "fs_types", types[i],
                                   opt, 0, &ret);
                if (ret)
                        return ret;
@@ -1087,36 +1321,36 @@ static char *get_string_from_profile(char **fs_types, const char *opt,
        return (ret);
 }
 
-static int get_int_from_profile(char **fs_types, const char *opt, int def_val)
+int get_int_from_profile(char **types, const char *opt, int def_val)
 {
        int ret;
        char **cpp;
 
        profile_get_integer(profile, "defaults", opt, 0, def_val, &ret);
-       for (cpp = fs_types; *cpp; cpp++)
+       for (cpp = types; *cpp; cpp++)
                profile_get_integer(profile, "fs_types", *cpp, opt, ret, &ret);
        return ret;
 }
 
-static double get_double_from_profile(char **fs_types, const char *opt,
+static double get_double_from_profile(char **types, const char *opt,
                                      double def_val)
 {
        double ret;
        char **cpp;
 
        profile_get_double(profile, "defaults", opt, 0, def_val, &ret);
-       for (cpp = fs_types; *cpp; cpp++)
+       for (cpp = types; *cpp; cpp++)
                profile_get_double(profile, "fs_types", *cpp, opt, ret, &ret);
        return ret;
 }
 
-static int get_bool_from_profile(char **fs_types, const char *opt, int def_val)
+int get_bool_from_profile(char **types, const char *opt, int def_val)
 {
        int ret;
        char **cpp;
 
        profile_get_boolean(profile, "defaults", opt, 0, def_val, &ret);
-       for (cpp = fs_types; *cpp; cpp++)
+       for (cpp = types; *cpp; cpp++)
                profile_get_boolean(profile, "fs_types", *cpp, opt, ret, &ret);
        return ret;
 }
@@ -1195,10 +1429,22 @@ static void PRS(int argc, char *argv[])
        char *          fs_type = 0;
        char *          usage_types = 0;
        blk64_t         dev_size;
+       /*
+        * NOTE: A few words about fs_blocks_count and blocksize:
+        *
+        * Initially, blocksize is set to zero, which implies 1024.
+        * If -b is specified, blocksize is updated to the user's value.
+        *
+        * Next, the device size or the user's "blocks" command line argument
+        * is used to set fs_blocks_count; the units are blocksize.
+        *
+        * Later, if blocksize hasn't been set and the profile specifies a
+        * blocksize, then blocksize is updated and fs_blocks_count is scaled
+        * appropriately.  Note the change in units!
+        *
+        * Finally, we complain about fs_blocks_count > 2^32 on a non-64bit fs.
+        */
        blk64_t         fs_blocks_count = 0;
-#ifdef __linux__
-       struct          utsname ut;
-#endif
        long            sysval;
        int             s_opt = -1, r_opt = -1;
        char            *fs_features = 0;
@@ -1210,7 +1456,8 @@ static void PRS(int argc, char *argv[])
                pathlen += strlen(oldpath);
        newpath = malloc(pathlen);
        if (!newpath) {
-               fprintf(stderr, _("Couldn't allocate memory for new PATH.\n"));
+               fprintf(stderr, "%s",
+                       _("Couldn't allocate memory for new PATH.\n"));
                exit(1);
        }
        strcpy(newpath, PATH_SET);
@@ -1263,15 +1510,8 @@ profile_error:
        memset(&fs_param, 0, sizeof(struct ext2_super_block));
        fs_param.s_rev_level = 1;  /* Create revision 1 filesystems now */
 
-#ifdef __linux__
-       if (uname(&ut)) {
-               perror("uname");
-               exit(1);
-       }
-       linux_version_code = parse_version_number(ut.release);
-       if (linux_version_code && linux_version_code < (2*65536 + 2*256))
+       if (is_before_linux_ver(2, 2))
                fs_param.s_rev_level = 0;
-#endif
 
        if (argc && *argv) {
                program_name = get_progname(*argv);
@@ -1283,13 +1523,13 @@ profile_error:
        }
 
        while ((c = getopt (argc, argv,
-                   "b:cg:i:jl:m:no:qr:s:t:vC:E:FG:I:J:KL:M:N:O:R:ST:U:V")) != EOF) {
+                   "b:cg:i:jl:m:no:qr:s:t:d:vC:DE:FG:I:J:KL:M:N:O:R:ST:U:V")) != EOF) {
                switch (c) {
                case 'b':
-                       blocksize = strtol(optarg, &tmp, 0);
+                       blocksize = parse_num_blocks2(optarg, -1);
                        b = (blocksize > 0) ? blocksize : -blocksize;
                        if (b < EXT2_MIN_BLOCK_SIZE ||
-                           b > EXT2_MAX_BLOCK_SIZE || *tmp) {
+                           b > EXT2_MAX_BLOCK_SIZE) {
                                com_err(program_name, 0,
                                        _("invalid block size - %s"), optarg);
                                exit(1);
@@ -1307,24 +1547,37 @@ profile_error:
                        cflag++;
                        break;
                case 'C':
-                       cluster_size = strtoul(optarg, &tmp, 0);
-                       if (cluster_size < EXT2_MIN_CLUSTER_SIZE ||
-                           cluster_size > EXT2_MAX_CLUSTER_SIZE || *tmp) {
+                       cluster_size = parse_num_blocks2(optarg, -1);
+                       if (cluster_size <= EXT2_MIN_CLUSTER_SIZE ||
+                           cluster_size > EXT2_MAX_CLUSTER_SIZE) {
                                com_err(program_name, 0,
-                                       _("invalid fragment size - %s"),
+                                       _("invalid cluster size - %s"),
                                        optarg);
                                exit(1);
                        }
                        break;
+               case 'D':
+                       direct_io = 1;
+                       break;
+               case 'R':
+                       com_err(program_name, 0, "%s",
+                               _("'-R' is deprecated, use '-E' instead"));
+                       /* fallthrough */
+               case 'E':
+                       extended_opts = optarg;
+                       break;
+               case 'F':
+                       force++;
+                       break;
                case 'g':
                        fs_param.s_blocks_per_group = strtoul(optarg, &tmp, 0);
                        if (*tmp) {
-                               com_err(program_name, 0,
-                                       _("Illegal number for blocks per group"));
+                               com_err(program_name, 0, "%s",
+                               _("Illegal number for blocks per group"));
                                exit(1);
                        }
                        if ((fs_param.s_blocks_per_group % 8) != 0) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                _("blocks per group must be multiple of 8"));
                                exit(1);
                        }
@@ -1332,13 +1585,13 @@ profile_error:
                case 'G':
                        flex_bg_size = strtoul(optarg, &tmp, 0);
                        if (*tmp) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                        _("Illegal number for flex_bg size"));
                                exit(1);
                        }
                        if (flex_bg_size < 1 ||
                            (flex_bg_size & (flex_bg_size-1)) != 0) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                        _("flex_bg size must be a power of 2"));
                                exit(1);
                        }
@@ -1355,29 +1608,42 @@ profile_error:
                                exit(1);
                        }
                        break;
+               case 'I':
+                       inode_size = strtoul(optarg, &tmp, 0);
+                       if (*tmp) {
+                               com_err(program_name, 0,
+                                       _("invalid inode size - %s"), optarg);
+                               exit(1);
+                       }
+                       break;
+               case 'j':
+                       if (!journal_size)
+                               journal_size = -1;
+                       break;
                case 'J':
                        parse_journal_opts(optarg);
                        break;
                case 'K':
-                       fprintf(stderr, _("Warning: -K option is deprecated and "
-                                         "should not be used anymore. Use "
-                                         "\'-E nodiscard\' extended option "
-                                         "instead!\n"));
+                       fprintf(stderr, "%s",
+                               _("Warning: -K option is deprecated and "
+                                 "should not be used anymore. Use "
+                                 "\'-E nodiscard\' extended option "
+                                 "instead!\n"));
                        discard = 0;
                        break;
-               case 'j':
-                       if (!journal_size)
-                               journal_size = -1;
-                       break;
                case 'l':
-                       bad_blocks_filename = malloc(strlen(optarg)+1);
+                       bad_blocks_filename = realloc(bad_blocks_filename,
+                                                     strlen(optarg) + 1);
                        if (!bad_blocks_filename) {
-                               com_err(program_name, ENOMEM,
+                               com_err(program_name, ENOMEM, "%s",
                                        _("in malloc for bad_blocks_filename"));
                                exit(1);
                        }
                        strcpy(bad_blocks_filename, optarg);
                        break;
+               case 'L':
+                       volume_label = optarg;
+                       break;
                case 'm':
                        reserved_ratio = strtod(optarg, &tmp);
                        if ( *tmp || reserved_ratio > 50 ||
@@ -1388,12 +1654,26 @@ profile_error:
                                exit(1);
                        }
                        break;
+               case 'M':
+                       mount_dir = optarg;
+                       break;
                case 'n':
                        noaction++;
                        break;
+               case 'N':
+                       num_inodes = strtoul(optarg, &tmp, 0);
+                       if (*tmp) {
+                               com_err(program_name, 0,
+                                       _("bad num inodes - %s"), optarg);
+                                       exit(1);
+                       }
+                       break;
                case 'o':
                        creator_os = optarg;
                        break;
+               case 'O':
+                       fs_features = optarg;
+                       break;
                case 'q':
                        quiet = 1;
                        break;
@@ -1409,53 +1689,34 @@ profile_error:
                case 's':       /* deprecated */
                        s_opt = atoi(optarg);
                        break;
-               case 'I':
-                       inode_size = strtoul(optarg, &tmp, 0);
-                       if (*tmp) {
-                               com_err(program_name, 0,
-                                       _("invalid inode size - %s"), optarg);
-                               exit(1);
-                       }
-                       break;
-               case 'v':
-                       verbose = 1;
-                       break;
-               case 'F':
-                       force++;
-                       break;
-               case 'L':
-                       volume_label = optarg;
-                       break;
-               case 'M':
-                       mount_dir = optarg;
-                       break;
-               case 'N':
-                       num_inodes = strtoul(optarg, &tmp, 0);
-                       if (*tmp) {
-                               com_err(program_name, 0,
-                                       _("bad num inodes - %s"), optarg);
-                                       exit(1);
-                       }
-                       break;
-               case 'O':
-                       fs_features = optarg;
-                       break;
-               case 'E':
-               case 'R':
-                       extended_opts = optarg;
-                       break;
                case 'S':
                        super_only = 1;
                        break;
                case 't':
+                       if (fs_type) {
+                               com_err(program_name, 0, "%s",
+                                   _("The -t option may only be used once"));
+                               exit(1);
+                       }
                        fs_type = strdup(optarg);
                        break;
                case 'T':
+                       if (usage_types) {
+                               com_err(program_name, 0, "%s",
+                                   _("The -T option may only be used once"));
+                               exit(1);
+                       }
                        usage_types = strdup(optarg);
                        break;
                case 'U':
                        fs_uuid = optarg;
                        break;
+               case 'd':
+                       root_dir = optarg;
+                       break;
+               case 'v':
+                       verbose = 1;
+                       break;
                case 'V':
                        /* Print version number and exit */
                        show_version_only++;
@@ -1543,20 +1804,20 @@ profile_error:
                                                 &dev_size);
 
        if (retval && (retval != EXT2_ET_UNIMPLEMENTED)) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while trying to determine filesystem size"));
                exit(1);
        }
        if (!fs_blocks_count) {
                if (retval == EXT2_ET_UNIMPLEMENTED) {
-                       com_err(program_name, 0,
+                       com_err(program_name, 0, "%s",
                                _("Couldn't determine device size; you "
                                "must specify\nthe size of the "
                                "filesystem\n"));
                        exit(1);
                } else {
                        if (dev_size == 0) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                _("Device size reported to be zero.  "
                                  "Invalid partition specified, or\n\t"
                                  "partition table wasn't reread "
@@ -1573,7 +1834,7 @@ profile_error:
                                             EXT2_BLOCK_SIZE(&fs_param))-1));
                }
        } else if (!force && (fs_blocks_count > dev_size)) {
-               com_err(program_name, 0,
+               com_err(program_name, 0, "%s",
                        _("Filesystem larger than apparent device size."));
                proceed_question();
        }
@@ -1594,7 +1855,7 @@ profile_error:
                                 fs_blocks_count ? fs_blocks_count : dev_size,
                                 argv[0]);
        if (!fs_types) {
-               fprintf(stderr, _("Failed to parse fs types list\n"));
+               fprintf(stderr, "%s", _("Failed to parse fs types list\n"));
                exit(1);
        }
 
@@ -1626,20 +1887,104 @@ profile_error:
                tmp = get_string_from_profile(fs_types, "default_features",
                                              "");
        }
+       /* Mask off features which aren't supported by the Hurd */
+       if (for_hurd(creator_os)) {
+               fs_param.s_feature_incompat &= ~EXT2_FEATURE_INCOMPAT_FILETYPE;
+               fs_param.s_feature_ro_compat &=
+                       ~(EXT4_FEATURE_RO_COMPAT_HUGE_FILE |
+                         EXT4_FEATURE_RO_COMPAT_METADATA_CSUM);
+       }
        edit_feature(fs_features ? fs_features : tmp,
                     &fs_param.s_feature_compat);
        if (tmp)
                free(tmp);
+       /*
+        * If the user specified features incompatible with the Hurd, complain
+        */
+       if (for_hurd(creator_os)) {
+               if (fs_param.s_feature_incompat &
+                   EXT2_FEATURE_INCOMPAT_FILETYPE) {
+                       fprintf(stderr, _("The HURD does not support the "
+                                         "filetype feature.\n"));
+                       exit(1);
+               }
+               if (fs_param.s_feature_ro_compat &
+                   EXT4_FEATURE_RO_COMPAT_HUGE_FILE) {
+                       fprintf(stderr, _("The HURD does not support the "
+                                         "huge_file feature.\n"));
+                       exit(1);
+               }
+               if (fs_param.s_feature_ro_compat &
+                   EXT4_FEATURE_RO_COMPAT_METADATA_CSUM) {
+                       fprintf(stderr, _("The HURD does not support the "
+                                         "metadata_csum feature.\n"));
+                       exit(1);
+               }
+       }
+
+       /* Get the hardware sector sizes, if available */
+       retval = ext2fs_get_device_sectsize(device_name, &lsector_size);
+       if (retval) {
+               com_err(program_name, retval, "%s",
+                       _("while trying to determine hardware sector size"));
+               exit(1);
+       }
+       retval = ext2fs_get_device_phys_sectsize(device_name, &psector_size);
+       if (retval) {
+               com_err(program_name, retval, "%s",
+                       _("while trying to determine physical sector size"));
+               exit(1);
+       }
+
+       tmp = getenv("MKE2FS_DEVICE_SECTSIZE");
+       if (tmp != NULL)
+               lsector_size = atoi(tmp);
+       tmp = getenv("MKE2FS_DEVICE_PHYS_SECTSIZE");
+       if (tmp != NULL)
+               psector_size = atoi(tmp);
+
+       /* Older kernels may not have physical/logical distinction */
+       if (!psector_size)
+               psector_size = lsector_size;
+
+       if (blocksize <= 0) {
+               use_bsize = get_int_from_profile(fs_types, "blocksize", 4096);
+
+               if (use_bsize == -1) {
+                       use_bsize = sys_page_size;
+                       if (is_before_linux_ver(2, 6) && use_bsize > 4096)
+                               use_bsize = 4096;
+               }
+               if (lsector_size && use_bsize < lsector_size)
+                       use_bsize = lsector_size;
+               if ((blocksize < 0) && (use_bsize < (-blocksize)))
+                       use_bsize = -blocksize;
+               blocksize = use_bsize;
+               fs_blocks_count /= (blocksize / 1024);
+       } else {
+               if (blocksize < lsector_size) {                 /* Impossible */
+                       com_err(program_name, EINVAL, "%s",
+                               _("while setting blocksize; too small "
+                                 "for device\n"));
+                       exit(1);
+               } else if ((blocksize < psector_size) &&
+                          (psector_size <= sys_page_size)) {   /* Suboptimal */
+                       fprintf(stderr, _("Warning: specified blocksize %d is "
+                               "less than device physical sectorsize %d\n"),
+                               blocksize, psector_size);
+               }
+       }
+
+       fs_param.s_log_block_size =
+               int_log2(blocksize >> EXT2_MIN_BLOCK_LOG_SIZE);
 
        /*
         * We now need to do a sanity check of fs_blocks_count for
         * 32-bit vs 64-bit block number support.
         */
-       if ((fs_blocks_count > MAX_32_NUM) && (blocksize == 0)) {
-               fs_blocks_count /= 4; /* Try using a 4k blocksize */
-               blocksize = 4096;
-               fs_param.s_log_block_size = 2;
-       }
+       if ((fs_blocks_count > MAX_32_NUM) &&
+           (fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT))
+               fs_param.s_feature_compat &= ~EXT2_FEATURE_COMPAT_RESIZE_INODE;
        if ((fs_blocks_count > MAX_32_NUM) &&
            !(fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT) &&
            get_bool_from_profile(fs_types, "auto_64-bit_support", 0)) {
@@ -1671,14 +2016,15 @@ profile_error:
        if (r_opt == EXT2_GOOD_OLD_REV &&
            (fs_param.s_feature_compat || fs_param.s_feature_incompat ||
             fs_param.s_feature_ro_compat)) {
-               fprintf(stderr, _("Filesystem features not supported "
-                                 "with revision 0 filesystems\n"));
+               fprintf(stderr, "%s", _("Filesystem features not supported "
+                                       "with revision 0 filesystems\n"));
                exit(1);
        }
 
        if (s_opt > 0) {
                if (r_opt == EXT2_GOOD_OLD_REV) {
-                       fprintf(stderr, _("Sparse superblocks not supported "
+                       fprintf(stderr, "%s",
+                               _("Sparse superblocks not supported "
                                  "with revision 0 filesystems\n"));
                        exit(1);
                }
@@ -1690,8 +2036,8 @@ profile_error:
 
        if (journal_size != 0) {
                if (r_opt == EXT2_GOOD_OLD_REV) {
-                       fprintf(stderr, _("Journals not supported "
-                                 "with revision 0 filesystems\n"));
+                       fprintf(stderr, "%s", _("Journals not supported with "
+                                               "revision 0 filesystems\n"));
                        exit(1);
                }
                fs_param.s_feature_compat |=
@@ -1718,12 +2064,11 @@ profile_error:
                fs_param.s_feature_ro_compat = 0;
        }
 
-       if ((fs_param.s_feature_incompat & EXT2_FEATURE_INCOMPAT_META_BG) &&
-           (fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_RESIZE_INODE)) {
-               fprintf(stderr, _("The resize_inode and meta_bg features "
-                                 "are not compatible.\n"
-                                 "They can not be both enabled "
-                                 "simultaneously.\n"));
+       /* Check the user's mkfs options for 64bit */
+       if ((fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT) &&
+           !(fs_param.s_feature_incompat & EXT3_FEATURE_INCOMPAT_EXTENTS)) {
+               printf("%s", _("Extents MUST be enabled for a 64-bit "
+                              "filesystem.  Pass -O extents to rectify.\n"));
                exit(1);
        }
 
@@ -1732,63 +2077,6 @@ profile_error:
        if ((fs_param.s_feature_incompat & EXT2_FEATURE_INCOMPAT_META_BG) &&
            ((tmp = getenv("MKE2FS_FIRST_META_BG"))))
                fs_param.s_first_meta_bg = atoi(tmp);
-
-       /* Get the hardware sector sizes, if available */
-       retval = ext2fs_get_device_sectsize(device_name, &lsector_size);
-       if (retval) {
-               com_err(program_name, retval,
-                       _("while trying to determine hardware sector size"));
-               exit(1);
-       }
-       retval = ext2fs_get_device_phys_sectsize(device_name, &psector_size);
-       if (retval) {
-               com_err(program_name, retval,
-                       _("while trying to determine physical sector size"));
-               exit(1);
-       }
-
-       if ((tmp = getenv("MKE2FS_DEVICE_SECTSIZE")) != NULL)
-               lsector_size = atoi(tmp);
-       if ((tmp = getenv("MKE2FS_DEVICE_PHYS_SECTSIZE")) != NULL)
-               psector_size = atoi(tmp);
-
-       /* Older kernels may not have physical/logical distinction */
-       if (!psector_size)
-               psector_size = lsector_size;
-
-       if (blocksize <= 0) {
-               use_bsize = get_int_from_profile(fs_types, "blocksize", 4096);
-
-               if (use_bsize == -1) {
-                       use_bsize = sys_page_size;
-                       if ((linux_version_code < (2*65536 + 6*256)) &&
-                           (use_bsize > 4096))
-                               use_bsize = 4096;
-               }
-               if (lsector_size && use_bsize < lsector_size)
-                       use_bsize = lsector_size;
-               if ((blocksize < 0) && (use_bsize < (-blocksize)))
-                       use_bsize = -blocksize;
-               blocksize = use_bsize;
-               ext2fs_blocks_count_set(&fs_param,
-                                       ext2fs_blocks_count(&fs_param) /
-                                       (blocksize / 1024));
-       } else {
-               if (blocksize < lsector_size) {                 /* Impossible */
-                       com_err(program_name, EINVAL,
-                               _("while setting blocksize; too small "
-                                 "for device\n"));
-                       exit(1);
-               } else if ((blocksize < psector_size) &&
-                          (psector_size <= sys_page_size)) {   /* Suboptimal */
-                       fprintf(stderr, _("Warning: specified blocksize %d is "
-                               "less than device physical sectorsize %d\n"),
-                               blocksize, psector_size);
-               }
-       }
-
-       fs_param.s_log_block_size =
-               int_log2(blocksize >> EXT2_MIN_BLOCK_LOG_SIZE);
        if (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) {
                if (!cluster_size)
                        cluster_size = get_int_from_profile(fs_types,
@@ -1796,6 +2084,18 @@ profile_error:
                                                            blocksize*16);
                fs_param.s_log_cluster_size =
                        int_log2(cluster_size >> EXT2_MIN_CLUSTER_LOG_SIZE);
+               if (fs_param.s_log_cluster_size &&
+                   fs_param.s_log_cluster_size < fs_param.s_log_block_size) {
+                       com_err(program_name, 0, "%s",
+                               _("The cluster size may not be "
+                                 "smaller than the block size.\n"));
+                       exit(1);
+               }
+       } else if (cluster_size) {
+               com_err(program_name, 0, "%s",
+                       _("specifying a cluster size requires the "
+                         "bigalloc feature"));
+               exit(1);
        } else
                fs_param.s_log_cluster_size = fs_param.s_log_block_size;
 
@@ -1822,8 +2122,18 @@ profile_error:
        }
 #endif
 
+       num_backups = get_int_from_profile(fs_types, "num_backup_sb", 2);
+
        blocksize = EXT2_BLOCK_SIZE(&fs_param);
 
+       /*
+        * Initialize s_desc_size so that the parse_extended_opts()
+        * can correctly handle "-E resize=NNN" if the 64-bit option
+        * is set.
+        */
+       if (fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT)
+               fs_param.s_desc_size = EXT2_MIN_DESC_SIZE_64BIT;
+
        /* This check should happen beyond the last assignment to blocksize */
        if (blocksize > sys_page_size) {
                if (!force) {
@@ -1848,6 +2158,21 @@ profile_error:
        journal_flags |= get_bool_from_profile(fs_types,
                                               "lazy_journal_init", 0) ?
                                               EXT2_MKJOURNAL_LAZYINIT : 0;
+       journal_flags |= EXT2_MKJOURNAL_NO_MNT_CHECK;
+
+       if (!journal_location_string)
+               journal_location_string = get_string_from_profile(fs_types,
+                                               "journal_location", "");
+       if ((journal_location == ~0ULL) && journal_location_string &&
+           *journal_location_string)
+               journal_location = parse_num_blocks2(journal_location_string,
+                                               fs_param.s_log_block_size);
+       free(journal_location_string);
+
+       packed_meta_blocks = get_bool_from_profile(fs_types,
+                                                  "packed_meta_blocks", 0);
+       if (packed_meta_blocks)
+               journal_location = 0;
 
        /* Get options from profile */
        for (cpp = fs_types; *cpp; cpp++) {
@@ -1861,12 +2186,52 @@ profile_error:
        if (extended_opts)
                parse_extended_opts(&fs_param, extended_opts);
 
-       /* Since sparse_super is the default, we would only have a problem
+       /* Don't allow user to set both metadata_csum and uninit_bg bits. */
+       if ((fs_param.s_feature_ro_compat &
+            EXT4_FEATURE_RO_COMPAT_METADATA_CSUM) &&
+           (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_GDT_CSUM))
+               fs_param.s_feature_ro_compat &=
+                               ~EXT4_FEATURE_RO_COMPAT_GDT_CSUM;
+
+       /* Can't support bigalloc feature without extents feature */
+       if ((fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) &&
+           !(fs_param.s_feature_incompat & EXT3_FEATURE_INCOMPAT_EXTENTS)) {
+               com_err(program_name, 0, "%s",
+                       _("Can't support bigalloc feature without "
+                         "extents feature"));
+               exit(1);
+       }
+
+       if ((fs_param.s_feature_incompat & EXT2_FEATURE_INCOMPAT_META_BG) &&
+           (fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_RESIZE_INODE)) {
+               fprintf(stderr, "%s", _("The resize_inode and meta_bg "
+                                       "features are not compatible.\n"
+                                       "They can not be both enabled "
+                                       "simultaneously.\n"));
+               exit(1);
+       }
+
+       if (!quiet &&
+           (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC))
+               fprintf(stderr, "%s", _("\nWarning: the bigalloc feature is "
+                                 "still under development\n"
+                                 "See https://ext4.wiki.kernel.org/"
+                                 "index.php/Bigalloc for more information\n\n"));
+
+       if (!quiet &&
+           (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA))
+               fprintf(stderr, "%s", _("\nWarning: the quota feature is "
+                                 "still under development\n"
+                                 "See https://ext4.wiki.kernel.org/"
+                                 "index.php/Quota for more information\n\n"));
+
+       /*
+        * Since sparse_super is the default, we would only have a problem
         * here if it was explicitly disabled.
         */
        if ((fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_RESIZE_INODE) &&
            !(fs_param.s_feature_ro_compat&EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER)) {
-               com_err(program_name, 0,
+               com_err(program_name, 0, "%s",
                        _("reserved online resize blocks not supported "
                          "on non-sparse filesystem"));
                exit(1);
@@ -1875,12 +2240,21 @@ profile_error:
        if (fs_param.s_blocks_per_group) {
                if (fs_param.s_blocks_per_group < 256 ||
                    fs_param.s_blocks_per_group > 8 * (unsigned) blocksize) {
-                       com_err(program_name, 0,
+                       com_err(program_name, 0, "%s",
                                _("blocks per group count out of range"));
                        exit(1);
                }
        }
 
+       /*
+        * If the bigalloc feature is enabled, then the -g option will
+        * specify the number of clusters per group.
+        */
+       if (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) {
+               fs_param.s_clusters_per_group = fs_param.s_blocks_per_group;
+               fs_param.s_blocks_per_group = 0;
+       }
+
        if (inode_size == 0)
                inode_size = get_int_from_profile(fs_types, "inode_size", 0);
        if (!flex_bg_size && (fs_param.s_feature_incompat &
@@ -1890,7 +2264,7 @@ profile_error:
        if (flex_bg_size) {
                if (!(fs_param.s_feature_incompat &
                      EXT4_FEATURE_INCOMPAT_FLEX_BG)) {
-                       com_err(program_name, 0,
+                       com_err(program_name, 0, "%s",
                                _("Flex_bg feature not enabled, so "
                                  "flex_bg size may not be specified"));
                        exit(1);
@@ -1908,6 +2282,18 @@ profile_error:
                                blocksize);
                        exit(1);
                }
+               /*
+                * If inode size is 128 and inline data is enabled, we need
+                * to notify users that inline data will never be useful.
+                */
+               if ((fs_param.s_feature_incompat &
+                    EXT4_FEATURE_INCOMPAT_INLINE_DATA) &&
+                   inode_size == EXT2_GOOD_OLD_INODE_SIZE) {
+                       com_err(program_name, 0,
+                               _("inode size is %d, inline data is useless"),
+                               inode_size);
+                       exit(1);
+               }
                fs_param.s_inode_size = inode_size;
        }
 
@@ -1921,7 +2307,7 @@ profile_error:
                                num_inodes = MAX_32_NUM;
                        else {
                                com_err(program_name, 0,
-                                       _("too many inodes (%llu), raise"
+                                       _("too many inodes (%llu), raise "
                                          "inode ratio?"), n);
                                exit(1);
                        }
@@ -1938,7 +2324,7 @@ profile_error:
        fs_param.s_inodes_count = num_inodes ? num_inodes :
                (ext2fs_blocks_count(&fs_param) * blocksize) / inode_ratio;
 
-       if ((((long long)fs_param.s_inodes_count) *
+       if ((((unsigned long long)fs_param.s_inodes_count) *
             (inode_size ? inode_size : EXT2_GOOD_OLD_INODE_SIZE)) >=
            ((ext2fs_blocks_count(&fs_param)) *
             EXT2_BLOCK_SIZE(&fs_param))) {
@@ -1959,6 +2345,13 @@ profile_error:
        ext2fs_r_blocks_count_set(&fs_param, reserved_ratio *
                                  ext2fs_blocks_count(&fs_param) / 100.0);
 
+       if (fs_param.s_feature_compat & EXT4_FEATURE_COMPAT_SPARSE_SUPER2) {
+               if (num_backups >= 1)
+                       fs_param.s_backup_bgs[0] = 1;
+               if (num_backups >= 2)
+                       fs_param.s_backup_bgs[1] = ~0;
+       }
+
        free(fs_type);
        free(usage_types);
 }
@@ -1973,7 +2366,8 @@ static int should_do_undo(const char *name)
        int csum_flag, force_undo;
 
        csum_flag = EXT2_HAS_RO_COMPAT_FEATURE(&fs_param,
-                                              EXT4_FEATURE_RO_COMPAT_GDT_CSUM);
+                               EXT4_FEATURE_RO_COMPAT_GDT_CSUM |
+                               EXT4_FEATURE_RO_COMPAT_METADATA_CSUM);
        force_undo = get_int_from_profile(fs_types, "force_undo", 0);
        if (!force_undo && (!csum_flag || !lazy_itable_init))
                return 0;
@@ -2017,40 +2411,44 @@ open_err_out:
 static int mke2fs_setup_tdb(const char *name, io_manager *io_ptr)
 {
        errcode_t retval = ENOMEM;
-       char *tdb_dir, *tdb_file = NULL;
-       char *device_name, *tmp_name;
+       char *tdb_dir = NULL, *tdb_file = NULL;
+       char *dev_name, *tmp_name;
+       int free_tdb_dir = 0;
 
        /*
         * Configuration via a conf file would be
         * nice
         */
        tdb_dir = getenv("E2FSPROGS_UNDO_DIR");
-       if (!tdb_dir)
+       if (!tdb_dir) {
                profile_get_string(profile, "defaults",
                                   "undo_dir", 0, "/var/lib/e2fsprogs",
                                   &tdb_dir);
+               free_tdb_dir = 1;
+       }
 
        if (!strcmp(tdb_dir, "none") || (tdb_dir[0] == 0) ||
-           access(tdb_dir, W_OK))
+           access(tdb_dir, W_OK)) {
+               if (free_tdb_dir)
+                       free(tdb_dir);
                return 0;
+       }
 
        tmp_name = strdup(name);
        if (!tmp_name)
                goto errout;
-       device_name = basename(tmp_name);
-       tdb_file = malloc(strlen(tdb_dir) + 8 + strlen(device_name) + 7 + 1);
+       dev_name = basename(tmp_name);
+       tdb_file = malloc(strlen(tdb_dir) + 8 + strlen(dev_name) + 7 + 1);
        if (!tdb_file) {
                free(tmp_name);
                goto errout;
        }
-       sprintf(tdb_file, "%s/mke2fs-%s.e2undo", tdb_dir, device_name);
+       sprintf(tdb_file, "%s/mke2fs-%s.e2undo", tdb_dir, dev_name);
        free(tmp_name);
 
-       if (!access(tdb_file, F_OK)) {
-               if (unlink(tdb_file) < 0) {
-                       retval = errno;
-                       goto errout;
-               }
+       if ((unlink(tdb_file) < 0) && (errno != ENOENT)) {
+               retval = errno;
+               goto errout;
        }
 
        set_undo_io_backing_manager(*io_ptr);
@@ -2062,12 +2460,16 @@ static int mke2fs_setup_tdb(const char *name, io_manager *io_ptr)
                 "using the command:\n"
                 "    e2undo %s %s\n\n"), tdb_file, name);
 
+       if (free_tdb_dir)
+               free(tdb_dir);
        free(tdb_file);
        return 0;
 
 errout:
+       if (free_tdb_dir)
+               free(tdb_dir);
        free(tdb_file);
-       com_err(program_name, retval,
+       com_err(program_name, retval, "%s",
                _("while trying to setup undo file\n"));
        return retval;
 }
@@ -2122,42 +2524,55 @@ static int mke2fs_discard_device(ext2_filsys fs)
 
 static void fix_cluster_bg_counts(ext2_filsys fs)
 {
-       blk64_t cluster, num_clusters, tot_free;
-       int     grp_free, num_free, group, num;
-
-       num_clusters = EXT2FS_B2C(fs, ext2fs_blocks_count(fs->super));
-       tot_free = num_free = num = group = grp_free = 0;
-       for (cluster = EXT2FS_B2C(fs, fs->super->s_first_data_block);
-            cluster < num_clusters; cluster++) {
-               if (!ext2fs_test_block_bitmap2(fs->block_map,
-                                              EXT2FS_C2B(fs, cluster))) {
-                       grp_free++;
-                       tot_free++;
+       blk64_t         block, num_blocks, last_block, next;
+       blk64_t         tot_free = 0;
+       errcode_t       retval;
+       dgrp_t          group = 0;
+       int             grp_free = 0;
+
+       num_blocks = ext2fs_blocks_count(fs->super);
+       last_block = ext2fs_group_last_block2(fs, group);
+       block = fs->super->s_first_data_block;
+       while (block < num_blocks) {
+               retval = ext2fs_find_first_zero_block_bitmap2(fs->block_map,
+                                               block, last_block, &next);
+               if (retval == 0)
+                       block = next;
+               else {
+                       block = last_block + 1;
+                       goto next_bg;
                }
-               num++;
-               if ((num == fs->super->s_clusters_per_group) ||
-                   (cluster == num_clusters-1)) {
+
+               retval = ext2fs_find_first_set_block_bitmap2(fs->block_map,
+                                               block, last_block, &next);
+               if (retval)
+                       next = last_block + 1;
+               grp_free += EXT2FS_NUM_B2C(fs, next - block);
+               tot_free += next - block;
+               block = next;
+
+               if (block > last_block) {
+               next_bg:
                        ext2fs_bg_free_blocks_count_set(fs, group, grp_free);
                        ext2fs_group_desc_csum_set(fs, group);
-                       num = 0;
                        grp_free = 0;
                        group++;
+                       last_block = ext2fs_group_last_block2(fs, group);
                }
        }
-       ext2fs_free_blocks_count_set(fs->super, EXT2FS_C2B(fs, tot_free));
+       ext2fs_free_blocks_count_set(fs->super, tot_free);
 }
 
 static int create_quota_inodes(ext2_filsys fs)
 {
        quota_ctx_t qctx;
 
-       init_quota_context(&qctx, fs, -1);
-       compute_quota(qctx, -1);
-       write_quota_inode(qctx, USRQUOTA);
-       write_quota_inode(qctx, GRPQUOTA);
-       release_quota_context(&qctx);
+       quota_init_context(&qctx, fs, -1);
+       quota_compute_usage(qctx);
+       quota_write_inode(qctx, quotatype);
+       quota_release_context(&qctx);
 
-       return;
+       return 0;
 }
 
 int main (int argc, char *argv[])
@@ -2166,12 +2581,13 @@ int main (int argc, char *argv[])
        ext2_filsys     fs;
        badblocks_list  bb_list = 0;
        unsigned int    journal_blocks;
-       unsigned int    i, max_mnt_count, checkinterval;
+       unsigned int    i, checkinterval;
+       int             max_mnt_count;
        int             val, hash_alg;
        int             flags;
        int             old_bitmaps;
        io_manager      io_ptr;
-       char            tdb_string[40];
+       char            opt_string[40];
        char            *hash_alg_str;
        int             itable_zeroed = 0;
 
@@ -2180,6 +2596,7 @@ int main (int argc, char *argv[])
        setlocale(LC_CTYPE, "");
        bindtextdomain(NLS_CAT_NAME, LOCALEDIR);
        textdomain(NLS_CAT_NAME);
+       set_com_err_gettext(gettext);
 #endif
        PRS(argc, argv);
 
@@ -2201,6 +2618,8 @@ int main (int argc, char *argv[])
         * Initialize the superblock....
         */
        flags = EXT2_FLAG_EXCLUSIVE;
+       if (direct_io)
+               flags |= EXT2_FLAG_DIRECT_IO;
        profile_get_boolean(profile, "options", "old_bitmaps", 0, 0,
                            &old_bitmaps);
        if (!old_bitmaps)
@@ -2214,25 +2633,58 @@ int main (int argc, char *argv[])
                flags |= EXT2_FLAG_PRINT_PROGRESS;
        retval = ext2fs_initialize(device_name, flags, &fs_param, io_ptr, &fs);
        if (retval) {
-               com_err(device_name, retval, _("while setting up superblock"));
+               com_err(device_name, retval, "%s",
+                       _("while setting up superblock"));
                exit(1);
        }
+       fs->progress_ops = &ext2fs_numeric_progress_ops;
+
+       /* Check the user's mkfs options for metadata checksumming */
+       if (!quiet &&
+           EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
+                                      EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) {
+               if (!EXT2_HAS_INCOMPAT_FEATURE(fs->super,
+                               EXT3_FEATURE_INCOMPAT_EXTENTS))
+                       printf(_("Extents are not enabled.  The file extent "
+                                "tree can be checksummed, whereas block maps "
+                                "cannot.  Not enabling extents reduces the "
+                                "coverage of metadata checksumming.  "
+                                "Pass -O extents to rectify.\n"));
+               if (!EXT2_HAS_INCOMPAT_FEATURE(fs->super,
+                               EXT4_FEATURE_INCOMPAT_64BIT))
+                       printf(_("64-bit filesystem support is not "
+                                "enabled.  The larger fields afforded by "
+                                "this feature enable full-strength "
+                                "checksumming.  Pass -O 64bit to rectify.\n"));
+       }
+
+       /* Calculate journal blocks */
+       if (!journal_device && ((journal_size) ||
+               (fs_param.s_feature_compat &
+                EXT3_FEATURE_COMPAT_HAS_JOURNAL)))
+               journal_blocks = figure_journal_size(journal_size, fs);
 
        /* Can't undo discard ... */
        if (!noaction && discard && (io_ptr != undo_io_manager)) {
                retval = mke2fs_discard_device(fs);
                if (!retval && io_channel_discard_zeroes_data(fs->io)) {
                        if (verbose)
-                               printf(_("Discard succeeded and will return 0s "
-                                        " - skipping inode table wipe\n"));
+                               printf("%s",
+                                      _("Discard succeeded and will return "
+                                        "0s - skipping inode table wipe\n"));
                        lazy_itable_init = 1;
                        itable_zeroed = 1;
+                       zero_hugefile = 0;
                }
        }
 
-       sprintf(tdb_string, "tdb_data_size=%d", fs->blocksize <= 4096 ?
+       sprintf(opt_string, "tdb_data_size=%d", fs->blocksize <= 4096 ?
                32768 : fs->blocksize * 8);
-       io_channel_set_options(fs->io, tdb_string);
+       io_channel_set_options(fs->io, opt_string);
+       if (offset) {
+               sprintf(opt_string, "offset=%llu", offset);
+               io_channel_set_options(fs->io, opt_string);
+       }
 
        if (fs_param.s_flags & EXT2_FLAGS_TEST_FILESYS)
                fs->super->s_flags |= EXT2_FLAGS_TEST_FILESYS;
@@ -2242,6 +2694,7 @@ int main (int argc, char *argv[])
            (fs_param.s_feature_ro_compat &
             (EXT4_FEATURE_RO_COMPAT_HUGE_FILE|EXT4_FEATURE_RO_COMPAT_GDT_CSUM|
              EXT4_FEATURE_RO_COMPAT_DIR_NLINK|
+             EXT4_FEATURE_RO_COMPAT_METADATA_CSUM|
              EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE)))
                fs->super->s_kbytes_written = 1;
 
@@ -2262,6 +2715,7 @@ int main (int argc, char *argv[])
                }
        } else
                uuid_generate(fs->super->s_uuid);
+       ext2fs_init_csum_seed(fs);
 
        /*
         * Initialize the directory index variables
@@ -2299,7 +2753,8 @@ int main (int argc, char *argv[])
                for (i = 0, val = 0 ; i < sizeof(fs->super->s_uuid); i++)
                        val += fs->super->s_uuid[i];
                fs->super->s_max_mnt_count += val % EXT2_DFL_MAX_MNT_COUNT;
-       }
+       } else
+               fs->super->s_max_mnt_count = -1;
 
        /*
         * Override the creator OS, if applicable
@@ -2337,6 +2792,10 @@ int main (int argc, char *argv[])
                        sizeof(fs->super->s_last_mounted));
        }
 
+       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
+                                      EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))
+               fs->super->s_checksum_type = EXT2_CRC32C_CHKSUM;
+
        if (!quiet || noaction)
                show_stats(fs);
 
@@ -2353,23 +2812,27 @@ int main (int argc, char *argv[])
                read_bb_file(fs, &bb_list, bad_blocks_filename);
        if (cflag)
                test_disk(fs, &bb_list);
-
        handle_bad_blocks(fs, bb_list);
+
        fs->stride = fs_stride = fs->super->s_raid_stride;
        if (!quiet)
-               printf(_("Allocating group tables: "));
-       retval = ext2fs_allocate_tables(fs);
+               printf("%s", _("Allocating group tables: "));
+       if ((fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_FLEX_BG) &&
+           packed_meta_blocks)
+               retval = packed_allocate_tables(fs);
+       else
+               retval = ext2fs_allocate_tables(fs);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while trying to allocate filesystem tables"));
                exit(1);
        }
        if (!quiet)
-               printf(_("done                            \n"));
+               printf("%s", _("done                            \n"));
 
        retval = ext2fs_convert_subcluster_bitmap(fs, &fs->block_map);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("\n\twhile converting subcluster bitmap"));
                exit(1);
        }
@@ -2377,6 +2840,16 @@ int main (int argc, char *argv[])
        if (super_only) {
                fs->super->s_state |= EXT2_ERROR_FS;
                fs->flags &= ~(EXT2_FLAG_IB_DIRTY|EXT2_FLAG_BB_DIRTY);
+               /* 
+                * The command "mke2fs -S" is used to recover
+                * corrupted file systems, so do not mark any of the
+                * inodes as unused; we want e2fsck to consider all
+                * inodes as potentially containing recoverable data.
+                */
+               if (ext2fs_has_group_desc_csum(fs)) {
+                       for (i = 0; i < fs->group_desc_count; i++)
+                               ext2fs_bg_itable_unused_set(fs, i, 0);
+               }
        } else {
                /* rsv must be a power of two (64kB is MD RAID sb alignment) */
                blk64_t rsv = 65536 / fs->blocksize;
@@ -2415,6 +2888,7 @@ int main (int argc, char *argv[])
                        retval = ext2fs_create_resize_inode(fs);
                        if (retval) {
                                com_err("ext2fs_create_resize_inode", retval,
+                                       "%s",
                                _("while reserving blocks for online resize"));
                                exit(1);
                        }
@@ -2450,16 +2924,14 @@ int main (int argc, char *argv[])
                        exit(1);
                }
                if (!quiet)
-                       printf(_("done\n"));
+                       printf("%s", _("done\n"));
                ext2fs_close(jfs);
                free(journal_device);
        } else if ((journal_size) ||
                   (fs_param.s_feature_compat &
                    EXT3_FEATURE_COMPAT_HAS_JOURNAL)) {
-               journal_blocks = figure_journal_size(journal_size, fs);
-
                if (super_only) {
-                       printf(_("Skipping journal creation in super-only mode\n"));
+                       printf("%s", _("Skipping journal creation in super-only mode\n"));
                        fs->super->s_journal_inum = EXT2_JOURNAL_INO;
                        goto no_journal;
                }
@@ -2474,17 +2946,32 @@ int main (int argc, char *argv[])
                               journal_blocks);
                        fflush(stdout);
                }
-               retval = ext2fs_add_journal_inode(fs, journal_blocks,
-                                                 journal_flags);
+               retval = ext2fs_add_journal_inode2(fs, journal_blocks,
+                                                  journal_location,
+                                                  journal_flags);
                if (retval) {
-                       com_err (program_name, retval,
-                                _("\n\twhile trying to create journal"));
+                       com_err(program_name, retval, "%s",
+                               _("\n\twhile trying to create journal"));
                        exit(1);
                }
                if (!quiet)
-                       printf(_("done\n"));
+                       printf("%s", _("done\n"));
        }
 no_journal:
+       if (!super_only &&
+           fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_MMP) {
+               retval = ext2fs_mmp_init(fs);
+               if (retval) {
+                       fprintf(stderr, "%s",
+                               _("\nError while enabling multiple "
+                                 "mount protection feature."));
+                       exit(1);
+               }
+               if (!quiet)
+                       printf(_("Multiple mount protection is enabled "
+                                "with update interval %d seconds.\n"),
+                              fs->super->s_mmp_update_interval);
+       }
 
        if (EXT2_HAS_RO_COMPAT_FEATURE(&fs_param,
                                       EXT4_FEATURE_RO_COMPAT_BIGALLOC))
@@ -2493,17 +2980,46 @@ no_journal:
                                       EXT4_FEATURE_RO_COMPAT_QUOTA))
                create_quota_inodes(fs);
 
+       retval = mk_hugefiles(fs);
+       if (retval)
+               com_err(program_name, retval, "while creating huge files");
+       /* Copy files from the specified directory */
+       if (root_dir) {
+               if (!quiet)
+                       printf("%s", _("Copying files into the device: "));
+
+               /*
+                * Allocate memory for the hardlinks, we don't need free()
+                * since the lifespan will be over after the fs populated.
+                */
+               if ((hdlinks.hdl = (struct hdlink_s *)
+                               malloc(hdlink_cnt * sizeof(struct hdlink_s))) == NULL) {
+                       fprintf(stderr, "%s", _("\nNot enough memory\n"));
+                       retval = ext2fs_close(fs);
+                       return retval;
+               }
+
+               hdlinks.count = 0;
+               retval = populate_fs(fs, EXT2_ROOT_INO, root_dir,
+                                    EXT2_ROOT_INO);
+               if (retval)
+                       fprintf(stderr, "%s",
+                               _("\nError while populating file system"));
+               else if (!quiet)
+                       printf("%s", _("done\n"));
+       }
+
        if (!quiet)
-               printf(_("Writing superblocks and "
+               printf("%s", _("Writing superblocks and "
                       "filesystem accounting information: "));
        checkinterval = fs->super->s_checkinterval;
        max_mnt_count = fs->super->s_max_mnt_count;
        retval = ext2fs_close(fs);
        if (retval) {
-               fprintf(stderr,
+               fprintf(stderr, "%s",
                        _("\nWarning, had trouble writing out superblocks."));
        } else if (!quiet) {
-               printf(_("done\n\n"));
+               printf("%s", _("done\n\n"));
                if (!getenv("MKE2FS_SKIP_CHECK_MSG"))
                        print_check_message(max_mnt_count, checkinterval);
        }