Whamcloud - gitweb
LU-5307 build: add support for RHEL-7 .spec file
[tools/e2fsprogs.git] / misc / dumpe2fs.c
index 2a3cf53..4185d6e 100644 (file)
@@ -20,6 +20,7 @@
  * 94/02/27    - Ported to use the ext2fs library
  */
 
+#include "config.h"
 #ifdef HAVE_GETOPT_H
 #include <getopt.h>
 #else
@@ -44,52 +45,60 @@ extern int optind;
 
 #define in_use(m, x)   (ext2fs_test_bit ((x), (m)))
 
-const char * program_name = "dumpe2fs";
-char * device_name = NULL;
-int hex_format = 0;
+static const char * program_name = "dumpe2fs";
+static char * device_name = NULL;
+static int hex_format = 0;
+static int blocks64 = 0;
 
 static void usage(void)
 {
-       fprintf (stderr, _("Usage: %s [-bfhixV] [-ob superblock] "
-                "[-oB blocksize] device\n"), program_name);
+       fprintf (stderr, _("Usage: %s [-bfhixV] [-o superblock=<num>] "
+                "[-o blocksize=<num>] device\n"), program_name);
        exit (1);
 }
 
-static void print_number(unsigned long num)
+static void print_number(unsigned long long num)
 {
-       if (hex_format) 
-               printf("0x%04lx", num);
-       else
-               printf("%lu", num);
+       if (hex_format) {
+               if (blocks64)
+                       printf("0x%08llx", num);
+               else
+                       printf("0x%04llx", num);
+       } else
+               printf("%llu", num);
 }
 
-static void print_range(unsigned long a, unsigned long b)
+static void print_range(unsigned long long a, unsigned long long b)
 {
-       if (hex_format) 
-               printf("0x%04lx-0x%04lx", a, b);
-       else
-               printf("%lu-%lu", a, b);
+       if (hex_format) {
+               if (blocks64)
+                       printf("0x%08llx-0x%08llx", a, b);
+               else
+                       printf("0x%04llx-0x%04llx", a, b);
+       } else
+               printf("%llu-%llu", a, b);
 }
 
-static void print_free (unsigned long group, char * bitmap,
-                       unsigned long nbytes, unsigned long offset)
+static void print_free(unsigned long group, char * bitmap,
+                      unsigned long num, unsigned long offset, int ratio)
 {
        int p = 0;
        unsigned long i;
        unsigned long j;
 
-       offset += group * nbytes;
-       for (i = 0; i < nbytes; i++)
+       offset /= ratio;
+       offset += group * num;
+       for (i = 0; i < num; i++)
                if (!in_use (bitmap, i))
                {
                        if (p)
                                printf (", ");
-                       print_number(i + offset);
-                       for (j = i; j < nbytes && !in_use (bitmap, j); j++)
+                       print_number((i + offset) * ratio);
+                       for (j = i; j < num && !in_use (bitmap, j); j++)
                                ;
                        if (--j != i) {
                                fputc('-', stdout);
-                               print_number(j + offset);
+                               print_number((j + offset) * ratio);
                                i = j;
                        }
                        p = 1;
@@ -110,36 +119,62 @@ static void print_bg_opt(int bg_flags, int mask,
 }
 static void print_bg_opts(ext2_filsys fs, dgrp_t i)
 {
-       int first = 1, bg_flags;
+       int first = 1, bg_flags = 0;
 
-       if (fs->super->s_feature_compat & EXT2_FEATURE_COMPAT_LAZY_BG)
-               bg_flags = fs->group_desc[i].bg_flags;
-       else
-               bg_flags = 0;
+       if (fs->super->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_GDT_CSUM)
+               bg_flags = ext2fs_bg_flags(fs, i);
 
-       print_bg_opt(bg_flags, EXT2_BG_INODE_UNINIT, "Inode not init",
+       print_bg_opt(bg_flags, EXT2_BG_INODE_UNINIT, "INODE_UNINIT",
+                    &first);
+       print_bg_opt(bg_flags, EXT2_BG_BLOCK_UNINIT, "BLOCK_UNINIT",
                     &first);
-       print_bg_opt(bg_flags, EXT2_BG_BLOCK_UNINIT, "Block not init",
+       print_bg_opt(bg_flags, EXT2_BG_INODE_ZEROED, "ITABLE_ZEROED",
                     &first);
        if (!first)
                fputc(']', stdout);
        fputc('\n', stdout);
 }
 
+static void print_bg_rel_offset(ext2_filsys fs, blk64_t block, int itable,
+                               blk64_t first_block, blk64_t last_block)
+{
+       if ((block >= first_block) && (block <= last_block)) {
+               if (itable && block == first_block)
+                       return;
+               printf(" (+%u)", (unsigned)(block - first_block));
+       } else if (fs->super->s_feature_incompat &
+                  EXT4_FEATURE_INCOMPAT_FLEX_BG) {
+               dgrp_t flex_grp = ext2fs_group_of_blk2(fs, block);
+               printf(" (bg #%u + %u)", flex_grp,
+                      (unsigned)(block-ext2fs_group_first_block2(fs,flex_grp)));
+       }
+}
+
 static void list_desc (ext2_filsys fs)
 {
        unsigned long i;
-       long diff;
-       blk_t   first_block, last_block;
-       blk_t   super_blk, old_desc_blk, new_desc_blk;
+       blk64_t first_block, last_block;
+       blk64_t super_blk, old_desc_blk, new_desc_blk;
        char *block_bitmap=NULL, *inode_bitmap=NULL;
+       const char *units = _("blocks");
        int inode_blocks_per_group, old_desc_blocks, reserved_gdt;
+       int             block_nbytes, inode_nbytes;
        int has_super;
+       blk64_t         blk_itr = EXT2FS_B2C(fs, fs->super->s_first_data_block);
+       ext2_ino_t      ino_itr = 1;
+       errcode_t       retval;
+
+       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
+                                      EXT4_FEATURE_RO_COMPAT_BIGALLOC))
+               units = _("clusters");
+
+       block_nbytes = EXT2_CLUSTERS_PER_GROUP(fs->super) / 8;
+       inode_nbytes = EXT2_INODES_PER_GROUP(fs->super) / 8;
 
        if (fs->block_map)
-               block_bitmap = fs->block_map->bitmap;
+               block_bitmap = malloc(block_nbytes);
        if (fs->inode_map)
-               inode_bitmap = fs->inode_map->bitmap;
+               inode_bitmap = malloc(inode_nbytes);
 
        inode_blocks_per_group = ((fs->super->s_inodes_per_group *
                                   EXT2_INODE_SIZE(fs->super)) +
@@ -153,18 +188,26 @@ static void list_desc (ext2_filsys fs)
        else
                old_desc_blocks = fs->desc_blocks;
        for (i = 0; i < fs->group_desc_count; i++) {
-               ext2fs_super_and_bgd_loc(fs, i, &super_blk, 
-                                        &old_desc_blk, &new_desc_blk, 0);
-               if (i == fs->group_desc_count - 1)
-                       last_block = fs->super->s_blocks_count - 1;
-               else
-                       last_block = first_block +
-                                    fs->super->s_blocks_per_group - 1;
+               first_block = ext2fs_group_first_block2(fs, i);
+               last_block = ext2fs_group_last_block2(fs, i);
+
+               ext2fs_super_and_bgd_loc2(fs, i, &super_blk,
+                                         &old_desc_blk, &new_desc_blk, 0);
 
                printf (_("Group %lu: (Blocks "), i);
                print_range(first_block, last_block);
                fputs(")", stdout);
                print_bg_opts(fs, i);
+               if (fs->super->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_GDT_CSUM) {
+                       unsigned csum = ext2fs_bg_checksum(fs, i);
+                       unsigned exp_csum = ext2fs_group_desc_csum(fs, i);
+
+                       printf(_("  Checksum 0x%04x"), csum);
+                       if (csum != exp_csum)
+                               printf(_(" (EXPECTED 0x%04x)"), exp_csum);
+                       printf(_(", unused inodes %u\n"),
+                              ext2fs_bg_itable_unused(fs, i));
+               }
                has_super = ((i==0) || super_blk);
                if (has_super) {
                        printf (_("  %s superblock at "),
@@ -172,62 +215,80 @@ static void list_desc (ext2_filsys fs)
                        print_number(super_blk);
                }
                if (old_desc_blk) {
-                       printf(_(", Group descriptors at "));
-                       print_range(old_desc_blk, 
+                       printf("%s", _(", Group descriptors at "));
+                       print_range(old_desc_blk,
                                    old_desc_blk + old_desc_blocks - 1);
                        if (reserved_gdt) {
-                               printf(_("\n  Reserved GDT blocks at "));
+                               printf("%s", _("\n  Reserved GDT blocks at "));
                                print_range(old_desc_blk + old_desc_blocks,
-                                           old_desc_blk + old_desc_blocks + 
+                                           old_desc_blk + old_desc_blocks +
                                            reserved_gdt - 1);
                        }
                } else if (new_desc_blk) {
                        fputc(has_super ? ',' : ' ', stdout);
-                       printf(_(" Group descriptor at "));
+                       printf("%s", _(" Group descriptor at "));
                        print_number(new_desc_blk);
                        has_super++;
                }
                if (has_super)
                        fputc('\n', stdout);
                fputs(_("  Block bitmap at "), stdout);
-               print_number(fs->group_desc[i].bg_block_bitmap);
-               diff = fs->group_desc[i].bg_block_bitmap - first_block;
-               if (diff >= 0)
-                       printf(" (+%ld)", diff);
+               print_number(ext2fs_block_bitmap_loc(fs, i));
+               print_bg_rel_offset(fs, ext2fs_block_bitmap_loc(fs, i), 0,
+                                   first_block, last_block);
                fputs(_(", Inode bitmap at "), stdout);
-               print_number(fs->group_desc[i].bg_inode_bitmap);
-               diff = fs->group_desc[i].bg_inode_bitmap - first_block;
-               if (diff >= 0)
-                       printf(" (+%ld)", diff);
+               print_number(ext2fs_inode_bitmap_loc(fs, i));
+               print_bg_rel_offset(fs, ext2fs_inode_bitmap_loc(fs, i), 0,
+                                   first_block, last_block);
                fputs(_("\n  Inode table at "), stdout);
-               print_range(fs->group_desc[i].bg_inode_table,
-                           fs->group_desc[i].bg_inode_table +
+               print_range(ext2fs_inode_table_loc(fs, i),
+                           ext2fs_inode_table_loc(fs, i) +
                            inode_blocks_per_group - 1);
-               diff = fs->group_desc[i].bg_inode_table - first_block;
-               if (diff > 0)
-                       printf(" (+%ld)", diff);
-               printf (_("\n  %d free blocks, %d free inodes, "
-                         "%d directories\n"),
-                       fs->group_desc[i].bg_free_blocks_count,
-                       fs->group_desc[i].bg_free_inodes_count,
-                       fs->group_desc[i].bg_used_dirs_count);
+               print_bg_rel_offset(fs, ext2fs_inode_table_loc(fs, i), 1,
+                                   first_block, last_block);
+               printf (_("\n  %u free %s, %u free inodes, "
+                         "%u directories%s"),
+                       ext2fs_bg_free_blocks_count(fs, i), units,
+                       ext2fs_bg_free_inodes_count(fs, i),
+                       ext2fs_bg_used_dirs_count(fs, i),
+                       ext2fs_bg_itable_unused(fs, i) ? "" : "\n");
+               if (ext2fs_bg_itable_unused(fs, i))
+                       printf (_(", %u unused inodes\n"),
+                               ext2fs_bg_itable_unused(fs, i));
                if (block_bitmap) {
                        fputs(_("  Free blocks: "), stdout);
-                       print_free (i, block_bitmap,
-                                   fs->super->s_blocks_per_group,
-                                   fs->super->s_first_data_block);
+                       retval = ext2fs_get_block_bitmap_range2(fs->block_map,
+                                blk_itr, block_nbytes << 3, block_bitmap);
+                       if (retval)
+                               com_err("list_desc", retval,
+                                       "while reading block bitmap");
+                       else
+                               print_free(i, block_bitmap,
+                                          fs->super->s_clusters_per_group,
+                                          fs->super->s_first_data_block,
+                                          EXT2FS_CLUSTER_RATIO(fs));
                        fputc('\n', stdout);
-                       block_bitmap += fs->super->s_blocks_per_group / 8;
+                       blk_itr += fs->super->s_clusters_per_group;
                }
                if (inode_bitmap) {
                        fputs(_("  Free inodes: "), stdout);
-                       print_free (i, inode_bitmap,
-                                   fs->super->s_inodes_per_group, 1);
+                       retval = ext2fs_get_inode_bitmap_range2(fs->inode_map,
+                                ino_itr, inode_nbytes << 3, inode_bitmap);
+                       if (retval)
+                               com_err("list_desc", retval,
+                                       "while reading inode bitmap");
+                       else
+                               print_free(i, inode_bitmap,
+                                          fs->super->s_inodes_per_group,
+                                          1, 1);
                        fputc('\n', stdout);
-                       inode_bitmap += fs->super->s_inodes_per_group / 8;
+                       ino_itr += fs->super->s_inodes_per_group;
                }
-               first_block += fs->super->s_blocks_per_group;
        }
+       if (block_bitmap)
+               free(block_bitmap);
+       if (inode_bitmap)
+               free(inode_bitmap);
 }
 
 static void list_bad_blocks(ext2_filsys fs, int dump)
@@ -246,14 +307,14 @@ static void list_bad_blocks(ext2_filsys fs, int dump)
        retval = ext2fs_badblocks_list_iterate_begin(bb_list, &bb_iter);
        if (retval) {
                com_err("ext2fs_badblocks_list_iterate_begin", retval,
-                       _("while printing bad block list"));
+                       "%s", _("while printing bad block list"));
                return;
        }
        if (dump) {
-               header = fmt = "%d\n";
+               header = fmt = "%u\n";
        } else {
-               header =  _("Bad blocks: %d");
-               fmt = ", %d";
+               header =  _("Bad blocks: %u");
+               fmt = ", %u";
        }
        while (ext2fs_badblocks_list_iterate(bb_iter, &blk)) {
                printf(header ? header : fmt, blk);
@@ -262,27 +323,80 @@ static void list_bad_blocks(ext2_filsys fs, int dump)
        ext2fs_badblocks_list_iterate_end(bb_iter);
        if (!dump)
                fputc('\n', stdout);
+       ext2fs_badblocks_list_free(bb_list);
 }
 
 static void print_inline_journal_information(ext2_filsys fs)
 {
+       journal_superblock_t    *jsb;
        struct ext2_inode       inode;
+       ext2_file_t             journal_file;
        errcode_t               retval;
        ino_t                   ino = fs->super->s_journal_inum;
-       int                     size;
-       
+       char                    buf[1024];
+       __u32                   *mask_ptr, mask, m;
+       int                     i, j, size, printed = 0;
+
+       if (fs->flags & EXT2_FLAG_IMAGE_FILE)
+               return;
        retval = ext2fs_read_inode(fs, ino,  &inode);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while reading journal inode"));
                exit(1);
        }
+       retval = ext2fs_file_open2(fs, ino, &inode, 0, &journal_file);
+       if (retval) {
+               com_err(program_name, retval, "%s",
+                       _("while opening journal inode"));
+               exit(1);
+       }
+       retval = ext2fs_file_read(journal_file, buf, sizeof(buf), 0);
+       if (retval) {
+               com_err(program_name, retval, "%s",
+                       _("while reading journal super block"));
+               exit(1);
+       }
+       ext2fs_file_close(journal_file);
+       jsb = (journal_superblock_t *) buf;
+       if (be32_to_cpu(jsb->s_header.h_magic) != JFS_MAGIC_NUMBER) {
+               fprintf(stderr, "%s",
+                       _("Journal superblock magic number invalid!\n"));
+               exit(1);
+       }
+       printf("%s", _("Journal features:        "));
+       for (i=0, mask_ptr=&jsb->s_feature_compat; i <3; i++,mask_ptr++) {
+               mask = be32_to_cpu(*mask_ptr);
+               for (j=0,m=1; j < 32; j++, m<<=1) {
+                       if (mask & m) {
+                               printf(" %s", e2p_jrnl_feature2string(i, m));
+                               printed++;
+                       }
+               }
+       }
+       if (printed == 0)
+               printf(" (none)");
+       printf("\n");
        fputs(_("Journal size:             "), stdout);
-       size = inode.i_blocks >> 1;
+       if ((fs->super->s_feature_ro_compat &
+            EXT4_FEATURE_RO_COMPAT_HUGE_FILE) &&
+           (inode.i_flags & EXT4_HUGE_FILE_FL))
+               size = inode.i_blocks / (fs->blocksize / 1024);
+       else
+               size = inode.i_blocks >> 1;
        if (size < 8192)
                printf("%uk\n", size);
        else
                printf("%uM\n", size >> 10);
+       printf(_("Journal length:           %u\n"
+                "Journal sequence:         0x%08x\n"
+                "Journal start:            %u\n"),
+              (unsigned int)ntohl(jsb->s_maxlen),
+              (unsigned int)ntohl(jsb->s_sequence),
+              (unsigned int)ntohl(jsb->s_start));
+       if (jsb->s_errno != 0)
+               printf(_("Journal errno:            %d\n"),
+                      (int) ntohl(jsb->s_errno));
 }
 
 static void print_journal_information(ext2_filsys fs)
@@ -294,8 +408,10 @@ static void print_journal_information(ext2_filsys fs)
        journal_superblock_t    *jsb;
 
        /* Get the journal superblock */
-       if ((retval = io_channel_read_blk(fs->io, fs->super->s_first_data_block+1, -1024, buf))) {
-               com_err(program_name, retval,
+       if ((retval = io_channel_read_blk64(fs->io,
+                                           fs->super->s_first_data_block + 1,
+                                           -1024, buf))) {
+               com_err(program_name, retval, "%s",
                        _("while reading journal superblock"));
                exit(1);
        }
@@ -303,7 +419,7 @@ static void print_journal_information(ext2_filsys fs)
        if ((jsb->s_header.h_magic != (unsigned) ntohl(JFS_MAGIC_NUMBER)) ||
            (jsb->s_header.h_blocktype !=
             (unsigned) ntohl(JFS_SUPERBLOCK_V2))) {
-               com_err(program_name, 0,
+               com_err(program_name, 0, "%s",
                        _("Couldn't find journal superblock magic numbers"));
                exit(1);
        }
@@ -326,18 +442,94 @@ static void print_journal_information(ext2_filsys fs)
        }
 }
 
+static void parse_extended_opts(const char *opts, blk64_t *superblock,
+                               int *blocksize)
+{
+       char    *buf, *token, *next, *p, *arg, *badopt = 0;
+       int     len;
+       int     do_usage = 0;
+
+       len = strlen(opts);
+       buf = malloc(len+1);
+       if (!buf) {
+               fprintf(stderr, "%s",
+                       _("Couldn't allocate memory to parse options!\n"));
+               exit(1);
+       }
+       strcpy(buf, opts);
+       for (token = buf; token && *token; token = next) {
+               p = strchr(token, ',');
+               next = 0;
+               if (p) {
+                       *p = 0;
+                       next = p+1;
+               }
+               arg = strchr(token, '=');
+               if (arg) {
+                       *arg = 0;
+                       arg++;
+               }
+               if (strcmp(token, "superblock") == 0 ||
+                   strcmp(token, "sb") == 0) {
+                       if (!arg) {
+                               do_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       *superblock = strtoul(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr,
+                                       _("Invalid superblock parameter: %s\n"),
+                                       arg);
+                               do_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "blocksize") == 0 ||
+                          strcmp(token, "bs") == 0) {
+                       if (!arg) {
+                               do_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       *blocksize = strtoul(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr,
+                                       _("Invalid blocksize parameter: %s\n"),
+                                       arg);
+                               do_usage++;
+                               continue;
+                       }
+               } else {
+                       do_usage++;
+                       badopt = token;
+               }
+       }
+       if (do_usage) {
+               fprintf(stderr, _("\nBad extended option(s) specified: %s\n\n"
+                       "Extended options are separated by commas, "
+                       "and may take an argument which\n"
+                       "\tis set off by an equals ('=') sign.\n\n"
+                       "Valid extended options are:\n"
+                       "\tsuperblock=<superblock number>\n"
+                       "\tblocksize=<blocksize>\n"),
+                       badopt ? badopt : "");
+               free(buf);
+               exit(1);
+       }
+       free(buf);
+}
+
 int main (int argc, char ** argv)
 {
        errcode_t       retval;
        ext2_filsys     fs;
        int             print_badblocks = 0;
-       int             use_superblock = 0;
+       blk64_t         use_superblock = 0;
        int             use_blocksize = 0;
        int             image_dump = 0;
        int             force = 0;
        int             flags;
        int             header_only = 0;
-       int             big_endian;
        int             c;
 
 #ifdef ENABLE_NLS
@@ -345,13 +537,14 @@ int main (int argc, char ** argv)
        setlocale(LC_CTYPE, "");
        bindtextdomain(NLS_CAT_NAME, LOCALEDIR);
        textdomain(NLS_CAT_NAME);
+       set_com_err_gettext(gettext);
 #endif
-       initialize_ext2_error_table();
+       add_error_table(&et_ext2_error_table);
        fprintf (stderr, "dumpe2fs %s (%s)\n", E2FSPROGS_VERSION,
                 E2FSPROGS_DATE);
        if (argc && *argv)
                program_name = *argv;
-       
+
        while ((c = getopt (argc, argv, "bfhixVo:")) != EOF) {
                switch (c) {
                case 'b':
@@ -367,12 +560,8 @@ int main (int argc, char ** argv)
                        image_dump++;
                        break;
                case 'o':
-                       if (optarg[0] == 'b')
-                               use_superblock = atoi(optarg+1);
-                       else if (optarg[0] == 'B')
-                               use_blocksize = atoi(optarg+1);
-                       else
-                               usage();
+                       parse_extended_opts(optarg, &use_superblock,
+                                           &use_blocksize);
                        break;
                case 'V':
                        /* Print version number and exit */
@@ -386,47 +575,57 @@ int main (int argc, char ** argv)
                        usage();
                }
        }
-       if (optind > argc - 1)
+       if (optind != argc - 1) {
                usage();
+               exit(1);
+       }
        device_name = argv[optind++];
-       if (use_superblock && !use_blocksize)
-               use_blocksize = 1024;
-       flags = EXT2_FLAG_JOURNAL_DEV_OK;
+       flags = EXT2_FLAG_JOURNAL_DEV_OK | EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS;
        if (force)
                flags |= EXT2_FLAG_FORCE;
        if (image_dump)
                flags |= EXT2_FLAG_IMAGE_FILE;
-       
-       retval = ext2fs_open (device_name, flags, use_superblock,
-                             use_blocksize, unix_io_manager, &fs);
+
+       if (use_superblock && !use_blocksize) {
+               for (use_blocksize = EXT2_MIN_BLOCK_SIZE;
+                    use_blocksize <= EXT2_MAX_BLOCK_SIZE;
+                    use_blocksize *= 2) {
+                       retval = ext2fs_open (device_name, flags,
+                                             use_superblock,
+                                             use_blocksize, unix_io_manager,
+                                             &fs);
+                       if (!retval)
+                               break;
+               }
+       } else
+               retval = ext2fs_open (device_name, flags, use_superblock,
+                                     use_blocksize, unix_io_manager, &fs);
        if (retval) {
                com_err (program_name, retval, _("while trying to open %s"),
                         device_name);
-               printf (_("Couldn't find valid filesystem superblock.\n"));
+               printf("%s", _("Couldn't find valid filesystem superblock.\n"));
                exit (1);
        }
+       fs->default_bitmap_type = EXT2FS_BMAP64_RBTREE;
+       if (fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT)
+               blocks64 = 1;
        if (print_badblocks) {
                list_bad_blocks(fs, 1);
        } else {
-               big_endian = ((fs->flags & EXT2_FLAG_SWAP_BYTES) != 0);
-#ifdef WORDS_BIGENDIAN
-               big_endian = !big_endian;
-#endif
-               if (big_endian)
-                       printf(_("Note: This is a byte-swapped filesystem\n"));
                list_super (fs->super);
                if (fs->super->s_feature_incompat &
                      EXT3_FEATURE_INCOMPAT_JOURNAL_DEV) {
                        print_journal_information(fs);
-                       ext2fs_close(fs);
+                       ext2fs_close_free(&fs);
                        exit(0);
                }
-               if (fs->super->s_feature_compat &
-                     EXT3_FEATURE_COMPAT_HAS_JOURNAL)
+               if ((fs->super->s_feature_compat &
+                    EXT3_FEATURE_COMPAT_HAS_JOURNAL) &&
+                   (fs->super->s_journal_inum != 0))
                        print_inline_journal_information(fs);
                list_bad_blocks(fs, 0);
                if (header_only) {
-                       ext2fs_close (fs);
+                       ext2fs_close_free(&fs);
                        exit (0);
                }
                retval = ext2fs_read_bitmaps (fs);
@@ -437,6 +636,7 @@ int main (int argc, char ** argv)
                               error_message(retval));
                }
        }
-       ext2fs_close (fs);
+       ext2fs_close_free(&fs);
+       remove_error_table(&et_ext2_error_table);
        exit (0);
 }