Whamcloud - gitweb
misc: clean up compiler warnings
[tools/e2fsprogs.git] / misc / badblocks.c
index ef6ab5b..1e7e1c8 100644 (file)
@@ -10,7 +10,7 @@
  *
  * This file is based on the minix file system programs fsck and mkfs
  * written and copyrighted by Linus Torvalds <Linus.Torvalds@cs.helsinki.fi>
- * 
+ *
  * %Begin-Header%
  * This file may be redistributed under the terms of the GNU Public
  * License.
  * 99/06/30...99/07/26 - Added non-destructive write-testing,
  *                       configurable blocks-at-once parameter,
  *                      loading of badblocks list to avoid testing
- *                      blocks known to be bad, multiple passes to 
+ *                      blocks known to be bad, multiple passes to
  *                      make sure that no new blocks are added to the
  *                      list.  (Work done by David Beattie)
  */
 
+#ifndef _GNU_SOURCE
 #define _GNU_SOURCE /* for O_DIRECT */
+#endif
+
+#ifndef O_LARGEFILE
+#define O_LARGEFILE 0
+#endif
 
 #include <errno.h>
 #include <fcntl.h>
@@ -51,7 +57,6 @@ extern int optind;
 #include <sys/time.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
-#include <sys/time.h>
 
 #include "et/com_err.h"
 #include "ext2fs/ext2_io.h"
@@ -60,7 +65,7 @@ extern int optind;
 #include "nls-enable.h"
 
 const char * program_name = "badblocks";
-const char * done_string = N_("done                                \n");
+const char * done_string = N_("done                                                 \n");
 
 static int v_flag = 0;                 /* verbose */
 static int w_flag = 0;                 /* do r/w test: 0=no, 1=yes,
@@ -71,9 +76,11 @@ static int t_flag = 0;                       /* number of test patterns */
 static int t_max = 0;                  /* allocated test patterns */
 static unsigned int *t_patts = NULL;   /* test patterns */
 static int current_O_DIRECT = 0;       /* Current status of O_DIRECT flag */
+static int use_buffered_io = 0;
 static int exclusive_ok = 0;
 static unsigned int max_bb = 0;                /* Abort test if more than this number of bad blocks has been encountered */
 static unsigned int d_flag = 0;                /* delay factor between reads */
+static struct timeval time_start;
 
 #define T_INC 32
 
@@ -92,23 +99,28 @@ static void usage(void)
 
 static void exclusive_usage(void)
 {
-       fprintf(stderr, 
-               _("%s: The -n and -w options are mutually exclusive.\n\n"), 
+       fprintf(stderr,
+               _("%s: The -n and -w options are mutually exclusive.\n\n"),
                program_name);
        exit(1);
 }
 
 static blk_t currently_testing = 0;
 static blk_t num_blocks = 0;
+static blk_t num_read_errors = 0;
+static blk_t num_write_errors = 0;
+static blk_t num_corruption_errors = 0;
 static ext2_badblocks_list bb_list = NULL;
 static FILE *out;
 static blk_t next_bad = 0;
 static ext2_badblocks_iterate bb_iter = NULL;
 
+enum error_types { READ_ERROR, WRITE_ERROR, CORRUPTION_ERROR };
+
 static void *allocate_buffer(size_t size)
 {
        void    *ret = 0;
-       
+
 #ifdef HAVE_POSIX_MEMALIGN
        if (posix_memalign(&ret, sys_page_size, size) < 0)
                ret = 0;
@@ -119,7 +131,7 @@ static void *allocate_buffer(size_t size)
 #ifdef HAVE_VALLOC
        ret = valloc(size);
 #endif /* HAVE_VALLOC */
-#endif /* HAVE_MEMALIGN */     
+#endif /* HAVE_MEMALIGN */
 #endif /* HAVE_POSIX_MEMALIGN */
 
        if (!ret)
@@ -132,7 +144,7 @@ static void *allocate_buffer(size_t size)
  * This routine reports a new bad block.  If the bad block has already
  * been seen before, then it returns 0; otherwise it returns 1.
  */
-static int bb_output (blk_t bad)
+static int bb_output (blk_t bad, enum error_types error_type)
 {
        errcode_t errcode;
 
@@ -149,19 +161,75 @@ static int bb_output (blk_t bad)
        }
 
        /* kludge:
-          increment the iteration through the bb_list if 
+          increment the iteration through the bb_list if
           an element was just added before the current iteration
           position.  This should not cause next_bad to change. */
        if (bb_iter && bad < next_bad)
                ext2fs_badblocks_list_iterate (bb_iter, &next_bad);
+
+       if (error_type == READ_ERROR) {
+         num_read_errors++;
+       } else if (error_type == WRITE_ERROR) {
+         num_write_errors++;
+       } else if (error_type == CORRUPTION_ERROR) {
+         num_corruption_errors++;
+       }
        return 1;
 }
 
+static char *time_diff_format(struct timeval *tv1,
+                             struct timeval *tv2, char *buf)
+{
+        time_t diff = (tv1->tv_sec - tv2->tv_sec);
+       int     hr,min,sec;
+
+       sec = diff % 60;
+       diff /= 60;
+       min = diff % 60;
+       hr = diff / 60;
+
+       if (hr)
+               sprintf(buf, "%d:%02d:%02d", hr, min, sec);
+       else
+               sprintf(buf, "%d:%02d", min, sec);
+       return buf;
+}
+
+static float calc_percent(unsigned long current, unsigned long total) {
+       float percent = 0.0;
+       if (total <= 0)
+               return percent;
+       if (current >= total) {
+               percent = 100.0;
+       } else {
+               percent=(100.0*(float)current/(float)total);
+       }
+       return percent;
+}
+
 static void print_status(void)
 {
-       fprintf(stderr, "%15lu/%15lu", (unsigned long) currently_testing, 
-               (unsigned long) num_blocks);
-       fputs("\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b", stderr);
+       struct timeval time_end;
+       char diff_buf[32], line_buf[128];
+       int len;
+
+       gettimeofday(&time_end, 0);
+       len = snprintf(line_buf, sizeof(line_buf), 
+                      _("%6.2f%% done, %s elapsed. "
+                        "(%d/%d/%d errors)"),
+                      calc_percent((unsigned long) currently_testing,
+                                   (unsigned long) num_blocks), 
+                      time_diff_format(&time_end, &time_start, diff_buf),
+                      num_read_errors,
+                      num_write_errors,
+                      num_corruption_errors);
+#ifdef HAVE_MBSTOWCS
+       len = mbstowcs(NULL, line_buf, sizeof(line_buf));
+#endif
+       fputs(line_buf, stderr);
+       memset(line_buf, '\b', len);
+       line_buf[len] = 0;
+       fputs(line_buf, stderr);        
        fflush (stderr);
 }
 
@@ -178,6 +246,10 @@ static void *terminate_addr = NULL;
 
 static void terminate_intr(int signo EXT2FS_ATTR((unused)))
 {
+       fflush(out);
+       fprintf(stderr, "\n\nInterrupted at block %llu\n", 
+               (unsigned long long) currently_testing);
+       fflush(stderr);
        if (terminate_addr)
                longjmp(terminate_addr,1);
        exit(1);
@@ -205,16 +277,21 @@ static void uncapture_terminate(void)
        signal (SIGUSR2, SIG_DFL);
 }
 
+/* Linux requires that O_DIRECT I/Os be 512-byte sector aligned */
+
+#define O_DIRECT_SIZE 512
+
 static void set_o_direct(int dev, unsigned char *buffer, size_t size,
-                        blk_t current_block)
+                        ext2_loff_t offset)
 {
 #ifdef O_DIRECT
        int new_flag = O_DIRECT;
        int flag;
-       
-       if ((((unsigned long) buffer & (sys_page_size - 1)) != 0) ||
+
+       if ((use_buffered_io != 0) ||
+           (((unsigned long) buffer & (sys_page_size - 1)) != 0) ||
            ((size & (sys_page_size - 1)) != 0) ||
-           ((current_block & ((sys_page_size >> 9)-1)) != 0))
+           ((offset & (O_DIRECT_SIZE - 1)) != 0))
                new_flag = 0;
 
        if (new_flag != current_O_DIRECT) {
@@ -235,7 +312,7 @@ static void pattern_fill(unsigned char *buffer, unsigned int pattern,
 {
        unsigned int    i, nb;
        unsigned char   bpattern[sizeof(pattern)], *ptr;
-       
+
        if (pattern == (unsigned int) ~0) {
                for (ptr = buffer; ptr < buffer + n; ptr++) {
                        (*ptr) = random() % (1 << (8 * sizeof(char)));
@@ -279,7 +356,11 @@ static int do_read (int dev, unsigned char * buffer, int try, int block_size,
 #define NANOSEC (1000000000L)
 #define MILISEC (1000L)
 
-       set_o_direct(dev, buffer, try * block_size, current_block);
+#if 0
+       printf("do_read: block %d, try %d\n", current_block, try);
+#endif
+       set_o_direct(dev, buffer, try * block_size,
+                    ((ext2_loff_t) current_block) * block_size);
 
        if (v_flag > 1)
                print_status();
@@ -296,7 +377,7 @@ static int do_read (int dev, unsigned char * buffer, int try, int block_size,
        if (d_flag)
                gettimeofday(&tv2, NULL);
        if (got < 0)
-               got = 0;        
+               got = 0;
        if (got & 511)
                fprintf(stderr, _("Weird value (%ld) in do_read\n"), got);
        got /= block_size;
@@ -348,7 +429,11 @@ static int do_write(int dev, unsigned char * buffer, int try, int block_size,
 {
        long got;
 
-       set_o_direct(dev, buffer, try * block_size, current_block);
+#if 0
+       printf("do_write: block %lu, try %d\n", current_block, try);
+#endif
+       set_o_direct(dev, buffer, try * block_size,
+                    ((ext2_loff_t) current_block) * block_size);
 
        if (v_flag > 1)
                print_status();
@@ -361,7 +446,7 @@ static int do_write(int dev, unsigned char * buffer, int try, int block_size,
        /* Try the write */
        got = write (dev, buffer, try * block_size);
        if (got < 0)
-               got = 0;        
+               got = 0;
        if (got & 511)
                fprintf(stderr, "Weird value (%ld) in do_write\n", got);
        got /= block_size;
@@ -374,6 +459,10 @@ static void flush_bufs(void)
 {
        errcode_t       retval;
 
+#ifdef O_DIRECT
+       if (!use_buffered_io)
+               return;
+#endif
        retval = ext2fs_sync_device(host_dev, 1);
        if (retval)
                com_err(program_name, retval, _("during ext2fs_sync_device"));
@@ -388,6 +477,10 @@ static unsigned int test_ro (int dev, blk_t last_block,
        int got;
        unsigned int bb_count = 0;
        errcode_t errcode;
+       blk_t recover_block = ~0;
+
+       /* set up abend handler */
+       capture_terminate(NULL);
 
        errcode = ext2fs_badblocks_list_iterate_begin(bb_list,&bb_iter);
        if (errcode) {
@@ -410,8 +503,8 @@ static unsigned int test_ro (int dev, blk_t last_block,
                exit (1);
        }
        if (v_flag) {
-               fprintf (stderr, _("Checking blocks %lu to %lu\n"), 
-                        (unsigned long) first_block, 
+               fprintf (stderr, _("Checking blocks %lu to %lu\n"),
+                        (unsigned long) first_block,
                         (unsigned long) last_block - 1);
        }
        if (t_flag) {
@@ -457,23 +550,20 @@ static unsigned int test_ro (int dev, blk_t last_block,
                                if (memcmp (blkbuf+i*block_size,
                                            blkbuf+blocks_at_once*block_size,
                                            block_size))
-                                       bb_count += bb_output(currently_testing + i);
+                                       bb_count += bb_output(currently_testing + i, CORRUPTION_ERROR);
                }
+               if (got == 0 && try == 1)
+                       bb_count += bb_output(currently_testing++, READ_ERROR);
                currently_testing += got;
-               if (got == try) {
-                       try = blocks_at_once;
-                       /* recover page-aligned offset for O_DIRECT */
-                       if ( (blocks_at_once >= sys_page_size >> 9)
-                            && (currently_testing % (sys_page_size >> 9)!= 0))
-                               try -= (sys_page_size >> 9)
-                                       - (currently_testing 
-                                          % (sys_page_size >> 9));
-                       continue;
-               }
-               else
+               if (got != try) {
                        try = 1;
-               if (got == 0) {
-                       bb_count += bb_output(currently_testing++);
+                       if (recover_block == ~0)
+                               recover_block = currently_testing - got +
+                                       blocks_at_once;
+                       continue;
+               } else if (currently_testing == recover_block) {
+                       try = blocks_at_once;
+                       recover_block = ~0;
                }
        }
        num_blocks = 0;
@@ -486,6 +576,8 @@ static unsigned int test_ro (int dev, blk_t last_block,
 
        ext2fs_badblocks_list_iterate_end(bb_iter);
 
+       uncapture_terminate();
+
        return bb_count;
 }
 
@@ -498,10 +590,14 @@ static unsigned int test_rw (int dev, blk_t last_block,
        const unsigned int *pattern;
        int i, try, got, nr_pattern, pat_idx;
        unsigned int bb_count = 0;
+       blk_t recover_block = ~0;
+
+       /* set up abend handler */
+       capture_terminate(NULL);
 
        buffer = allocate_buffer(2 * blocks_at_once * block_size);
        read_buffer = buffer + blocks_at_once * block_size;
-       
+
        if (!buffer) {
                com_err (program_name, ENOMEM, _("while allocating buffers"));
                exit (1);
@@ -510,10 +606,10 @@ static unsigned int test_rw (int dev, blk_t last_block,
        flush_bufs();
 
        if (v_flag) {
-               fputs(_("Checking for bad blocks in read-write mode\n"), 
+               fputs(_("Checking for bad blocks in read-write mode\n"),
                      stderr);
                fprintf(stderr, _("From block %lu to %lu\n"),
-                       (unsigned long) first_block, 
+                       (unsigned long) first_block,
                        (unsigned long) last_block - 1);
        }
        if (t_flag) {
@@ -546,24 +642,21 @@ static unsigned int test_rw (int dev, blk_t last_block,
                        if (v_flag > 1)
                                print_status();
 
+                       if (got == 0 && try == 1)
+                               bb_count += bb_output(currently_testing++, WRITE_ERROR);
                        currently_testing += got;
-                       if (got == try) {
-                               try = blocks_at_once;
-                               /* recover page-aligned offset for O_DIRECT */
-                               if ( (blocks_at_once >= sys_page_size >> 9)
-                                    && (currently_testing % 
-                                        (sys_page_size >> 9)!= 0))
-                                       try -= (sys_page_size >> 9)
-                                               - (currently_testing 
-                                                  % (sys_page_size >> 9));
-                               continue;
-                       } else
+                       if (got != try) {
                                try = 1;
-                       if (got == 0) {
-                               bb_count += bb_output(currently_testing++);
+                               if (recover_block == ~0)
+                                       recover_block = currently_testing -
+                                               got + blocks_at_once;
+                               continue;
+                       } else if (currently_testing == recover_block) {
+                               try = blocks_at_once;
+                               recover_block = ~0;
                        }
                }
-               
+
                num_blocks = 0;
                alarm (0);
                if (s_flag | v_flag)
@@ -588,29 +681,29 @@ static unsigned int test_rw (int dev, blk_t last_block,
                                try = last_block - currently_testing;
                        got = do_read (dev, read_buffer, try, block_size,
                                       currently_testing);
-                       if (got == 0) {
-                               bb_count += bb_output(currently_testing++);
+                       if (got == 0 && try == 1)
+                               bb_count += bb_output(currently_testing++, READ_ERROR);
+                       currently_testing += got;
+                       if (got != try) {
+                               try = 1;
+                               if (recover_block == ~0)
+                                       recover_block = currently_testing -
+                                               got + blocks_at_once;
                                continue;
+                       } else if (currently_testing == recover_block) {
+                               try = blocks_at_once;
+                               recover_block = ~0;
                        }
                        for (i=0; i < got; i++) {
                                if (memcmp(read_buffer + i * block_size,
                                           buffer + i * block_size,
                                           block_size))
-                                       bb_count += bb_output(currently_testing+i);
+                                       bb_count += bb_output(currently_testing+i, CORRUPTION_ERROR);
                        }
-                       currently_testing += got;
-                       /* recover page-aligned offset for O_DIRECT */
-                       if ( (blocks_at_once >= sys_page_size >> 9)
-                            && (currently_testing % (sys_page_size >> 9)!= 0))
-                               try = blocks_at_once - (sys_page_size >> 9)
-                                       - (currently_testing 
-                                          % (sys_page_size >> 9));
-                       else
-                               try = blocks_at_once;
                        if (v_flag > 1)
                                print_status();
                }
-               
+
                num_blocks = 0;
                alarm (0);
                if (s_flag | v_flag)
@@ -646,6 +739,8 @@ static unsigned int test_nd (int dev, blk_t last_block,
        errcode_t errcode;
        unsigned long buf_used;
        static unsigned int bb_count;
+       int granularity = blocks_at_once;
+       blk_t recover_block = ~0;
 
        bb_count = 0;
        errcode = ext2fs_badblocks_list_iterate_begin(bb_list,&bb_iter);
@@ -668,13 +763,13 @@ static unsigned int test_nd (int dev, blk_t last_block,
        save_base = blkbuf;
        test_base = blkbuf + (blocks_at_once * block_size);
        read_base = blkbuf + (2 * blocks_at_once * block_size);
-       
+
        num_saved = 0;
 
        flush_bufs();
        if (v_flag) {
            fputs(_("Checking for bad blocks in non-destructive read-write mode\n"), stderr);
-           fprintf (stderr, _("From block %lu to %lu\n"), 
+           fprintf (stderr, _("From block %lu to %lu\n"),
                     (unsigned long) first_block,
                     (unsigned long) last_block - 1);
        }
@@ -697,7 +792,7 @@ static unsigned int test_nd (int dev, blk_t last_block,
                fflush (out);
                exit(1);
        }
-       
+
        /* set up abend handler */
        capture_terminate(terminate_env);
 
@@ -728,7 +823,7 @@ static unsigned int test_nd (int dev, blk_t last_block,
                                }
                                break;
                        }
-                       got = try = blocks_at_once - buf_used;
+                       got = try = granularity - buf_used;
                        if (next_bad) {
                                if (currently_testing == next_bad) {
                                        /* fprintf (out, "%lu\n", nextbad); */
@@ -744,8 +839,15 @@ static unsigned int test_nd (int dev, blk_t last_block,
                        got = do_read (dev, save_ptr, try, block_size,
                                       currently_testing);
                        if (got == 0) {
+                               if (recover_block == ~0)
+                                       recover_block = currently_testing +
+                                               blocks_at_once;
+                               if (granularity != 1) {
+                                       granularity = 1;
+                                       continue;
+                               }
                                /* First block must have been bad. */
-                               bb_count += bb_output(currently_testing++);
+                               bb_count += bb_output(currently_testing++, READ_ERROR);
                                goto check_for_more;
                        }
 
@@ -763,15 +865,20 @@ static unsigned int test_nd (int dev, blk_t last_block,
                        if (written != got)
                                com_err (program_name, errno,
                                         _("during test data write, block %lu"),
-                                        (unsigned long) currently_testing + 
+                                        (unsigned long) currently_testing +
                                         written);
 
                        buf_used += got;
                        save_ptr += got * block_size;
                        test_ptr += got * block_size;
                        currently_testing += got;
-                       if (got != try)
-                               bb_count += bb_output(currently_testing++);
+                       if (got != try) {
+                               try = 1;
+                               if (recover_block == ~0)
+                                       recover_block = currently_testing -
+                                               got + blocks_at_once;
+                               continue;
+                       }
 
                check_for_more:
                        /*
@@ -779,10 +886,15 @@ static unsigned int test_nd (int dev, blk_t last_block,
                         * around, and we're not done yet testing the disk, go
                         * back and get some more blocks.
                         */
-                       if ((buf_used != blocks_at_once) &&
+                       if ((buf_used != granularity) &&
                            (currently_testing < last_block))
                                continue;
 
+                       if (currently_testing >= recover_block) {
+                               granularity = blocks_at_once;
+                               recover_block = ~0;
+                       }
+
                        flush_bufs();
                        save_currently_testing = currently_testing;
 
@@ -810,7 +922,7 @@ static unsigned int test_nd (int dev, blk_t last_block,
                                        try = test_record[used2].num;
                                        used2++;
                                }
-                               
+
                                got = do_read (dev, read_ptr, try,
                                               block_size, currently_testing);
 
@@ -819,12 +931,12 @@ static unsigned int test_nd (int dev, blk_t last_block,
                                for (i = 0; i < got; ++i)
                                        if (memcmp (test_ptr+i*block_size,
                                                    read_ptr+i*block_size, block_size))
-                                               bb_count += bb_output(currently_testing + i);
+                                               bb_count += bb_output(currently_testing + i, CORRUPTION_ERROR);
                                if (got < try) {
-                                       bb_count += bb_output(currently_testing + got);
+                                       bb_count += bb_output(currently_testing + got, READ_ERROR);
                                        got++;
                                }
-                                       
+
                                /* write back original data */
                                do_write (dev, save_ptr, got,
                                          block_size, currently_testing);
@@ -903,7 +1015,7 @@ static unsigned int parse_uint(const char *str, const char *descr)
 {
        char            *tmp;
        unsigned long   ret;
-       
+
        errno = 0;
        ret = strtoul(str, &tmp, 0);
        if (*tmp || errno || (ret > UINT_MAX) ||
@@ -924,7 +1036,7 @@ int main (int argc, char ** argv)
        FILE * in = NULL;
        int block_size = 1024;
        unsigned int blocks_at_once = 64;
-       blk_t last_block, first_block;
+       blk64_t last_block, first_block;
        int num_passes = 0;
        int passes_clean = 0;
        int dev;
@@ -933,7 +1045,7 @@ int main (int argc, char ** argv)
        unsigned int (*test_func)(int, blk_t,
                                  int, blk_t,
                                  unsigned int);
-       int open_flag = 0;
+       int open_flag;
        long sysval;
 
        setbuf(stdout, NULL);
@@ -958,18 +1070,13 @@ int main (int argc, char ** argv)
                sys_page_size = sysval;
 #endif /* _SC_PAGESIZE */
 #endif /* HAVE_SYSCONF */
-       
+
        if (argc && *argv)
                program_name = *argv;
-       while ((c = getopt (argc, argv, "b:d:e:fi:o:svwnc:p:h:t:X")) != EOF) {
+       while ((c = getopt (argc, argv, "b:d:e:fi:o:svwnc:p:h:t:BX")) != EOF) {
                switch (c) {
                case 'b':
                        block_size = parse_uint(optarg, "block size");
-                       if (block_size > 4096) {
-                               com_err (program_name, 0,
-                                        _("bad block size - %s"), optarg);
-                               exit (1);
-                       }
                        break;
                case 'f':
                        force++;
@@ -1008,7 +1115,7 @@ int main (int argc, char ** argv)
                        d_flag = parse_uint(optarg, "read delay factor");
                        break;
                case 'p':
-                       num_passes = parse_uint(optarg, 
+                       num_passes = parse_uint(optarg,
                                                "number of clean passes");
                        break;
                case 'h':
@@ -1018,7 +1125,7 @@ int main (int argc, char ** argv)
                        if (t_flag + 1 > t_max) {
                                unsigned int *t_patts_new;
 
-                               t_patts_new = realloc(t_patts, sizeof(int) * 
+                               t_patts_new = realloc(t_patts, sizeof(int) *
                                                      (t_max + T_INC));
                                if (!t_patts_new) {
                                        com_err(program_name, ENOMEM,
@@ -1039,6 +1146,9 @@ int main (int argc, char ** argv)
                                t_patts[t_flag++] = pattern;
                        }
                        break;
+               case 'B':
+                       use_buffered_io = 1;
+                       break;
                case 'X':
                        exclusive_ok++;
                        break;
@@ -1064,7 +1174,7 @@ int main (int argc, char ** argv)
                usage();
        device_name = argv[optind++];
        if (optind > argc - 1) {
-               errcode = ext2fs_get_device_size(device_name,
+               errcode = ext2fs_get_device_size2(device_name,
                                                 block_size,
                                                 &last_block);
                if (errcode == EXT2_ET_UNIMPLEMENTED) {
@@ -1095,8 +1205,9 @@ int main (int argc, char ** argv)
        }
        if (w_flag)
                check_mount(device_name);
-       
-       open_flag = w_flag ? O_RDWR : O_RDONLY;
+
+       gettimeofday(&time_start, 0);
+       open_flag = O_LARGEFILE | (w_flag ? O_RDWR : O_RDONLY);
        dev = open (device_name, open_flag);
        if (dev == -1) {
                com_err (program_name, errno, _("while trying to open %s"),
@@ -1180,19 +1291,17 @@ int main (int argc, char ** argv)
                        passes_clean = 0;
                else
                        ++passes_clean;
-               
+
                if (v_flag)
                        fprintf(stderr,
-                               _("Pass completed, %u bad blocks found.\n"), 
-                               bb_count);
+                               _("Pass completed, %u bad blocks found. (%d/%d/%d errors)\n"),
+                               bb_count, num_read_errors, num_write_errors, num_corruption_errors);
 
        } while (passes_clean < num_passes);
 
        close (dev);
        if (out != stdout)
                fclose (out);
-       if (t_patts)
-               free(t_patts);
+       free(t_patts);
        return 0;
 }
-