Whamcloud - gitweb
lib/ext2fs: consistently use #ifdefs in ext2fs_print_bmap_statistics()
[tools/e2fsprogs.git] / lib / ext2fs / gen_bitmap64.c
index 4526a09..4289e81 100644 (file)
  * e2fsck can request an encoding which is optimized for that.
  */
 
-static void warn_bitmap(ext2fs_generic_bitmap bitmap,
+static void warn_bitmap(ext2fs_generic_bitmap_64 bitmap,
                        int code, __u64 arg)
 {
 #ifndef OMIT_COM_ERR
        if (bitmap->description)
                com_err(0, bitmap->base_error_code+code,
-                       "#%llu for %s", arg, bitmap->description);
+                       "#%llu for %s", (unsigned long long) arg,
+                       bitmap->description);
        else
-               com_err(0, bitmap->base_error_code + code, "#%llu", arg);
+               com_err(0, bitmap->base_error_code + code, "#%llu",
+                       (unsigned long long) arg);
 #endif
 }
 
@@ -93,7 +95,7 @@ errcode_t ext2fs_alloc_generic_bmap(ext2_filsys fs, errcode_t magic,
                                    const char *descr,
                                    ext2fs_generic_bitmap *ret)
 {
-       ext2fs_generic_bitmap   bitmap;
+       ext2fs_generic_bitmap_64 bitmap;
        struct ext2_bitmap_ops  *ops;
        ext2_ino_t num_dirs;
        errcode_t retval;
@@ -119,7 +121,7 @@ errcode_t ext2fs_alloc_generic_bmap(ext2_filsys fs, errcode_t magic,
                return EINVAL;
        }
 
-       retval = ext2fs_get_memzero(sizeof(struct ext2fs_struct_generic_bitmap),
+       retval = ext2fs_get_memzero(sizeof(struct ext2fs_struct_generic_bitmap_64),
                                    &bitmap);
        if (retval)
                return retval;
@@ -170,22 +172,20 @@ errcode_t ext2fs_alloc_generic_bmap(ext2_filsys fs, errcode_t magic,
                return retval;
        }
 
-       *ret = bitmap;
+       *ret = (ext2fs_generic_bitmap) bitmap;
        return 0;
 }
 
 #ifdef ENABLE_BMAP_STATS
-static void ext2fs_print_bmap_statistics(ext2fs_generic_bitmap bitmap)
+static void ext2fs_print_bmap_statistics(ext2fs_generic_bitmap_64 bitmap)
 {
        struct ext2_bmap_statistics *stats = &bitmap->stats;
 #ifdef ENABLE_BMAP_STATS_OPS
        float mark_seq_perc = 0.0, test_seq_perc = 0.0;
        float mark_back_perc = 0.0, test_back_perc = 0.0;
-#endif
-       double inuse;
        struct timeval now;
+       double inuse;
 
-#ifdef ENABLE_BMAP_STATS_OPS
        if (stats->test_count) {
                test_seq_perc = ((float)stats->test_seq /
                                 stats->test_count) * 100;
@@ -199,7 +199,6 @@ static void ext2fs_print_bmap_statistics(ext2fs_generic_bitmap bitmap)
                mark_back_perc = ((float)stats->mark_back /
                                  stats->mark_count) * 100;
        }
-#endif
 
        if (gettimeofday(&now, (struct timezone *) NULL) == -1) {
                perror("gettimeofday");
@@ -210,6 +209,7 @@ static void ext2fs_print_bmap_statistics(ext2fs_generic_bitmap bitmap)
                (((double) now.tv_usec) * 0.000001);
        inuse -= (double) stats->created.tv_sec + \
                (((double) stats->created.tv_usec) * 0.000001);
+#endif /* ENABLE_BMAP_STATS_OPS */
 
        fprintf(stderr, "\n[+] %s bitmap (type %d)\n", bitmap->description,
                stats->type);
@@ -241,13 +241,15 @@ static void ext2fs_print_bmap_statistics(ext2fs_generic_bitmap bitmap)
 }
 #endif
 
-void ext2fs_free_generic_bmap(ext2fs_generic_bitmap bmap)
+void ext2fs_free_generic_bmap(ext2fs_generic_bitmap gen_bmap)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
+
        if (!bmap)
                return;
 
        if (EXT2FS_IS_32_BITMAP(bmap)) {
-               ext2fs_free_generic_bitmap(bmap);
+               ext2fs_free_generic_bitmap(gen_bmap);
                return;
        }
 
@@ -271,24 +273,25 @@ void ext2fs_free_generic_bmap(ext2fs_generic_bitmap bmap)
        ext2fs_free_mem(&bmap);
 }
 
-errcode_t ext2fs_copy_generic_bmap(ext2fs_generic_bitmap src,
+errcode_t ext2fs_copy_generic_bmap(ext2fs_generic_bitmap gen_src,
                                   ext2fs_generic_bitmap *dest)
 {
+       ext2fs_generic_bitmap_64 src = (ext2fs_generic_bitmap_64) gen_src;
        char *descr, *new_descr;
-       ext2fs_generic_bitmap   new_bmap;
+       ext2fs_generic_bitmap_64 new_bmap;
        errcode_t retval;
 
        if (!src)
                return EINVAL;
 
        if (EXT2FS_IS_32_BITMAP(src))
-               return ext2fs_copy_generic_bitmap(src, dest);
+               return ext2fs_copy_generic_bitmap(gen_src, dest);
 
        if (!EXT2FS_IS_64_BITMAP(src))
                return EINVAL;
 
        /* Allocate a new bitmap struct */
-       retval = ext2fs_get_memzero(sizeof(struct ext2fs_struct_generic_bitmap),
+       retval = ext2fs_get_memzero(sizeof(struct ext2fs_struct_generic_bitmap_64),
                                    &new_bmap);
        if (retval)
                return retval;
@@ -336,21 +339,23 @@ errcode_t ext2fs_copy_generic_bmap(ext2fs_generic_bitmap src,
                return retval;
        }
 
-       *dest = new_bmap;
+       *dest = (ext2fs_generic_bitmap) new_bmap;
 
        return 0;
 }
 
-errcode_t ext2fs_resize_generic_bmap(ext2fs_generic_bitmap bmap,
+errcode_t ext2fs_resize_generic_bmap(ext2fs_generic_bitmap gen_bmap,
                                     __u64 new_end,
                                     __u64 new_real_end)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
+
        if (!bmap)
                return EINVAL;
 
        if (EXT2FS_IS_32_BITMAP(bmap))
-               return ext2fs_resize_generic_bitmap(bmap->magic, new_end,
-                                                   new_real_end, bmap);
+               return ext2fs_resize_generic_bitmap(gen_bmap->magic, new_end,
+                                                   new_real_end, gen_bmap);
 
        if (!EXT2FS_IS_64_BITMAP(bmap))
                return EINVAL;
@@ -360,10 +365,12 @@ errcode_t ext2fs_resize_generic_bmap(ext2fs_generic_bitmap bmap,
        return bmap->bitmap_ops->resize_bmap(bmap, new_end, new_real_end);
 }
 
-errcode_t ext2fs_fudge_generic_bmap_end(ext2fs_generic_bitmap bitmap,
+errcode_t ext2fs_fudge_generic_bmap_end(ext2fs_generic_bitmap gen_bitmap,
                                        errcode_t neq,
                                        __u64 end, __u64 *oend)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
+
        if (!bitmap)
                return EINVAL;
 
@@ -371,7 +378,8 @@ errcode_t ext2fs_fudge_generic_bmap_end(ext2fs_generic_bitmap bitmap,
                ext2_ino_t tmp_oend;
                int retval;
 
-               retval = ext2fs_fudge_generic_bitmap_end(bitmap, bitmap->magic,
+               retval = ext2fs_fudge_generic_bitmap_end(gen_bitmap,
+                                                        bitmap->magic,
                                                         neq, end, &tmp_oend);
                if (oend)
                        *oend = tmp_oend;
@@ -389,13 +397,15 @@ errcode_t ext2fs_fudge_generic_bmap_end(ext2fs_generic_bitmap bitmap,
        return 0;
 }
 
-__u64 ext2fs_get_generic_bmap_start(ext2fs_generic_bitmap bitmap)
+__u64 ext2fs_get_generic_bmap_start(ext2fs_generic_bitmap gen_bitmap)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
+
        if (!bitmap)
                return EINVAL;
 
        if (EXT2FS_IS_32_BITMAP(bitmap))
-               return ext2fs_get_generic_bitmap_start(bitmap);
+               return ext2fs_get_generic_bitmap_start(gen_bitmap);
 
        if (!EXT2FS_IS_64_BITMAP(bitmap))
                return EINVAL;
@@ -403,13 +413,15 @@ __u64 ext2fs_get_generic_bmap_start(ext2fs_generic_bitmap bitmap)
        return bitmap->start;
 }
 
-__u64 ext2fs_get_generic_bmap_end(ext2fs_generic_bitmap bitmap)
+__u64 ext2fs_get_generic_bmap_end(ext2fs_generic_bitmap gen_bitmap)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
+
        if (!bitmap)
                return EINVAL;
 
        if (EXT2FS_IS_32_BITMAP(bitmap))
-               return ext2fs_get_generic_bitmap_end(bitmap);
+               return ext2fs_get_generic_bitmap_end(gen_bitmap);
 
        if (!EXT2FS_IS_64_BITMAP(bitmap))
                return EINVAL;
@@ -417,27 +429,31 @@ __u64 ext2fs_get_generic_bmap_end(ext2fs_generic_bitmap bitmap)
        return bitmap->end;
 }
 
-void ext2fs_clear_generic_bmap(ext2fs_generic_bitmap bitmap)
+void ext2fs_clear_generic_bmap(ext2fs_generic_bitmap gen_bitmap)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
+
        if (EXT2FS_IS_32_BITMAP(bitmap))
-               ext2fs_clear_generic_bitmap(bitmap);
+               ext2fs_clear_generic_bitmap(gen_bitmap);
        else
-               bitmap->bitmap_ops->clear_bmap (bitmap);
+               bitmap->bitmap_ops->clear_bmap(bitmap);
 }
 
-int ext2fs_mark_generic_bmap(ext2fs_generic_bitmap bitmap,
+int ext2fs_mark_generic_bmap(ext2fs_generic_bitmap gen_bitmap,
                             __u64 arg)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
+
        if (!bitmap)
                return 0;
 
        if (EXT2FS_IS_32_BITMAP(bitmap)) {
                if (arg & ~0xffffffffULL) {
-                       ext2fs_warn_bitmap2(bitmap,
+                       ext2fs_warn_bitmap2(gen_bitmap,
                                            EXT2FS_MARK_ERROR, 0xffffffff);
                        return 0;
                }
-               return ext2fs_mark_generic_bitmap(bitmap, arg);
+               return ext2fs_mark_generic_bitmap(gen_bitmap, arg);
        }
 
        if (!EXT2FS_IS_64_BITMAP(bitmap))
@@ -462,19 +478,21 @@ int ext2fs_mark_generic_bmap(ext2fs_generic_bitmap bitmap,
        return bitmap->bitmap_ops->mark_bmap(bitmap, arg);
 }
 
-int ext2fs_unmark_generic_bmap(ext2fs_generic_bitmap bitmap,
+int ext2fs_unmark_generic_bmap(ext2fs_generic_bitmap gen_bitmap,
                               __u64 arg)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
+
        if (!bitmap)
                return 0;
 
        if (EXT2FS_IS_32_BITMAP(bitmap)) {
                if (arg & ~0xffffffffULL) {
-                       ext2fs_warn_bitmap2(bitmap, EXT2FS_UNMARK_ERROR,
+                       ext2fs_warn_bitmap2(gen_bitmap, EXT2FS_UNMARK_ERROR,
                                            0xffffffff);
                        return 0;
                }
-               return ext2fs_unmark_generic_bitmap(bitmap, arg);
+               return ext2fs_unmark_generic_bitmap(gen_bitmap, arg);
        }
 
        if (!EXT2FS_IS_64_BITMAP(bitmap))
@@ -492,19 +510,20 @@ int ext2fs_unmark_generic_bmap(ext2fs_generic_bitmap bitmap,
        return bitmap->bitmap_ops->unmark_bmap(bitmap, arg);
 }
 
-int ext2fs_test_generic_bmap(ext2fs_generic_bitmap bitmap,
+int ext2fs_test_generic_bmap(ext2fs_generic_bitmap gen_bitmap,
                             __u64 arg)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
        if (!bitmap)
                return 0;
 
        if (EXT2FS_IS_32_BITMAP(bitmap)) {
                if (arg & ~0xffffffffULL) {
-                       ext2fs_warn_bitmap2(bitmap, EXT2FS_TEST_ERROR,
+                       ext2fs_warn_bitmap2(gen_bitmap, EXT2FS_TEST_ERROR,
                                            0xffffffff);
                        return 0;
                }
-               return ext2fs_test_generic_bitmap(bitmap, arg);
+               return ext2fs_test_generic_bitmap(gen_bitmap, arg);
        }
 
        if (!EXT2FS_IS_64_BITMAP(bitmap))
@@ -529,20 +548,22 @@ int ext2fs_test_generic_bmap(ext2fs_generic_bitmap bitmap,
        return bitmap->bitmap_ops->test_bmap(bitmap, arg);
 }
 
-errcode_t ext2fs_set_generic_bmap_range(ext2fs_generic_bitmap bmap,
+errcode_t ext2fs_set_generic_bmap_range(ext2fs_generic_bitmap gen_bmap,
                                        __u64 start, unsigned int num,
                                        void *in)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
+
        if (!bmap)
                return EINVAL;
 
        if (EXT2FS_IS_32_BITMAP(bmap)) {
                if ((start+num-1) & ~0xffffffffULL) {
-                       ext2fs_warn_bitmap2(bmap, EXT2FS_UNMARK_ERROR,
+                       ext2fs_warn_bitmap2(gen_bmap, EXT2FS_UNMARK_ERROR,
                                            0xffffffff);
                        return EINVAL;
                }
-               return ext2fs_set_generic_bitmap_range(bmap, bmap->magic,
+               return ext2fs_set_generic_bitmap_range(gen_bmap, bmap->magic,
                                                       start, num, in);
        }
 
@@ -554,20 +575,22 @@ errcode_t ext2fs_set_generic_bmap_range(ext2fs_generic_bitmap bmap,
        return bmap->bitmap_ops->set_bmap_range(bmap, start, num, in);
 }
 
-errcode_t ext2fs_get_generic_bmap_range(ext2fs_generic_bitmap bmap,
+errcode_t ext2fs_get_generic_bmap_range(ext2fs_generic_bitmap gen_bmap,
                                        __u64 start, unsigned int num,
                                        void *out)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
+
        if (!bmap)
                return EINVAL;
 
        if (EXT2FS_IS_32_BITMAP(bmap)) {
                if ((start+num-1) & ~0xffffffffULL) {
-                       ext2fs_warn_bitmap2(bmap,
+                       ext2fs_warn_bitmap2(gen_bmap,
                                            EXT2FS_UNMARK_ERROR, 0xffffffff);
                        return EINVAL;
                }
-               return ext2fs_get_generic_bitmap_range(bmap, bmap->magic,
+               return ext2fs_get_generic_bitmap_range(gen_bmap, bmap->magic,
                                                       start, num, out);
        }
 
@@ -580,9 +603,11 @@ errcode_t ext2fs_get_generic_bmap_range(ext2fs_generic_bitmap bmap,
 }
 
 errcode_t ext2fs_compare_generic_bmap(errcode_t neq,
-                                     ext2fs_generic_bitmap bm1,
-                                     ext2fs_generic_bitmap bm2)
+                                     ext2fs_generic_bitmap gen_bm1,
+                                     ext2fs_generic_bitmap gen_bm2)
 {
+       ext2fs_generic_bitmap_64 bm1 = (ext2fs_generic_bitmap_64) gen_bm1;
+       ext2fs_generic_bitmap_64 bm2 = (ext2fs_generic_bitmap_64) gen_bm2;
        blk64_t i;
 
        if (!bm1 || !bm2)
@@ -592,7 +617,8 @@ errcode_t ext2fs_compare_generic_bmap(errcode_t neq,
 
        /* Now we know both bitmaps have the same magic */
        if (EXT2FS_IS_32_BITMAP(bm1))
-               return ext2fs_compare_generic_bitmap(bm1->magic, neq, bm1, bm2);
+               return ext2fs_compare_generic_bitmap(bm1->magic, neq,
+                                                    gen_bm1, gen_bm2);
 
        if (!EXT2FS_IS_64_BITMAP(bm1))
                return EINVAL;
@@ -601,20 +627,25 @@ errcode_t ext2fs_compare_generic_bmap(errcode_t neq,
            (bm1->end != bm2->end))
                return neq;
 
-       for (i = bm1->end - ((bm1->end - bm1->start) % 8); i <= bm1->end; i++)
-               if (ext2fs_test_generic_bmap(bm1, i) !=
-                   ext2fs_test_generic_bmap(bm2, i))
+       for (i = bm1->start; i < bm1->end; i++) {
+               int ret1, ret2;
+               ret1 = !!ext2fs_test_generic_bmap(gen_bm1, i);
+               ret2 = !!ext2fs_test_generic_bmap(gen_bm2, i);
+               if (ret1 != ret2) {
                        return neq;
+               }
+       }
 
        return 0;
 }
 
-void ext2fs_set_generic_bmap_padding(ext2fs_generic_bitmap bmap)
+void ext2fs_set_generic_bmap_padding(ext2fs_generic_bitmap gen_bmap)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
        __u64   start, num;
 
        if (EXT2FS_IS_32_BITMAP(bmap)) {
-               ext2fs_set_generic_bitmap_padding(bmap);
+               ext2fs_set_generic_bitmap_padding(gen_bmap);
                return;
        }
 
@@ -624,9 +655,10 @@ void ext2fs_set_generic_bmap_padding(ext2fs_generic_bitmap bmap)
        /* XXX ought to warn on error */
 }
 
-int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap bmap,
+int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap gen_bmap,
                                    blk64_t block, unsigned int num)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
        __u64   end = block + num;
 
        if (!bmap)
@@ -637,7 +669,8 @@ int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap bmap,
                                                 bmap, block);
 
        if (EXT2FS_IS_32_BITMAP(bmap)) {
-               if ((block+num-1) & ~0xffffffffULL) {
+               if ((block & ~0xffffffffULL) ||
+                   ((block+num-1) & ~0xffffffffULL)) {
                        ext2fs_warn_bitmap2((ext2fs_generic_bitmap) bmap,
                                            EXT2FS_UNMARK_ERROR, 0xffffffff);
                        return EINVAL;
@@ -653,11 +686,12 @@ int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap bmap,
 
        /* convert to clusters if necessary */
        block >>= bmap->cluster_bits;
-       end += (1 << bmap->cluster_bits) - 1;
+       end += (1ULL << bmap->cluster_bits) - 1;
        end >>= bmap->cluster_bits;
        num = end - block;
 
-       if ((block < bmap->start) || (block+num-1 > bmap->end)) {
+       if ((block < bmap->start) || (block > bmap->end) ||
+           (block+num-1 > bmap->end)) {
                ext2fs_warn_bitmap(EXT2_ET_BAD_BLOCK_TEST, block,
                                   bmap->description);
                return EINVAL;
@@ -666,16 +700,18 @@ int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap bmap,
        return bmap->bitmap_ops->test_clear_bmap_extent(bmap, block, num);
 }
 
-void ext2fs_mark_block_bitmap_range2(ext2fs_block_bitmap bmap,
+void ext2fs_mark_block_bitmap_range2(ext2fs_block_bitmap gen_bmap,
                                     blk64_t block, unsigned int num)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
        __u64   end = block + num;
 
        if (!bmap)
                return;
 
        if (EXT2FS_IS_32_BITMAP(bmap)) {
-               if ((block+num-1) & ~0xffffffffULL) {
+               if ((block & ~0xffffffffULL) ||
+                   ((block+num-1) & ~0xffffffffULL)) {
                        ext2fs_warn_bitmap2((ext2fs_generic_bitmap) bmap,
                                            EXT2FS_UNMARK_ERROR, 0xffffffff);
                        return;
@@ -691,11 +727,12 @@ void ext2fs_mark_block_bitmap_range2(ext2fs_block_bitmap bmap,
 
        /* convert to clusters if necessary */
        block >>= bmap->cluster_bits;
-       end += (1 << bmap->cluster_bits) - 1;
+       end += (1ULL << bmap->cluster_bits) - 1;
        end >>= bmap->cluster_bits;
        num = end - block;
 
-       if ((block < bmap->start) || (block+num-1 > bmap->end)) {
+       if ((block < bmap->start) || (block > bmap->end) ||
+           (block+num-1 > bmap->end)) {
                ext2fs_warn_bitmap(EXT2_ET_BAD_BLOCK_MARK, block,
                                   bmap->description);
                return;
@@ -704,16 +741,18 @@ void ext2fs_mark_block_bitmap_range2(ext2fs_block_bitmap bmap,
        bmap->bitmap_ops->mark_bmap_extent(bmap, block, num);
 }
 
-void ext2fs_unmark_block_bitmap_range2(ext2fs_block_bitmap bmap,
+void ext2fs_unmark_block_bitmap_range2(ext2fs_block_bitmap gen_bmap,
                                       blk64_t block, unsigned int num)
 {
+       ext2fs_generic_bitmap_64 bmap = (ext2fs_generic_bitmap_64) gen_bmap;
        __u64   end = block + num;
 
        if (!bmap)
                return;
 
        if (EXT2FS_IS_32_BITMAP(bmap)) {
-               if ((block+num-1) & ~0xffffffffULL) {
+               if ((block & ~0xffffffffULL) ||
+                   ((block+num-1) & ~0xffffffffULL)) {
                        ext2fs_warn_bitmap2((ext2fs_generic_bitmap) bmap,
                                            EXT2FS_UNMARK_ERROR, 0xffffffff);
                        return;
@@ -729,11 +768,12 @@ void ext2fs_unmark_block_bitmap_range2(ext2fs_block_bitmap bmap,
 
        /* convert to clusters if necessary */
        block >>= bmap->cluster_bits;
-       end += (1 << bmap->cluster_bits) - 1;
+       end += (1ULL << bmap->cluster_bits) - 1;
        end >>= bmap->cluster_bits;
        num = end - block;
 
-       if ((block < bmap->start) || (block+num-1 > bmap->end)) {
+       if ((block < bmap->start) || (block > bmap->end) ||
+           (block+num-1 > bmap->end)) {
                ext2fs_warn_bitmap(EXT2_ET_BAD_BLOCK_UNMARK, block,
                                   bmap->description);
                return;
@@ -742,8 +782,10 @@ void ext2fs_unmark_block_bitmap_range2(ext2fs_block_bitmap bmap,
        bmap->bitmap_ops->unmark_bmap_extent(bmap, block, num);
 }
 
-void ext2fs_warn_bitmap32(ext2fs_generic_bitmap bitmap, const char *func)
+void ext2fs_warn_bitmap32(ext2fs_generic_bitmap gen_bitmap, const char *func)
 {
+       ext2fs_generic_bitmap_64 bitmap = (ext2fs_generic_bitmap_64) gen_bitmap;
+
 #ifndef OMIT_COM_ERR
        if (bitmap && bitmap->description)
                com_err(0, EXT2_ET_MAGIC_GENERIC_BITMAP,
@@ -758,50 +800,45 @@ void ext2fs_warn_bitmap32(ext2fs_generic_bitmap bitmap, const char *func)
 errcode_t ext2fs_convert_subcluster_bitmap(ext2_filsys fs,
                                           ext2fs_block_bitmap *bitmap)
 {
-       ext2fs_block_bitmap     cmap, bmap;
+       ext2fs_generic_bitmap_64 bmap, cmap;
+       ext2fs_block_bitmap     gen_bmap = *bitmap, gen_cmap;
        errcode_t               retval;
-       blk64_t                 i, b_end, c_end;
-       int                     n, ratio;
-
-       bmap = *bitmap;
+       blk64_t                 i, next, b_end, c_end;
 
-       if (fs->cluster_ratio_bits == ext2fs_get_bitmap_granularity(bmap))
+       bmap = (ext2fs_generic_bitmap_64) gen_bmap;
+       if (fs->cluster_ratio_bits == ext2fs_get_bitmap_granularity(gen_bmap))
                return 0;       /* Nothing to do */
 
        retval = ext2fs_allocate_block_bitmap(fs, "converted cluster bitmap",
-                                             &cmap);
+                                             &gen_cmap);
        if (retval)
                return retval;
 
+       cmap = (ext2fs_generic_bitmap_64) gen_cmap;
        i = bmap->start;
        b_end = bmap->end;
        bmap->end = bmap->real_end;
        c_end = cmap->end;
        cmap->end = cmap->real_end;
-       n = 0;
-       ratio = 1 << fs->cluster_ratio_bits;
        while (i < bmap->real_end) {
-               if (ext2fs_test_block_bitmap2(bmap, i)) {
-                       ext2fs_mark_block_bitmap2(cmap, i);
-                       i += ratio - n;
-                       n = 0;
-                       continue;
-               }
-               i++; n++;
-               if (n >= ratio)
-                       n = 0;
+               retval = ext2fs_find_first_set_block_bitmap2(gen_bmap,
+                                               i, bmap->real_end, &next);
+               if (retval)
+                       break;
+               ext2fs_mark_block_bitmap2(gen_cmap, next);
+               i = EXT2FS_C2B(fs, EXT2FS_B2C(fs, next) + 1);
        }
        bmap->end = b_end;
        cmap->end = c_end;
-       ext2fs_free_block_bitmap(bmap);
-       *bitmap = cmap;
+       ext2fs_free_block_bitmap(gen_bmap);
+       *bitmap = (ext2fs_block_bitmap) cmap;
        return 0;
 }
 
 errcode_t ext2fs_find_first_zero_generic_bmap(ext2fs_generic_bitmap bitmap,
                                              __u64 start, __u64 end, __u64 *out)
 {
-       int b;
+       ext2fs_generic_bitmap_64 bmap64 = (ext2fs_generic_bitmap_64) bitmap;
        __u64 cstart, cend, cout;
        errcode_t retval;
 
@@ -827,27 +864,27 @@ errcode_t ext2fs_find_first_zero_generic_bmap(ext2fs_generic_bitmap bitmap,
        if (!EXT2FS_IS_64_BITMAP(bitmap))
                return EINVAL;
 
-       cstart = start >> bitmap->cluster_bits;
-       cend = end >> bitmap->cluster_bits;
+       cstart = start >> bmap64->cluster_bits;
+       cend = end >> bmap64->cluster_bits;
 
-       if (cstart < bitmap->start || cend > bitmap->end || start > end) {
-               warn_bitmap(bitmap, EXT2FS_TEST_ERROR, start);
+       if (cstart < bmap64->start || cend > bmap64->end || start > end) {
+               warn_bitmap(bmap64, EXT2FS_TEST_ERROR, start);
                return EINVAL;
        }
 
-       if (bitmap->bitmap_ops->find_first_zero) {
-               retval = bitmap->bitmap_ops->find_first_zero(bitmap, cstart,
+       if (bmap64->bitmap_ops->find_first_zero) {
+               retval = bmap64->bitmap_ops->find_first_zero(bmap64, cstart,
                                                             cend, &cout);
                if (retval)
                        return retval;
        found:
-               cout <<= bitmap->cluster_bits;
+               cout <<= bmap64->cluster_bits;
                *out = (cout >= start) ? cout : start;
                return 0;
        }
 
        for (cout = cstart; cout <= cend; cout++)
-               if (!bitmap->bitmap_ops->test_bmap(bitmap, cout))
+               if (!bmap64->bitmap_ops->test_bmap(bmap64, cout))
                        goto found;
 
        return ENOENT;
@@ -856,7 +893,7 @@ errcode_t ext2fs_find_first_zero_generic_bmap(ext2fs_generic_bitmap bitmap,
 errcode_t ext2fs_find_first_set_generic_bmap(ext2fs_generic_bitmap bitmap,
                                             __u64 start, __u64 end, __u64 *out)
 {
-       int b;
+       ext2fs_generic_bitmap_64 bmap64 = (ext2fs_generic_bitmap_64) bitmap;
        __u64 cstart, cend, cout;
        errcode_t retval;
 
@@ -882,28 +919,63 @@ errcode_t ext2fs_find_first_set_generic_bmap(ext2fs_generic_bitmap bitmap,
        if (!EXT2FS_IS_64_BITMAP(bitmap))
                return EINVAL;
 
-       cstart = start >> bitmap->cluster_bits;
-       cend = end >> bitmap->cluster_bits;
+       cstart = start >> bmap64->cluster_bits;
+       cend = end >> bmap64->cluster_bits;
 
-       if (cstart < bitmap->start || cend > bitmap->end || start > end) {
-               warn_bitmap(bitmap, EXT2FS_TEST_ERROR, start);
+       if (cstart < bmap64->start || cend > bmap64->end || start > end) {
+               warn_bitmap(bmap64, EXT2FS_TEST_ERROR, start);
                return EINVAL;
        }
 
-       if (bitmap->bitmap_ops->find_first_set) {
-               retval = bitmap->bitmap_ops->find_first_set(bitmap, cstart,
+       if (bmap64->bitmap_ops->find_first_set) {
+               retval = bmap64->bitmap_ops->find_first_set(bmap64, cstart,
                                                            cend, &cout);
                if (retval)
                        return retval;
        found:
-               cout <<= bitmap->cluster_bits;
+               cout <<= bmap64->cluster_bits;
                *out = (cout >= start) ? cout : start;
                return 0;
        }
 
        for (cout = cstart; cout <= cend; cout++)
-               if (bitmap->bitmap_ops->test_bmap(bitmap, cout))
+               if (bmap64->bitmap_ops->test_bmap(bmap64, cout))
                        goto found;
 
        return ENOENT;
 }
+
+errcode_t ext2fs_count_used_clusters(ext2_filsys fs, blk64_t start,
+                                    blk64_t end, blk64_t *out)
+{
+       blk64_t         next;
+       blk64_t         tot_set = 0;
+       errcode_t       retval = 0;
+
+       while (start < end) {
+               retval = ext2fs_find_first_set_block_bitmap2(fs->block_map,
+                                                       start, end, &next);
+               if (retval) {
+                       if (retval == ENOENT)
+                               retval = 0;
+                       break;
+               }
+               start = next;
+
+               retval = ext2fs_find_first_zero_block_bitmap2(fs->block_map,
+                                                       start, end, &next);
+               if (retval == 0) {
+                       tot_set += next - start;
+                       start  = next + 1;
+               } else if (retval == ENOENT) {
+                       retval = 0;
+                       tot_set += end - start + 1;
+                       break;
+               } else
+                       break;
+       }
+
+       if (!retval)
+               *out = EXT2FS_NUM_B2C(fs, tot_set);
+       return retval;
+}