Whamcloud - gitweb
LU-16067 misc: cleanup compiler warnings
[tools/e2fsprogs.git] / lib / ext2fs / ext_attr.c
index f4cc2d0..ad51371 100644 (file)
 #endif
 #include <string.h>
 #include <time.h>
+#include <errno.h>
+#if defined HAVE_SYS_XATTR_H
+#include <sys/xattr.h>
+#elif defined HAVE_ATTR_XATTR_H
+#include <attr/xattr.h>
+#endif
 
 #include "ext2_fs.h"
 #include "ext2_ext_attr.h"
@@ -127,6 +133,33 @@ void ext2fs_ext_attr_block_rehash(struct ext2_ext_attr_header *header,
        header->h_hash = hash;
 }
 
+/*
+ * Re-compute the extended attribute hash value after an entry has changed.
+ */
+static void ext2fs_attr_rehash(struct ext2_ext_attr_header *header,
+                               struct ext2_ext_attr_entry *entry)
+{
+       struct ext2_ext_attr_entry *here;
+       __u32 hash = 0;
+
+       entry->e_hash = ext2fs_ext_attr_hash_entry(entry, (char *)header +
+                                                  entry->e_value_offs);
+
+       here = ENTRY(header+1);
+       while (!EXT2_EXT_IS_LAST_ENTRY(here)) {
+               if (!here->e_hash) {
+                       /* Block is not shared if an entry's hash value == 0 */
+                       hash = 0;
+                       break;
+               }
+               hash = (hash << BLOCK_HASH_SHIFT) ^
+                      (hash >> (8*sizeof(hash) - BLOCK_HASH_SHIFT)) ^
+                      here->e_hash;
+               here = EXT2_EXT_ATTR_NEXT(here);
+       }
+       header->h_hash = hash;
+}
+
 #undef BLOCK_HASH_SHIFT
 
 __u32 ext2fs_get_ea_inode_hash(struct ext2_inode *inode)
@@ -260,7 +293,10 @@ errcode_t ext2fs_adjust_ea_refcount3(ext2_filsys fs, blk64_t blk,
        if (retval)
                goto errout;
 
-       header = (struct ext2_ext_attr_header *) block_buf;
+       header = BHDR(block_buf);
+       if (header->h_magic != EXT2_EXT_ATTR_MAGIC)
+               return EXT2_ET_EA_BAD_MAGIC;
+
        header->h_refcount += adjust;
        if (newcount)
                *newcount = header->h_refcount;
@@ -293,7 +329,9 @@ errcode_t ext2fs_adjust_ea_refcount(ext2_filsys fs, blk_t blk,
 
 /* Manipulate the contents of extended attribute regions */
 struct ext2_xattr {
+       int name_index;
        char *name;
+       char *short_name;
        void *value;
        unsigned int value_len;
        ext2_ino_t ea_ino;
@@ -336,10 +374,12 @@ struct ea_name_index {
 
 /* Keep these names sorted in order of decreasing specificity. */
 static struct ea_name_index ea_names[] = {
+       {10, "gnu."},
        {3, "system.posix_acl_default"},
        {2, "system.posix_acl_access"},
        {8, "system.richacl"},
        {6, "security."},
+       {5, "lustre."},
        {4, "trusted."},
        {7, "system."},
        {1, "user."},
@@ -357,13 +397,13 @@ static const char *find_ea_prefix(int index)
        return NULL;
 }
 
-static int find_ea_index(const char *fullname, char **name, int *index)
+static int find_ea_index(const char *fullname, const char **name, int *index)
 {
        struct ea_name_index *e;
 
        for (e = ea_names; e->name; e++) {
                if (strncmp(fullname, e->name, strlen(e->name)) == 0) {
-                       *name = (char *)fullname + strlen(e->name);
+                       *name = fullname + strlen(e->name);
                        *index = e->index;
                        return 1;
                }
@@ -525,11 +565,13 @@ posix_acl_xattr_count(size_t size)
 static errcode_t convert_posix_acl_to_disk_buffer(const void *value, size_t size,
                                                  void *out_buf, size_t *size_out)
 {
-       posix_acl_xattr_header *header = (posix_acl_xattr_header*) value;
-       posix_acl_xattr_entry *entry = (posix_acl_xattr_entry *)(header+1), *end;
+       const posix_acl_xattr_header *header =
+               (const posix_acl_xattr_header*) value;
+       const posix_acl_xattr_entry *end, *entry =
+               (const posix_acl_xattr_entry *)(header+1);
        ext4_acl_header *ext_acl;
        size_t s;
-       void *e;
+       char *e;
 
        int count;
 
@@ -579,7 +621,7 @@ static errcode_t convert_disk_buffer_to_posix_acl(const void *value, size_t size
 {
        posix_acl_xattr_header *header;
        posix_acl_xattr_entry *entry;
-       ext4_acl_header *ext_acl = (ext4_acl_header *) value;
+       const ext4_acl_header *ext_acl = (const ext4_acl_header *) value;
        errcode_t err;
        const char *cp;
        char *out;
@@ -597,7 +639,7 @@ static errcode_t convert_disk_buffer_to_posix_acl(const void *value, size_t size
        header->a_version = ext2fs_cpu_to_le32(POSIX_ACL_XATTR_VERSION);
        entry = (posix_acl_xattr_entry *) (out + sizeof(posix_acl_xattr_header));
 
-       cp = value + sizeof(ext4_acl_header);
+       cp = (const char *) value + sizeof(ext4_acl_header);
        size -= sizeof(ext4_acl_header);
 
        while (size > 0) {
@@ -624,7 +666,6 @@ static errcode_t convert_disk_buffer_to_posix_acl(const void *value, size_t size
                default:
                        ext2fs_free_mem(&out);
                        return EINVAL;
-                       break;
                }
                entry++;
        }
@@ -640,40 +681,30 @@ write_xattrs_to_buffer(ext2_filsys fs, struct ext2_xattr *attrs, int count,
 {
        struct ext2_xattr *x;
        struct ext2_ext_attr_entry *e = entries_start;
-       void *end = entries_start + storage_size;
-       char *shortname;
-       unsigned int entry_size, value_size;
-       int idx, ret;
+       char *end = (char *) entries_start + storage_size;
+       unsigned int value_size;
        errcode_t err;
 
        memset(entries_start, 0, storage_size);
        for (x = attrs; x < attrs + count; x++) {
-               /* Calculate index and shortname position */
-               shortname = x->name;
-               ret = find_ea_index(x->name, &shortname, &idx);
-
-               /* Calculate entry and value size */
-               entry_size = (sizeof(*e) + strlen(shortname) +
-                             EXT2_EXT_ATTR_PAD - 1) &
-                            ~(EXT2_EXT_ATTR_PAD - 1);
                value_size = ((x->value_len + EXT2_EXT_ATTR_PAD - 1) /
                              EXT2_EXT_ATTR_PAD) * EXT2_EXT_ATTR_PAD;
 
                /* Fill out e appropriately */
-               e->e_name_len = strlen(shortname);
-               e->e_name_index = (ret ? idx : 0);
+               e->e_name_len = strlen(x->short_name);
+               e->e_name_index = x->name_index;
 
                e->e_value_size = x->value_len;
                e->e_value_inum = x->ea_ino;
 
                /* Store name */
-               memcpy((char *)e + sizeof(*e), shortname, e->e_name_len);
+               memcpy((char *)e + sizeof(*e), x->short_name, e->e_name_len);
                if (x->ea_ino) {
                        e->e_value_offs = 0;
                } else {
                        end -= value_size;
-                       e->e_value_offs = end - entries_start +
-                                                       value_offset_correction;
+                       e->e_value_offs = end - (char *) entries_start +
+                                               value_offset_correction;
                        memcpy(end, x->value, e->e_value_size);
                }
 
@@ -695,7 +726,7 @@ write_xattrs_to_buffer(ext2_filsys fs, struct ext2_xattr *attrs, int count,
 errcode_t ext2fs_xattrs_write(struct ext2_xattr_handle *handle)
 {
        ext2_filsys fs = handle->fs;
-       const int inode_size = EXT2_INODE_SIZE(fs->super);
+       const unsigned int inode_size = EXT2_INODE_SIZE(fs->super);
        struct ext2_inode_large *inode;
        char *start, *block_buf = NULL;
        struct ext2_ext_attr_header *header;
@@ -877,6 +908,8 @@ static errcode_t read_xattrs_from_buffer(struct ext2_xattr_handle *handle,
                        memcpy(x->name + prefix_len,
                               (char *)entry + sizeof(*entry),
                               entry->e_name_len);
+               x->short_name = x->name + prefix_len;
+               x->name_index = entry->e_name_index;
 
                /* Check & copy value */
                if (!ext2fs_has_feature_ea_inode(handle->fs->super) &&
@@ -903,6 +936,7 @@ static errcode_t read_xattrs_from_buffer(struct ext2_xattr_handle *handle,
                        memcpy(x->value, value_start + entry->e_value_offs,
                               entry->e_value_size);
                } else {
+                       struct ext2_inode *ea_inode;
                        ext2_file_t ea_file;
 
                        if (entry->e_value_offs != 0)
@@ -920,8 +954,13 @@ static errcode_t read_xattrs_from_buffer(struct ext2_xattr_handle *handle,
                        if (err)
                                return err;
 
-                       if (ext2fs_file_get_size(ea_file) !=
-                           entry->e_value_size)
+                       ea_inode = ext2fs_file_get_inode(ea_file);
+                       if ((ea_inode->i_flags & EXT4_INLINE_DATA_FL) ||
+                           !(ea_inode->i_flags & EXT4_EA_INODE_FL) ||
+                           ea_inode->i_links_count == 0)
+                               err = EXT2_ET_EA_INODE_CORRUPTED;
+                       else if ((__u64) ext2fs_file_get_size(ea_file) !=
+                                entry->e_value_size)
                                err = EXT2_ET_EA_BAD_VALUE_SIZE;
                        else
                                err = ext2fs_file_read(ea_file, x->value,
@@ -971,7 +1010,7 @@ static errcode_t read_xattrs_from_buffer(struct ext2_xattr_handle *handle,
 static void xattrs_free_keys(struct ext2_xattr_handle *h)
 {
        struct ext2_xattr *a = h->attrs;
-       size_t i;
+       int i;
 
        for (i = 0; i < h->capacity; i++) {
                if (a[i].name)
@@ -983,30 +1022,19 @@ static void xattrs_free_keys(struct ext2_xattr_handle *h)
        h->ibody_count = 0;
 }
 
-errcode_t ext2fs_xattrs_read(struct ext2_xattr_handle *handle)
+/* fetch xattrs from an already-loaded inode */
+errcode_t ext2fs_xattrs_read_inode(struct ext2_xattr_handle *handle,
+                                  struct ext2_inode_large *inode)
 {
-       struct ext2_inode_large *inode;
+
        struct ext2_ext_attr_header *header;
        __u32 ea_inode_magic;
        unsigned int storage_size;
        char *start, *block_buf = NULL;
        blk64_t blk;
-       size_t i;
        errcode_t err;
 
        EXT2_CHECK_MAGIC(handle, EXT2_ET_MAGIC_EA_HANDLE);
-       i = EXT2_INODE_SIZE(handle->fs->super);
-       if (i < sizeof(*inode))
-               i = sizeof(*inode);
-       err = ext2fs_get_memzero(i, &inode);
-       if (err)
-               return err;
-
-       err = ext2fs_read_inode_full(handle->fs, handle->ino,
-                                    (struct ext2_inode *)inode,
-                                    EXT2_INODE_SIZE(handle->fs->super));
-       if (err)
-               goto out;
 
        xattrs_free_keys(handle);
 
@@ -1042,7 +1070,7 @@ errcode_t ext2fs_xattrs_read(struct ext2_xattr_handle *handle)
 
 read_ea_block:
        /* Look for EA in a separate EA block */
-       blk = ext2fs_file_acl_block(handle->fs, (struct ext2_inode *)inode);
+       blk = ext2fs_file_acl_block(handle->fs, EXT2_INODE(inode));
        if (blk != 0) {
                if ((blk < handle->fs->super->s_first_data_block) ||
                    (blk >= ext2fs_blocks_count(handle->fs->super))) {
@@ -1073,26 +1101,46 @@ read_ea_block:
                err = read_xattrs_from_buffer(handle, inode,
                                        (struct ext2_ext_attr_entry *) start,
                                        storage_size, block_buf);
-               if (err)
-                       goto out3;
+       }
 
+out3:
+       if (block_buf)
                ext2fs_free_mem(&block_buf);
-       }
+out:
+       return err;
+}
 
-       ext2fs_free_mem(&block_buf);
-       ext2fs_free_mem(&inode);
-       return 0;
+errcode_t ext2fs_xattrs_read(struct ext2_xattr_handle *handle)
+{
+       struct ext2_inode_large *inode;
+       size_t inode_size = EXT2_INODE_SIZE(handle->fs->super);
+       errcode_t err;
+
+       EXT2_CHECK_MAGIC(handle, EXT2_ET_MAGIC_EA_HANDLE);
+
+       if (inode_size < sizeof(*inode))
+               inode_size = sizeof(*inode);
+       err = ext2fs_get_memzero(inode_size, &inode);
+       if (err)
+               return err;
+
+       err = ext2fs_read_inode_full(handle->fs, handle->ino, EXT2_INODE(inode),
+                                    EXT2_INODE_SIZE(handle->fs->super));
+       if (err)
+               goto out;
+
+       err = ext2fs_xattrs_read_inode(handle, inode);
 
-out3:
-       ext2fs_free_mem(&block_buf);
 out:
        ext2fs_free_mem(&inode);
+
        return err;
 }
 
 errcode_t ext2fs_xattrs_iterate(struct ext2_xattr_handle *h,
                                int (*func)(char *name, char *value,
-                                           size_t value_len, void *data),
+                                           size_t value_len,
+                                           ext2_ino_t inode_num, void *data),
                                void *data)
 {
        struct ext2_xattr *x;
@@ -1101,7 +1149,7 @@ errcode_t ext2fs_xattrs_iterate(struct ext2_xattr_handle *h,
 
        EXT2_CHECK_MAGIC(h, EXT2_ET_MAGIC_EA_HANDLE);
        for (x = h->attrs; x < h->attrs + h->count; x++) {
-               ret = func(x->name, x->value, x->value_len, data);
+               ret = func(x->name, x->value, x->value_len, x->ea_ino, data);
                if (ret & XATTR_CHANGED)
                        dirty = 1;
                if (ret & XATTR_ABORT)
@@ -1298,7 +1346,8 @@ out:
 }
 
 static errcode_t xattr_update_entry(ext2_filsys fs, struct ext2_xattr *x,
-                                   const char *name, const void *value,
+                                   const char *name, const char *short_name,
+                                   int index, const void *value,
                                    size_t value_len, int in_inode)
 {
        ext2_ino_t ea_ino = 0;
@@ -1332,8 +1381,11 @@ static errcode_t xattr_update_entry(ext2_filsys fs, struct ext2_xattr *x,
                        goto fail;
        }
 
-       if (!x->name)
+       if (!x->name) {
                x->name = new_name;
+               x->short_name = new_name + (short_name  - name);
+       }
+       x->name_index = index;
 
        if (x->value)
                ext2fs_free_mem(&x->value);
@@ -1352,45 +1404,43 @@ fail:
 }
 
 static int xattr_find_position(struct ext2_xattr *attrs, int count,
-                              const char *name)
+                              const char *shortname, int name_idx)
 {
        struct ext2_xattr *x;
        int i;
-       char *shortname, *x_shortname;
-       int name_idx, x_name_idx;
        int shortname_len, x_shortname_len;
 
-       find_ea_index(name, &shortname, &name_idx);
        shortname_len = strlen(shortname);
 
        for (i = 0, x = attrs; i < count; i++, x++) {
-               find_ea_index(x->name, &x_shortname, &x_name_idx);
-               if (name_idx < x_name_idx)
+               if (name_idx < x->name_index)
                        break;
-               if (name_idx > x_name_idx)
+               if (name_idx > x->name_index)
                        continue;
 
-               x_shortname_len = strlen(x_shortname);
+               x_shortname_len = strlen(x->short_name);
                if (shortname_len < x_shortname_len)
                        break;
                if (shortname_len > x_shortname_len)
                        continue;
 
-               if (memcmp(shortname, x_shortname, shortname_len) <= 0)
+               if (memcmp(shortname, x->short_name, shortname_len) <= 0)
                        break;
        }
        return i;
 }
 
-errcode_t xattr_array_update(struct ext2_xattr_handle *h, const char *name,
-                       const void *value, size_t value_len, int ibody_free,
-                       int block_free, int old_idx, int in_inode)
+static errcode_t xattr_array_update(struct ext2_xattr_handle *h,
+                                   const char *name,
+                                   const void *value, size_t value_len,
+                                   int ibody_free, int block_free,
+                                   int old_idx, int in_inode)
 {
        struct ext2_xattr tmp;
        int add_to_ibody;
        int needed;
-       int name_len, name_idx;
-       char *shortname;
+       int name_len, name_idx = 0;
+       const char *shortname = name;
        int new_idx;
        int ret;
 
@@ -1417,7 +1467,8 @@ errcode_t xattr_array_update(struct ext2_xattr_handle *h, const char *name,
 
                /* Update the existing entry. */
                ret = xattr_update_entry(h->fs, &h->attrs[old_idx], name,
-                                        value, value_len, in_inode);
+                                        shortname, name_idx, value,
+                                        value_len, in_inode);
                if (ret)
                        return ret;
                if (h->ibody_count <= old_idx) {
@@ -1445,7 +1496,8 @@ errcode_t xattr_array_update(struct ext2_xattr_handle *h, const char *name,
        if (old_idx >= 0) {
                /* Update the existing entry. */
                ret = xattr_update_entry(h->fs, &h->attrs[old_idx], name,
-                                        value, value_len, in_inode);
+                                        shortname, name_idx, value,
+                                        value_len, in_inode);
                if (ret)
                        return ret;
                if (old_idx < h->ibody_count) {
@@ -1454,7 +1506,8 @@ errcode_t xattr_array_update(struct ext2_xattr_handle *h, const char *name,
                         * entries in the block are sorted.
                         */
                        new_idx = xattr_find_position(h->attrs + h->ibody_count,
-                               h->count - h->ibody_count, name);
+                                                     h->count - h->ibody_count,
+                                                     shortname, name_idx);
                        new_idx += h->ibody_count - 1;
                        tmp = h->attrs[old_idx];
                        memmove(h->attrs + old_idx, h->attrs + old_idx + 1,
@@ -1466,7 +1519,8 @@ errcode_t xattr_array_update(struct ext2_xattr_handle *h, const char *name,
        }
 
        new_idx = xattr_find_position(h->attrs + h->ibody_count,
-                                     h->count - h->ibody_count, name);
+                                     h->count - h->ibody_count,
+                                     shortname, name_idx);
        new_idx += h->ibody_count;
        add_to_ibody = 0;
 
@@ -1477,8 +1531,8 @@ add_new:
                        return ret;
        }
 
-       ret = xattr_update_entry(h->fs, &h->attrs[h->count], name, value,
-                                value_len, in_inode);
+       ret = xattr_update_entry(h->fs, &h->attrs[h->count], name, shortname,
+                                name_idx, value, value_len, in_inode);
        if (ret)
                return ret;
 
@@ -1492,16 +1546,14 @@ add_new:
        return 0;
 }
 
-int space_used(struct ext2_xattr *attrs, int count)
+static int space_used(struct ext2_xattr *attrs, int count)
 {
        int total = 0;
        struct ext2_xattr *x;
-       char *shortname;
-       int i, len, name_idx;
+       int i, len;
 
        for (i = 0, x = attrs; i < count; i++, x++) {
-               find_ea_index(x->name, &shortname, &name_idx);
-               len = strlen(shortname);
+               len = strlen(x->short_name);
                total += EXT2_EXT_ATTR_LEN(len);
                if (!x->ea_ino)
                        total += EXT2_EXT_ATTR_SIZE(x->value_len);
@@ -1544,14 +1596,15 @@ errcode_t ext2fs_xattr_set(struct ext2_xattr_handle *h,
                                                       new_value, &value_len);
                if (ret)
                        goto out;
-       } else
+       } else if (value_len)
                memcpy(new_value, value, value_len);
 
        /* Imitate kernel behavior by skipping update if value is the same. */
        for (x = h->attrs; x < h->attrs + h->count; x++) {
                if (!strcmp(x->name, name)) {
                        if (!x->ea_ino && x->value_len == value_len &&
-                           !memcmp(x->value, new_value, value_len)) {
+                           (!value_len ||
+                            !memcmp(x->value, new_value, value_len))) {
                                ret = 0;
                                goto out;
                        }
@@ -1589,7 +1642,8 @@ errcode_t ext2fs_xattr_set(struct ext2_xattr_handle *h,
                        ret = EXT2_ET_FILESYSTEM_CORRUPTED;
                        goto out;
                }
-               ret = xattr_array_update(h, name, value, value_len, ibody_free,
+               ret = xattr_array_update(h, name, new_value, value_len,
+                                        ibody_free,
                                         0 /* block_free */, old_idx,
                                         0 /* in_inode */);
                if (ret)
@@ -1608,12 +1662,12 @@ errcode_t ext2fs_xattr_set(struct ext2_xattr_handle *h,
            value_len > EXT4_XATTR_MIN_LARGE_EA_SIZE(fs->blocksize))
                in_inode = 1;
 
-       ret = xattr_array_update(h, name, value, value_len, ibody_free,
+       ret = xattr_array_update(h, name, new_value, value_len, ibody_free,
                                 block_free, old_idx, in_inode);
        if (ret == EXT2_ET_EA_NO_SPACE && !in_inode &&
            ext2fs_has_feature_ea_inode(fs->super))
-               ret = xattr_array_update(h, name, value, value_len, ibody_free,
-                                block_free, old_idx, 1 /* in_inode */);
+               ret = xattr_array_update(h, name, new_value, value_len,
+                       ibody_free, block_free, old_idx, 1 /* in_inode */);
        if (ret)
                goto out;
 
@@ -1709,3 +1763,905 @@ errcode_t ext2fs_xattrs_flags(struct ext2_xattr_handle *handle,
                handle->flags = *new_flags;
        return 0;
 }
+
+struct ext2_attr_info {
+       int name_index;
+       const char *name;
+       const char *value;
+       int value_len;
+};
+
+struct ext2_attr_search {
+       struct ext2_ext_attr_entry *first;
+       char *base;
+       char *end;
+       struct ext2_ext_attr_entry *here;
+       int not_found;
+};
+
+struct ext2_attr_ibody_find {
+       ext2_ino_t ino;
+       struct ext2_attr_search s;
+};
+
+struct ext2_attr_block_find {
+       struct ext2_attr_search s;
+       char *block;
+};
+
+void ext2fs_attr_shift_entries(struct ext2_ext_attr_entry *entry,
+                              int value_offs_shift, char *to,
+                              char *from, int n)
+{
+       struct ext2_ext_attr_entry *last = entry;
+
+       /* Adjust the value offsets of the entries */
+       for (; !EXT2_EXT_IS_LAST_ENTRY(last); last = EXT2_EXT_ATTR_NEXT(last)) {
+               if (!last->e_value_inum && last->e_value_size) {
+                       last->e_value_offs = last->e_value_offs +
+                                                       value_offs_shift;
+               }
+       }
+       /* Shift the entries by n bytes and zero freed space in inode */
+       memmove(to, from, n);
+       if (to > from)
+               memset(from, 0, to - from);
+}
+
+/*
+ * This function returns the free space present in the inode or the EA block.
+ * total is number of bytes taken up by the EA entries and is used to shift
+ * the EAs in ext2fs_expand_extra_isize().
+ */
+int ext2fs_attr_free_space(struct ext2_ext_attr_entry *last,
+                          int *min_offs, char *base, int *total)
+{
+       for (; !EXT2_EXT_IS_LAST_ENTRY(last); last = EXT2_EXT_ATTR_NEXT(last)) {
+               *total += EXT2_EXT_ATTR_LEN(last->e_name_len);
+               if (!last->e_value_inum && last->e_value_size) {
+                       int offs = last->e_value_offs;
+                       if (offs < *min_offs)
+                               *min_offs = offs;
+               }
+       }
+
+       return *min_offs - ((char *)last - base) - sizeof(__u32);
+}
+
+static errcode_t ext2fs_attr_check_names(struct ext2_ext_attr_entry *entry,
+                                        char *end)
+{
+       while (!EXT2_EXT_IS_LAST_ENTRY(entry)) {
+               struct ext2_ext_attr_entry *next = EXT2_EXT_ATTR_NEXT(entry);
+               if ((char *)next >= end)
+                       return EXT2_ET_EA_BAD_ENTRIES;
+               entry = next;
+       }
+       return 0;
+}
+
+/* The unused parameter used to be the blocksize, but with in-inode xattrs
+ * the xattr storage area size depends on where the xattrs are kept.  Keep
+ * this parameter for API/ABI compatibility, but it is not needed. */
+static errcode_t ext2fs_attr_find_entry(struct ext2_ext_attr_entry **pentry,
+                                       int name_index, const char *name,
+                                       int unused, int sorted)
+{
+       struct ext2_ext_attr_entry *entry;
+       int name_len;
+       int cmp = 1;
+
+       if (name == NULL)
+               return EXT2_ET_EA_BAD_NAME;
+
+       name_len = strlen(name);
+       entry = *pentry;
+       for (; !EXT2_EXT_IS_LAST_ENTRY(entry);
+               entry = EXT2_EXT_ATTR_NEXT(entry)) {
+               cmp = name_index - entry->e_name_index;
+               if (!cmp)
+                       cmp = name_len - entry->e_name_len;
+               if (!cmp)
+                       cmp = memcmp(name, entry->e_name, name_len);
+               if (cmp <= 0 && (sorted || cmp == 0))
+                       break;
+       }
+       *pentry = entry;
+
+       return cmp ? EXT2_ET_EA_NAME_NOT_FOUND : 0;
+}
+
+static errcode_t ext2fs_attr_block_find(ext2_filsys fs,struct ext2_inode *inode,
+                                       struct ext2_attr_info *i,
+                                       struct ext2_attr_block_find *bs)
+{
+       struct ext2_ext_attr_header *header;
+       errcode_t error;
+
+       if (inode->i_file_acl) {
+               /* The inode already has an extended attribute block. */
+               error = ext2fs_get_mem(fs->blocksize, &bs->block);
+               if (error)
+                       return error;
+               error = ext2fs_read_ext_attr(fs, inode->i_file_acl, bs->block);
+               if (error)
+                       goto cleanup;
+
+               header = BHDR(bs->block);
+               if (header->h_magic != EXT2_EXT_ATTR_MAGIC) {
+                       error = EXT2_ET_EA_BAD_MAGIC;
+                       goto cleanup;
+               }
+
+               /* Find the named attribute. */
+               bs->s.base = bs->block;
+               bs->s.first = (struct ext2_ext_attr_entry *)(header + 1);
+               bs->s.end = bs->block + fs->blocksize;
+               bs->s.here = bs->s.first;
+               error = ext2fs_attr_find_entry(&bs->s.here, i->name_index,
+                                              i->name, fs->blocksize, 1);
+               if (error && error != EXT2_ET_EA_NAME_NOT_FOUND)
+                       goto cleanup;
+               bs->s.not_found = error;
+       }
+       error = 0;
+
+cleanup:
+       if (error && bs->block)
+               ext2fs_free_mem(&bs->block);
+       return error;
+}
+
+static errcode_t ext2fs_attr_ibody_find(ext2_filsys fs,
+                                       struct ext2_inode_large *inode,
+                                       struct ext2_attr_info *i,
+                                       struct ext2_attr_ibody_find *is)
+{
+       errcode_t error;
+
+       if (EXT2_INODE_SIZE(fs->super) == EXT2_GOOD_OLD_INODE_SIZE)
+               return 0;
+
+       if (inode->i_extra_isize == 0)
+               return 0;
+
+       is->s.first = &IHDR(inode)->h_first_entry[0];
+       is->s.base = (char *)is->s.first;
+       is->s.here = is->s.first;
+       is->s.end = (char *)inode + EXT2_INODE_SIZE(fs->super);
+       if (IHDR(inode)->h_magic == EXT2_EXT_ATTR_MAGIC) {
+               error = ext2fs_attr_check_names(is->s.first, is->s.end);
+               if (error)
+                       return error;
+               /* Find the named attribute. */
+               error = ext2fs_attr_find_entry(&is->s.here, i->name_index,
+                                              i->name, is->s.end -
+                                              (char *)is->s.base, 0);
+               if (error && error != EXT2_ET_EA_NAME_NOT_FOUND)
+                       return error;
+               is->s.not_found = error;
+       }
+
+       return 0;
+}
+
+static errcode_t ext2fs_attr_set_entry(ext2_filsys fs, struct ext2_attr_info *i,
+                                      struct ext2_attr_search *s)
+{
+       struct ext2_ext_attr_entry *last;
+       int free, min_offs = s->end - s->base, name_len = strlen(i->name);
+
+       /* Compute min_offs and last. */
+       for (last = s->first; !EXT2_EXT_IS_LAST_ENTRY(last);
+            last = EXT2_EXT_ATTR_NEXT(last)) {
+               if (!last->e_value_inum && last->e_value_size) {
+                       int offs = last->e_value_offs;
+
+                       if (offs < min_offs)
+                               min_offs = offs;
+               }
+       }
+       free = min_offs - ((char *)last - s->base) - sizeof(__u32);
+
+       if (!s->not_found) {
+               if (!s->here->e_value_inum && s->here->e_value_size) {
+                       int size = s->here->e_value_size;
+                       free += EXT2_EXT_ATTR_SIZE(size);
+               }
+               free += EXT2_EXT_ATTR_LEN(name_len);
+       }
+       if (i->value) {
+               if (free < EXT2_EXT_ATTR_LEN(name_len) +
+                          EXT2_EXT_ATTR_SIZE(i->value_len))
+                       return EXT2_ET_EA_NO_SPACE;
+       }
+
+       if (i->value && s->not_found) {
+               /* Insert the new name. */
+               int size = EXT2_EXT_ATTR_LEN(name_len);
+               int rest = (char *)last - (char *)s->here + sizeof(__u32);
+
+               memmove((char *)s->here + size, s->here, rest);
+               memset(s->here, 0, size);
+               s->here->e_name_index = i->name_index;
+               s->here->e_name_len = name_len;
+               memcpy(s->here->e_name, i->name, name_len);
+       } else {
+               if (!s->here->e_value_inum && s->here->e_value_size) {
+                       char *first_val = s->base + min_offs;
+                       int offs = s->here->e_value_offs;
+                       char *val = s->base + offs;
+                       int size = EXT2_EXT_ATTR_SIZE(s->here->e_value_size);
+
+                       if (i->value &&
+                           size == EXT2_EXT_ATTR_SIZE(i->value_len)) {
+                               /* The old and the new value have the same
+                                  size. Just replace. */
+                               s->here->e_value_size = i->value_len;
+                               memset(val + size - EXT2_EXT_ATTR_PAD, 0,
+                                      EXT2_EXT_ATTR_PAD); /* Clear pad bytes */
+                               memcpy(val, i->value, i->value_len);
+                               return 0;
+                       }
+
+                       /* Remove the old value. */
+                       memmove(first_val + size, first_val, val - first_val);
+                       memset(first_val, 0, size);
+                       s->here->e_value_size = 0;
+                       s->here->e_value_offs = 0;
+                       min_offs += size;
+
+                       /* Adjust all value offsets. */
+                       last = s->first;
+                       while (!EXT2_EXT_IS_LAST_ENTRY(last)) {
+                               int o = last->e_value_offs;
+
+                               if (!last->e_value_inum &&
+                                   last->e_value_size && o < offs)
+                                       last->e_value_offs = o + size;
+                               last = EXT2_EXT_ATTR_NEXT(last);
+                       }
+               }
+               if (!i->value) {
+                       /* Remove the old name. */
+                       int size = EXT2_EXT_ATTR_LEN(name_len);
+
+                       last = ENTRY((char *)last - size);
+                       memmove((char *)s->here, (char *)s->here + size,
+                               (char *)last - (char *)s->here + sizeof(__u32));
+                       memset(last, 0, size);
+               }
+       }
+
+       if (i->value) {
+               /* Insert the new value. */
+               s->here->e_value_size = i->value_len;
+               if (i->value_len) {
+                       int size = EXT2_EXT_ATTR_SIZE(i->value_len);
+                       char *val = s->base + min_offs - size;
+
+                       s->here->e_value_offs = min_offs - size;
+                       memset(val + size - EXT2_EXT_ATTR_PAD, 0,
+                              EXT2_EXT_ATTR_PAD); /* Clear the pad bytes. */
+                       memcpy(val, i->value, i->value_len);
+               }
+       }
+
+       return 0;
+}
+
+static errcode_t ext2fs_attr_block_set(ext2_filsys fs, struct ext2_inode *inode,
+                                      struct ext2_attr_info *i,
+                                      struct ext2_attr_block_find *bs)
+{
+       struct ext2_attr_search *s = &bs->s;
+       char *new_buf = NULL, *old_block = NULL;
+       blk_t blk;
+       int clear_flag = 0;
+       errcode_t error;
+
+       if (i->value && i->value_len > fs->blocksize)
+               return EXT2_ET_EA_NO_SPACE;
+
+       if (s->base) {
+               if (BHDR(s->base)->h_refcount != 1) {
+                       int offset = (char *)s->here - bs->block;
+
+                       /* Decrement the refcount of the shared block */
+                       old_block = s->base;
+                       BHDR(s->base)->h_refcount -= 1;
+
+                       error = ext2fs_get_mem(fs->blocksize, &s->base);
+                       if (error)
+                               goto cleanup;
+                       clear_flag = 1;
+                       memcpy(s->base, bs->block, fs->blocksize);
+                       s->first = ENTRY(BHDR(s->base)+1);
+                       BHDR(s->base)->h_refcount = 1;
+                       s->here = ENTRY(s->base + offset);
+                       s->end = s->base + fs->blocksize;
+               }
+       } else {
+               error = ext2fs_get_mem(fs->blocksize, &s->base);
+               if (error)
+                       goto cleanup;
+               clear_flag = 1;
+               memset(s->base, 0, fs->blocksize);
+               BHDR(s->base)->h_magic = EXT2_EXT_ATTR_MAGIC;
+               BHDR(s->base)->h_blocks = 1;
+               BHDR(s->base)->h_refcount = 1;
+               s->first = ENTRY(BHDR(s->base)+1);
+               s->here = ENTRY(BHDR(s->base)+1);
+               s->end = s->base + fs->blocksize;
+       }
+
+       error = ext2fs_attr_set_entry(fs, i, s);
+       if (error)
+               goto cleanup;
+
+       if (!EXT2_EXT_IS_LAST_ENTRY(s->first))
+               ext2fs_attr_rehash(BHDR(s->base), s->here);
+
+       if (!EXT2_EXT_IS_LAST_ENTRY(s->first)) {
+               if (bs->block && bs->block == s->base) {
+                       /* We are modifying this block in-place */
+                       new_buf = bs->block;
+                       blk = inode->i_file_acl;
+                       error = ext2fs_write_ext_attr(fs, blk, s->base);
+                       if (error)
+                               goto cleanup;
+               } else {
+                       /* We need to allocate a new block */
+                       error = ext2fs_new_block(fs, 0, 0, &blk);
+                       if (error)
+                               goto cleanup;
+                       ext2fs_block_alloc_stats(fs, blk, 1);
+                       error = ext2fs_write_ext_attr(fs, blk, s->base);
+                       if (error)
+                               goto cleanup;
+                       new_buf = s->base;
+                       if (old_block) {
+                               BHDR(s->base)->h_refcount -= 1;
+                               error = ext2fs_write_ext_attr(fs,
+                                                             inode->i_file_acl,
+                                                             s->base);
+                               if (error)
+                                       goto cleanup;
+                       }
+               }
+       }
+
+       /* Update the i_blocks if we added a new EA block */
+       if (!inode->i_file_acl && new_buf)
+               inode->i_blocks += fs->blocksize / 512;
+       /* Update the inode. */
+       inode->i_file_acl = new_buf ? blk : 0;
+
+cleanup:
+       if (clear_flag)
+               ext2fs_free_mem(&s->base);
+       return 0;
+}
+
+static errcode_t ext2fs_attr_ibody_set(ext2_filsys fs,
+                                      struct ext2_inode_large *inode,
+                                      struct ext2_attr_info *i,
+                                      struct ext2_attr_ibody_find *is)
+{
+       struct ext2_attr_search *s = &is->s;
+       errcode_t error;
+
+       if (EXT2_INODE_SIZE(fs->super) == EXT2_GOOD_OLD_INODE_SIZE)
+               return EXT2_ET_EA_NO_SPACE;
+
+       error = ext2fs_attr_set_entry(fs, i, s);
+       if (error)
+               return error;
+
+       if (!EXT2_EXT_IS_LAST_ENTRY(s->first))
+               IHDR(inode)->h_magic = EXT2_EXT_ATTR_MAGIC;
+       else
+               IHDR(inode)->h_magic = 0;
+
+       return ext2fs_write_inode_full(fs, is->ino, (struct ext2_inode *)inode,
+                                      EXT2_INODE_SIZE(fs->super));
+}
+
+static struct {
+       char str[28];
+       int len;
+} ext2_attr_index_prefix[] = {
+       [EXT2_ATTR_INDEX_USER] = { EXT2_ATTR_INDEX_USER_PREFIX,
+                                  sizeof(EXT2_ATTR_INDEX_USER_PREFIX) },
+       [EXT2_ATTR_INDEX_POSIX_ACL_ACCESS] = {
+               EXT2_ATTR_INDEX_POSIX_ACL_ACCESS_PREFIX,
+               sizeof(EXT2_ATTR_INDEX_POSIX_ACL_ACCESS_PREFIX) },
+       [EXT2_ATTR_INDEX_POSIX_ACL_DEFAULT] = {
+               EXT2_ATTR_INDEX_POSIX_ACL_DEFAULT_PREFIX,
+               sizeof(EXT2_ATTR_INDEX_POSIX_ACL_DEFAULT_PREFIX) },
+       [EXT2_ATTR_INDEX_TRUSTED] = { EXT2_ATTR_INDEX_TRUSTED_PREFIX,
+                                     sizeof(EXT2_ATTR_INDEX_TRUSTED_PREFIX) },
+       [EXT2_ATTR_INDEX_LUSTRE] = { EXT2_ATTR_INDEX_LUSTRE_PREFIX,
+                                    sizeof(EXT2_ATTR_INDEX_LUSTRE_PREFIX) },
+       [EXT2_ATTR_INDEX_SECURITY] = { EXT2_ATTR_INDEX_SECURITY_PREFIX,
+                                      sizeof(EXT2_ATTR_INDEX_SECURITY_PREFIX)},
+       { "", 0 }
+};
+
+errcode_t ext2fs_attr_set(ext2_filsys fs, ext2_ino_t ino,
+                         struct ext2_inode *inode,
+                         int name_index, const char *name, const char *value,
+                         int value_len, int flags)
+{
+       struct ext2_inode_large *inode_large = NULL;
+       struct ext2_attr_info i = {
+               .name_index = name_index,
+               .name = name,
+               .value = value,
+               .value_len = value_len,
+       };
+       struct ext2_attr_ibody_find is = {
+               .ino = ino,
+               .s = { .not_found = -ENODATA, },
+       };
+       struct ext2_attr_block_find bs = {
+               .s = { .not_found = -ENODATA, },
+       };
+       errcode_t error;
+
+       if (!name)
+               return EXT2_ET_EA_BAD_NAME;
+       if (strlen(name) > 255)
+               return EXT2_ET_EA_NAME_TOO_BIG;
+
+       /* If the prefix is still present, skip it */
+       if (strncmp(name, ext2_attr_index_prefix[name_index].str,
+                   ext2_attr_index_prefix[name_index].len) == 0)
+               i.name += ext2_attr_index_prefix[name_index].len;
+
+       if (EXT2_INODE_SIZE(fs->super) > EXT2_GOOD_OLD_INODE_SIZE) {
+               inode_large = (struct ext2_inode_large *)inode;
+
+               error = ext2fs_attr_ibody_find(fs, inode_large, &i, &is);
+               if (error)
+                       goto cleanup;
+       }
+       if (is.s.not_found) {
+               error = ext2fs_attr_block_find(fs, inode, &i, &bs);
+               if (error)
+                       goto cleanup;
+       }
+
+       if (is.s.not_found && bs.s.not_found) {
+               error = EXT2_ET_EA_NAME_NOT_FOUND;
+               if (flags & XATTR_REPLACE)
+                       goto cleanup;
+               error = 0;
+               if (!value)
+                       goto cleanup;
+       } else {
+               error = EXT2_ET_EA_NAME_EXISTS;
+               if (flags & XATTR_CREATE)
+                       goto cleanup;
+       }
+
+       if (!value) {
+               if (!is.s.not_found &&
+                   (EXT2_INODE_SIZE(fs->super) > EXT2_GOOD_OLD_INODE_SIZE))
+                       error = ext2fs_attr_ibody_set(fs, inode_large, &i, &is);
+               else if (!bs.s.not_found)
+                       error = ext2fs_attr_block_set(fs, inode, &i, &bs);
+       } else {
+               if (EXT2_INODE_SIZE(fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
+                       error = ext2fs_attr_ibody_set(fs, inode_large, &i, &is);
+               if (!error && !bs.s.not_found) {
+                       i.value = NULL;
+                       error = ext2fs_attr_block_set(fs, inode, &i, &bs);
+               } else if (error == EXT2_ET_EA_NO_SPACE) {
+                       error = ext2fs_attr_block_set(fs, inode, &i, &bs);
+                       if (error)
+                               goto cleanup;
+                       if (!is.s.not_found) {
+                               i.value = NULL;
+                               if (EXT2_INODE_SIZE(fs->super) >
+                                   EXT2_GOOD_OLD_INODE_SIZE)
+                                       error = ext2fs_attr_ibody_set(fs,
+                                                       inode_large, &i, &is);
+                       }
+               }
+       }
+
+cleanup:
+       return error;
+}
+
+static errcode_t ext2fs_attr_check_block(ext2_filsys fs, char *buffer)
+{
+       if (BHDR(buffer)->h_magic != (EXT2_EXT_ATTR_MAGIC) ||
+           BHDR(buffer)->h_blocks != 1)
+               return EXT2_ET_EA_BAD_MAGIC;
+
+       return ext2fs_attr_check_names((struct ext2_ext_attr_entry *)
+                                      (BHDR(buffer) + 1),
+                                      buffer + fs->blocksize);
+}
+
+static errcode_t ext2fs_attr_block_get(ext2_filsys fs, struct ext2_inode *inode,
+                                      int name_index, const char *name,
+                                      void *buffer, size_t buffer_size,
+                                      int *easize)
+{
+       struct ext2_ext_attr_header *header = NULL;
+       struct ext2_ext_attr_entry *entry;
+       char *block_buf = NULL;
+       errcode_t error;
+
+       error = EXT2_ET_EA_NAME_NOT_FOUND;
+       if (!inode->i_file_acl)
+               goto cleanup;
+
+       error = ext2fs_get_mem(fs->blocksize, &block_buf);
+       if (error)
+               return error;
+       error = ext2fs_read_ext_attr(fs, inode->i_file_acl, block_buf);
+       if (error)
+               goto cleanup;
+
+       error = ext2fs_attr_check_block(fs, block_buf);
+       if (error)
+               goto cleanup;
+
+       header = BHDR(block_buf);
+       entry = (struct ext2_ext_attr_entry *)(header + 1);
+       error = ext2fs_attr_find_entry(&entry, name_index, name,
+                                      fs->blocksize, 1);
+       if (error)
+               goto cleanup;
+       if (easize)
+               *easize = entry->e_value_size;
+       if (buffer) {
+               if (entry->e_value_size > buffer_size) {
+                       error = EXT2_ET_EA_TOO_BIG;
+                       goto cleanup;
+               }
+               memcpy(buffer, block_buf + entry->e_value_offs,
+                      entry->e_value_size);
+               error = 0;
+       }
+
+cleanup:
+       if (block_buf)
+               ext2fs_free_mem(&block_buf);
+       return error;
+}
+
+static errcode_t ext2fs_attr_check_ibody(ext2_filsys fs,
+                                        struct ext2_inode_large *inode)
+{
+       const int inode_size = EXT2_INODE_SIZE(fs->super);
+
+       if (inode_size == EXT2_GOOD_OLD_INODE_SIZE)
+               return EXT2_ET_EA_NAME_NOT_FOUND;
+
+       if (IHDR(inode)->h_magic != EXT2_EXT_ATTR_MAGIC)
+               return EXT2_ET_EA_BAD_MAGIC;
+
+       return ext2fs_attr_check_names(&IHDR(inode)->h_first_entry[0],
+                                      (char *)inode + inode_size);
+}
+
+
+static errcode_t ext2fs_attr_ibody_get(ext2_filsys fs,
+                                      struct ext2_inode_large *inode,
+                                      int name_index, const char *name,
+                                      void *buffer, size_t buffer_size,
+                                      int *easize)
+{
+       struct ext2_ext_attr_entry *entry;
+       int error;
+
+       error = ext2fs_attr_check_ibody(fs, inode);
+       if (error)
+               return error;
+
+       entry = &IHDR(inode)->h_first_entry[0];
+
+       error = ext2fs_attr_find_entry(&entry, name_index, name,
+                               (char *)inode + EXT2_INODE_SIZE(fs->super) -
+                               (char *)entry, 0);
+       if (error)
+               goto cleanup;
+       if (easize)
+               *easize = entry->e_value_size;
+       if (buffer) {
+               if (entry->e_value_size > buffer_size) {
+                       error = EXT2_ET_EA_TOO_BIG;
+                       goto cleanup;
+               }
+               memcpy(buffer, (char *)&IHDR(inode)->h_first_entry[0] +
+                              entry->e_value_offs, entry->e_value_size);
+       }
+
+cleanup:
+       return error;
+}
+
+
+errcode_t ext2fs_attr_get(ext2_filsys fs, struct ext2_inode *inode,
+                         int name_index, const char *name, char *buffer,
+                         size_t buffer_size, int *easize)
+{
+       errcode_t error;
+
+       error = ext2fs_attr_ibody_get(fs, (struct ext2_inode_large *)inode,
+                                     name_index, name, buffer, buffer_size,
+                                     easize);
+       if (error == EXT2_ET_EA_NAME_NOT_FOUND || error == EXT2_ET_EA_BAD_MAGIC)
+               error = ext2fs_attr_block_get(fs, inode, name_index, name,
+                                             buffer, buffer_size, easize);
+
+       return error;
+}
+
+int ext2fs_attr_get_next_attr(struct ext2_ext_attr_entry *entry, int name_index,
+                             char *buffer, int buffer_size, int start)
+{
+       const int prefix_len = ext2_attr_index_prefix[name_index].len;
+       int total_len;
+
+       if (!start && !EXT2_EXT_IS_LAST_ENTRY(entry))
+               entry = EXT2_EXT_ATTR_NEXT(entry);
+
+       for (; !EXT2_EXT_IS_LAST_ENTRY(entry);
+            entry = EXT2_EXT_ATTR_NEXT(entry)) {
+               if (!name_index)
+                       break;
+               if (name_index == entry->e_name_index)
+                       break;
+       }
+       if (EXT2_EXT_IS_LAST_ENTRY(entry))
+               return 0;
+
+       total_len = prefix_len + entry->e_name_len + 1;
+       if (buffer && total_len <= buffer_size) {
+               memcpy(buffer, ext2_attr_index_prefix[name_index].str,
+                      prefix_len);
+               memcpy(buffer + prefix_len, entry->e_name, entry->e_name_len);
+               buffer[prefix_len + entry->e_name_len] = '\0';
+       }
+
+       return total_len;
+}
+
+errcode_t ext2fs_expand_extra_isize(ext2_filsys fs, ext2_ino_t ino,
+                                   struct ext2_inode_large *inode,
+                                   int new_extra_isize, int *ret,
+                                   int *needed_size)
+{
+       struct ext2_inode *inode_buf = NULL;
+       struct ext2_ext_attr_header *header = NULL;
+       struct ext2_ext_attr_entry *entry = NULL, *last = NULL;
+       struct ext2_attr_ibody_find is = {
+               .ino = ino,
+               .s = { .not_found = EXT2_ET_EA_NO_SPACE, },
+       };
+       struct ext2_attr_block_find bs = {
+               .s = { .not_found = EXT2_ET_EA_NO_SPACE, },
+       };
+       char *start, *end, *block_buf = NULL, *buffer =NULL, *b_entry_name=NULL;
+       int total_ino = 0, total_blk, free, offs, tried_min_extra_isize = 0;
+       int s_min_extra_isize = fs->super->s_min_extra_isize;
+       errcode_t error = 0;
+
+       if (needed_size)
+               *needed_size = new_extra_isize;
+       error = ext2fs_get_mem(fs->blocksize, &block_buf);
+       if (error)
+               return error;
+
+       if (inode == NULL) {
+               error = ext2fs_get_mem(EXT2_INODE_SIZE(fs->super), &inode_buf);
+               if (error)
+                       goto cleanup;
+
+               error = ext2fs_read_inode_full(fs, ino, inode_buf,
+                                              EXT2_INODE_SIZE(fs->super));
+               if (error)
+                       goto cleanup;
+
+               inode = (struct ext2_inode_large *)inode_buf;
+       }
+
+retry:
+       if (inode->i_extra_isize >= new_extra_isize)
+               goto cleanup;
+
+       start = (char *)inode + EXT2_GOOD_OLD_INODE_SIZE + inode->i_extra_isize;
+       /* No extended attributes present */
+       if (IHDR(inode)->h_magic != EXT2_EXT_ATTR_MAGIC) {
+               memset(start, 0,
+                      EXT2_INODE_SIZE(fs->super) - EXT2_GOOD_OLD_INODE_SIZE -
+                      inode->i_extra_isize);
+               inode->i_extra_isize = new_extra_isize;
+               if (needed_size)
+                       *needed_size = 0;
+               goto write_inode;
+       }
+
+       start += sizeof(__u32);
+       end = (char *)inode + EXT2_INODE_SIZE(fs->super);
+       last = entry = (struct ext2_ext_attr_entry *)start;
+       offs = end - start;
+       /* Consider space takenup by magic number */
+       total_ino = sizeof(__u32);
+       free = ext2fs_attr_free_space(last, &offs, start, &total_ino);
+
+       /* Enough free space available in the inode for expansion */
+       if (free >= new_extra_isize) {
+               ext2fs_attr_shift_entries(entry,
+                                       inode->i_extra_isize - new_extra_isize,
+                                       (char *)inode +
+                                       EXT2_GOOD_OLD_INODE_SIZE +
+                                       new_extra_isize,
+                                       start - sizeof(__u32), total_ino);
+               inode->i_extra_isize = new_extra_isize;
+               if (needed_size)
+                       *needed_size = 0;
+               goto write_inode;
+       }
+
+       if (inode->i_file_acl) {
+               error = ext2fs_read_ext_attr(fs, inode->i_file_acl, block_buf);
+               if (error)
+                       goto cleanup;
+
+               header = BHDR(block_buf);
+               if (header->h_magic != EXT2_EXT_ATTR_MAGIC) {
+                       error = EXT2_ET_EA_BAD_MAGIC;
+                       goto cleanup;
+               }
+               end = block_buf + fs->blocksize;
+               last = entry = (struct ext2_ext_attr_entry *)(header+1);
+               start = (char *)entry;
+               offs = end - start;
+               free = ext2fs_attr_free_space(last, &offs, start, &total_blk);
+               if (free < new_extra_isize) {
+                       if (!tried_min_extra_isize && s_min_extra_isize) {
+                               tried_min_extra_isize++;
+                               new_extra_isize = s_min_extra_isize;
+                               goto retry;
+                       }
+                       if (ret)
+                               *ret = EXT2_EXPAND_EISIZE_NOSPC;
+                       error = EXT2_ET_EA_NO_SPACE;
+                       goto cleanup;
+               }
+       } else {
+               if (ret && *ret == EXT2_EXPAND_EISIZE_UNSAFE) {
+                       *ret = EXT2_EXPAND_EISIZE_NEW_BLOCK;
+                       error = 0;
+                       goto cleanup;
+               }
+               free = fs->blocksize;
+       }
+
+       while (new_extra_isize > 0) {
+               int offs, size, entry_size;
+               struct ext2_ext_attr_entry *small_entry = NULL;
+               struct ext2_attr_info i = {
+                       .value = NULL,
+                       .value_len = 0,
+               };
+               unsigned int total_size, shift_bytes, temp = ~0U, extra_isize=0;
+
+               start = (char *)inode + EXT2_GOOD_OLD_INODE_SIZE +
+                               inode->i_extra_isize + sizeof(__u32);
+               end = (char *)inode + EXT2_INODE_SIZE(fs->super);
+               last = (struct ext2_ext_attr_entry *)start;
+
+               /* Find the entry best suited to be pushed into EA block */
+               entry = NULL;
+               for (; !EXT2_EXT_IS_LAST_ENTRY(last);
+                       last = EXT2_EXT_ATTR_NEXT(last)) {
+                       total_size = EXT2_EXT_ATTR_SIZE(last->e_value_size) +
+                                       EXT2_EXT_ATTR_LEN(last->e_name_len);
+                       if (total_size <= free && total_size < temp) {
+                               if (total_size < new_extra_isize) {
+                                       small_entry = last;
+                               } else {
+                                       entry = last;
+                                       temp = total_size;
+                               }
+                       }
+               }
+
+               if (entry == NULL) {
+                       if (small_entry) {
+                               entry = small_entry;
+                       } else {
+                               if (!tried_min_extra_isize &&
+                                   s_min_extra_isize) {
+                                       tried_min_extra_isize++;
+                                       new_extra_isize = s_min_extra_isize;
+                                       goto retry;
+                               }
+                               if (ret)
+                                       *ret = EXT2_EXPAND_EISIZE_NOSPC;
+                               error = EXT2_ET_EA_NO_SPACE;
+                               goto cleanup;
+                       }
+               }
+               offs = entry->e_value_offs;
+               size = entry->e_value_size;
+               entry_size = EXT2_EXT_ATTR_LEN(entry->e_name_len);
+               i.name_index = entry->e_name_index;
+               error = ext2fs_get_mem(EXT2_EXT_ATTR_SIZE(size), &buffer);
+               if (error)
+                       goto cleanup;
+               error = ext2fs_get_mem(entry->e_name_len + 1, &b_entry_name);
+               if (error)
+                       goto cleanup;
+               /* Save the entry name and the entry value */
+               memcpy((char *)buffer, (char *)start + offs,
+                      EXT2_EXT_ATTR_SIZE(size));
+               memcpy((char *)b_entry_name, (char *)entry->e_name,
+                      entry->e_name_len);
+               b_entry_name[entry->e_name_len] = '\0';
+               i.name = b_entry_name;
+
+               error = ext2fs_attr_ibody_find(fs, inode, &i, &is);
+               if (error)
+                       goto cleanup;
+
+               error = ext2fs_attr_set_entry(fs, &i, &is.s);
+               if (error)
+                       goto cleanup;
+
+               entry = (struct ext2_ext_attr_entry *)start;
+               if (entry_size + EXT2_EXT_ATTR_SIZE(size) >= new_extra_isize)
+                       shift_bytes = new_extra_isize;
+               else
+                       shift_bytes = entry_size + EXT2_EXT_ATTR_SIZE(size);
+               ext2fs_attr_shift_entries(entry,
+                                       inode->i_extra_isize - shift_bytes,
+                                       (char *)inode +EXT2_GOOD_OLD_INODE_SIZE+
+                                       extra_isize + shift_bytes,
+                                       start - sizeof(__u32),
+                                       total_ino - entry_size);
+
+               extra_isize += shift_bytes;
+               new_extra_isize -= shift_bytes;
+               if (needed_size)
+                       *needed_size = new_extra_isize;
+               inode->i_extra_isize = extra_isize;
+
+               i.name = b_entry_name;
+               i.value = buffer;
+               i.value_len = size;
+               error = ext2fs_attr_block_find(fs, (struct ext2_inode *)inode,
+                                              &i, &bs);
+               if (error)
+                       goto cleanup;
+
+               /* Add entry which was removed from the inode into the block */
+               error = ext2fs_attr_block_set(fs, (struct ext2_inode *)inode,
+                                             &i, &bs);
+               if (error)
+                       goto cleanup;
+       }
+
+write_inode:
+       error = ext2fs_write_inode_full(fs, ino, (struct ext2_inode *)inode,
+                                       EXT2_INODE_SIZE(fs->super));
+cleanup:
+       if (inode_buf)
+               ext2fs_free_mem(&inode_buf);
+       if (block_buf)
+               ext2fs_free_mem(&block_buf);
+       if (buffer)
+               ext2fs_free_mem(&buffer);
+       if (b_entry_name)
+               ext2fs_free_mem(&b_entry_name);
+
+       return error;
+}