Whamcloud - gitweb
e2fsck: update mmp block in one thread
[tools/e2fsprogs.git] / e2fsck / unix.c
index 7a8fce2..fb1c419 100644 (file)
@@ -45,12 +45,16 @@ extern int optind;
 #ifdef HAVE_DIRENT_H
 #include <dirent.h>
 #endif
+#include <libgen.h>
 
 #include "e2p/e2p.h"
 #include "et/com_err.h"
 #include "e2p/e2p.h"
+#include "uuid/uuid.h"
+#include "support/plausible.h"
 #include "e2fsck.h"
 #include "problem.h"
+#include "jfs_user.h"
 #include "../version.h"
 
 /* Command line options */
@@ -64,32 +68,35 @@ static char *bad_blocks_file;
 
 e2fsck_t e2fsck_global_ctx;    /* Try your very best not to use this! */
 
-#ifdef CONFIG_JBD_DEBUG                /* Enabled by configure --enable-jfs-debug */
+#ifdef CONFIG_JBD_DEBUG                /* Enabled by configure --enable-jbd-debug */
 int journal_enable_debug = -1;
 #endif
 
 static void usage(e2fsck_t ctx)
 {
        fprintf(stderr,
-               _("Usage: %s [-panyrcdfvtDFV] [-b superblock] [-B blocksize]\n"
-               "\t\t[-I inode_buffer_blocks] [-P process_inode_size]\n"
+               _("Usage: %s [-pamnyrcdfktvDFV] [-b superblock] [-B blocksize]\n"
                "\t\t[-l|-L bad_blocks_file] [-C fd] [-j external_journal]\n"
-               "\t\t[-E extended-options] device\n"),
+               "\t\t[-E extended-options] [-z undo_file] device\n"),
                ctx->program_name);
 
-       fprintf(stderr, _("\nEmergency help:\n"
+       fprintf(stderr, "%s", _("\nEmergency help:\n"
                " -p                   Automatic repair (no questions)\n"
+#ifdef HAVE_PTHREAD
+               " -m                   multiple threads to speedup fsck\n"
+#endif
                " -n                   Make no changes to the filesystem\n"
                " -y                   Assume \"yes\" to all questions\n"
                " -c                   Check for bad blocks and add them to the badblock list\n"
                " -f                   Force checking even if filesystem is marked clean\n"));
-       fprintf(stderr, _(""
+       fprintf(stderr, "%s", _(""
                " -v                   Be verbose\n"
                " -b superblock        Use alternative superblock\n"
                " -B blocksize         Force blocksize when looking for superblock\n"
                " -j external_journal  Set location of the external journal\n"
                " -l bad_blocks_file   Add to badblocks list\n"
                " -L bad_blocks_file   Set badblocks list\n"
+               " -z undo_file         Create an undo file\n"
                ));
 
        exit(FSCK_USAGE);
@@ -103,7 +110,7 @@ static void show_stats(e2fsck_t     ctx)
        unsigned int dir_links;
        unsigned int num_files, num_links;
        __u32 *mask, m;
-       int frag_percent_file, frag_percent_dir, frag_percent_total;
+       int frag_percent_file = 0, frag_percent_dir = 0, frag_percent_total = 0;
        int i, j, printed = 0;
 
        dir_links = 2 * ctx->fs_directory_count - 1;
@@ -116,23 +123,26 @@ static void show_stats(e2fsck_t   ctx)
        blocks_used = (ext2fs_blocks_count(fs->super) -
                       ext2fs_free_blocks_count(fs->super));
 
-       frag_percent_file = (10000 * ctx->fs_fragmented) / inodes_used;
-       frag_percent_file = (frag_percent_file + 5) / 10;
+       if (inodes_used > 0) {
+               frag_percent_file = (10000 * ctx->fs_fragmented) / inodes_used;
+               frag_percent_file = (frag_percent_file + 5) / 10;
 
-       frag_percent_dir = (10000 * ctx->fs_fragmented_dir) / inodes_used;
-       frag_percent_dir = (frag_percent_dir + 5) / 10;
+               frag_percent_dir = (10000 * ctx->fs_fragmented_dir) / inodes_used;
+               frag_percent_dir = (frag_percent_dir + 5) / 10;
 
-       frag_percent_total = ((10000 * (ctx->fs_fragmented +
-                                       ctx->fs_fragmented_dir))
-                             / inodes_used);
-       frag_percent_total = (frag_percent_total + 5) / 10;
+               frag_percent_total = ((10000 * (ctx->fs_fragmented +
+                                               ctx->fs_fragmented_dir))
+                                     / inodes_used);
+               frag_percent_total = (frag_percent_total + 5) / 10;
+       }
 
        if (!verbose) {
                log_out(ctx, _("%s: %u/%u files (%0d.%d%% non-contiguous), "
                               "%llu/%llu blocks\n"),
                        ctx->device_name, inodes_used, inodes,
                        frag_percent_total / 10, frag_percent_total % 10,
-                       blocks_used, blocks);
+                       (unsigned long long) blocks_used,
+                       (unsigned long long) blocks);
                return;
        }
        profile_get_boolean(ctx->profile, "options", "report_features", 0, 0,
@@ -176,7 +186,7 @@ static void show_stats(e2fsck_t     ctx)
                if (ctx->extent_depth_count[j])
                        break;
        if (++j) {
-               log_out(ctx, _("             Extent depth histogram: "));
+               log_out(ctx, "%s", _("             Extent depth histogram: "));
                for (i=0; i < j; i++) {
                        if (i)
                                fputc('/', stdout);
@@ -188,7 +198,8 @@ static void show_stats(e2fsck_t     ctx)
        log_out(ctx, P_("%12llu block used (%2.2f%%, out of %llu)\n",
                        "%12llu blocks used (%2.2f%%, out of %llu)\n",
                   blocks_used),
-               blocks_used, 100.0 * blocks_used / blocks, blocks);
+               (unsigned long long) blocks_used, 100.0 * blocks_used / blocks,
+               (unsigned long long) blocks);
        log_out(ctx, P_("%12u bad block\n", "%12u bad blocks\n",
                        ctx->fs_badblocks_count), ctx->fs_badblocks_count);
        log_out(ctx, P_("%12u large file\n", "%12u large files\n",
@@ -249,26 +260,30 @@ static void check_mount(e2fsck_t ctx)
             ((ctx->options & E2F_OPT_FORCE) &&
              (ctx->mount_flags & EXT2_MF_READONLY))) &&
            !(ctx->options & E2F_OPT_WRITECHECK)) {
-               log_out(ctx, _("Warning!  %s is %s.\n"),
-                       ctx->filesystem_name,
-                       ctx->mount_flags & EXT2_MF_MOUNTED ?
-                               "mounted" : "in use");
+               if (ctx->mount_flags & EXT2_MF_MOUNTED)
+                       log_out(ctx, _("Warning!  %s is mounted.\n"),
+                                       ctx->filesystem_name);
+               else
+                       log_out(ctx, _("Warning!  %s is in use.\n"),
+                                       ctx->filesystem_name);
                return;
        }
 
-       log_out(ctx, _("%s is %s.\n"), ctx->filesystem_name,
-               ctx->mount_flags & EXT2_MF_MOUNTED ? "mounted" : "in use");
+       if (ctx->mount_flags & EXT2_MF_MOUNTED)
+               log_out(ctx, _("%s is mounted.\n"), ctx->filesystem_name);
+       else
+               log_out(ctx, _("%s is in use.\n"), ctx->filesystem_name);
        if (!ctx->interactive || ctx->mount_flags & EXT2_MF_BUSY)
                fatal_error(ctx, _("Cannot continue, aborting.\n\n"));
        puts("\007\007\007\007");
-       log_out(ctx, _("\n\nWARNING!!!  "
+       log_out(ctx, "%s", _("\n\nWARNING!!!  "
                       "The filesystem is mounted.   "
                       "If you continue you ***WILL***\n"
                       "cause ***SEVERE*** filesystem damage.\n\n"));
        puts("\007\007\007");
        cont = ask_yn(ctx, _("Do you really want to continue"), 0);
        if (!cont) {
-               printf (_("check aborted.\n"));
+               printf("%s", _("check aborted.\n"));
                exit (0);
        }
        return;
@@ -278,7 +293,7 @@ static int is_on_batt(void)
 {
        FILE    *f;
        DIR     *d;
-       char    tmp[80], tmp2[80], fname[80];
+       char    tmp[80], tmp2[80], fname[NAME_MAX+30];
        unsigned int    acflag;
        struct dirent*  de;
 
@@ -302,7 +317,8 @@ static int is_on_batt(void)
                while ((de=readdir(d)) != NULL) {
                        if (!strncmp(".", de->d_name, 1))
                                continue;
-                       snprintf(fname, 80, "/proc/acpi/ac_adapter/%s/state",
+                       snprintf(fname, sizeof(fname),
+                                "/proc/acpi/ac_adapter/%s/state",
                                 de->d_name);
                        f = fopen(fname, "r");
                        if (!f)
@@ -337,6 +353,9 @@ static void check_if_skip(e2fsck_t ctx)
        int broken_system_clock;
        time_t lastcheck;
 
+       if (ctx->flags & E2F_FLAG_PROBLEMS_FIXED)
+               return;
+
        profile_get_boolean(ctx->profile, "options", "broken_system_clock",
                            0, 0, &broken_system_clock);
        if (ctx->flags & E2F_FLAG_TIME_INSANE)
@@ -384,11 +403,16 @@ static void check_if_skip(e2fsck_t ctx)
                if (batt && ((ctx->now - fs->super->s_lastcheck) <
                             fs->super->s_checkinterval*2))
                        reason = 0;
+       } else if (broken_system_clock && fs->super->s_checkinterval) {
+               log_out(ctx, "%s: ", ctx->device_name);
+               log_out(ctx, "%s",
+                       _("ignoring check interval, broken_system_clock set\n"));
        }
+
        if (reason) {
                log_out(ctx, "%s", ctx->device_name);
                log_out(ctx, reason, reason_arg);
-               log_out(ctx, _(", check forced.\n"));
+               log_out(ctx, "%s", _(", check forced.\n"));
                return;
        }
 
@@ -425,9 +449,9 @@ static void check_if_skip(e2fsck_t ctx)
                ctx->device_name,
                fs->super->s_inodes_count - fs->super->s_free_inodes_count,
                fs->super->s_inodes_count,
-               ext2fs_blocks_count(fs->super) -
+               (unsigned long long) ext2fs_blocks_count(fs->super) -
                ext2fs_free_blocks_count(fs->super),
-               ext2fs_blocks_count(fs->super));
+               (unsigned long long) ext2fs_blocks_count(fs->super));
        next_check = 100000;
        if (fs->super->s_max_mnt_count > 0) {
                next_check = fs->super->s_max_mnt_count - fs->super->s_mnt_count;
@@ -440,17 +464,18 @@ static void check_if_skip(e2fsck_t ctx)
        if (next_check <= 5) {
                if (next_check == 1) {
                        if (batt)
-                               log_out(ctx, _(" (check deferred; "
-                                              "on battery)"));
+                               log_out(ctx, "%s",
+                                       _(" (check deferred; on battery)"));
                        else
-                               log_out(ctx, _(" (check after next mount)"));
+                               log_out(ctx, "%s",
+                                       _(" (check after next mount)"));
                } else
-                       log_out(ctx, _(" (check in %ld mounts)"), next_check);
+                       log_out(ctx, _(" (check in %ld mounts)"),
+                               next_check);
        }
        log_out(ctx, "\n");
 skip:
-       ext2fs_close(fs);
-       ctx->fs = NULL;
+       ext2fs_close_free(&ctx->fs);
        e2fsck_free_context(ctx);
        exit(FSCK_OK);
 }
@@ -462,7 +487,7 @@ struct percent_tbl {
        int     max_pass;
        int     table[32];
 };
-struct percent_tbl e2fsck_tbl = {
+static struct percent_tbl e2fsck_tbl = {
        5, { 0, 70, 90, 92,  95, 100 }
 };
 static char bar[128], spaces[128];
@@ -481,7 +506,7 @@ static float calc_percent(struct percent_tbl *tbl, int pass, int curr,
                + tbl->table[pass-1]);
 }
 
-extern void e2fsck_clear_progbar(e2fsck_t ctx)
+void e2fsck_clear_progbar(e2fsck_t ctx)
 {
        if (!(ctx->flags & E2F_FLAG_PROG_BAR))
                return;
@@ -598,9 +623,10 @@ static void reserve_stdio_fds(void)
                        fprintf(stderr, _("ERROR: Couldn't open "
                                "/dev/null (%s)\n"),
                                strerror(errno));
-                       break;
+                       return;
                }
        }
+       (void) close(fd);
 }
 
 #ifdef HAVE_SIGNAL_H
@@ -641,6 +667,7 @@ static void parse_extended_opts(e2fsck_t ctx, const char *opts)
        char    *buf, *token, *next, *p, *arg;
        int     ea_ver;
        int     extended_usage = 0;
+       unsigned long long reada_kb;
 
        buf = string_copy(ctx, opts, 0);
        for (token = buf; token && *token; token = next) {
@@ -663,12 +690,25 @@ static void parse_extended_opts(e2fsck_t ctx, const char *opts)
                        ea_ver = strtoul(arg, &p, 0);
                        if (*p ||
                            ((ea_ver != 1) && (ea_ver != 2))) {
-                               fprintf(stderr,
+                               fprintf(stderr, "%s",
                                        _("Invalid EA version.\n"));
                                extended_usage++;
                                continue;
                        }
                        ctx->ext_attr_ver = ea_ver;
+               } else if (strcmp(token, "readahead_kb") == 0) {
+                       if (!arg) {
+                               extended_usage++;
+                               continue;
+                       }
+                       reada_kb = strtoull(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr, "%s",
+                                       _("Invalid readahead buffer size.\n"));
+                               extended_usage++;
+                               continue;
+                       }
+                       ctx->readahead_kb = reada_kb;
                } else if (strcmp(token, "fragcheck") == 0) {
                        ctx->options |= E2F_OPT_FRAGCHECK;
                        continue;
@@ -684,12 +724,48 @@ static void parse_extended_opts(e2fsck_t ctx, const char *opts)
                } else if (strcmp(token, "nodiscard") == 0) {
                        ctx->options &= ~E2F_OPT_DISCARD;
                        continue;
+               } else if (strcmp(token, "optimize_extents") == 0) {
+                       ctx->options &= ~E2F_OPT_NOOPT_EXTENTS;
+                       continue;
+               } else if (strcmp(token, "no_optimize_extents") == 0) {
+                       ctx->options |= E2F_OPT_NOOPT_EXTENTS;
+                       continue;
+               } else if (strcmp(token, "inode_count_fullmap") == 0) {
+                       ctx->options |= E2F_OPT_ICOUNT_FULLMAP;
+                       continue;
+               } else if (strcmp(token, "no_inode_count_fullmap") == 0) {
+                       ctx->options &= ~E2F_OPT_ICOUNT_FULLMAP;
+                       continue;
                } else if (strcmp(token, "log_filename") == 0) {
                        if (!arg)
                                extended_usage++;
                        else
                                ctx->log_fn = string_copy(ctx, arg, 0);
                        continue;
+               } else if (strcmp(token, "problem_log") == 0) {
+                       if (!arg)
+                               extended_usage++;
+                       else
+                               ctx->problem_log_fn = string_copy(ctx, arg, 0);
+                       continue;
+               } else if (strcmp(token, "bmap2extent") == 0) {
+                       ctx->options |= E2F_OPT_CONVERT_BMAP;
+                       continue;
+               } else if (strcmp(token, "fixes_only") == 0) {
+                       ctx->options |= E2F_OPT_FIXES_ONLY;
+                       continue;
+               } else if (strcmp(token, "unshare_blocks") == 0) {
+                       ctx->options |= E2F_OPT_UNSHARE_BLOCKS;
+                       ctx->options |= E2F_OPT_FORCE;
+                       continue;
+               } else if (strcmp(token, "check_encoding") == 0) {
+                       ctx->options |= E2F_OPT_CHECK_ENCODING;
+                       continue;
+#ifdef CONFIG_DEVELOPER_FEATURES
+               } else if (strcmp(token, "clear_all_uninit_bits") == 0) {
+                       ctx->options |= E2F_OPT_CLEAR_UNINIT;
+                       continue;
+#endif
                } else {
                        fprintf(stderr, _("Unknown extended option: %s\n"),
                                token);
@@ -699,15 +775,24 @@ static void parse_extended_opts(e2fsck_t ctx, const char *opts)
        free(buf);
 
        if (extended_usage) {
-               fputs(("\nExtended options are separated by commas, "
+               fputs(_("\nExtended options are separated by commas, "
                       "and may take an argument which\n"
                       "is set off by an equals ('=') sign.  "
-                      "Valid extended options are:\n"), stderr);
-               fputs(("\tea_ver=<ea_version (1 or 2)>\n"), stderr);
-               fputs(("\tfragcheck\n"), stderr);
-               fputs(("\tjournal_only\n"), stderr);
-               fputs(("\tdiscard\n"), stderr);
-               fputs(("\tnodiscard\n"), stderr);
+                      "Valid extended options are:\n\n"), stderr);
+               fputs(_("\tea_ver=<ea_version (1 or 2)>\n"), stderr);
+               fputs("\tfragcheck\n", stderr);
+               fputs("\tjournal_only\n", stderr);
+               fputs("\tdiscard\n", stderr);
+               fputs("\tnodiscard\n", stderr);
+               fputs("\toptimize_extents\n", stderr);
+               fputs("\tno_optimize_extents\n", stderr);
+               fputs("\tinode_count_fullmap\n", stderr);
+               fputs("\tno_inode_count_fullmap\n", stderr);
+               fputs(_("\treadahead_kb=<buffer size>\n"), stderr);
+               fputs("\tbmap2extent\n", stderr);
+               fputs("\tunshare_blocks\n", stderr);
+               fputs("\tfixes_only\n", stderr);
+               fputs("\tcheck_encoding\n", stderr);
                fputc('\n', stderr);
                exit(1);
        }
@@ -741,16 +826,22 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
 #ifdef CONFIG_JBD_DEBUG
        char            *jbd_debug;
 #endif
+#ifdef HAVE_PTHREAD
+       char            *pm;
+       unsigned long   thread_num;
+#endif
+       unsigned long long phys_mem_kb, blk;
 
        retval = e2fsck_allocate_context(&ctx);
        if (retval)
                return retval;
 
        *ret_ctx = ctx;
+       e2fsck_global_ctx = ctx;
 
        setvbuf(stdout, NULL, _IONBF, BUFSIZ);
        setvbuf(stderr, NULL, _IONBF, BUFSIZ);
-       if (isatty(0) && isatty(1)) {
+       if (getenv("E2FSCK_FORCE_INTERACTIVE") || (isatty(0) && isatty(1))) {
                ctx->interactive = 1;
        } else {
                ctx->start_meta[0] = '\001';
@@ -767,7 +858,14 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
        else
                ctx->program_name = "e2fsck";
 
-       while ((c = getopt (argc, argv, "panyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDk")) != EOF)
+       phys_mem_kb = get_memory_size() / 1024;
+       ctx->readahead_kb = ~0ULL;
+
+#ifdef HAVE_PTHREAD
+       while ((c = getopt(argc, argv, "pam:nyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDkz:")) != EOF)
+#else
+       while ((c = getopt(argc, argv, "panyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDkz:")) != EOF)
+#endif
                switch (c) {
                case 'C':
                        ctx->progress = e2fsck_update_progress;
@@ -808,6 +906,22 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        }
                        ctx->options |= E2F_OPT_PREEN;
                        break;
+#ifdef HAVE_PTHREAD
+               case 'm':
+                       thread_num = strtoul(optarg, &pm, 0);
+                       if (*pm)
+                               fatal_error(ctx,
+                                       _("Invalid multiple thread num.\n"));
+                       if (thread_num > E2FSCK_MAX_THREADS) {
+                               fprintf(stderr,
+                                       _("threads %lu too large (max %lu)\n"),
+                                       thread_num, E2FSCK_MAX_THREADS);
+                               fatal_error(ctx, 0);
+                       }
+                       ctx->options |= E2F_OPT_MULTITHREAD;
+                       ctx->fs_num_threads = thread_num;
+                       break;
+#endif
                case 'n':
                        if (ctx->options & (E2F_OPT_YES|E2F_OPT_PREEN))
                                goto conflict_opt;
@@ -838,7 +952,8 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        /* What we do by default, anyway! */
                        break;
                case 'b':
-                       res = sscanf(optarg, "%llu", &ctx->use_superblock);
+                       res = sscanf(optarg, "%llu", &blk);
+                       ctx->use_superblock = blk;
                        if (res != 1)
                                goto sscanf_err;
                        ctx->flags |= E2F_FLAG_SB_SPECIFIED;
@@ -868,6 +983,7 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        break;
                case 'L':
                        replace_bad_blocks++;
+                       /* fall through */
                case 'l':
                        if (bad_blocks_file)
                                free(bad_blocks_file);
@@ -899,6 +1015,9 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                case 'k':
                        keep_bad_blocks++;
                        break;
+               case 'z':
+                       ctx->undo_file = optarg;
+                       break;
                default:
                        usage(ctx);
                }
@@ -908,20 +1027,34 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                usage(ctx);
        if ((ctx->options & E2F_OPT_NO) &&
            (ctx->options & E2F_OPT_COMPRESS_DIRS)) {
-               com_err(ctx->program_name, 0,
+               com_err(ctx->program_name, 0, "%s",
                        _("The -n and -D options are incompatible."));
                fatal_error(ctx, 0);
        }
        if ((ctx->options & E2F_OPT_NO) && cflag) {
-               com_err(ctx->program_name, 0,
+               com_err(ctx->program_name, 0, "%s",
                        _("The -n and -c options are incompatible."));
                fatal_error(ctx, 0);
        }
        if ((ctx->options & E2F_OPT_NO) && bad_blocks_file) {
-               com_err(ctx->program_name, 0,
+               com_err(ctx->program_name, 0, "%s",
                        _("The -n and -l/-L options are incompatible."));
                fatal_error(ctx, 0);
        }
+#ifdef HAVE_PTHREAD
+       if (ctx->options & E2F_OPT_MULTITHREAD) {
+               if ((ctx->options & (E2F_OPT_YES|E2F_OPT_NO|E2F_OPT_PREEN)) == 0) {
+                       com_err(ctx->program_name, 0, "%s",
+                               _("The -m option should be used together with one of -p/-y/-n options."));
+                       fatal_error(ctx, 0);
+               }
+               if (ctx->progress) {
+                       com_err(ctx->program_name, 0, "%s",
+                               _("Only one of the options -C or -m may be specified."));
+                       fatal_error(ctx, 0);
+               }
+       }
+#endif
        if (ctx->options & E2F_OPT_NO)
                ctx->options |= E2F_OPT_READONLY;
 
@@ -937,6 +1070,22 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
        if (extended_opts)
                parse_extended_opts(ctx, extended_opts);
 
+       /* Complain about mutually exclusive rebuilding activities */
+       if (getenv("E2FSCK_FIXES_ONLY"))
+               ctx->options |= E2F_OPT_FIXES_ONLY;
+       if ((ctx->options & E2F_OPT_COMPRESS_DIRS) &&
+           (ctx->options & E2F_OPT_FIXES_ONLY)) {
+               com_err(ctx->program_name, 0, "%s",
+                       _("The -D and -E fixes_only options are incompatible."));
+               fatal_error(ctx, 0);
+       }
+       if ((ctx->options & E2F_OPT_CONVERT_BMAP) &&
+           (ctx->options & E2F_OPT_FIXES_ONLY)) {
+               com_err(ctx->program_name, 0, "%s",
+                       _("The -E bmap2extent and fixes_only options are incompatible."));
+               fatal_error(ctx, 0);
+       }
+
        if ((cp = getenv("E2FSCK_CONFIG")) != NULL)
                config_fn[0] = cp;
        profile_set_syntax_err_cb(syntax_err_report);
@@ -951,6 +1100,30 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
        if (c)
                verbose = 1;
 
+       profile_get_boolean(ctx->profile, "options", "no_optimize_extents",
+                           0, 0, &c);
+       if (c)
+               ctx->options |= E2F_OPT_NOOPT_EXTENTS;
+
+       profile_get_boolean(ctx->profile, "options", "inode_count_fullmap",
+                           0, 0, &c);
+       if (c)
+               ctx->options |= E2F_OPT_ICOUNT_FULLMAP;
+
+       if (ctx->readahead_kb == ~0ULL) {
+               profile_get_integer(ctx->profile, "options",
+                                   "readahead_mem_pct", 0, -1, &c);
+               if (c >= 0 && c <= 100)
+                       ctx->readahead_kb = phys_mem_kb * c / 100;
+               profile_get_integer(ctx->profile, "options",
+                                   "readahead_kb", 0, -1, &c);
+               if (c >= 0)
+                       ctx->readahead_kb = c;
+               if (ctx->readahead_kb != ~0ULL &&
+                   ctx->readahead_kb > phys_mem_kb)
+                       ctx->readahead_kb = phys_mem_kb;
+       }
+
        /* Turn off discard in read-only mode */
        if ((ctx->options & E2F_OPT_NO) &&
            (ctx->options & E2F_OPT_DISCARD))
@@ -973,8 +1146,8 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                close(fd);
        }
        if (cflag && bad_blocks_file) {
-               fprintf(stderr, _("The -c and the -l/-L options may "
-                                 "not be both used at the same time.\n"));
+               fprintf(stderr, "%s", _("The -c and the -l/-L options may not "
+                                       "be both used at the same time.\n"));
                exit(FSCK_USAGE);
        }
 #ifdef HAVE_SIGNAL_H
@@ -988,11 +1161,12 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
 #ifdef SA_RESTART
        sa.sa_flags = SA_RESTART;
 #endif
-       e2fsck_global_ctx = ctx;
-       sa.sa_handler = signal_progress_on;
-       sigaction(SIGUSR1, &sa, 0);
-       sa.sa_handler = signal_progress_off;
-       sigaction(SIGUSR2, &sa, 0);
+       if ((ctx->options & E2F_OPT_MULTITHREAD) == 0) {
+               sa.sa_handler = signal_progress_on;
+               sigaction(SIGUSR1, &sa, 0);
+               sa.sa_handler = signal_progress_off;
+               sigaction(SIGUSR2, &sa, 0);
+       }
 #endif
 
        /* Update our PATH to include /sbin if we need to run badblocks  */
@@ -1064,9 +1238,11 @@ static errcode_t try_open_fs(e2fsck_t ctx, int flags, io_manager io_ptr,
                retval = ext2fs_open2(ctx->filesystem_name, ctx->io_options,
                                      flags, 0, 0, io_ptr, ret_fs);
 
-       if (retval == 0)
+       if (retval == 0) {
+               (*ret_fs)->priv_data = ctx;
                e2fsck_set_bitmap_type(*ret_fs, EXT2FS_BMAP64_RBTREE,
                                       "default", NULL);
+       }
        return retval;
 }
 
@@ -1117,7 +1293,7 @@ static errcode_t e2fsck_check_mmp(ext2_filsys fs, e2fsck_t ctx)
        if (retval)
                goto check_error;
 
-       /* Print warning if e2fck will wait for more than 20 secs. */
+       /* Print warning if e2fsck will wait for more than 20 secs. */
        if (verbose || wait_time > EXT4_MMP_MIN_CHECK_INTERVAL * 4) {
                log_out(ctx, _("MMP interval is %u seconds and total wait "
                               "time is %u seconds. Please wait...\n"),
@@ -1135,17 +1311,18 @@ check_error:
                        retval = 0;
                }
        } else if (retval == EXT2_ET_MMP_FAILED) {
-               com_err(ctx->program_name, retval,
+               com_err(ctx->program_name, retval, "%s",
                        _("while checking MMP block"));
                dump_mmp_msg(fs->mmp_buf, NULL);
        } else if (retval == EXT2_ET_MMP_FSCK_ON ||
                   retval == EXT2_ET_MMP_UNKNOWN_SEQ) {
-               com_err(ctx->program_name, retval,
+               com_err(ctx->program_name, retval, "%s",
                        _("while checking MMP block"));
                dump_mmp_msg(fs->mmp_buf,
                             _("If you are sure the filesystem is not "
                               "in use on any node, run:\n"
-                              "'tune2fs -f -E clear_mmp {device}'\n"));
+                              "'tune2fs -f -E clear_mmp %s'\n"),
+                            ctx->device_name);
        } else if (retval == EXT2_ET_MMP_MAGIC_INVALID) {
                if (fix_problem(ctx, PR_0_MMP_INVALID_MAGIC, &pctx)) {
                        ext2fs_mmp_clear(fs);
@@ -1156,7 +1333,96 @@ check_error:
                        ext2fs_mmp_clear(fs);
                        retval = 0;
                }
+       } else
+               com_err(ctx->program_name, retval, "%s",
+                       _("while reading MMP block"));
+       return retval;
+}
+
+static int e2fsck_setup_tdb(e2fsck_t ctx, io_manager *io_ptr)
+{
+       errcode_t retval = ENOMEM;
+       char *tdb_dir = NULL, *tdb_file = NULL;
+       char *dev_name, *tmp_name;
+       int free_tdb_dir = 0;
+
+       /* (re)open a specific undo file */
+       if (ctx->undo_file && ctx->undo_file[0] != 0) {
+               retval = set_undo_io_backing_manager(*io_ptr);
+               if (retval)
+                       goto err;
+               *io_ptr = undo_io_manager;
+               retval = set_undo_io_backup_file(ctx->undo_file);
+               if (retval)
+                       goto err;
+               printf(_("Overwriting existing filesystem; this can be undone "
+                        "using the command:\n"
+                        "    e2undo %s %s\n\n"),
+                       ctx->undo_file, ctx->filesystem_name);
+               return retval;
+       }
+
+       /*
+        * Configuration via a conf file would be
+        * nice
+        */
+       tdb_dir = getenv("E2FSPROGS_UNDO_DIR");
+       if (!tdb_dir) {
+               profile_get_string(ctx->profile, "defaults",
+                                  "undo_dir", 0, "/var/lib/e2fsprogs",
+                                  &tdb_dir);
+               free_tdb_dir = 1;
+       }
+
+       if (!strcmp(tdb_dir, "none") || (tdb_dir[0] == 0) ||
+           access(tdb_dir, W_OK)) {
+               if (free_tdb_dir)
+                       free(tdb_dir);
+               return 0;
+       }
+
+       tmp_name = strdup(ctx->filesystem_name);
+       if (!tmp_name)
+               goto errout;
+       dev_name = basename(tmp_name);
+       tdb_file = malloc(strlen(tdb_dir) + 8 + strlen(dev_name) + 7 + 1);
+       if (!tdb_file) {
+               free(tmp_name);
+               goto errout;
        }
+       sprintf(tdb_file, "%s/e2fsck-%s.e2undo", tdb_dir, dev_name);
+       free(tmp_name);
+
+       if ((unlink(tdb_file) < 0) && (errno != ENOENT)) {
+               retval = errno;
+               com_err(ctx->program_name, retval,
+                       _("while trying to delete %s"), tdb_file);
+               goto errout;
+       }
+
+       retval = set_undo_io_backing_manager(*io_ptr);
+       if (retval)
+               goto errout;
+       *io_ptr = undo_io_manager;
+       retval = set_undo_io_backup_file(tdb_file);
+       if (retval)
+               goto errout;
+       printf(_("Overwriting existing filesystem; this can be undone "
+                "using the command:\n"
+                "    e2undo %s %s\n\n"), tdb_file, ctx->filesystem_name);
+
+       if (free_tdb_dir)
+               free(tdb_dir);
+       free(tdb_file);
+       return 0;
+
+errout:
+       if (free_tdb_dir)
+               free(tdb_dir);
+       free(tdb_file);
+err:
+       com_err(ctx->program_name, retval, "%s",
+               _("while trying to setup undo file\n"));
        return retval;
 }
 
@@ -1170,15 +1436,16 @@ int main (int argc, char *argv[])
        const char      *lib_ver_date;
        int             my_ver, lib_ver;
        e2fsck_t        ctx;
-       blk64_t         orig_superblock;
+       blk64_t         orig_superblock = ~(blk64_t)0;
        struct problem_context pctx;
-       int flags, run_result;
+       int flags, run_result, was_changed;
        int journal_size;
        int sysval, sys_page_size = 4096;
        int old_bitmaps;
        __u32 features[3];
        char *cp;
-       int qtype = -99;  /* quota type */
+       enum quota_type qtype;
+       struct ext2fs_journal_params jparams;
 
        clear_problem_context(&pctx);
        sigcatcher_setup();
@@ -1198,22 +1465,24 @@ int main (int argc, char *argv[])
        my_ver = ext2fs_parse_version_string(my_ver_string);
        lib_ver = ext2fs_get_library_version(0, &lib_ver_date);
        if (my_ver > lib_ver) {
-               fprintf( stderr, _("Error: ext2fs library version "
-                       "out of date!\n"));
+               fprintf( stderr, "%s",
+                        _("Error: ext2fs library version out of date!\n"));
                show_version_only++;
        }
 
        retval = PRS(argc, argv, &ctx);
        if (retval) {
-               com_err("e2fsck", retval,
+               com_err("e2fsck", retval, "%s",
                        _("while trying to initialize program"));
                exit(FSCK_ERROR);
        }
        reserve_stdio_fds();
 
+       ctx->global_ctx = NULL;
        set_up_logging(ctx);
        if (ctx->logf) {
                int i;
+
                fputs("E2fsck run: ", ctx->logf);
                for (i = 0; i < argc; i++) {
                        if (i)
@@ -1222,6 +1491,19 @@ int main (int argc, char *argv[])
                }
                fputc('\n', ctx->logf);
        }
+       if (ctx->problem_logf) {
+               int i;
+
+               fputs("<?xml version=\"1.0\" encoding=\"utf-8\"?>\n",
+                     ctx->problem_logf);
+               fprintf(ctx->problem_logf, "<problem_log time=\"%lu\">\n",
+                       (unsigned long) ctx->now);
+               fprintf(ctx->problem_logf, "<invocation prog=\"%s\"",
+                       argv[0]);
+               for (i = 1; i < argc; i++)
+                       fprintf(ctx->problem_logf, " arg%d=\"%s\"", i, argv[i]);
+               fputs("/>\n", ctx->problem_logf);
+       }
 
        init_resource_track(&ctx->global_rtrack, NULL);
        if (!(ctx->options & E2F_OPT_PREEN) || show_version_only)
@@ -1245,7 +1527,7 @@ int main (int argc, char *argv[])
        }
        ctx->superblock = ctx->use_superblock;
 
-       flags = EXT2_FLAG_SKIP_MMP;
+       flags = EXT2_FLAG_SKIP_MMP | EXT2_FLAG_THREADS;
 restart:
 #ifdef CONFIG_TESTIO_DEBUG
        if (getenv("TEST_IO_FLAGS") || getenv("TEST_IO_BLOCK")) {
@@ -1269,6 +1551,14 @@ restart:
                        flags &= ~EXT2_FLAG_EXCLUSIVE;
        }
 
+       if (ctx->undo_file) {
+               retval = e2fsck_setup_tdb(ctx, &io_ptr);
+               if (retval)
+                       exit(FSCK_ERROR);
+       }
+
+       ctx->openfs_flags = flags;
+       ctx->io_manager = io_ptr;
        retval = try_open_fs(ctx, flags, io_ptr, &fs);
 
        if (!ctx->superblock && !(ctx->options & E2F_OPT_PREEN) &&
@@ -1302,12 +1592,12 @@ restart:
                        orig_superblock = ctx->superblock;
                        get_backup_sb(ctx, fs, ctx->filesystem_name, io_ptr);
                        if (fs)
-                               ext2fs_close(fs);
+                               ext2fs_close_free(&fs);
                        orig_retval = retval;
                        retval = try_open_fs(ctx, flags, io_ptr, &fs);
                        if ((orig_retval == 0) && retval != 0) {
                                if (fs)
-                                       ext2fs_close(fs);
+                                       ext2fs_close_free(&fs);
                                log_out(ctx, _("%s: %s while using the "
                                               "backup blocks"),
                                        ctx->program_name,
@@ -1340,35 +1630,62 @@ failure:
                com_err(ctx->program_name, retval, _("while trying to open %s"),
                        ctx->filesystem_name);
                if (retval == EXT2_ET_REV_TOO_HIGH) {
-                       log_out(ctx, _("The filesystem revision is apparently "
-                              "too high for this version of e2fsck.\n"
-                              "(Or the filesystem superblock "
-                              "is corrupt)\n\n"));
+                       log_out(ctx, "%s",
+                               _("The filesystem revision is apparently "
+                                 "too high for this version of e2fsck.\n"
+                                 "(Or the filesystem superblock "
+                                 "is corrupt)\n\n"));
                        fix_problem(ctx, PR_0_SB_CORRUPT, &pctx);
                } else if (retval == EXT2_ET_SHORT_READ)
-                       log_out(ctx, _("Could this be a zero-length "
-                                      "partition?\n"));
+                       log_out(ctx, "%s",
+                               _("Could this be a zero-length partition?\n"));
                else if ((retval == EPERM) || (retval == EACCES))
                        log_out(ctx, _("You must have %s access to the "
-                              "filesystem or be root\n"),
+                                      "filesystem or be root\n"),
                               (ctx->options & E2F_OPT_READONLY) ?
                               "r/o" : "r/w");
                else if (retval == ENXIO)
-                       log_out(ctx, _("Possibly non-existent or "
-                                      "swap device?\n"));
+                       log_out(ctx, "%s",
+                               _("Possibly non-existent or swap device?\n"));
                else if (retval == EBUSY)
-                       log_out(ctx, _("Filesystem mounted or opened "
-                                "exclusively by another program?\n"));
+                       log_out(ctx, "%s", _("Filesystem mounted or opened "
+                                        "exclusively by another program?\n"));
                else if (retval == ENOENT)
-                       log_out(ctx, _("Possibly non-existent device?\n"));
+                       log_out(ctx, "%s",
+                               _("Possibly non-existent device?\n"));
 #ifdef EROFS
                else if (retval == EROFS)
-                       log_out(ctx, _("Disk write-protected; use the -n "
-                                      "option to do a read-only\n"
-                                      "check of the device.\n"));
+                       log_out(ctx, "%s", _("Disk write-protected; use the "
+                                            "-n option to do a read-only\n"
+                                            "check of the device.\n"));
 #endif
-               else
+               else {
+                       /*
+                        * Let's try once more will less consistency checking
+                        * so that we are able to recover from more errors
+                        * (e.g. some tool messing up some value in the sb).
+                        */
+                       if ((retval == EXT2_ET_CORRUPT_SUPERBLOCK) &&
+                           !(flags & EXT2_FLAG_IGNORE_SB_ERRORS)) {
+                               if (fs)
+                                       ext2fs_close_free(&fs);
+                               log_out(ctx, _("%s: Trying to load superblock "
+                                       "despite errors...\n"),
+                                       ctx->program_name);
+                               flags |= EXT2_FLAG_IGNORE_SB_ERRORS;
+                               /*
+                                * If we tried backup sb, revert to the
+                                * original one now.
+                                */
+                               if (orig_superblock != ~(blk64_t)0)
+                                       ctx->superblock = orig_superblock;
+                               goto restart;
+                       }
                        fix_problem(ctx, PR_0_SB_CORRUPT, &pctx);
+                       if (retval == EXT2_ET_BAD_MAGIC)
+                               check_plausibility(ctx->filesystem_name,
+                                                  CHECK_FS_EXIST, NULL);
+               }
                fatal_error(ctx, 0);
        }
        /*
@@ -1399,7 +1716,7 @@ failure:
                 * reopen the filesystem after we get the device size.
                 */
                if (pctx.errcode == EBUSY) {
-                       ext2fs_close(fs);
+                       ext2fs_close_free(&fs);
                        need_restart++;
                        pctx.errcode =
                                ext2fs_get_device_size2(ctx->filesystem_name,
@@ -1419,7 +1736,6 @@ failure:
        }
 
        ctx->fs = fs;
-       fs->priv_data = ctx;
        fs->now = ctx->now;
        sb = fs->super;
 
@@ -1435,20 +1751,36 @@ failure:
         * Set the device name, which is used whenever we print error
         * or informational messages to the user.
         */
-       if (ctx->device_name == 0 &&
-           (sb->s_volume_name[0] != 0)) {
-               ctx->device_name = string_copy(ctx, sb->s_volume_name,
+       if (ctx->device_name == 0 && sb->s_volume_name[0])
+               ctx->device_name = string_copy(ctx, (char *) sb->s_volume_name,
                                               sizeof(sb->s_volume_name));
-       }
+
        if (ctx->device_name == 0)
                ctx->device_name = string_copy(ctx, ctx->filesystem_name, 0);
        for (cp = ctx->device_name; *cp; cp++)
                if (isspace(*cp) || *cp == ':')
                        *cp = '_';
 
+       if (ctx->problem_logf) {
+
+               fprintf(ctx->problem_logf, "<filesystem dev=\"%s\"",
+                       ctx->filesystem_name);
+               if (!uuid_is_null(sb->s_uuid)) {
+                       char buf[48];
+
+                       uuid_unparse(sb->s_uuid, buf);
+                       fprintf(ctx->problem_logf, " uuid=\"%s\"", buf);
+               }
+               if (sb->s_volume_name[0])
+                       fprintf(ctx->problem_logf, " label=\"%.*s\"",
+                               EXT2_LEN_STR(sb->s_volume_name));
+
+               fputs("/>\n", ctx->problem_logf);
+       }
+
        ehandler_init(fs->io);
 
-       if ((fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_MMP) &&
+       if (ext2fs_has_feature_mmp(fs->super) &&
            (flags & EXT2_FLAG_SKIP_MMP)) {
                if (e2fsck_check_mmp(fs, ctx))
                        fatal_error(ctx, 0);
@@ -1456,8 +1788,7 @@ failure:
                /*
                 * Restart in order to reopen fs but this time start mmp.
                 */
-               ext2fs_close(fs);
-               ctx->fs = NULL;
+               ext2fs_close_free(&ctx->fs);
                flags &= ~EXT2_FLAG_SKIP_MMP;
                goto restart;
        }
@@ -1469,23 +1800,26 @@ failure:
        /*
         * Make sure the ext3 superblock fields are consistent.
         */
-       retval = e2fsck_check_ext3_journal(ctx);
-       if (retval) {
-               com_err(ctx->program_name, retval,
-                       _("while checking ext3 journal for %s"),
-                       ctx->device_name);
-               fatal_error(ctx, 0);
+       if ((ctx->mount_flags & (EXT2_MF_MOUNTED | EXT2_MF_BUSY)) == 0) {
+               retval = e2fsck_check_ext3_journal(ctx);
+               if (retval) {
+                       com_err(ctx->program_name, retval,
+                               _("while checking journal for %s"),
+                               ctx->device_name);
+                       fatal_error(ctx,
+                               _("Cannot proceed with file system check"));
+               }
        }
 
        /*
         * Check to see if we need to do ext3-style recovery.  If so,
         * do it, and then restart the fsck.
         */
-       if (sb->s_feature_incompat & EXT3_FEATURE_INCOMPAT_RECOVER) {
+       if (ext2fs_has_feature_journal_needs_recovery(sb)) {
                if (ctx->options & E2F_OPT_READONLY) {
-                       log_out(ctx, _("Warning: skipping journal recovery "
-                                      "because doing a read-only filesystem "
-                                      "check.\n"));
+                       log_out(ctx, "%s",
+                               _("Warning: skipping journal recovery because "
+                                 "doing a read-only filesystem check.\n"));
                        io_channel_flush(ctx->fs->io);
                } else {
                        if (ctx->flags & E2F_FLAG_RESTARTED) {
@@ -1496,18 +1830,24 @@ failure:
                                 * device driver is being bogus.
                                 */
                                com_err(ctx->program_name, 0,
-                                       _("unable to set superblock flags on %s\n"), ctx->device_name);
+                                       _("unable to set superblock flags "
+                                         "on %s\n"), ctx->device_name);
                                fatal_error(ctx, 0);
                        }
                        retval = e2fsck_run_ext3_journal(ctx);
-                       if (retval) {
+                       if (retval == EFSBADCRC) {
+                               log_out(ctx, _("Journal checksum error "
+                                              "found in %s\n"),
+                                       ctx->device_name);
+                       } else if (retval == EFSCORRUPTED) {
+                               log_out(ctx, _("Journal corrupted in %s\n"),
+                                       ctx->device_name);
+                       } else if (retval) {
                                com_err(ctx->program_name, retval,
-                               _("while recovering ext3 journal of %s"),
+                               _("while recovering journal of %s"),
                                        ctx->device_name);
-                               fatal_error(ctx, 0);
                        }
-                       ext2fs_close(ctx->fs);
-                       ctx->fs = 0;
+                       ext2fs_close_free(&ctx->fs);
                        ctx->flags |= E2F_FLAG_RESTARTED;
                        goto restart;
                }
@@ -1539,20 +1879,12 @@ print_unsupp_features:
                log_err(ctx, "\n");
                goto get_newer;
        }
-#ifdef ENABLE_COMPRESSION
-       if (sb->s_feature_incompat & EXT2_FEATURE_INCOMPAT_COMPRESSION)
-               log_err(ctx, _("%s: warning: compression support "
-                              "is experimental.\n"),
-                       ctx->program_name);
-#endif
-#ifndef ENABLE_HTREE
-       if (sb->s_feature_compat & EXT2_FEATURE_COMPAT_DIR_INDEX) {
-               log_err(ctx, _("%s: e2fsck not compiled with HTREE support,\n\t"
-                         "but filesystem %s has HTREE directories.\n"),
-                       ctx->program_name, ctx->device_name);
+
+       if (ext2fs_has_feature_casefold(sb) && !fs->encoding) {
+               log_err(ctx, _("%s has unsupported encoding: %0x\n"),
+                       ctx->filesystem_name, sb->s_encoding);
                goto get_newer;
        }
-#endif
 
        /*
         * If the user specified a specific superblock, presumably the
@@ -1602,118 +1934,176 @@ print_unsupp_features:
                log_out(ctx, _("%s: %s while reading bad blocks inode\n"),
                        ctx->program_name, error_message(retval));
                preenhalt(ctx);
-               log_out(ctx, _("This doesn't bode well, "
-                              "but we'll try to go on...\n"));
+               log_out(ctx, "%s", _("This doesn't bode well, "
+                                    "but we'll try to go on...\n"));
        }
 
        /*
         * Save the journal size in megabytes.
         * Try and use the journal size from the backup else let e2fsck
-        * find the default journal size.
+        * find the default journal size. If fast commit feature is enabled,
+        * it is not clear how many of the journal blocks were fast commit
+        * blocks. So, ignore the size of journal found in backup.
+        *
+        * TODO: Add a new backup type that captures fast commit info as
+        * well.
         */
-       if (sb->s_jnl_backup_type == EXT3_JNL_BACKUP_BLOCKS)
+       if (sb->s_jnl_backup_type == EXT3_JNL_BACKUP_BLOCKS &&
+               !ext2fs_has_feature_fast_commit(sb))
                journal_size = (sb->s_jnl_blocks[15] << (32 - 20)) |
                               (sb->s_jnl_blocks[16] >> 20);
        else
                journal_size = -1;
 
-       if (sb->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA) {
+       if (ext2fs_has_feature_quota(sb)) {
                /* Quotas were enabled. Do quota accounting during fsck. */
-               if ((sb->s_usr_quota_inum && sb->s_grp_quota_inum) ||
-                   (!sb->s_usr_quota_inum && !sb->s_grp_quota_inum))
-                       qtype = -1;
-               else
-                       qtype = sb->s_usr_quota_inum ? USRQUOTA : GRPQUOTA;
-
-               quota_init_context(&ctx->qctx, ctx->fs, qtype);
+               clear_problem_context(&pctx);
+               pctx.errcode = quota_init_context(&ctx->qctx, ctx->fs, 0);
+               if (pctx.errcode) {
+                       fix_problem(ctx, PR_0_QUOTA_INIT_CTX, &pctx);
+                       fatal_error(ctx, 0);
+               }
        }
 
        run_result = e2fsck_run(ctx);
        e2fsck_clear_progbar(ctx);
 
-       if (ctx->flags & E2F_FLAG_JOURNAL_INODE) {
+       if (!ctx->invalid_bitmaps &&
+           (ctx->flags & E2F_FLAG_JOURNAL_INODE)) {
                if (fix_problem(ctx, PR_6_RECREATE_JOURNAL, &pctx)) {
-                       if (journal_size < 1024)
-                               journal_size = ext2fs_default_journal_size(ext2fs_blocks_count(fs->super));
-                       if (journal_size < 0) {
-                               fs->super->s_feature_compat &=
-                                       ~EXT3_FEATURE_COMPAT_HAS_JOURNAL;
-                               fs->flags &= ~EXT2_FLAG_MASTER_SB_ONLY;
-                               log_out(ctx, "%s: Couldn't determine "
-                                       "journal size\n", ctx->program_name);
-                               goto no_journal;
+                       if (journal_size < 1024) {
+                               ext2fs_get_journal_params(&jparams, fs);
+                       } else {
+                               jparams.num_journal_blocks = journal_size;
+                               jparams.num_fc_blocks = 0;
                        }
                        log_out(ctx, _("Creating journal (%d blocks): "),
-                              journal_size);
+                              jparams.num_journal_blocks);
                        fflush(stdout);
-                       retval = ext2fs_add_journal_inode(fs,
-                                                         journal_size, 0);
+                       retval = ext2fs_add_journal_inode3(fs, &jparams, ~0ULL, 0);
                        if (retval) {
                                log_out(ctx, "%s: while trying to create "
                                        "journal\n", error_message(retval));
                                goto no_journal;
                        }
-                       log_out(ctx, _(" Done.\n"));
-                       log_out(ctx, _("\n*** journal has been re-created - "
-                                      "filesystem is now ext3 again ***\n"));
+                       log_out(ctx, "%s", _(" Done.\n"));
+                       log_out(ctx, "%s",
+                               _("\n*** journal has been regenerated ***\n"));
                }
        }
 no_journal:
 
-       if (ctx->qctx) {
-               int i, needs_writeout;
-               for (i = 0; i < MAXQUOTAS; i++) {
-                       if (qtype != -1 && qtype != i)
+       if (run_result & E2F_FLAG_ABORT) {
+               fatal_error(ctx, _("aborted"));
+       } else if (run_result & E2F_FLAG_CANCEL) {
+               log_out(ctx, _("%s: e2fsck canceled.\n"), ctx->device_name ?
+                       ctx->device_name : ctx->filesystem_name);
+               exit_value |= FSCK_CANCELED;
+       } else if (ctx->qctx && !ctx->invalid_bitmaps) {
+               int needs_writeout;
+
+               for (qtype = 0; qtype < MAXQUOTAS; qtype++) {
+                       if (*quota_sb_inump(sb, qtype) == 0)
                                continue;
                        needs_writeout = 0;
-                       pctx.num = i;
-                       retval = quota_compare_and_update(ctx->qctx, i,
+                       pctx.num = qtype;
+                       retval = quota_compare_and_update(ctx->qctx, qtype,
                                                          &needs_writeout);
                        if ((retval || needs_writeout) &&
-                           fix_problem(ctx, PR_6_UPDATE_QUOTAS, &pctx))
-                               quota_write_inode(ctx->qctx, i);
+                           fix_problem(ctx, PR_6_UPDATE_QUOTAS, &pctx)) {
+                               pctx.errcode = quota_write_inode(ctx->qctx,
+                                                                1 << qtype);
+                               if (pctx.errcode)
+                                       (void) fix_problem(ctx,
+                                               PR_6_WRITE_QUOTAS, &pctx);
+                       }
                }
                quota_release_context(&ctx->qctx);
        }
 
        if (run_result == E2F_FLAG_RESTART) {
-               log_out(ctx, _("Restarting e2fsck from the beginning...\n"));
+               log_out(ctx, "%s",
+                       _("Restarting e2fsck from the beginning...\n"));
                retval = e2fsck_reset_context(ctx);
                if (retval) {
-                       com_err(ctx->program_name, retval,
+                       com_err(ctx->program_name, retval, "%s",
                                _("while resetting context"));
                        fatal_error(ctx, 0);
                }
-               ext2fs_close(fs);
+               ext2fs_close_free(&ctx->fs);
                goto restart;
        }
-       if (run_result & E2F_FLAG_CANCEL) {
-               log_out(ctx, _("%s: e2fsck canceled.\n"), ctx->device_name ?
-                       ctx->device_name : ctx->filesystem_name);
-               exit_value |= FSCK_CANCELED;
-       }
-       if (run_result & E2F_FLAG_ABORT)
-               fatal_error(ctx, _("aborted"));
-       if (check_backup_super_block(ctx)) {
-               fs->flags &= ~EXT2_FLAG_MASTER_SB_ONLY;
-               ext2fs_mark_super_dirty(fs);
-       }
 
 #ifdef MTRACE
        mtrace_print("Cleanup");
 #endif
-       if (ext2fs_test_changed(fs)) {
-               exit_value |= FSCK_NONDESTRUCT;
-               if (!(ctx->options & E2F_OPT_PREEN))
-                       log_out(ctx, _("\n%s: ***** FILE SYSTEM WAS "
-                                      "MODIFIED *****\n"),
+       was_changed = ext2fs_test_changed(fs);
+       if (!(ctx->flags & E2F_FLAG_RUN_RETURN) &&
+           !(ctx->options & E2F_OPT_READONLY)) {
+               if (ext2fs_test_valid(fs)) {
+                       if (!(sb->s_state & EXT2_VALID_FS))
+                               exit_value |= FSCK_NONDESTRUCT;
+                       sb->s_state = EXT2_VALID_FS;
+                       if (check_backup_super_block(ctx))
+                               fs->flags &= ~EXT2_FLAG_MASTER_SB_ONLY;
+               } else
+                       sb->s_state &= ~EXT2_VALID_FS;
+               if (!(ctx->flags & E2F_FLAG_TIME_INSANE))
+                       sb->s_lastcheck = ctx->now;
+               sb->s_mnt_count = 0;
+               memset(((char *) sb) + EXT4_S_ERR_START, 0, EXT4_S_ERR_LEN);
+               pctx.errcode = ext2fs_set_gdt_csum(ctx->fs);
+               if (pctx.errcode)
+                       fix_problem(ctx, PR_6_SET_BG_CHECKSUM, &pctx);
+               ext2fs_mark_super_dirty(fs);
+       }
+
+       if (ext2fs_has_feature_shared_blocks(ctx->fs->super) &&
+           (ctx->options & E2F_OPT_UNSHARE_BLOCKS) &&
+           (ctx->options & E2F_OPT_NO))
+               /* Don't try to write or flush I/O, we just wanted to know whether or
+                * not there were enough free blocks to undo deduplication.
+                */
+               goto skip_write;
+
+       if (!(ctx->options & E2F_OPT_READONLY)) {
+               e2fsck_write_bitmaps(ctx);
+               if (fs->flags & EXT2_FLAG_DIRTY) {
+                       pctx.errcode = ext2fs_flush(ctx->fs);
+                       if (pctx.errcode)
+                               fix_problem(ctx, PR_6_FLUSH_FILESYSTEM, &pctx);
+               }
+               pctx.errcode = io_channel_flush(ctx->fs->io);
+               if (pctx.errcode)
+                       fix_problem(ctx, PR_6_IO_FLUSH, &pctx);
+       }
+
+       if (was_changed) {
+               int fs_fixed = (ctx->flags & E2F_FLAG_PROBLEMS_FIXED);
+
+               if (fs_fixed)
+                       exit_value |= FSCK_NONDESTRUCT;
+               if (!(ctx->options & E2F_OPT_PREEN)) {
+#if 0  /* Do this later; it breaks too many tests' golden outputs */
+                       log_out(ctx, fs_fixed ?
+                               _("\n%s: ***** FILE SYSTEM ERRORS "
+                                 "CORRECTED *****\n") :
+                               _("%s: File system was modified.\n"),
                                ctx->device_name);
+#else
+                       log_out(ctx,
+                               _("\n%s: ***** FILE SYSTEM WAS MODIFIED *****\n"),
+                               ctx->device_name);
+#endif
+               }
                if (ctx->mount_flags & EXT2_MF_ISROOT) {
-                       log_out(ctx, _("%s: ***** REBOOT LINUX *****\n"),
+                       log_out(ctx, _("%s: ***** REBOOT SYSTEM *****\n"),
                                ctx->device_name);
                        exit_value |= FSCK_REBOOT;
                }
        }
+
+skip_write:
        if (!ext2fs_test_valid(fs) ||
            ((exit_value & FSCK_CANCELED) &&
             (sb->s_state & EXT2_ERROR_FS))) {
@@ -1733,43 +2123,16 @@ no_journal:
                    (sb->s_state & EXT2_VALID_FS) &&
                    !(sb->s_state & EXT2_ERROR_FS))
                        exit_value = 0;
-       } else {
+       } else
                show_stats(ctx);
-               if (!(ctx->options & E2F_OPT_READONLY)) {
-                       if (ext2fs_test_valid(fs)) {
-                               if (!(sb->s_state & EXT2_VALID_FS))
-                                       exit_value |= FSCK_NONDESTRUCT;
-                               sb->s_state = EXT2_VALID_FS;
-                       } else
-                               sb->s_state &= ~EXT2_VALID_FS;
-                       sb->s_mnt_count = 0;
-                       if (!(ctx->flags & E2F_FLAG_TIME_INSANE))
-                               sb->s_lastcheck = ctx->now;
-                       memset(((char *) sb) + EXT4_S_ERR_START, 0,
-                              EXT4_S_ERR_LEN);
-                       ext2fs_mark_super_dirty(fs);
-               }
-       }
 
-       if ((run_result & E2F_FLAG_CANCEL) == 0 &&
-           ext2fs_has_group_desc_csum(ctx->fs) &&
-           !(ctx->options & E2F_OPT_READONLY)) {
-               retval = ext2fs_set_gdt_csum(ctx->fs);
-               if (retval) {
-                       com_err(ctx->program_name, retval,
-                               _("while setting block group checksum info"));
-                       fatal_error(ctx, 0);
-               }
-       }
-
-       e2fsck_write_bitmaps(ctx);
-       io_channel_flush(ctx->fs->io);
        print_resource_track(ctx, NULL, &ctx->global_rtrack, ctx->fs->io);
 
-       ext2fs_close(fs);
-       ctx->fs = NULL;
+       ext2fs_close_free(&ctx->fs);
        free(ctx->journal_name);
 
+       if (ctx->logf)
+               fprintf(ctx->logf, "Exit status: %d\n", exit_value);
        e2fsck_free_context(ctx);
        remove_error_table(&et_ext2_error_table);
        remove_error_table(&et_prof_error_table);