Whamcloud - gitweb
Merge branch 'maint' into next
[tools/e2fsprogs.git] / e2fsck / unix.c
index 4f73a4b..a6c8d25 100644 (file)
@@ -33,9 +33,6 @@ extern int optind;
 #ifdef HAVE_ERRNO_H
 #include <errno.h>
 #endif
-#ifdef HAVE_MNTENT_H
-#include <mntent.h>
-#endif
 #ifdef HAVE_SYS_IOCTL_H
 #include <sys/ioctl.h>
 #endif
@@ -105,8 +102,9 @@ static void show_stats(e2fsck_t     ctx)
        blk64_t blocks, blocks_used;
        unsigned int dir_links;
        unsigned int num_files, num_links;
+       __u32 *mask, m;
        int frag_percent_file, frag_percent_dir, frag_percent_total;
-       int i, j;
+       int i, j, printed = 0;
 
        dir_links = 2 * ctx->fs_directory_count - 1;
        num_files = ctx->fs_total_count - dir_links;
@@ -137,21 +135,40 @@ static void show_stats(e2fsck_t   ctx)
                        blocks_used, blocks);
                return;
        }
-       log_out(ctx, P_("\n%8u inode used (%2.2f%%)\n",
-                       "\n%8u inodes used (%2.2f%%)\n",
+       profile_get_boolean(ctx->profile, "options", "report_features", 0, 0,
+                           &i);
+       if (verbose && i) {
+               log_out(ctx, "\nFilesystem features:");
+               mask = &ctx->fs->super->s_feature_compat;
+               for (i = 0; i < 3; i++, mask++) {
+                       for (j = 0, m = 1; j < 32; j++, m <<= 1) {
+                               if (*mask & m) {
+                                       log_out(ctx, " %s",
+                                               e2p_feature2string(i, m));
+                                       printed++;
+                               }
+                       }
+               }
+               if (printed == 0)
+                       log_out(ctx, " (none)");
+               log_out(ctx, "\n");
+       }
+
+       log_out(ctx, P_("\n%12u inode used (%2.2f%%, out of %u)\n",
+                       "\n%12u inodes used (%2.2f%%, out of %u)\n",
                        inodes_used), inodes_used,
-               100.0 * inodes_used / inodes);
-       log_out(ctx, P_("%8u non-contiguous file (%0d.%d%%)\n",
-                       "%8u non-contiguous files (%0d.%d%%)\n",
+               100.0 * inodes_used / inodes, inodes);
+       log_out(ctx, P_("%12u non-contiguous file (%0d.%d%%)\n",
+                       "%12u non-contiguous files (%0d.%d%%)\n",
                        ctx->fs_fragmented),
                ctx->fs_fragmented, frag_percent_file / 10,
                frag_percent_file % 10);
-       log_out(ctx, P_("%8u non-contiguous directory (%0d.%d%%)\n",
-                       "%8u non-contiguous directories (%0d.%d%%)\n",
+       log_out(ctx, P_("%12u non-contiguous directory (%0d.%d%%)\n",
+                       "%12u non-contiguous directories (%0d.%d%%)\n",
                        ctx->fs_fragmented_dir),
                ctx->fs_fragmented_dir, frag_percent_dir / 10,
                frag_percent_dir % 10);
-       log_out(ctx, _("         # of inodes with ind/dind/tind blocks: "
+       log_out(ctx, _("             # of inodes with ind/dind/tind blocks: "
                       "%u/%u/%u\n"),
                ctx->fs_ind_count, ctx->fs_dind_count, ctx->fs_tind_count);
 
@@ -159,7 +176,7 @@ static void show_stats(e2fsck_t     ctx)
                if (ctx->extent_depth_count[j])
                        break;
        if (++j) {
-               log_out(ctx, _("         Extent depth histogram: "));
+               log_out(ctx, _("             Extent depth histogram: "));
                for (i=0; i < j; i++) {
                        if (i)
                                fputc('/', stdout);
@@ -168,39 +185,39 @@ static void show_stats(e2fsck_t   ctx)
                log_out(ctx, "\n");
        }
 
-       log_out(ctx, P_("%8llu block used (%2.2f%%)\n",
-                       "%8llu blocks used (%2.2f%%)\n",
-                  blocks_used), blocks_used, 100.0 * blocks_used / blocks);
-       log_out(ctx, P_("%8u bad block\n", "%8u bad blocks\n",
+       log_out(ctx, P_("%12llu block used (%2.2f%%, out of %llu)\n",
+                       "%12llu blocks used (%2.2f%%, out of %llu)\n",
+                  blocks_used),
+               blocks_used, 100.0 * blocks_used / blocks, blocks);
+       log_out(ctx, P_("%12u bad block\n", "%12u bad blocks\n",
                        ctx->fs_badblocks_count), ctx->fs_badblocks_count);
-       log_out(ctx, P_("%8u large file\n", "%8u large files\n",
+       log_out(ctx, P_("%12u large file\n", "%12u large files\n",
                        ctx->large_files), ctx->large_files);
-       log_out(ctx, P_("\n%8u regular file\n", "\n%8u regular files\n",
+       log_out(ctx, P_("\n%12u regular file\n", "\n%12u regular files\n",
                        ctx->fs_regular_count), ctx->fs_regular_count);
-       log_out(ctx, P_("%8u directory\n", "%8u directories\n",
+       log_out(ctx, P_("%12u directory\n", "%12u directories\n",
                        ctx->fs_directory_count), ctx->fs_directory_count);
-       log_out(ctx, P_("%8u character device file\n",
-                       "%8u character device files\n", ctx->fs_chardev_count),
+       log_out(ctx, P_("%12u character device file\n",
+                       "%12u character device files\n", ctx->fs_chardev_count),
                ctx->fs_chardev_count);
-       log_out(ctx, P_("%8u block device file\n", "%8u block device files\n",
+       log_out(ctx, P_("%12u block device file\n", "%12u block device files\n",
                        ctx->fs_blockdev_count), ctx->fs_blockdev_count);
-       log_out(ctx, P_("%8u fifo\n", "%8u fifos\n", ctx->fs_fifo_count),
+       log_out(ctx, P_("%12u fifo\n", "%12u fifos\n", ctx->fs_fifo_count),
                ctx->fs_fifo_count);
-       log_out(ctx, P_("%8u link\n", "%8u links\n",
-                       ctx->fs_links_count - dir_links),
+       log_out(ctx, P_("%12u link\n", "%12u links\n", num_links),
                ctx->fs_links_count - dir_links);
-       log_out(ctx, P_("%8u symbolic link", "%8u symbolic links",
+       log_out(ctx, P_("%12u symbolic link", "%12u symbolic links",
                        ctx->fs_symlinks_count), ctx->fs_symlinks_count);
        log_out(ctx, P_(" (%u fast symbolic link)\n",
                        " (%u fast symbolic links)\n",
                        ctx->fs_fast_symlinks_count),
                ctx->fs_fast_symlinks_count);
-       log_out(ctx, P_("%8u socket\n", "%8u sockets\n", ctx->fs_sockets_count),
+       log_out(ctx, P_("%12u socket\n", "%12u sockets\n",
+                       ctx->fs_sockets_count),
                ctx->fs_sockets_count);
-       log_out(ctx, "--------\n");
-       log_out(ctx, P_("%8u file\n", "%8u files\n",
-                       ctx->fs_total_count - dir_links),
-               ctx->fs_total_count - dir_links);
+       log_out(ctx, "------------\n");
+       log_out(ctx, P_("%12u file\n", "%12u files\n", num_files),
+               num_files);
 }
 
 static void check_mount(e2fsck_t ctx)
@@ -222,21 +239,26 @@ static void check_mount(e2fsck_t ctx)
         * filesystem and it's mounted read-only, and we're not doing
         * a read/write check, then everything's fine.
         */
-       if ((!(ctx->mount_flags & EXT2_MF_MOUNTED)) ||
+       if ((!(ctx->mount_flags & (EXT2_MF_MOUNTED | EXT2_MF_BUSY))) ||
            ((ctx->mount_flags & EXT2_MF_ISROOT) &&
             (ctx->mount_flags & EXT2_MF_READONLY) &&
             !(ctx->options & E2F_OPT_WRITECHECK)))
                return;
 
-       if ((ctx->options & E2F_OPT_READONLY) &&
+       if (((ctx->options & E2F_OPT_READONLY) ||
+            ((ctx->options & E2F_OPT_FORCE) &&
+             (ctx->mount_flags & EXT2_MF_READONLY))) &&
            !(ctx->options & E2F_OPT_WRITECHECK)) {
-               log_out(ctx, _("Warning!  %s is mounted.\n"),
-                       ctx->filesystem_name);
+               log_out(ctx, _("Warning!  %s is %s.\n"),
+                       ctx->filesystem_name,
+                       ctx->mount_flags & EXT2_MF_MOUNTED ?
+                               "mounted" : "in use");
                return;
        }
 
-       log_out(ctx, _("%s is mounted.  "), ctx->filesystem_name);
-       if (!ctx->interactive)
+       log_out(ctx, _("%s is %s.\n"), ctx->filesystem_name,
+               ctx->mount_flags & EXT2_MF_MOUNTED ? "mounted" : "in use");
+       if (!ctx->interactive || ctx->mount_flags & EXT2_MF_BUSY)
                fatal_error(ctx, _("Cannot continue, aborting.\n\n"));
        puts("\007\007\007\007");
        log_out(ctx, _("\n\nWARNING!!!  "
@@ -262,7 +284,7 @@ static int is_on_batt(void)
 
        f = fopen("/sys/class/power_supply/AC/online", "r");
        if (f) {
-               if (fscanf(f, "%d\n", &acflag) == 1) {
+               if (fscanf(f, "%u\n", &acflag) == 1) {
                        fclose(f);
                        return (!acflag);
                }
@@ -918,6 +940,15 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
        profile_set_syntax_err_cb(syntax_err_report);
        profile_init(config_fn, &ctx->profile);
 
+       profile_get_boolean(ctx->profile, "options", "report_time", 0, 0,
+                           &c);
+       if (c)
+               ctx->options |= E2F_OPT_TIME | E2F_OPT_TIME2;
+       profile_get_boolean(ctx->profile, "options", "report_verbose", 0, 0,
+                           &c);
+       if (c)
+               verbose = 1;
+
        /* Turn off discard in read-only mode */
        if ((ctx->options & E2F_OPT_NO) &&
            (ctx->options & E2F_OPT_DISCARD))
@@ -1031,7 +1062,7 @@ static errcode_t try_open_fs(e2fsck_t ctx, int flags, io_manager io_ptr,
                retval = ext2fs_open2(ctx->filesystem_name, ctx->io_options,
                                      flags, 0, 0, io_ptr, ret_fs);
 
-       if (ret_fs)
+       if (retval == 0)
                e2fsck_set_bitmap_type(*ret_fs, EXT2FS_BMAP64_RBTREE,
                                       "default", NULL);
        return retval;
@@ -1040,7 +1071,7 @@ static errcode_t try_open_fs(e2fsck_t ctx, int flags, io_manager io_ptr,
 static const char *my_ver_string = E2FSPROGS_VERSION;
 static const char *my_ver_date = E2FSPROGS_DATE;
 
-int e2fsck_check_mmp(ext2_filsys fs, e2fsck_t ctx)
+static errcode_t e2fsck_check_mmp(ext2_filsys fs, e2fsck_t ctx)
 {
        struct mmp_struct *mmp_s;
        unsigned int mmp_check_interval;
@@ -1118,6 +1149,11 @@ check_error:
                        ext2fs_mmp_clear(fs);
                        retval = 0;
                }
+       } else if (retval == EXT2_ET_MMP_CSUM_INVALID) {
+               if (fix_problem(ctx, PR_0_MMP_CSUM_INVALID, &pctx)) {
+                       ext2fs_mmp_clear(fs);
+                       retval = 0;
+               }
        }
        return retval;
 }
@@ -1132,7 +1168,7 @@ int main (int argc, char *argv[])
        const char      *lib_ver_date;
        int             my_ver, lib_ver;
        e2fsck_t        ctx;
-       blk_t           orig_superblock;
+       blk64_t         orig_superblock;
        struct problem_context pctx;
        int flags, run_result;
        int journal_size;
@@ -1140,6 +1176,7 @@ int main (int argc, char *argv[])
        int old_bitmaps;
        __u32 features[3];
        char *cp;
+       int qtype = -99;  /* quota type */
 
        clear_problem_context(&pctx);
        sigcatcher_setup();
@@ -1220,19 +1257,34 @@ restart:
                            &old_bitmaps);
        if (!old_bitmaps)
                flags |= EXT2_FLAG_64BITS;
-       if ((ctx->options & E2F_OPT_READONLY) == 0)
+       if ((ctx->options & E2F_OPT_READONLY) == 0) {
                flags |= EXT2_FLAG_RW;
-       if ((ctx->mount_flags & EXT2_MF_MOUNTED) == 0)
-               flags |= EXT2_FLAG_EXCLUSIVE;
+               if (!(ctx->mount_flags & EXT2_MF_ISROOT &&
+                     ctx->mount_flags & EXT2_MF_READONLY))
+                       flags |= EXT2_FLAG_EXCLUSIVE;
+               if ((ctx->mount_flags & EXT2_MF_READONLY) &&
+                   (ctx->options & E2F_OPT_FORCE))
+                       flags &= ~EXT2_FLAG_EXCLUSIVE;
+       }
 
        retval = try_open_fs(ctx, flags, io_ptr, &fs);
 
        if (!ctx->superblock && !(ctx->options & E2F_OPT_PREEN) &&
            !(ctx->flags & E2F_FLAG_SB_SPECIFIED) &&
            ((retval == EXT2_ET_BAD_MAGIC) ||
+            (retval == EXT2_ET_SB_CSUM_INVALID) ||
             (retval == EXT2_ET_CORRUPT_SUPERBLOCK) ||
             ((retval == 0) && (retval2 = ext2fs_check_desc(fs))))) {
-               if (retval2 == ENOMEM) {
+               if (retval) {
+                       pctx.errcode = retval;
+                       fix_problem(ctx, PR_0_OPEN_FAILED, &pctx);
+               }
+               if (retval2) {
+                       pctx.errcode = retval2;
+                       fix_problem(ctx, PR_0_CHECK_DESC_FAILED, &pctx);
+               }
+               pctx.errcode = 0;
+               if (retval2 == ENOMEM || retval2 == EXT2_ET_NO_MEMORY) {
                        retval = retval2;
                        goto failure;
                }
@@ -1398,12 +1450,10 @@ failure:
            (flags & EXT2_FLAG_SKIP_MMP)) {
                if (e2fsck_check_mmp(fs, ctx))
                        fatal_error(ctx, 0);
-       }
 
-        /*
-         * Restart in order to reopen fs but this time start mmp.
-         */
-       if (flags & EXT2_FLAG_SKIP_MMP) {
+               /*
+                * Restart in order to reopen fs but this time start mmp.
+                */
                ext2fs_close(fs);
                ctx->fs = NULL;
                flags &= ~EXT2_FLAG_SKIP_MMP;
@@ -1414,10 +1464,6 @@ failure:
                fprintf(ctx->logf, "Filesystem UUID: %s\n",
                        e2p_uuid2str(sb->s_uuid));
 
-       if ((ctx->mount_flags & EXT2_MF_MOUNTED) &&
-           !(sb->s_feature_incompat & EXT3_FEATURE_INCOMPAT_RECOVER))
-               goto skip_journal;
-
        /*
         * Make sure the ext3 superblock fields are consistent.
         */
@@ -1465,7 +1511,6 @@ failure:
                }
        }
 
-skip_journal:
        /*
         * Check for compatibility with the feature sets.  We need to
         * be more stringent than ext2fs_open().
@@ -1571,7 +1616,6 @@ print_unsupp_features:
                journal_size = -1;
 
        if (sb->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA) {
-               int qtype;
                /* Quotas were enabled. Do quota accounting during fsck. */
                if ((sb->s_usr_quota_inum && sb->s_grp_quota_inum) ||
                    (!sb->s_usr_quota_inum && !sb->s_grp_quota_inum))
@@ -1615,7 +1659,18 @@ print_unsupp_features:
 no_journal:
 
        if (ctx->qctx) {
-               quota_write_inode(ctx->qctx, -1);
+               int i, needs_writeout;
+               for (i = 0; i < MAXQUOTAS; i++) {
+                       if (qtype != -1 && qtype != i)
+                               continue;
+                       needs_writeout = 0;
+                       pctx.num = i;
+                       retval = quota_compare_and_update(ctx->qctx, i,
+                                                         &needs_writeout);
+                       if ((retval || needs_writeout) &&
+                           fix_problem(ctx, PR_6_UPDATE_QUOTAS, &pctx))
+                               quota_write_inode(ctx->qctx, i);
+               }
                quota_release_context(&ctx->qctx);
        }
 
@@ -1695,7 +1750,7 @@ no_journal:
        }
 
        if ((run_result & E2F_FLAG_CANCEL) == 0 &&
-           sb->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_GDT_CSUM &&
+           ext2fs_has_group_desc_csum(ctx->fs) &&
            !(ctx->options & E2F_OPT_READONLY)) {
                retval = ext2fs_set_gdt_csum(ctx->fs);
                if (retval) {