Whamcloud - gitweb
e2fsck: add support for dirdata feature
[tools/e2fsprogs.git] / e2fsck / unix.c
index 3f3479c..4cda592 100644 (file)
@@ -45,12 +45,16 @@ extern int optind;
 #ifdef HAVE_DIRENT_H
 #include <dirent.h>
 #endif
+#include <libgen.h>
 
 #include "e2p/e2p.h"
 #include "et/com_err.h"
 #include "e2p/e2p.h"
+#include "uuid/uuid.h"
+#include "support/plausible.h"
 #include "e2fsck.h"
 #include "problem.h"
+#include "jfs_user.h"
 #include "../version.h"
 
 /* Command line options */
@@ -64,21 +68,23 @@ static char *bad_blocks_file;
 
 e2fsck_t e2fsck_global_ctx;    /* Try your very best not to use this! */
 
-#ifdef CONFIG_JBD_DEBUG                /* Enabled by configure --enable-jfs-debug */
+#ifdef CONFIG_JBD_DEBUG                /* Enabled by configure --enable-jbd-debug */
 int journal_enable_debug = -1;
 #endif
 
 static void usage(e2fsck_t ctx)
 {
        fprintf(stderr,
-               _("Usage: %s [-panyrcdfvtDFV] [-b superblock] [-B blocksize]\n"
-               "\t\t[-I inode_buffer_blocks] [-P process_inode_size]\n"
+               _("Usage: %s [-pamnyrcdfktvDFV] [-b superblock] [-B blocksize]\n"
                "\t\t[-l|-L bad_blocks_file] [-C fd] [-j external_journal]\n"
-               "\t\t[-E extended-options] device\n"),
+               "\t\t[-E extended-options] [-z undo_file] device\n"),
                ctx->program_name);
 
        fprintf(stderr, "%s", _("\nEmergency help:\n"
                " -p                   Automatic repair (no questions)\n"
+#ifdef HAVE_PTHREAD
+               " -m                   multiple threads to speedup fsck\n"
+#endif
                " -n                   Make no changes to the filesystem\n"
                " -y                   Assume \"yes\" to all questions\n"
                " -c                   Check for bad blocks and add them to the badblock list\n"
@@ -90,6 +96,7 @@ static void usage(e2fsck_t ctx)
                " -j external_journal  Set location of the external journal\n"
                " -l bad_blocks_file   Add to badblocks list\n"
                " -L bad_blocks_file   Set badblocks list\n"
+               " -z undo_file         Create an undo file\n"
                ));
 
        exit(FSCK_USAGE);
@@ -103,7 +110,7 @@ static void show_stats(e2fsck_t     ctx)
        unsigned int dir_links;
        unsigned int num_files, num_links;
        __u32 *mask, m;
-       int frag_percent_file, frag_percent_dir, frag_percent_total;
+       int frag_percent_file = 0, frag_percent_dir = 0, frag_percent_total = 0;
        int i, j, printed = 0;
 
        dir_links = 2 * ctx->fs_directory_count - 1;
@@ -116,23 +123,26 @@ static void show_stats(e2fsck_t   ctx)
        blocks_used = (ext2fs_blocks_count(fs->super) -
                       ext2fs_free_blocks_count(fs->super));
 
-       frag_percent_file = (10000 * ctx->fs_fragmented) / inodes_used;
-       frag_percent_file = (frag_percent_file + 5) / 10;
+       if (inodes_used > 0) {
+               frag_percent_file = (10000 * ctx->fs_fragmented) / inodes_used;
+               frag_percent_file = (frag_percent_file + 5) / 10;
 
-       frag_percent_dir = (10000 * ctx->fs_fragmented_dir) / inodes_used;
-       frag_percent_dir = (frag_percent_dir + 5) / 10;
+               frag_percent_dir = (10000 * ctx->fs_fragmented_dir) / inodes_used;
+               frag_percent_dir = (frag_percent_dir + 5) / 10;
 
-       frag_percent_total = ((10000 * (ctx->fs_fragmented +
-                                       ctx->fs_fragmented_dir))
-                             / inodes_used);
-       frag_percent_total = (frag_percent_total + 5) / 10;
+               frag_percent_total = ((10000 * (ctx->fs_fragmented +
+                                               ctx->fs_fragmented_dir))
+                                     / inodes_used);
+               frag_percent_total = (frag_percent_total + 5) / 10;
+       }
 
        if (!verbose) {
                log_out(ctx, _("%s: %u/%u files (%0d.%d%% non-contiguous), "
                               "%llu/%llu blocks\n"),
                        ctx->device_name, inodes_used, inodes,
                        frag_percent_total / 10, frag_percent_total % 10,
-                       blocks_used, blocks);
+                       (unsigned long long) blocks_used,
+                       (unsigned long long) blocks);
                return;
        }
        profile_get_boolean(ctx->profile, "options", "report_features", 0, 0,
@@ -188,7 +198,8 @@ static void show_stats(e2fsck_t     ctx)
        log_out(ctx, P_("%12llu block used (%2.2f%%, out of %llu)\n",
                        "%12llu blocks used (%2.2f%%, out of %llu)\n",
                   blocks_used),
-               blocks_used, 100.0 * blocks_used / blocks, blocks);
+               (unsigned long long) blocks_used, 100.0 * blocks_used / blocks,
+               (unsigned long long) blocks);
        log_out(ctx, P_("%12u bad block\n", "%12u bad blocks\n",
                        ctx->fs_badblocks_count), ctx->fs_badblocks_count);
        log_out(ctx, P_("%12u large file\n", "%12u large files\n",
@@ -282,7 +293,7 @@ static int is_on_batt(void)
 {
        FILE    *f;
        DIR     *d;
-       char    tmp[80], tmp2[80], fname[80];
+       char    tmp[80], tmp2[80], fname[NAME_MAX+30];
        unsigned int    acflag;
        struct dirent*  de;
 
@@ -306,7 +317,8 @@ static int is_on_batt(void)
                while ((de=readdir(d)) != NULL) {
                        if (!strncmp(".", de->d_name, 1))
                                continue;
-                       snprintf(fname, 80, "/proc/acpi/ac_adapter/%s/state",
+                       snprintf(fname, sizeof(fname),
+                                "/proc/acpi/ac_adapter/%s/state",
                                 de->d_name);
                        f = fopen(fname, "r");
                        if (!f)
@@ -391,7 +403,12 @@ static void check_if_skip(e2fsck_t ctx)
                if (batt && ((ctx->now - fs->super->s_lastcheck) <
                             fs->super->s_checkinterval*2))
                        reason = 0;
+       } else if (broken_system_clock && fs->super->s_checkinterval) {
+               log_out(ctx, "%s: ", ctx->device_name);
+               log_out(ctx, "%s",
+                       _("ignoring check interval, broken_system_clock set\n"));
        }
+
        if (reason) {
                log_out(ctx, "%s", ctx->device_name);
                log_out(ctx, reason, reason_arg);
@@ -432,9 +449,9 @@ static void check_if_skip(e2fsck_t ctx)
                ctx->device_name,
                fs->super->s_inodes_count - fs->super->s_free_inodes_count,
                fs->super->s_inodes_count,
-               ext2fs_blocks_count(fs->super) -
+               (unsigned long long) ext2fs_blocks_count(fs->super) -
                ext2fs_free_blocks_count(fs->super),
-               ext2fs_blocks_count(fs->super));
+               (unsigned long long) ext2fs_blocks_count(fs->super));
        next_check = 100000;
        if (fs->super->s_max_mnt_count > 0) {
                next_check = fs->super->s_max_mnt_count - fs->super->s_mnt_count;
@@ -458,8 +475,7 @@ static void check_if_skip(e2fsck_t ctx)
        }
        log_out(ctx, "\n");
 skip:
-       ext2fs_close(fs);
-       ctx->fs = NULL;
+       ext2fs_close_free(&ctx->fs);
        e2fsck_free_context(ctx);
        exit(FSCK_OK);
 }
@@ -607,9 +623,10 @@ static void reserve_stdio_fds(void)
                        fprintf(stderr, _("ERROR: Couldn't open "
                                "/dev/null (%s)\n"),
                                strerror(errno));
-                       break;
+                       return;
                }
        }
+       (void) close(fd);
 }
 
 #ifdef HAVE_SIGNAL_H
@@ -645,11 +662,55 @@ static void signal_cancel(int sig EXT2FS_ATTR((unused)))
 }
 #endif
 
+static void initialize_profile_options(e2fsck_t ctx)
+{
+       char *tmp;
+
+       /* [options] shared=preserve|lost+found|delete */
+       tmp = NULL;
+       ctx->shared = E2F_SHARED_PRESERVE;
+       profile_get_string(ctx->profile, "options", "shared", 0,
+                          "preserve", &tmp);
+       if (tmp) {
+               if (strcmp(tmp, "preserve") == 0)
+                       ctx->shared = E2F_SHARED_PRESERVE;
+               else if (strcmp(tmp, "delete") == 0)
+                       ctx->shared = E2F_SHARED_DELETE;
+               else if (strcmp(tmp, "lost+found") == 0)
+                       ctx->shared = E2F_SHARED_LPF;
+               else {
+                       com_err(ctx->program_name, 0,
+                               _("configuration error: 'shared=%s'"), tmp);
+                       fatal_error(ctx, 0);
+               }
+               free(tmp);
+       }
+
+       /* [options] clone=dup|zero */
+       tmp = NULL;
+       ctx->clone = E2F_CLONE_DUP;
+       profile_get_string(ctx->profile, "options", "clone", 0,
+                          "dup", &tmp);
+       if (tmp) {
+               if (strcmp(tmp, "dup") == 0)
+                       ctx->clone = E2F_CLONE_DUP;
+               else if (strcmp(tmp, "zero") == 0)
+                       ctx->clone = E2F_CLONE_ZERO;
+               else {
+                       com_err(ctx->program_name, 0,
+                               _("configuration error: 'clone=%s'"), tmp);
+                       fatal_error(ctx, 0);
+               }
+               free(tmp);
+       }
+}
+
 static void parse_extended_opts(e2fsck_t ctx, const char *opts)
 {
        char    *buf, *token, *next, *p, *arg;
        int     ea_ver;
        int     extended_usage = 0;
+       unsigned long long reada_kb;
 
        buf = string_copy(ctx, opts, 0);
        for (token = buf; token && *token; token = next) {
@@ -678,9 +739,74 @@ static void parse_extended_opts(e2fsck_t ctx, const char *opts)
                                continue;
                        }
                        ctx->ext_attr_ver = ea_ver;
+               } else if (strcmp(token, "readahead_kb") == 0) {
+                       if (!arg) {
+                               extended_usage++;
+                               continue;
+                       }
+                       reada_kb = strtoull(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr, "%s",
+                                       _("Invalid readahead buffer size.\n"));
+                               extended_usage++;
+                               continue;
+                       }
+                       ctx->readahead_kb = reada_kb;
                } else if (strcmp(token, "fragcheck") == 0) {
                        ctx->options |= E2F_OPT_FRAGCHECK;
                        continue;
+               /* -E shared=preserve|lost+found|delete */
+               } else if (strcmp(token, "shared") == 0) {
+                       if (!arg) {
+                               extended_usage++;
+                               continue;
+                       }
+                       if (strcmp(arg, "preserve") == 0) {
+                               ctx->shared = E2F_SHARED_PRESERVE;
+                       } else if (strcmp(arg, "lost+found") == 0) {
+                               ctx->shared = E2F_SHARED_LPF;
+                       } else if (strcmp(arg, "delete") == 0) {
+                               ctx->shared = E2F_SHARED_DELETE;
+                       } else {
+                               extended_usage++;
+                               continue;
+                       }
+               /* -E clone=dup|zero */
+               } else if (strcmp(token, "clone") == 0) {
+                       if (!arg) {
+                               extended_usage++;
+                               continue;
+                       }
+                       if (strcmp(arg, "dup") == 0) {
+                               ctx->clone = E2F_CLONE_DUP;
+                       } else if (strcmp(arg, "zero") == 0) {
+                               ctx->clone = E2F_CLONE_ZERO;
+                       } else {
+                               extended_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "expand_extra_isize") == 0) {
+                       ctx->flags |= E2F_FLAG_EXPAND_EISIZE;
+                       if (arg) {
+                               extended_usage++;
+                               continue;
+                       }
+               /* -E inode_badness_threshold=<value> */
+               } else if (strcmp(token, "inode_badness_threshold") == 0) {
+                       unsigned int val;
+
+                       if (!arg) {
+                               extended_usage++;
+                               continue;
+                       }
+                       val = strtoul(arg, &p, 0);
+                       if (*p != '\0' || (val < 3 && val != 0) || val > 200) {
+                               fprintf(stderr, _("Invalid badness '%s'\n"),
+                                       arg);
+                               extended_usage++;
+                               continue;
+                       }
+                       ctx->inode_badness_threshold = val;
                } else if (strcmp(token, "journal_only") == 0) {
                        if (arg) {
                                extended_usage++;
@@ -693,12 +819,48 @@ static void parse_extended_opts(e2fsck_t ctx, const char *opts)
                } else if (strcmp(token, "nodiscard") == 0) {
                        ctx->options &= ~E2F_OPT_DISCARD;
                        continue;
+               } else if (strcmp(token, "optimize_extents") == 0) {
+                       ctx->options &= ~E2F_OPT_NOOPT_EXTENTS;
+                       continue;
+               } else if (strcmp(token, "no_optimize_extents") == 0) {
+                       ctx->options |= E2F_OPT_NOOPT_EXTENTS;
+                       continue;
+               } else if (strcmp(token, "inode_count_fullmap") == 0) {
+                       ctx->options |= E2F_OPT_ICOUNT_FULLMAP;
+                       continue;
+               } else if (strcmp(token, "no_inode_count_fullmap") == 0) {
+                       ctx->options &= ~E2F_OPT_ICOUNT_FULLMAP;
+                       continue;
                } else if (strcmp(token, "log_filename") == 0) {
                        if (!arg)
                                extended_usage++;
                        else
                                ctx->log_fn = string_copy(ctx, arg, 0);
                        continue;
+               } else if (strcmp(token, "problem_log") == 0) {
+                       if (!arg)
+                               extended_usage++;
+                       else
+                               ctx->problem_log_fn = string_copy(ctx, arg, 0);
+                       continue;
+               } else if (strcmp(token, "bmap2extent") == 0) {
+                       ctx->options |= E2F_OPT_CONVERT_BMAP;
+                       continue;
+               } else if (strcmp(token, "fixes_only") == 0) {
+                       ctx->options |= E2F_OPT_FIXES_ONLY;
+                       continue;
+               } else if (strcmp(token, "unshare_blocks") == 0) {
+                       ctx->options |= E2F_OPT_UNSHARE_BLOCKS;
+                       ctx->options |= E2F_OPT_FORCE;
+                       continue;
+               } else if (strcmp(token, "check_encoding") == 0) {
+                       ctx->options |= E2F_OPT_CHECK_ENCODING;
+                       continue;
+#ifdef CONFIG_DEVELOPER_FEATURES
+               } else if (strcmp(token, "clear_all_uninit_bits") == 0) {
+                       ctx->options |= E2F_OPT_CLEAR_UNINIT;
+                       continue;
+#endif
                } else {
                        fprintf(stderr, _("Unknown extended option: %s\n"),
                                token);
@@ -708,15 +870,28 @@ static void parse_extended_opts(e2fsck_t ctx, const char *opts)
        free(buf);
 
        if (extended_usage) {
-               fputs(("\nExtended options are separated by commas, "
+               fputs(_("\nExtended options are separated by commas, "
                       "and may take an argument which\n"
                       "is set off by an equals ('=') sign.  "
-                      "Valid extended options are:\n"), stderr);
-               fputs(("\tea_ver=<ea_version (1 or 2)>\n"), stderr);
-               fputs(("\tfragcheck\n"), stderr);
-               fputs(("\tjournal_only\n"), stderr);
-               fputs(("\tdiscard\n"), stderr);
-               fputs(("\tnodiscard\n"), stderr);
+                      "Valid extended options are:\n\n"), stderr);
+               fputs(_("\tea_ver=<ea_version (1 or 2)>\n"), stderr);
+               fputs("\tfragcheck\n", stderr);
+               fputs("\tjournal_only\n", stderr);
+               fputs("\tdiscard\n", stderr);
+               fputs("\tnodiscard\n", stderr);
+               fputs(("\tshared=<preserve|lost+found|delete>\n"), stderr);
+               fputs(("\tclone=<dup|zero>\n"), stderr);
+               fputs(("\texpand_extra_isize\n"), stderr);
+               fputs(("\tinode_badness_threhold=(value)\n"), stderr);
+               fputs("\toptimize_extents\n", stderr);
+               fputs("\tno_optimize_extents\n", stderr);
+               fputs("\tinode_count_fullmap\n", stderr);
+               fputs("\tno_inode_count_fullmap\n", stderr);
+               fputs(_("\treadahead_kb=<buffer size>\n"), stderr);
+               fputs("\tbmap2extent\n", stderr);
+               fputs("\tunshare_blocks\n", stderr);
+               fputs("\tfixes_only\n", stderr);
+               fputs("\tcheck_encoding\n", stderr);
                fputc('\n', stderr);
                exit(1);
        }
@@ -744,12 +919,16 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
 #ifdef HAVE_SIGNAL_H
        struct sigaction        sa;
 #endif
-       char            *extended_opts = 0;
        char            *cp;
        int             res;            /* result of sscanf */
 #ifdef CONFIG_JBD_DEBUG
        char            *jbd_debug;
 #endif
+#ifdef HAVE_PTHREAD
+       char            *pm;
+       unsigned long   thread_num;
+#endif
+       unsigned long long phys_mem_kb, blk;
 
        retval = e2fsck_allocate_context(&ctx);
        if (retval)
@@ -760,7 +939,7 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
 
        setvbuf(stdout, NULL, _IONBF, BUFSIZ);
        setvbuf(stderr, NULL, _IONBF, BUFSIZ);
-       if (isatty(0) && isatty(1)) {
+       if (getenv("E2FSCK_FORCE_INTERACTIVE") || (isatty(0) && isatty(1))) {
                ctx->interactive = 1;
        } else {
                ctx->start_meta[0] = '\001';
@@ -777,7 +956,23 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
        else
                ctx->program_name = "e2fsck";
 
-       while ((c = getopt (argc, argv, "panyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDk")) != EOF)
+       cp = getenv("E2FSCK_CONFIG");
+       if (cp != NULL)
+               config_fn[0] = cp;
+       profile_set_syntax_err_cb(syntax_err_report);
+       profile_init(config_fn, &ctx->profile);
+
+       initialize_profile_options(ctx);
+
+       phys_mem_kb = get_memory_size() / 1024;
+       ctx->readahead_kb = ~0ULL;
+       ctx->inode_badness_threshold = BADNESS_THRESHOLD;
+
+#ifdef HAVE_PTHREAD
+       while ((c = getopt(argc, argv, "pam:nyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDkz:")) != EOF)
+#else
+       while ((c = getopt(argc, argv, "panyrcC:B:dE:fvtFVM:b:I:j:P:l:L:N:SsDkz:")) != EOF)
+#endif
                switch (c) {
                case 'C':
                        ctx->progress = e2fsck_update_progress;
@@ -807,7 +1002,7 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        ctx->options |= E2F_OPT_COMPRESS_DIRS;
                        break;
                case 'E':
-                       extended_opts = optarg;
+                       parse_extended_opts(ctx, optarg);
                        break;
                case 'p':
                case 'a':
@@ -818,6 +1013,22 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        }
                        ctx->options |= E2F_OPT_PREEN;
                        break;
+#ifdef HAVE_PTHREAD
+               case 'm':
+                       thread_num = strtoul(optarg, &pm, 0);
+                       if (*pm)
+                               fatal_error(ctx,
+                                       _("Invalid multiple thread num.\n"));
+                       if (thread_num > E2FSCK_MAX_THREADS) {
+                               fprintf(stderr,
+                                       _("threads %lu too large (max %u)\n"),
+                                       thread_num, E2FSCK_MAX_THREADS);
+                               fatal_error(ctx, 0);
+                       }
+                       ctx->options |= E2F_OPT_MULTITHREAD;
+                       ctx->pfs_num_threads = thread_num;
+                       break;
+#endif
                case 'n':
                        if (ctx->options & (E2F_OPT_YES|E2F_OPT_PREEN))
                                goto conflict_opt;
@@ -848,7 +1059,8 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        /* What we do by default, anyway! */
                        break;
                case 'b':
-                       res = sscanf(optarg, "%llu", &ctx->use_superblock);
+                       res = sscanf(optarg, "%llu", &blk);
+                       ctx->use_superblock = blk;
                        if (res != 1)
                                goto sscanf_err;
                        ctx->flags |= E2F_FLAG_SB_SPECIFIED;
@@ -878,6 +1090,7 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        break;
                case 'L':
                        replace_bad_blocks++;
+                       /* fall through */
                case 'l':
                        if (bad_blocks_file)
                                free(bad_blocks_file);
@@ -909,6 +1122,9 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                case 'k':
                        keep_bad_blocks++;
                        break;
+               case 'z':
+                       ctx->undo_file = optarg;
+                       break;
                default:
                        usage(ctx);
                }
@@ -932,6 +1148,20 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        _("The -n and -l/-L options are incompatible."));
                fatal_error(ctx, 0);
        }
+#ifdef HAVE_PTHREAD
+       if (ctx->options & E2F_OPT_MULTITHREAD) {
+               if ((ctx->options & (E2F_OPT_YES|E2F_OPT_NO|E2F_OPT_PREEN)) == 0) {
+                       com_err(ctx->program_name, 0, "%s",
+                               _("The -m option should be used together with one of -p/-y/-n options."));
+                       fatal_error(ctx, 0);
+               }
+               if (ctx->progress) {
+                       com_err(ctx->program_name, 0, "%s",
+                               _("Only one of the options -C or -m may be specified."));
+                       fatal_error(ctx, 0);
+               }
+       }
+#endif
        if (ctx->options & E2F_OPT_NO)
                ctx->options |= E2F_OPT_READONLY;
 
@@ -944,13 +1174,22 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
                        argv[optind]);
                fatal_error(ctx, 0);
        }
-       if (extended_opts)
-               parse_extended_opts(ctx, extended_opts);
 
-       if ((cp = getenv("E2FSCK_CONFIG")) != NULL)
-               config_fn[0] = cp;
-       profile_set_syntax_err_cb(syntax_err_report);
-       profile_init(config_fn, &ctx->profile);
+       /* Complain about mutually exclusive rebuilding activities */
+       if (getenv("E2FSCK_FIXES_ONLY"))
+               ctx->options |= E2F_OPT_FIXES_ONLY;
+       if ((ctx->options & E2F_OPT_COMPRESS_DIRS) &&
+           (ctx->options & E2F_OPT_FIXES_ONLY)) {
+               com_err(ctx->program_name, 0, "%s",
+                       _("The -D and -E fixes_only options are incompatible."));
+               fatal_error(ctx, 0);
+       }
+       if ((ctx->options & E2F_OPT_CONVERT_BMAP) &&
+           (ctx->options & E2F_OPT_FIXES_ONLY)) {
+               com_err(ctx->program_name, 0, "%s",
+                       _("The -E bmap2extent and fixes_only options are incompatible."));
+               fatal_error(ctx, 0);
+       }
 
        profile_get_boolean(ctx->profile, "options", "report_time", 0, 0,
                            &c);
@@ -961,6 +1200,30 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
        if (c)
                verbose = 1;
 
+       profile_get_boolean(ctx->profile, "options", "no_optimize_extents",
+                           0, 0, &c);
+       if (c)
+               ctx->options |= E2F_OPT_NOOPT_EXTENTS;
+
+       profile_get_boolean(ctx->profile, "options", "inode_count_fullmap",
+                           0, 0, &c);
+       if (c)
+               ctx->options |= E2F_OPT_ICOUNT_FULLMAP;
+
+       if (ctx->readahead_kb == ~0ULL) {
+               profile_get_integer(ctx->profile, "options",
+                                   "readahead_mem_pct", 0, -1, &c);
+               if (c >= 0 && c <= 100)
+                       ctx->readahead_kb = phys_mem_kb * c / 100;
+               profile_get_integer(ctx->profile, "options",
+                                   "readahead_kb", 0, -1, &c);
+               if (c >= 0)
+                       ctx->readahead_kb = c;
+               if (ctx->readahead_kb != ~0ULL &&
+                   ctx->readahead_kb > phys_mem_kb)
+                       ctx->readahead_kb = phys_mem_kb;
+       }
+
        /* Turn off discard in read-only mode */
        if ((ctx->options & E2F_OPT_NO) &&
            (ctx->options & E2F_OPT_DISCARD))
@@ -998,10 +1261,12 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
 #ifdef SA_RESTART
        sa.sa_flags = SA_RESTART;
 #endif
-       sa.sa_handler = signal_progress_on;
-       sigaction(SIGUSR1, &sa, 0);
-       sa.sa_handler = signal_progress_off;
-       sigaction(SIGUSR2, &sa, 0);
+       if ((ctx->options & E2F_OPT_MULTITHREAD) == 0) {
+               sa.sa_handler = signal_progress_on;
+               sigaction(SIGUSR1, &sa, 0);
+               sa.sa_handler = signal_progress_off;
+               sigaction(SIGUSR2, &sa, 0);
+       }
 #endif
 
        /* Update our PATH to include /sbin if we need to run badblocks  */
@@ -1128,7 +1393,7 @@ static errcode_t e2fsck_check_mmp(ext2_filsys fs, e2fsck_t ctx)
        if (retval)
                goto check_error;
 
-       /* Print warning if e2fck will wait for more than 20 secs. */
+       /* Print warning if e2fsck will wait for more than 20 secs. */
        if (verbose || wait_time > EXT4_MMP_MIN_CHECK_INTERVAL * 4) {
                log_out(ctx, _("MMP interval is %u seconds and total wait "
                               "time is %u seconds. Please wait...\n"),
@@ -1156,13 +1421,108 @@ check_error:
                dump_mmp_msg(fs->mmp_buf,
                             _("If you are sure the filesystem is not "
                               "in use on any node, run:\n"
-                              "'tune2fs -f -E clear_mmp {device}'\n"));
+                              "'tune2fs -f -E clear_mmp %s'\n"),
+                            ctx->device_name);
        } else if (retval == EXT2_ET_MMP_MAGIC_INVALID) {
                if (fix_problem(ctx, PR_0_MMP_INVALID_MAGIC, &pctx)) {
                        ext2fs_mmp_clear(fs);
                        retval = 0;
                }
+       } else if (retval == EXT2_ET_MMP_CSUM_INVALID) {
+               if (fix_problem(ctx, PR_0_MMP_CSUM_INVALID, &pctx)) {
+                       ext2fs_mmp_clear(fs);
+                       retval = 0;
+               }
+       } else
+               com_err(ctx->program_name, retval, "%s",
+                       _("while reading MMP block"));
+       return retval;
+}
+
+static int e2fsck_setup_tdb(e2fsck_t ctx, io_manager *io_ptr)
+{
+       errcode_t retval = ENOMEM;
+       char *tdb_dir = NULL, *tdb_file = NULL;
+       char *dev_name, *tmp_name;
+       int free_tdb_dir = 0;
+
+       /* (re)open a specific undo file */
+       if (ctx->undo_file && ctx->undo_file[0] != 0) {
+               retval = set_undo_io_backing_manager(*io_ptr);
+               if (retval)
+                       goto err;
+               *io_ptr = undo_io_manager;
+               retval = set_undo_io_backup_file(ctx->undo_file);
+               if (retval)
+                       goto err;
+               printf(_("Overwriting existing filesystem; this can be undone "
+                        "using the command:\n"
+                        "    e2undo %s %s\n\n"),
+                       ctx->undo_file, ctx->filesystem_name);
+               return retval;
        }
+
+       /*
+        * Configuration via a conf file would be
+        * nice
+        */
+       tdb_dir = getenv("E2FSPROGS_UNDO_DIR");
+       if (!tdb_dir) {
+               profile_get_string(ctx->profile, "defaults",
+                                  "undo_dir", 0, "/var/lib/e2fsprogs",
+                                  &tdb_dir);
+               free_tdb_dir = 1;
+       }
+
+       if (!strcmp(tdb_dir, "none") || (tdb_dir[0] == 0) ||
+           access(tdb_dir, W_OK)) {
+               if (free_tdb_dir)
+                       free(tdb_dir);
+               return 0;
+       }
+
+       tmp_name = strdup(ctx->filesystem_name);
+       if (!tmp_name)
+               goto errout;
+       dev_name = basename(tmp_name);
+       tdb_file = malloc(strlen(tdb_dir) + 8 + strlen(dev_name) + 7 + 1);
+       if (!tdb_file) {
+               free(tmp_name);
+               goto errout;
+       }
+       sprintf(tdb_file, "%s/e2fsck-%s.e2undo", tdb_dir, dev_name);
+       free(tmp_name);
+
+       if ((unlink(tdb_file) < 0) && (errno != ENOENT)) {
+               retval = errno;
+               com_err(ctx->program_name, retval,
+                       _("while trying to delete %s"), tdb_file);
+               goto errout;
+       }
+
+       retval = set_undo_io_backing_manager(*io_ptr);
+       if (retval)
+               goto errout;
+       *io_ptr = undo_io_manager;
+       retval = set_undo_io_backup_file(tdb_file);
+       if (retval)
+               goto errout;
+       printf(_("Overwriting existing filesystem; this can be undone "
+                "using the command:\n"
+                "    e2undo %s %s\n\n"), tdb_file, ctx->filesystem_name);
+
+       if (free_tdb_dir)
+               free(tdb_dir);
+       free(tdb_file);
+       return 0;
+
+errout:
+       if (free_tdb_dir)
+               free(tdb_dir);
+       free(tdb_file);
+err:
+       com_err(ctx->program_name, retval, "%s",
+               _("while trying to setup undo file\n"));
        return retval;
 }
 
@@ -1176,15 +1536,16 @@ int main (int argc, char *argv[])
        const char      *lib_ver_date;
        int             my_ver, lib_ver;
        e2fsck_t        ctx;
-       blk64_t         orig_superblock;
+       blk64_t         orig_superblock = ~(blk64_t)0;
        struct problem_context pctx;
-       int flags, run_result;
+       int flags, run_result, was_changed;
        int journal_size;
        int sysval, sys_page_size = 4096;
        int old_bitmaps;
        __u32 features[3];
        char *cp;
-       int qtype = -99;  /* quota type */
+       enum quota_type qtype;
+       struct ext2fs_journal_params jparams;
 
        clear_problem_context(&pctx);
        sigcatcher_setup();
@@ -1217,9 +1578,11 @@ int main (int argc, char *argv[])
        }
        reserve_stdio_fds();
 
+       ctx->global_ctx = NULL;
        set_up_logging(ctx);
        if (ctx->logf) {
                int i;
+
                fputs("E2fsck run: ", ctx->logf);
                for (i = 0; i < argc; i++) {
                        if (i)
@@ -1228,6 +1591,19 @@ int main (int argc, char *argv[])
                }
                fputc('\n', ctx->logf);
        }
+       if (ctx->problem_logf) {
+               int i;
+
+               fputs("<?xml version=\"1.0\" encoding=\"utf-8\"?>\n",
+                     ctx->problem_logf);
+               fprintf(ctx->problem_logf, "<problem_log time=\"%lu\">\n",
+                       (unsigned long) ctx->now);
+               fprintf(ctx->problem_logf, "<invocation prog=\"%s\"",
+                       argv[0]);
+               for (i = 1; i < argc; i++)
+                       fprintf(ctx->problem_logf, " arg%d=\"%s\"", i, argv[i]);
+               fputs("/>\n", ctx->problem_logf);
+       }
 
        init_resource_track(&ctx->global_rtrack, NULL);
        if (!(ctx->options & E2F_OPT_PREEN) || show_version_only)
@@ -1251,7 +1627,7 @@ int main (int argc, char *argv[])
        }
        ctx->superblock = ctx->use_superblock;
 
-       flags = EXT2_FLAG_SKIP_MMP;
+       flags = EXT2_FLAG_SKIP_MMP | EXT2_FLAG_THREADS;
 restart:
 #ifdef CONFIG_TESTIO_DEBUG
        if (getenv("TEST_IO_FLAGS") || getenv("TEST_IO_BLOCK")) {
@@ -1275,11 +1651,20 @@ restart:
                        flags &= ~EXT2_FLAG_EXCLUSIVE;
        }
 
+       if (ctx->undo_file) {
+               retval = e2fsck_setup_tdb(ctx, &io_ptr);
+               if (retval)
+                       exit(FSCK_ERROR);
+       }
+
+       ctx->openfs_flags = flags;
+       ctx->io_manager = io_ptr;
        retval = try_open_fs(ctx, flags, io_ptr, &fs);
 
        if (!ctx->superblock && !(ctx->options & E2F_OPT_PREEN) &&
            !(ctx->flags & E2F_FLAG_SB_SPECIFIED) &&
            ((retval == EXT2_ET_BAD_MAGIC) ||
+            (retval == EXT2_ET_SB_CSUM_INVALID) ||
             (retval == EXT2_ET_CORRUPT_SUPERBLOCK) ||
             ((retval == 0) && (retval2 = ext2fs_check_desc(fs))))) {
                if (retval) {
@@ -1307,12 +1692,12 @@ restart:
                        orig_superblock = ctx->superblock;
                        get_backup_sb(ctx, fs, ctx->filesystem_name, io_ptr);
                        if (fs)
-                               ext2fs_close(fs);
+                               ext2fs_close_free(&fs);
                        orig_retval = retval;
                        retval = try_open_fs(ctx, flags, io_ptr, &fs);
                        if ((orig_retval == 0) && retval != 0) {
                                if (fs)
-                                       ext2fs_close(fs);
+                                       ext2fs_close_free(&fs);
                                log_out(ctx, _("%s: %s while using the "
                                               "backup blocks"),
                                        ctx->program_name,
@@ -1374,8 +1759,33 @@ failure:
                                             "-n option to do a read-only\n"
                                             "check of the device.\n"));
 #endif
-               else
+               else {
+                       /*
+                        * Let's try once more will less consistency checking
+                        * so that we are able to recover from more errors
+                        * (e.g. some tool messing up some value in the sb).
+                        */
+                       if ((retval == EXT2_ET_CORRUPT_SUPERBLOCK) &&
+                           !(flags & EXT2_FLAG_IGNORE_SB_ERRORS)) {
+                               if (fs)
+                                       ext2fs_close_free(&fs);
+                               log_out(ctx, _("%s: Trying to load superblock "
+                                       "despite errors...\n"),
+                                       ctx->program_name);
+                               flags |= EXT2_FLAG_IGNORE_SB_ERRORS;
+                               /*
+                                * If we tried backup sb, revert to the
+                                * original one now.
+                                */
+                               if (orig_superblock != ~(blk64_t)0)
+                                       ctx->superblock = orig_superblock;
+                               goto restart;
+                       }
                        fix_problem(ctx, PR_0_SB_CORRUPT, &pctx);
+                       if (retval == EXT2_ET_BAD_MAGIC)
+                               check_plausibility(ctx->filesystem_name,
+                                                  CHECK_FS_EXIST, NULL);
+               }
                fatal_error(ctx, 0);
        }
        /*
@@ -1406,7 +1816,7 @@ failure:
                 * reopen the filesystem after we get the device size.
                 */
                if (pctx.errcode == EBUSY) {
-                       ext2fs_close(fs);
+                       ext2fs_close_free(&fs);
                        need_restart++;
                        pctx.errcode =
                                ext2fs_get_device_size2(ctx->filesystem_name,
@@ -1427,6 +1837,9 @@ failure:
 
        ctx->fs = fs;
        fs->now = ctx->now;
+#ifdef HAVE_PTHREAD
+       fs->fs_num_threads = ctx->pfs_num_threads;
+#endif
        sb = fs->super;
 
        if (sb->s_rev_level > E2FSCK_CURRENT_REV) {
@@ -1441,20 +1854,36 @@ failure:
         * Set the device name, which is used whenever we print error
         * or informational messages to the user.
         */
-       if (ctx->device_name == 0 &&
-           (sb->s_volume_name[0] != 0)) {
-               ctx->device_name = string_copy(ctx, sb->s_volume_name,
+       if (ctx->device_name == 0 && sb->s_volume_name[0])
+               ctx->device_name = string_copy(ctx, (char *) sb->s_volume_name,
                                               sizeof(sb->s_volume_name));
-       }
+
        if (ctx->device_name == 0)
                ctx->device_name = string_copy(ctx, ctx->filesystem_name, 0);
        for (cp = ctx->device_name; *cp; cp++)
                if (isspace(*cp) || *cp == ':')
                        *cp = '_';
 
+       if (ctx->problem_logf) {
+
+               fprintf(ctx->problem_logf, "<filesystem dev=\"%s\"",
+                       ctx->filesystem_name);
+               if (!uuid_is_null(sb->s_uuid)) {
+                       char buf[48];
+
+                       uuid_unparse(sb->s_uuid, buf);
+                       fprintf(ctx->problem_logf, " uuid=\"%s\"", buf);
+               }
+               if (sb->s_volume_name[0])
+                       fprintf(ctx->problem_logf, " label=\"%.*s\"",
+                               EXT2_LEN_STR(sb->s_volume_name));
+
+               fputs("/>\n", ctx->problem_logf);
+       }
+
        ehandler_init(fs->io);
 
-       if ((fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_MMP) &&
+       if (ext2fs_has_feature_mmp(fs->super) &&
            (flags & EXT2_FLAG_SKIP_MMP)) {
                if (e2fsck_check_mmp(fs, ctx))
                        fatal_error(ctx, 0);
@@ -1462,8 +1891,7 @@ failure:
                /*
                 * Restart in order to reopen fs but this time start mmp.
                 */
-               ext2fs_close(fs);
-               ctx->fs = NULL;
+               ext2fs_close_free(&ctx->fs);
                flags &= ~EXT2_FLAG_SKIP_MMP;
                goto restart;
        }
@@ -1475,19 +1903,22 @@ failure:
        /*
         * Make sure the ext3 superblock fields are consistent.
         */
-       retval = e2fsck_check_ext3_journal(ctx);
-       if (retval) {
-               com_err(ctx->program_name, retval,
-                       _("while checking ext3 journal for %s"),
-                       ctx->device_name);
-               fatal_error(ctx, 0);
+       if ((ctx->mount_flags & (EXT2_MF_MOUNTED | EXT2_MF_BUSY)) == 0) {
+               retval = e2fsck_check_ext3_journal(ctx);
+               if (retval) {
+                       com_err(ctx->program_name, retval,
+                               _("while checking journal for %s"),
+                               ctx->device_name);
+                       fatal_error(ctx,
+                               _("Cannot proceed with file system check"));
+               }
        }
 
        /*
         * Check to see if we need to do ext3-style recovery.  If so,
         * do it, and then restart the fsck.
         */
-       if (sb->s_feature_incompat & EXT3_FEATURE_INCOMPAT_RECOVER) {
+       if (ext2fs_has_feature_journal_needs_recovery(sb)) {
                if (ctx->options & E2F_OPT_READONLY) {
                        log_out(ctx, "%s",
                                _("Warning: skipping journal recovery because "
@@ -1507,14 +1938,19 @@ failure:
                                fatal_error(ctx, 0);
                        }
                        retval = e2fsck_run_ext3_journal(ctx);
-                       if (retval) {
+                       if (retval == EFSBADCRC) {
+                               log_out(ctx, _("Journal checksum error "
+                                              "found in %s\n"),
+                                       ctx->device_name);
+                       } else if (retval == EFSCORRUPTED) {
+                               log_out(ctx, _("Journal corrupted in %s\n"),
+                                       ctx->device_name);
+                       } else if (retval) {
                                com_err(ctx->program_name, retval,
-                               _("while recovering ext3 journal of %s"),
+                               _("while recovering journal of %s"),
                                        ctx->device_name);
-                               fatal_error(ctx, 0);
                        }
-                       ext2fs_close(ctx->fs);
-                       ctx->fs = 0;
+                       ext2fs_close_free(&ctx->fs);
                        ctx->flags |= E2F_FLAG_RESTARTED;
                        goto restart;
                }
@@ -1546,20 +1982,20 @@ print_unsupp_features:
                log_err(ctx, "\n");
                goto get_newer;
        }
-#ifdef ENABLE_COMPRESSION
-       if (sb->s_feature_incompat & EXT2_FEATURE_INCOMPAT_COMPRESSION)
-               log_err(ctx, _("%s: warning: compression support "
-                              "is experimental.\n"),
-                       ctx->program_name);
-#endif
-#ifndef ENABLE_HTREE
-       if (sb->s_feature_compat & EXT2_FEATURE_COMPAT_DIR_INDEX) {
-               log_err(ctx, _("%s: e2fsck not compiled with HTREE support,\n\t"
-                         "but filesystem %s has HTREE directories.\n"),
-                       ctx->program_name, ctx->device_name);
+
+       if (ext2fs_has_feature_dirdata(sb) &&
+           ext2fs_has_feature_casefold(sb)) {
+               com_err(ctx->program_name, 0,
+                       _("%s has both casefold and dirdata, aborting fsck"),
+                       ctx->filesystem_name);
+               fatal_error(ctx, 0);
+       }
+
+       if (ext2fs_has_feature_casefold(sb) && !fs->encoding) {
+               log_err(ctx, _("%s has unsupported encoding: %0x\n"),
+                       ctx->filesystem_name, sb->s_encoding);
                goto get_newer;
        }
-#endif
 
        /*
         * If the user specified a specific superblock, presumably the
@@ -1591,6 +2027,52 @@ print_unsupp_features:
        if (ctx->flags & E2F_FLAG_SIGNAL_MASK)
                fatal_error(ctx, 0);
        check_if_skip(ctx);
+
+       if (EXT2_GOOD_OLD_INODE_SIZE + sb->s_want_extra_isize >
+                                                       EXT2_INODE_SIZE(sb)) {
+               if (fix_problem(ctx, PR_0_WANT_EXTRA_ISIZE_INVALID, &pctx))
+                       sb->s_want_extra_isize =
+                               sizeof(struct ext2_inode_large) -
+                               EXT2_GOOD_OLD_INODE_SIZE;
+       }
+       if (EXT2_GOOD_OLD_INODE_SIZE + sb->s_min_extra_isize >
+                                                       EXT2_INODE_SIZE(sb)) {
+               if (fix_problem(ctx, PR_0_MIN_EXTRA_ISIZE_INVALID, &pctx))
+                       sb->s_min_extra_isize = 0;
+       }
+       if (EXT2_INODE_SIZE(sb) > EXT2_GOOD_OLD_INODE_SIZE) {
+               ctx->want_extra_isize = sizeof(struct ext2_inode_large) -
+                                                    EXT2_GOOD_OLD_INODE_SIZE;
+               ctx->min_extra_isize = ~0L;
+               if (EXT2_HAS_RO_COMPAT_FEATURE(sb,
+                                      EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE)) {
+                       if (ctx->want_extra_isize < sb->s_want_extra_isize)
+                               ctx->want_extra_isize = sb->s_want_extra_isize;
+                       if (ctx->want_extra_isize < sb->s_min_extra_isize)
+                               ctx->want_extra_isize = sb->s_min_extra_isize;
+               }
+       } else {
+               /* Leave extra_isize set, it is harmless, and clearing it
+                * here breaks some regression tests by printing an extra
+                * message to the output for very little value. */
+               sb->s_want_extra_isize = 0;
+               sb->s_min_extra_isize = 0;
+               ctx->flags &= ~E2F_FLAG_EXPAND_EISIZE;
+       }
+
+       if (ctx->options & E2F_OPT_READONLY) {
+               if (ctx->flags & (E2F_FLAG_EXPAND_EISIZE)) {
+                       fprintf(stderr, _("Cannot enable EXTRA_ISIZE feature "
+                                         "on read-only filesystem\n"));
+                       exit(1);
+               }
+       } else {
+               if (sb->s_want_extra_isize > sb->s_min_extra_isize &&
+                   (sb->s_feature_ro_compat &
+                    EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE))
+                       ctx->flags |= E2F_FLAG_EXPAND_EISIZE;
+       }
+
        check_resize_inode(ctx);
        if (bad_blocks_file)
                read_bad_blocks_file(ctx, bad_blocks_file, replace_bad_blocks);
@@ -1616,45 +2098,46 @@ print_unsupp_features:
        /*
         * Save the journal size in megabytes.
         * Try and use the journal size from the backup else let e2fsck
-        * find the default journal size.
+        * find the default journal size. If fast commit feature is enabled,
+        * it is not clear how many of the journal blocks were fast commit
+        * blocks. So, ignore the size of journal found in backup.
+        *
+        * TODO: Add a new backup type that captures fast commit info as
+        * well.
         */
-       if (sb->s_jnl_backup_type == EXT3_JNL_BACKUP_BLOCKS)
+       if (sb->s_jnl_backup_type == EXT3_JNL_BACKUP_BLOCKS &&
+               !ext2fs_has_feature_fast_commit(sb))
                journal_size = (sb->s_jnl_blocks[15] << (32 - 20)) |
                               (sb->s_jnl_blocks[16] >> 20);
        else
                journal_size = -1;
 
-       if (sb->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA) {
+       if (ext2fs_has_feature_quota(sb)) {
                /* Quotas were enabled. Do quota accounting during fsck. */
-               if ((sb->s_usr_quota_inum && sb->s_grp_quota_inum) ||
-                   (!sb->s_usr_quota_inum && !sb->s_grp_quota_inum))
-                       qtype = -1;
-               else
-                       qtype = sb->s_usr_quota_inum ? USRQUOTA : GRPQUOTA;
-
-               quota_init_context(&ctx->qctx, ctx->fs, qtype);
+               clear_problem_context(&pctx);
+               pctx.errcode = quota_init_context(&ctx->qctx, ctx->fs, 0);
+               if (pctx.errcode) {
+                       fix_problem(ctx, PR_0_QUOTA_INIT_CTX, &pctx);
+                       fatal_error(ctx, 0);
+               }
        }
 
        run_result = e2fsck_run(ctx);
        e2fsck_clear_progbar(ctx);
 
-       if (ctx->flags & E2F_FLAG_JOURNAL_INODE) {
+       if (!ctx->invalid_bitmaps &&
+           (ctx->flags & E2F_FLAG_JOURNAL_INODE)) {
                if (fix_problem(ctx, PR_6_RECREATE_JOURNAL, &pctx)) {
-                       if (journal_size < 1024)
-                               journal_size = ext2fs_default_journal_size(ext2fs_blocks_count(fs->super));
-                       if (journal_size < 0) {
-                               fs->super->s_feature_compat &=
-                                       ~EXT3_FEATURE_COMPAT_HAS_JOURNAL;
-                               fs->flags &= ~EXT2_FLAG_MASTER_SB_ONLY;
-                               log_out(ctx, "%s: Couldn't determine "
-                                       "journal size\n", ctx->program_name);
-                               goto no_journal;
+                       if (journal_size < 1024) {
+                               ext2fs_get_journal_params(&jparams, fs);
+                       } else {
+                               jparams.num_journal_blocks = journal_size;
+                               jparams.num_fc_blocks = 0;
                        }
                        log_out(ctx, _("Creating journal (%d blocks): "),
-                              journal_size);
+                              jparams.num_journal_blocks);
                        fflush(stdout);
-                       retval = ext2fs_add_journal_inode(fs,
-                                                         journal_size, 0);
+                       retval = ext2fs_add_journal_inode3(fs, &jparams, ~0ULL, 0);
                        if (retval) {
                                log_out(ctx, "%s: while trying to create "
                                        "journal\n", error_message(retval));
@@ -1662,24 +2145,35 @@ print_unsupp_features:
                        }
                        log_out(ctx, "%s", _(" Done.\n"));
                        log_out(ctx, "%s",
-                               _("\n*** journal has been re-created - "
-                                 "filesystem is now ext3 again ***\n"));
+                               _("\n*** journal has been regenerated ***\n"));
                }
        }
 no_journal:
 
-       if (ctx->qctx) {
-               int i, needs_writeout;
-               for (i = 0; i < MAXQUOTAS; i++) {
-                       if (qtype != -1 && qtype != i)
+       if (run_result & E2F_FLAG_ABORT) {
+               fatal_error(ctx, _("aborted"));
+       } else if (run_result & E2F_FLAG_CANCEL) {
+               log_out(ctx, _("%s: e2fsck canceled.\n"), ctx->device_name ?
+                       ctx->device_name : ctx->filesystem_name);
+               exit_value |= FSCK_CANCELED;
+       } else if (ctx->qctx && !ctx->invalid_bitmaps) {
+               int needs_writeout;
+
+               for (qtype = 0; qtype < MAXQUOTAS; qtype++) {
+                       if (*quota_sb_inump(sb, qtype) == 0)
                                continue;
                        needs_writeout = 0;
-                       pctx.num = i;
-                       retval = quota_compare_and_update(ctx->qctx, i,
+                       pctx.num = qtype;
+                       retval = quota_compare_and_update(ctx->qctx, qtype,
                                                          &needs_writeout);
                        if ((retval || needs_writeout) &&
-                           fix_problem(ctx, PR_6_UPDATE_QUOTAS, &pctx))
-                               quota_write_inode(ctx->qctx, i);
+                           fix_problem(ctx, PR_6_UPDATE_QUOTAS, &pctx)) {
+                               pctx.errcode = quota_write_inode(ctx->qctx,
+                                                                1 << qtype);
+                               if (pctx.errcode)
+                                       (void) fix_problem(ctx,
+                                               PR_6_WRITE_QUOTAS, &pctx);
+                       }
                }
                quota_release_context(&ctx->qctx);
        }
@@ -1693,36 +2187,80 @@ no_journal:
                                _("while resetting context"));
                        fatal_error(ctx, 0);
                }
-               ext2fs_close(fs);
+               ext2fs_close_free(&ctx->fs);
                goto restart;
        }
-       if (run_result & E2F_FLAG_CANCEL) {
-               log_out(ctx, _("%s: e2fsck canceled.\n"), ctx->device_name ?
-                       ctx->device_name : ctx->filesystem_name);
-               exit_value |= FSCK_CANCELED;
-       }
-       if (run_result & E2F_FLAG_ABORT)
-               fatal_error(ctx, _("aborted"));
-       if (check_backup_super_block(ctx)) {
-               fs->flags &= ~EXT2_FLAG_MASTER_SB_ONLY;
-               ext2fs_mark_super_dirty(fs);
-       }
 
 #ifdef MTRACE
        mtrace_print("Cleanup");
 #endif
-       if (ext2fs_test_changed(fs)) {
-               exit_value |= FSCK_NONDESTRUCT;
-               if (!(ctx->options & E2F_OPT_PREEN))
-                       log_out(ctx, _("\n%s: ***** FILE SYSTEM WAS "
-                                      "MODIFIED *****\n"),
+       was_changed = ext2fs_test_changed(fs);
+       if (!(ctx->flags & E2F_FLAG_RUN_RETURN) &&
+           !(ctx->options & E2F_OPT_READONLY)) {
+               if (ext2fs_test_valid(fs)) {
+                       if (!(sb->s_state & EXT2_VALID_FS))
+                               exit_value |= FSCK_NONDESTRUCT;
+                       sb->s_state = EXT2_VALID_FS;
+                       if (check_backup_super_block(ctx))
+                               fs->flags &= ~EXT2_FLAG_MASTER_SB_ONLY;
+               } else
+                       sb->s_state &= ~EXT2_VALID_FS;
+               if (!(ctx->flags & E2F_FLAG_TIME_INSANE))
+                       sb->s_lastcheck = ctx->now;
+               sb->s_mnt_count = 0;
+               memset(((char *) sb) + EXT4_S_ERR_START, 0, EXT4_S_ERR_LEN);
+               pctx.errcode = ext2fs_set_gdt_csum(ctx->fs);
+               if (pctx.errcode)
+                       fix_problem(ctx, PR_6_SET_BG_CHECKSUM, &pctx);
+               ext2fs_mark_super_dirty(fs);
+       }
+
+       if (ext2fs_has_feature_shared_blocks(ctx->fs->super) &&
+           (ctx->options & E2F_OPT_UNSHARE_BLOCKS) &&
+           (ctx->options & E2F_OPT_NO))
+               /* Don't try to write or flush I/O, we just wanted to know whether or
+                * not there were enough free blocks to undo deduplication.
+                */
+               goto skip_write;
+
+       if (!(ctx->options & E2F_OPT_READONLY)) {
+               e2fsck_write_bitmaps(ctx);
+               if (fs->flags & EXT2_FLAG_DIRTY) {
+                       pctx.errcode = ext2fs_flush(ctx->fs);
+                       if (pctx.errcode)
+                               fix_problem(ctx, PR_6_FLUSH_FILESYSTEM, &pctx);
+               }
+               pctx.errcode = io_channel_flush(ctx->fs->io);
+               if (pctx.errcode)
+                       fix_problem(ctx, PR_6_IO_FLUSH, &pctx);
+       }
+
+       if (was_changed) {
+               int fs_fixed = (ctx->flags & E2F_FLAG_PROBLEMS_FIXED);
+
+               if (fs_fixed)
+                       exit_value |= FSCK_NONDESTRUCT;
+               if (!(ctx->options & E2F_OPT_PREEN)) {
+#if 0  /* Do this later; it breaks too many tests' golden outputs */
+                       log_out(ctx, fs_fixed ?
+                               _("\n%s: ***** FILE SYSTEM ERRORS "
+                                 "CORRECTED *****\n") :
+                               _("%s: File system was modified.\n"),
+                               ctx->device_name);
+#else
+                       log_out(ctx,
+                               _("\n%s: ***** FILE SYSTEM WAS MODIFIED *****\n"),
                                ctx->device_name);
+#endif
+               }
                if (ctx->mount_flags & EXT2_MF_ISROOT) {
-                       log_out(ctx, _("%s: ***** REBOOT LINUX *****\n"),
+                       log_out(ctx, _("%s: ***** REBOOT SYSTEM *****\n"),
                                ctx->device_name);
                        exit_value |= FSCK_REBOOT;
                }
        }
+
+skip_write:
        if (!ext2fs_test_valid(fs) ||
            ((exit_value & FSCK_CANCELED) &&
             (sb->s_state & EXT2_ERROR_FS))) {
@@ -1742,43 +2280,16 @@ no_journal:
                    (sb->s_state & EXT2_VALID_FS) &&
                    !(sb->s_state & EXT2_ERROR_FS))
                        exit_value = 0;
-       } else {
+       } else
                show_stats(ctx);
-               if (!(ctx->options & E2F_OPT_READONLY)) {
-                       if (ext2fs_test_valid(fs)) {
-                               if (!(sb->s_state & EXT2_VALID_FS))
-                                       exit_value |= FSCK_NONDESTRUCT;
-                               sb->s_state = EXT2_VALID_FS;
-                       } else
-                               sb->s_state &= ~EXT2_VALID_FS;
-                       sb->s_mnt_count = 0;
-                       if (!(ctx->flags & E2F_FLAG_TIME_INSANE))
-                               sb->s_lastcheck = ctx->now;
-                       memset(((char *) sb) + EXT4_S_ERR_START, 0,
-                              EXT4_S_ERR_LEN);
-                       ext2fs_mark_super_dirty(fs);
-               }
-       }
-
-       if ((run_result & E2F_FLAG_CANCEL) == 0 &&
-           sb->s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_GDT_CSUM &&
-           !(ctx->options & E2F_OPT_READONLY)) {
-               retval = ext2fs_set_gdt_csum(ctx->fs);
-               if (retval) {
-                       com_err(ctx->program_name, retval, "%s",
-                               _("while setting block group checksum info"));
-                       fatal_error(ctx, 0);
-               }
-       }
 
-       e2fsck_write_bitmaps(ctx);
-       io_channel_flush(ctx->fs->io);
        print_resource_track(ctx, NULL, &ctx->global_rtrack, ctx->fs->io);
 
-       ext2fs_close(fs);
-       ctx->fs = NULL;
+       ext2fs_close_free(&ctx->fs);
        free(ctx->journal_name);
 
+       if (ctx->logf)
+               fprintf(ctx->logf, "Exit status: %d\n", exit_value);
        e2fsck_free_context(ctx);
        remove_error_table(&et_ext2_error_table);
        remove_error_table(&et_prof_error_table);