Whamcloud - gitweb
Merge branch 'maint'
[tools/e2fsprogs.git] / e2fsck / rehash.c
index fbb206f..5592e3f 100644 (file)
@@ -1,13 +1,13 @@
 /*
  * rehash.c --- rebuild hash tree directories
- * 
+ *
  * Copyright (C) 2002 Theodore Ts'o
  *
  * %Begin-Header%
  * This file may be redistributed under the terms of the GNU Public
  * License.
  * %End-Header%
- * 
+ *
  * This algorithm is designed for simplicity of implementation and to
  * pack the directory as much as possible.  It however requires twice
  * as much memory as the size of the directory.  The maximum size
@@ -36,7 +36,7 @@
  *    --------------------------------------------------------
  *                  ^ ptr    ^ptr
  *                tail new   head old
- * 
+ *
  * This is going to be a pain in the tuckus to implement, and will
  * require a lot more disk accesses.  So I'm going to skip it for now;
  * it's only really going to be an issue for really, really big
  * require that e2fsck use VM first.
  */
 
+#include "config.h"
+#include <string.h>
+#include <ctype.h>
 #include <errno.h>
 #include "e2fsck.h"
 #include "problem.h"
 
+/* Schedule a dir to be rebuilt during pass 3A. */
+void e2fsck_rehash_dir_later(e2fsck_t ctx, ext2_ino_t ino)
+{
+       if (!ctx->dirs_to_hash)
+               ext2fs_u32_list_create(&ctx->dirs_to_hash, 50);
+       if (ctx->dirs_to_hash)
+               ext2fs_u32_list_add(ctx->dirs_to_hash, ino);
+}
+
+/* Ask if a dir will be rebuilt during pass 3A. */
+int e2fsck_dir_will_be_rehashed(e2fsck_t ctx, ext2_ino_t ino)
+{
+       if (ctx->options & E2F_OPT_COMPRESS_DIRS)
+               return 1;
+       if (!ctx->dirs_to_hash)
+               return 0;
+       return ext2fs_u32_list_test(ctx->dirs_to_hash, ino);
+}
+
 struct fill_dir_struct {
        char *buf;
        struct ext2_inode *inode;
@@ -56,14 +78,16 @@ struct fill_dir_struct {
        e2fsck_t ctx;
        struct hash_entry *harray;
        int max_array, num_array;
-       int dir_size;
+       unsigned int dir_size;
        int compress;
        ino_t parent;
+       ext2_ino_t dir;
 };
 
 struct hash_entry {
        ext2_dirhash_t  hash;
        ext2_dirhash_t  minor_hash;
+       ino_t           ino;
        struct ext2_dir_entry   *dir;
 };
 
@@ -75,18 +99,19 @@ struct out_dir {
 };
 
 static int fill_dir_block(ext2_filsys fs,
-                         blk_t *block_nr,
+                         blk64_t *block_nr,
                          e2_blkcnt_t blockcnt,
-                         blk_t ref_block,
-                         int ref_offset
+                         blk64_t ref_block EXT2FS_ATTR((unused)),
+                         int ref_offset EXT2FS_ATTR((unused)),
                          void *priv_data)
 {
        struct fill_dir_struct  *fd = (struct fill_dir_struct *) priv_data;
        struct hash_entry       *new_array, *ent;
        struct ext2_dir_entry   *dirent;
        char                    *dir;
-       int                     offset, dir_offset;
-       
+       unsigned int            offset, dir_offset, rec_len;
+       int                     hash_alg;
+
        if (blockcnt < 0)
                return 0;
 
@@ -99,24 +124,32 @@ static int fill_dir_block(ext2_filsys fs,
        if (HOLE_BLKADDR(*block_nr)) {
                memset(dir, 0, fs->blocksize);
                dirent = (struct ext2_dir_entry *) dir;
-               dirent->rec_len = fs->blocksize;
+               (void) ext2fs_set_rec_len(fs, fs->blocksize, dirent);
        } else {
-               fd->err = ext2fs_read_dir_block(fs, *block_nr, dir);
+               fs->flags |= EXT2_FLAG_IGNORE_CSUM_ERRORS;
+               fd->err = ext2fs_read_dir_block4(fs, *block_nr, dir, 0,
+                                                fd->dir);
+               fs->flags &= ~EXT2_FLAG_IGNORE_CSUM_ERRORS;
                if (fd->err)
                        return BLOCK_ABORT;
        }
+       hash_alg = fs->super->s_def_hash_version;
+       if ((hash_alg <= EXT2_HASH_TEA) &&
+           (fs->super->s_flags & EXT2_FLAGS_UNSIGNED_HASH))
+               hash_alg += 3;
        /* While the directory block is "hot", index it. */
        dir_offset = 0;
        while (dir_offset < fs->blocksize) {
                dirent = (struct ext2_dir_entry *) (dir + dir_offset);
-               if (((dir_offset + dirent->rec_len) > fs->blocksize) ||
-                   (dirent->rec_len < 8) ||
-                   ((dirent->rec_len % 4) != 0) ||
-                   (((dirent->name_len & 0xFF)+8) > dirent->rec_len)) {
+               (void) ext2fs_get_rec_len(fs, dirent, &rec_len);
+               if (((dir_offset + rec_len) > fs->blocksize) ||
+                   (rec_len < 8) ||
+                   ((rec_len % 4) != 0) ||
+                   (((dirent->name_len & 0xFF)+8U) > rec_len)) {
                        fd->err = EXT2_ET_DIR_CORRUPTED;
                        return BLOCK_ABORT;
                }
-               dir_offset += dirent->rec_len;
+               dir_offset += rec_len;
                if (dirent->inode == 0)
                        continue;
                if (!fd->compress && ((dirent->name_len&0xFF) == 1) &&
@@ -140,11 +173,11 @@ static int fill_dir_block(ext2_filsys fs,
                ent = fd->harray + fd->num_array++;
                ent->dir = dirent;
                fd->dir_size += EXT2_DIR_REC_LEN(dirent->name_len & 0xFF);
+               ent->ino = dirent->inode;
                if (fd->compress)
                        ent->hash = ent->minor_hash = 0;
                else {
-                       fd->err = ext2fs_dirhash(fs->super->s_def_hash_version,
-                                                dirent->name,
+                       fd->err = ext2fs_dirhash(hash_alg, dirent->name,
                                                 dirent->name_len & 0xFF,
                                                 fs->super->s_hash_seed,
                                                 &ent->hash, &ent->minor_hash);
@@ -152,11 +185,20 @@ static int fill_dir_block(ext2_filsys fs,
                                return BLOCK_ABORT;
                }
        }
-       
+
        return 0;
 }
 
 /* Used for sorting the hash entry */
+static EXT2_QSORT_TYPE ino_cmp(const void *a, const void *b)
+{
+       const struct hash_entry *he_a = (const struct hash_entry *) a;
+       const struct hash_entry *he_b = (const struct hash_entry *) b;
+
+       return (he_a->ino - he_b->ino);
+}
+
+/* Used for sorting the hash entry */
 static EXT2_QSORT_TYPE name_cmp(const void *a, const void *b)
 {
        const struct hash_entry *he_a = (const struct hash_entry *) a;
@@ -175,7 +217,7 @@ static EXT2_QSORT_TYPE name_cmp(const void *a, const void *b)
                else if (he_a->dir->name_len < he_b->dir->name_len)
                        ret = -1;
                else
-                       ret = 0;
+                       ret = he_b->dir->inode - he_a->dir->inode;
        }
        return ret;
 }
@@ -186,7 +228,7 @@ static EXT2_QSORT_TYPE hash_cmp(const void *a, const void *b)
        const struct hash_entry *he_a = (const struct hash_entry *) a;
        const struct hash_entry *he_b = (const struct hash_entry *) b;
        int     ret;
-       
+
        if (he_a->hash > he_b->hash)
                ret = 1;
        else if (he_a->hash < he_b->hash)
@@ -202,7 +244,7 @@ static EXT2_QSORT_TYPE hash_cmp(const void *a, const void *b)
        return ret;
 }
 
-static errcode_t alloc_size_dir(ext2_filsys fs, struct out_dir *outdir, 
+static errcode_t alloc_size_dir(ext2_filsys fs, struct out_dir *outdir,
                                int blocks)
 {
        void                    *new_mem;
@@ -228,10 +270,8 @@ static errcode_t alloc_size_dir(ext2_filsys fs, struct out_dir *outdir,
 
 static void free_out_dir(struct out_dir *outdir)
 {
-       if (outdir->buf)
-               free(outdir->buf);
-       if (outdir->hashes)
-               free(outdir->hashes);
+       free(outdir->buf);
+       free(outdir->hashes);
        outdir->max = 0;
        outdir->num =0;
 }
@@ -261,7 +301,7 @@ static void mutate_name(char *str, __u16 *len)
 {
        int     i;
        __u16   l = *len & 0xFF, h = *len & 0xff00;
-       
+
        /*
         * First check to see if it looks the name has been mutated
         * already
@@ -304,7 +344,7 @@ static void mutate_name(char *str, __u16 *len)
                } else {
                        if (str[0] == '~')
                                str[0] = 'a';
-                       else 
+                       else
                                str[0]++;
                }
                break;
@@ -321,10 +361,16 @@ static int duplicate_search_and_fix(e2fsck_t ctx, ext2_filsys fs,
        int                     fixed = 0;
        char                    new_name[256];
        __u16                   new_len;
-       
+       int                     hash_alg;
+
        clear_problem_context(&pctx);
        pctx.ino = ino;
 
+       hash_alg = fs->super->s_def_hash_version;
+       if ((hash_alg <= EXT2_HASH_TEA) &&
+           (fs->super->s_flags & EXT2_FLAGS_UNSIGNED_HASH))
+               hash_alg += 3;
+
        for (i=1; i < fd->num_array; i++) {
                ent = fd->harray + i;
                prev = ent - 1;
@@ -347,13 +393,13 @@ static int duplicate_search_and_fix(e2fsck_t ctx, ext2_filsys fs,
                mutate_name(new_name, &new_len);
                for (j=0; j < fd->num_array; j++) {
                        if ((i==j) ||
-                           ((ent->dir->name_len & 0xFF) !=
+                           ((new_len & 0xFF) !=
                             (fd->harray[j].dir->name_len & 0xFF)) ||
                            (strncmp(new_name, fd->harray[j].dir->name,
                                     new_len & 0xFF)))
                                continue;
                        mutate_name(new_name, &new_len);
-                       
+
                        j = -1;
                }
                new_name[new_len & 0xFF] = 0;
@@ -361,8 +407,7 @@ static int duplicate_search_and_fix(e2fsck_t ctx, ext2_filsys fs,
                if (fix_problem(ctx, PR_2_NON_UNIQUE_FILE, &pctx)) {
                        memcpy(ent->dir->name, new_name, new_len & 0xFF);
                        ent->dir->name_len = new_len;
-                       ext2fs_dirhash(fs->super->s_def_hash_version,
-                                      ent->dir->name,
+                       ext2fs_dirhash(hash_alg, ent->dir->name,
                                       ent->dir->name_len & 0xFF,
                                       fs->super->s_hash_seed,
                                       &ent->hash, &ent->minor_hash);
@@ -373,18 +418,34 @@ static int duplicate_search_and_fix(e2fsck_t ctx, ext2_filsys fs,
 }
 
 
-static errcode_t copy_dir_entries(ext2_filsys fs,
+static errcode_t copy_dir_entries(e2fsck_t ctx,
                                  struct fill_dir_struct *fd,
                                  struct out_dir *outdir)
 {
+       ext2_filsys             fs = ctx->fs;
        errcode_t               retval;
        char                    *block_start;
        struct hash_entry       *ent;
        struct ext2_dir_entry   *dirent;
-       int                     i, rec_len, left;
+       unsigned int            rec_len, prev_rec_len, left, slack, offset;
+       int                     i;
        ext2_dirhash_t          prev_hash;
-       int                     offset;
-       
+       int                     csum_size = 0;
+       struct                  ext2_dir_entry_tail *t;
+
+       if (ctx->htree_slack_percentage == 255) {
+               profile_get_uint(ctx->profile, "options",
+                                "indexed_dir_slack_percentage",
+                                0, 20,
+                                &ctx->htree_slack_percentage);
+               if (ctx->htree_slack_percentage > 100)
+                       ctx->htree_slack_percentage = 20;
+       }
+
+       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
+                                      EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))
+               csum_size = sizeof(struct ext2_dir_entry_tail);
+
        outdir->max = 0;
        retval = alloc_size_dir(fs, outdir,
                                (fd->dir_size / fs->blocksize) + 2);
@@ -397,21 +458,36 @@ static errcode_t copy_dir_entries(ext2_filsys fs,
        if ((retval = get_next_block(fs, outdir, &block_start)))
                return retval;
        dirent = (struct ext2_dir_entry *) block_start;
-       left = fs->blocksize;
-       for (i=0; i < fd->num_array; i++) {
+       prev_rec_len = 0;
+       rec_len = 0;
+       left = fs->blocksize - csum_size;
+       slack = fd->compress ? 12 :
+               ((fs->blocksize - csum_size) * ctx->htree_slack_percentage)/100;
+       if (slack < 12)
+               slack = 12;
+       for (i = 0; i < fd->num_array; i++) {
                ent = fd->harray + i;
                if (ent->dir->inode == 0)
                        continue;
                rec_len = EXT2_DIR_REC_LEN(ent->dir->name_len & 0xFF);
                if (rec_len > left) {
-                       if (left)
-                               dirent->rec_len += left;
+                       if (left) {
+                               left += prev_rec_len;
+                               retval = ext2fs_set_rec_len(fs, left, dirent);
+                               if (retval)
+                                       return retval;
+                       }
+                       if (csum_size) {
+                               t = EXT2_DIRENT_TAIL(block_start,
+                                                    fs->blocksize);
+                               ext2fs_initialize_dirent_tail(fs, t);
+                       }
                        if ((retval = get_next_block(fs, outdir,
                                                      &block_start)))
                                return retval;
                        offset = 0;
                }
-               left = fs->blocksize - offset;
+               left = (fs->blocksize - csum_size) - offset;
                dirent = (struct ext2_dir_entry *) (block_start + offset);
                if (offset == 0) {
                        if (ent->hash == prev_hash)
@@ -421,21 +497,31 @@ static errcode_t copy_dir_entries(ext2_filsys fs,
                }
                dirent->inode = ent->dir->inode;
                dirent->name_len = ent->dir->name_len;
-               dirent->rec_len = rec_len;
+               retval = ext2fs_set_rec_len(fs, rec_len, dirent);
+               if (retval)
+                       return retval;
+               prev_rec_len = rec_len;
                memcpy(dirent->name, ent->dir->name, dirent->name_len & 0xFF);
                offset += rec_len;
                left -= rec_len;
-               if (left < 12) {
-                       dirent->rec_len += left;
+               if (left < slack) {
+                       prev_rec_len += left;
+                       retval = ext2fs_set_rec_len(fs, prev_rec_len, dirent);
+                       if (retval)
+                               return retval;
                        offset += left;
                        left = 0;
                }
                prev_hash = ent->hash;
        }
        if (left)
-               dirent->rec_len += left;
+               retval = ext2fs_set_rec_len(fs, rec_len + left, dirent);
+       if (csum_size) {
+               t = EXT2_DIRENT_TAIL(block_start, fs->blocksize);
+               ext2fs_initialize_dirent_tail(fs, t);
+       }
 
-       return 0;
+       return retval;
 }
 
 
@@ -446,10 +532,11 @@ static struct ext2_dx_root_info *set_root_node(ext2_filsys fs, char *buf,
        struct ext2_dx_root_info        *root;
        struct ext2_dx_countlimit       *limits;
        int                             filetype = 0;
+       int                             csum_size = 0;
 
        if (fs->super->s_feature_incompat & EXT2_FEATURE_INCOMPAT_FILETYPE)
                filetype = EXT2_FT_DIR << 8;
-       
+
        memset(buf, 0, fs->blocksize);
        dir = (struct ext2_dir_entry *) buf;
        dir->inode = ino;
@@ -462,7 +549,7 @@ static struct ext2_dx_root_info *set_root_node(ext2_filsys fs, char *buf,
        dir->name[1] = '.';
        dir->name_len = 2 | filetype;
        dir->rec_len = fs->blocksize - 12;
-       
+
        root = (struct ext2_dx_root_info *) (buf+24);
        root->reserved_zero = 0;
        root->hash_version = fs->super->s_def_hash_version;
@@ -470,8 +557,13 @@ static struct ext2_dx_root_info *set_root_node(ext2_filsys fs, char *buf,
        root->indirect_levels = 0;
        root->unused_flags = 0;
 
+       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
+                                       EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))
+               csum_size = sizeof(struct ext2_dx_tail);
+
        limits = (struct ext2_dx_countlimit *) (buf+32);
-       limits->limit = (fs->blocksize - 32) / sizeof(struct ext2_dx_entry);
+       limits->limit = (fs->blocksize - (32 + csum_size)) /
+                       sizeof(struct ext2_dx_entry);
        limits->count = 0;
 
        return root;
@@ -482,14 +574,20 @@ static struct ext2_dx_entry *set_int_node(ext2_filsys fs, char *buf)
 {
        struct ext2_dir_entry           *dir;
        struct ext2_dx_countlimit       *limits;
+       int                             csum_size = 0;
 
        memset(buf, 0, fs->blocksize);
        dir = (struct ext2_dir_entry *) buf;
        dir->inode = 0;
-       dir->rec_len = fs->blocksize;
-       
+       (void) ext2fs_set_rec_len(fs, fs->blocksize, dir);
+
+       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
+                                       EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))
+               csum_size = sizeof(struct ext2_dx_tail);
+
        limits = (struct ext2_dx_countlimit *) (buf+8);
-       limits->limit = (fs->blocksize - 8) / sizeof(struct ext2_dx_entry);
+       limits->limit = (fs->blocksize - (8 + csum_size)) /
+                       sizeof(struct ext2_dx_entry);
        limits->count = 0;
 
        return (struct ext2_dx_entry *) limits;
@@ -511,7 +609,7 @@ static errcode_t calculate_tree(ext2_filsys fs,
        char                            * block_start;
        int                             i, c1, c2, nblks;
        int                             limit_offset, root_offset;
-       
+
        root_info = set_root_node(fs, outdir->buf, ino, parent);
        root_offset = limit_offset = ((char *) root_info - outdir->buf) +
                root_info->info_length;
@@ -540,7 +638,7 @@ static errcode_t calculate_tree(ext2_filsys fs,
                                return ENOSPC;
                        if (c2 == 0) {
                                if (limit)
-                                       limit->limit = limit->count = 
+                                       limit->limit = limit->count =
                ext2fs_cpu_to_le16(limit->limit);
                                root = (struct ext2_dx_entry *)
                                        (outdir->buf + root_offset);
@@ -579,38 +677,51 @@ struct write_dir_struct {
        errcode_t       err;
        e2fsck_t        ctx;
        int             cleared;
+       ext2_ino_t      dir;
 };
 
 /*
  * Helper function which writes out a directory block.
  */
 static int write_dir_block(ext2_filsys fs,
-                          blk_t        *block_nr,
+                          blk64_t *block_nr,
                           e2_blkcnt_t blockcnt,
-                          blk_t ref_block,
-                          int ref_offset
+                          blk64_t ref_block EXT2FS_ATTR((unused)),
+                          int ref_offset EXT2FS_ATTR((unused)),
                           void *priv_data)
 {
        struct write_dir_struct *wd = (struct write_dir_struct *) priv_data;
-       blk_t   blk;
-       char    *dir;
+       blk64_t blk;
+       char    *dir, *buf = 0;
 
        if (*block_nr == 0)
                return 0;
-       if (blockcnt >= wd->outdir->num) {
+       if (blockcnt < 0)
+               return 0;
+       if (blockcnt < wd->outdir->num)
+               dir = wd->outdir->buf + (blockcnt * fs->blocksize);
+       else if (wd->ctx->lost_and_found == wd->dir) {
+               /* Don't release any extra directory blocks for lost+found */
+               wd->err = ext2fs_new_dir_block(fs, 0, 0, &buf);
+               if (wd->err)
+                       return BLOCK_ABORT;
+               dir = buf;
+               wd->outdir->num++;
+       } else {
+               /* We don't need this block, so release it */
                e2fsck_read_bitmaps(wd->ctx);
                blk = *block_nr;
-               ext2fs_unmark_block_bitmap(wd->ctx->block_found_map, blk);
-               ext2fs_block_alloc_stats(fs, blk, -1);
+               ext2fs_unmark_block_bitmap2(wd->ctx->block_found_map, blk);
+               ext2fs_block_alloc_stats2(fs, blk, -1);
                *block_nr = 0;
                wd->cleared++;
                return BLOCK_CHANGED;
        }
-       if (blockcnt < 0)
-               return 0;
 
-       dir = wd->outdir->buf + (blockcnt * fs->blocksize);
-       wd->err = ext2fs_write_dir_block(fs, *block_nr, dir);
+       wd->err = ext2fs_write_dir_block4(fs, *block_nr, dir, 0, wd->dir);
+       if (buf)
+               ext2fs_free_mem(&buf);
+
        if (wd->err)
                return BLOCK_ABORT;
        return 0;
@@ -632,8 +743,9 @@ static errcode_t write_directory(e2fsck_t ctx, ext2_filsys fs,
        wd.err = 0;
        wd.ctx = ctx;
        wd.cleared = 0;
+       wd.dir = ino;
 
-       retval = ext2fs_block_iterate2(fs, ino, 0, 0,
+       retval = ext2fs_block_iterate3(fs, ino, 0, 0,
                                       write_dir_block, &wd);
        if (retval)
                return retval;
@@ -646,7 +758,7 @@ static errcode_t write_directory(e2fsck_t ctx, ext2_filsys fs,
        else
                inode.i_flags |= EXT2_INDEX_FL;
        inode.i_size = outdir->num * fs->blocksize;
-       inode.i_blocks -= (fs->blocksize / 512) * wd.cleared;
+       ext2fs_iblk_sub_blocks(fs, &inode, wd.cleared);
        e2fsck_write_inode(ctx, ino, &inode, "rehash_dir");
 
        return 0;
@@ -660,7 +772,7 @@ errcode_t e2fsck_rehash_dir(e2fsck_t ctx, ext2_ino_t ino)
        char                    *dir_buf = 0;
        struct fill_dir_struct  fd;
        struct out_dir          outdir;
-       
+
        outdir.max = outdir.num = 0;
        outdir.buf = 0;
        outdir.hashes = 0;
@@ -684,19 +796,32 @@ errcode_t e2fsck_rehash_dir(e2fsck_t ctx, ext2_ino_t ino)
        fd.err = 0;
        fd.dir_size = 0;
        fd.compress = 0;
+       fd.dir = ino;
        if (!(fs->super->s_feature_compat & EXT2_FEATURE_COMPAT_DIR_INDEX) ||
            (inode.i_size / fs->blocksize) < 2)
                fd.compress = 1;
        fd.parent = 0;
 
+retry_nohash:
        /* Read in the entire directory into memory */
-       retval = ext2fs_block_iterate2(fs, ino, 0, 0,
+       retval = ext2fs_block_iterate3(fs, ino, 0, 0,
                                       fill_dir_block, &fd);
        if (fd.err) {
                retval = fd.err;
                goto errout;
        }
 
+       /* 
+        * If the entries read are less than a block, then don't index
+        * the directory
+        */
+       if (!fd.compress && (fd.dir_size < (fs->blocksize - 24))) {
+               fd.compress = 1;
+               fd.dir_size = 0;
+               fd.num_array = 0;
+               goto retry_nohash;
+       }
+
 #if 0
        printf("%d entries (%d bytes) found in inode %d\n",
               fd.num_array, fd.dir_size, ino);
@@ -705,11 +830,11 @@ errcode_t e2fsck_rehash_dir(e2fsck_t ctx, ext2_ino_t ino)
        /* Sort the list */
 resort:
        if (fd.compress)
-               qsort(fd.harray+2, fd.num_array-2,
-                     sizeof(struct hash_entry), name_cmp);
+               qsort(fd.harray+2, fd.num_array-2, sizeof(struct hash_entry),
+                     hash_cmp);
        else
-               qsort(fd.harray, fd.num_array,
-                     sizeof(struct hash_entry), hash_cmp);
+               qsort(fd.harray, fd.num_array, sizeof(struct hash_entry),
+                     hash_cmp);
 
        /*
         * Look for duplicates
@@ -722,14 +847,19 @@ resort:
                goto errout;
        }
 
+       /* Sort non-hashed directories by inode number */
+       if (fd.compress)
+               qsort(fd.harray+2, fd.num_array-2,
+                     sizeof(struct hash_entry), ino_cmp);
+
        /*
         * Copy the directory entries.  In a htree directory these
         * will become the leaf nodes.
         */
-       retval = copy_dir_entries(fs, &fd, &outdir);
+       retval = copy_dir_entries(ctx, &fd, &outdir);
        if (retval)
                goto errout;
-       
+
        free(dir_buf); dir_buf = 0;
 
        if (!fd.compress) {
@@ -738,16 +868,14 @@ resort:
                if (retval)
                        goto errout;
        }
-       
+
        retval = write_directory(ctx, fs, &outdir, ino, fd.compress);
        if (retval)
                goto errout;
 
 errout:
-       if (dir_buf)
-               free(dir_buf);
-       if (fd.harray)
-               free(fd.harray);
+       free(dir_buf);
+       free(fd.harray);
 
        free_out_dir(&outdir);
        return retval;
@@ -761,30 +889,27 @@ void e2fsck_rehash_directories(e2fsck_t ctx)
 #endif
        struct dir_info         *dir;
        ext2_u32_iterate        iter;
+       struct dir_info_iter *  dirinfo_iter = 0;
        ext2_ino_t              ino;
        errcode_t               retval;
-       int                     i, cur, max, all_dirs, dir_index, first = 1;
-
-#ifdef RESOURCE_TRACK
-       init_resource_track(&rtrack);
-#endif
+       int                     cur, max, all_dirs, first = 1;
 
+       init_resource_track(&rtrack, ctx->fs->io);
        all_dirs = ctx->options & E2F_OPT_COMPRESS_DIRS;
 
        if (!ctx->dirs_to_hash && !all_dirs)
                return;
 
-       e2fsck_get_lost_and_found(ctx, 0);
-               
+       (void) e2fsck_get_lost_and_found(ctx, 0);
+
        clear_problem_context(&pctx);
 
-       dir_index = ctx->fs->super->s_feature_compat & EXT2_FEATURE_COMPAT_DIR_INDEX;
        cur = 0;
        if (all_dirs) {
-               i = 0;
+               dirinfo_iter = e2fsck_dir_info_iter_begin(ctx);
                max = e2fsck_get_num_dirinfo(ctx);
        } else {
-               retval = ext2fs_u32_list_iterate_begin(ctx->dirs_to_hash, 
+               retval = ext2fs_u32_list_iterate_begin(ctx->dirs_to_hash,
                                                       &iter);
                if (retval) {
                        pctx.errcode = retval;
@@ -795,15 +920,15 @@ void e2fsck_rehash_directories(e2fsck_t ctx)
        }
        while (1) {
                if (all_dirs) {
-                       if ((dir = e2fsck_dir_info_iter(ctx, &i)) == 0)
+                       if ((dir = e2fsck_dir_info_iter(ctx,
+                                                       dirinfo_iter)) == 0)
                                break;
                        ino = dir->ino;
                } else {
                        if (!ext2fs_u32_list_iterate(iter, &ino))
                                break;
                }
-               if (ino == ctx->lost_and_found)
-                       continue;
+
                pctx.dir = ino;
                if (first) {
                        fix_problem(ctx, PR_3A_PASS_HEADER, &pctx);
@@ -822,17 +947,14 @@ void e2fsck_rehash_directories(e2fsck_t ctx)
                               100.0 * (float) (++cur) / (float) max, ino);
        }
        end_problem_latch(ctx, PR_LATCH_OPTIMIZE_DIR);
-       if (!all_dirs)
+       if (all_dirs)
+               e2fsck_dir_info_iter_end(ctx, dirinfo_iter);
+       else
                ext2fs_u32_list_iterate_end(iter);
-       
+
        if (ctx->dirs_to_hash)
                ext2fs_u32_list_free(ctx->dirs_to_hash);
        ctx->dirs_to_hash = 0;
 
-#ifdef RESOURCE_TRACK
-       if (ctx->options & E2F_OPT_TIME2) {
-               e2fsck_clear_progbar(ctx);
-               print_resource_track("Pass 3A", &rtrack);
-       }
-#endif
+       print_resource_track(ctx, "Pass 3A", &rtrack, ctx->fs->io);
 }