Whamcloud - gitweb
ChangeLog:
[tools/e2fsprogs.git] / e2fsck / pass3.c
index 2f97aa4..2e4bfe2 100644 (file)
  * offer to reconnect the directory to /lost+found in to break the
  * filesystem loop.
  * 
- * Pass 3 also contains the subroutine, reconnect_file() to reconnect
- * inodes to /lost+found; this subroutine is also used by pass 4.
- * reconnect_file() calls get_lost_and_found(), which is responsible
- * for creating /lost+found if it does not exist.
+ * Pass 3 also contains the subroutine, e2fsck_reconnect_file() to
+ * reconnect inodes to /lost+found; this subroutine is also used by
+ * pass 4.  e2fsck_reconnect_file() calls get_lost_and_found(), which
+ * is responsible for creating /lost+found if it does not exist.
  *
  * Pass 3 frees the following data structures:
  *             - The dirinfo directory information cache.
 #ifdef HAVE_ERRNO_H
 #include <errno.h>
 #endif
-#include "et/com_err.h"
 
 #include "e2fsck.h"
 #include "problem.h"
 
-static void check_root(ext2_filsys fs);
-static void check_directory(ext2_filsys fs, struct dir_info *dir,
+static void check_root(e2fsck_t ctx);
+static void check_directory(e2fsck_t ctx, struct dir_info *dir,
                            struct problem_context *pctx);
-static ino_t get_lost_and_found(ext2_filsys fs);
-static void fix_dotdot(ext2_filsys fs, struct dir_info *dir, ino_t parent);
-static errcode_t adjust_inode_count(ext2_filsys fs, ino_t ino, int adj);
-static errcode_t expand_directory(ext2_filsys fs, ino_t dir);
+static ino_t get_lost_and_found(e2fsck_t ctx);
+static void fix_dotdot(e2fsck_t ctx, struct dir_info *dir, ino_t parent);
+static errcode_t adjust_inode_count(e2fsck_t ctx, ino_t ino, int adj);
+static errcode_t expand_directory(e2fsck_t ctx, ino_t dir);
 
 static ino_t lost_and_found = 0;
 static int bad_lost_and_found = 0;
 
-static ext2fs_inode_bitmap inode_loop_detect;
-static ext2fs_inode_bitmap inode_done_map;
+static ext2fs_inode_bitmap inode_loop_detect = 0;
+static ext2fs_inode_bitmap inode_done_map = 0;
        
-void pass3(ext2_filsys fs)
+void e2fsck_pass3(e2fsck_t ctx)
 {
+       ext2_filsys fs = ctx->fs;
        int             i;
-       errcode_t       retval;
+#ifdef RESOURCE_TRACK
        struct resource_track   rtrack;
+#endif
        struct problem_context  pctx;
        struct dir_info *dir;
-       
+       unsigned long maxdirs, count;
+
+#ifdef RESOURCE_TRACK
        init_resource_track(&rtrack);
+#endif
+
+       clear_problem_context(&pctx);
 
 #ifdef MTRACE
        mtrace_print("Pass 3");
 #endif
 
-       if (!preen)
-               printf("Pass 3: Checking directory connectivity\n");
+       if (!(ctx->options & E2F_OPT_PREEN))
+               fix_problem(ctx, PR_3_PASS_HEADER, &pctx);
 
        /*
         * Allocate some bitmaps to do loop detection.
         */
-       retval = ext2fs_allocate_inode_bitmap(fs,
-                                             "inode loop detection bitmap",
-                                             &inode_loop_detect);
-       if (retval) {
-               com_err("ext2fs_allocate_inode_bitmap", retval,
-                       "while allocating inode_loop_detect");
-               fatal_error(0);
+       pctx.errcode = ext2fs_allocate_inode_bitmap(fs,
+                   "inode loop detection bitmap", &inode_loop_detect);
+       if (pctx.errcode) {
+               pctx.num = 1;
+               fix_problem(ctx, PR_3_ALLOCATE_IBITMAP_ERROR, &pctx);
+               ctx->flags |= E2F_FLAG_ABORT;
+               goto abort_exit;
        }
-       retval = ext2fs_allocate_inode_bitmap(fs, "inode done bitmap",
-                                             &inode_done_map);
-       if (retval) {
-               com_err("ext2fs_allocate_inode_bitmap", retval,
-                       "while allocating inode_done_map");
-               fatal_error(0);
+       pctx.errcode = ext2fs_allocate_inode_bitmap(fs, "inode done bitmap",
+                                                   &inode_done_map);
+       if (pctx.errcode) {
+               pctx.num = 2;
+               fix_problem(ctx, PR_3_ALLOCATE_IBITMAP_ERROR, &pctx);
+               ctx->flags |= E2F_FLAG_ABORT;
+               goto abort_exit;
        }
-       if (tflag) {
-               printf("Peak memory: ");
-               print_resource_track(&global_rtrack);
+#ifdef RESOURCE_TRACK
+       if (ctx->options & E2F_OPT_TIME) {
+               e2fsck_clear_progbar(ctx);
+               print_resource_track("Peak memory", &ctx->global_rtrack);
        }
+#endif
+
+       check_root(ctx);
+       if (ctx->flags & E2F_FLAG_SIGNAL_MASK)
+               goto abort_exit;
 
-       check_root(fs);
        ext2fs_mark_inode_bitmap(inode_done_map, EXT2_ROOT_INO);
 
-       clear_problem_context(&pctx);
-       for (i=0; (dir = dir_info_iter(&i)) != 0;) {
-               if (ext2fs_test_inode_bitmap(inode_dir_map, dir->ino))
-                       check_directory(fs, dir, &pctx);
-       }
-       
+       maxdirs = e2fsck_get_num_dirinfo(ctx);
+       count = 1;
+
+       if (ctx->progress)
+               if ((ctx->progress)(ctx, 3, 0, maxdirs))
+                       goto abort_exit;
        
-       free_dir_info(fs);
-       ext2fs_free_inode_bitmap(inode_loop_detect);
-       ext2fs_free_inode_bitmap(inode_done_map);
-       if (tflag > 1) {
-               printf("Pass 3: ");
-               print_resource_track(&rtrack);
+       for (i=0; (dir = e2fsck_dir_info_iter(ctx, &i)) != 0;) {
+               if (ctx->progress)
+                       if ((ctx->progress)(ctx, 3, count++, maxdirs))
+                               goto abort_exit;
+               if (ext2fs_test_inode_bitmap(ctx->inode_dir_map, dir->ino))
+                       check_directory(ctx, dir, &pctx);
        }
+
+       /*
+        * Force the creation of /lost+found if not present
+        */
+       if ((ctx->flags & E2F_OPT_READONLY) == 0)
+               get_lost_and_found(ctx);
+
+abort_exit:
+       e2fsck_free_dir_info(ctx);
+       if (inode_loop_detect)
+               ext2fs_free_inode_bitmap(inode_loop_detect);
+       if (inode_done_map)
+               ext2fs_free_inode_bitmap(inode_done_map);
+#ifdef RESOURCE_TRACK
+       if (ctx->options & E2F_OPT_TIME2) {
+               e2fsck_clear_progbar(ctx);
+               print_resource_track("Pass 3", &rtrack);
+       }
+#endif
 }
 
 /*
  * This makes sure the root inode is present; if not, we ask if the
  * user wants us to create it.  Not creating it is a fatal error.
  */
-static void check_root(ext2_filsys fs)
+static void check_root(e2fsck_t ctx)
 {
+       ext2_filsys fs = ctx->fs;
        blk_t                   blk;
-       errcode_t               retval;
        struct ext2_inode       inode;
        char *                  block;
+       struct problem_context  pctx;
        
-       if (ext2fs_test_inode_bitmap(inode_used_map, EXT2_ROOT_INO)) {
+       clear_problem_context(&pctx);
+       
+       if (ext2fs_test_inode_bitmap(ctx->inode_used_map, EXT2_ROOT_INO)) {
                /*
-                * If the root inode is a directory, die here.  The
+                * If the root inode is not a directory, die here.  The
                 * user must have answered 'no' in pass1 when we
                 * offered to clear it.
                 */
-               if (!(ext2fs_test_inode_bitmap(inode_dir_map, EXT2_ROOT_INO)))
-                       fatal_error("Root inode not directory");
+               if (!(ext2fs_test_inode_bitmap(ctx->inode_dir_map,
+                                              EXT2_ROOT_INO))) {
+                       fix_problem(ctx, PR_3_ROOT_NOT_DIR_ABORT, &pctx);
+                       ctx->flags |= E2F_FLAG_ABORT;
+               }
                return;
        }
 
-       if (!fix_problem(fs, PR_3_NO_ROOT_INODE, 0))
-               fatal_error("Cannot proceed without a root inode.");
+       if (!fix_problem(ctx, PR_3_NO_ROOT_INODE, &pctx)) {
+               fix_problem(ctx, PR_3_NO_ROOT_INODE_ABORT, &pctx);
+               ctx->flags |= E2F_FLAG_ABORT;
+               return;
+       }
 
-       read_bitmaps(fs);
+       e2fsck_read_bitmaps(ctx);
        
        /*
         * First, find a free block
         */
-       retval = ext2fs_new_block(fs, 0, block_found_map, &blk);
-       if (retval) {
-               com_err("ext2fs_new_block", retval,
-                       "while trying to create root directory");
-               fatal_error(0);
+       pctx.errcode = ext2fs_new_block(fs, 0, ctx->block_found_map, &blk);
+       if (pctx.errcode) {
+               pctx.str = "ext2fs_new_block";
+               fix_problem(ctx, PR_3_CREATE_ROOT_ERROR, &pctx);
+               ctx->flags |= E2F_FLAG_ABORT;
+               return;
        }
-       ext2fs_mark_block_bitmap(block_found_map, blk);
+       ext2fs_mark_block_bitmap(ctx->block_found_map, blk);
        ext2fs_mark_block_bitmap(fs->block_map, blk);
        ext2fs_mark_bb_dirty(fs);
 
        /*
         * Now let's create the actual data block for the inode
         */
-       retval = ext2fs_new_dir_block(fs, EXT2_ROOT_INO, EXT2_ROOT_INO,
-                                     &block);
-       if (retval) {
-               com_err("ext2fs_new_dir_block", retval,
-                       "while creating new root directory");
-               fatal_error(0);
+       pctx.errcode = ext2fs_new_dir_block(fs, EXT2_ROOT_INO, EXT2_ROOT_INO,
+                                           &block);
+       if (pctx.errcode) {
+               pctx.str = "ext2fs_new_dir_block";
+               fix_problem(ctx, PR_3_CREATE_ROOT_ERROR, &pctx);
+               ctx->flags |= E2F_FLAG_ABORT;
+               return;
        }
 
-       retval = ext2fs_write_dir_block(fs, blk, block);
-       if (retval) {
-               com_err("ext2fs_write_dir_block", retval,
-                       "while writing the root directory block");
-               fatal_error(0);
+       pctx.errcode = ext2fs_write_dir_block(fs, blk, block);
+       if (pctx.errcode) {
+               pctx.str = "ext2fs_write_dir_block";
+               fix_problem(ctx, PR_3_CREATE_ROOT_ERROR, &pctx);
+               ctx->flags |= E2F_FLAG_ABORT;
+               return;
        }
-       free(block);
+       ext2fs_free_mem((void **) &block);
 
        /*
         * Set up the inode structure
@@ -188,22 +231,23 @@ static void check_root(ext2_filsys fs)
        /*
         * Write out the inode.
         */
-       retval = ext2fs_write_inode(fs, EXT2_ROOT_INO, &inode);
-       if (retval) {
-               com_err("ext2fs_write_inode", retval,
-                       "While trying to create /lost+found");
-               fatal_error(0);
+       pctx.errcode = ext2fs_write_inode(fs, EXT2_ROOT_INO, &inode);
+       if (pctx.errcode) {
+               pctx.str = "ext2fs_write_inode";
+               fix_problem(ctx, PR_3_CREATE_ROOT_ERROR, &pctx);
+               ctx->flags |= E2F_FLAG_ABORT;
+               return;
        }
        
        /*
         * Miscellaneous bookkeeping...
         */
-       add_dir_info(fs, EXT2_ROOT_INO, EXT2_ROOT_INO);
-       ext2fs_icount_store(inode_count, EXT2_ROOT_INO, 2);
-       ext2fs_icount_store(inode_link_info, EXT2_ROOT_INO, 2);
+       e2fsck_add_dir_info(ctx, EXT2_ROOT_INO, EXT2_ROOT_INO);
+       ext2fs_icount_store(ctx->inode_count, EXT2_ROOT_INO, 2);
+       ext2fs_icount_store(ctx->inode_link_info, EXT2_ROOT_INO, 2);
 
-       ext2fs_mark_inode_bitmap(inode_used_map, EXT2_ROOT_INO);
-       ext2fs_mark_inode_bitmap(inode_dir_map, EXT2_ROOT_INO);
+       ext2fs_mark_inode_bitmap(ctx->inode_used_map, EXT2_ROOT_INO);
+       ext2fs_mark_inode_bitmap(ctx->inode_dir_map, EXT2_ROOT_INO);
        ext2fs_mark_inode_bitmap(fs->inode_map, EXT2_ROOT_INO);
        ext2fs_mark_ib_dirty(fs);
 }
@@ -216,22 +260,25 @@ static void check_root(ext2_filsys fs)
  * a loop, we treat that as a disconnected directory and offer to
  * reparent it to lost+found.
  */
-static void check_directory(ext2_filsys fs, struct dir_info *dir,
+static void check_directory(e2fsck_t ctx, struct dir_info *dir,
                            struct problem_context *pctx)
 {
+       ext2_filsys fs = ctx->fs;
        struct dir_info *p = dir;
 
+       if (!p)
+               return;
+
        ext2fs_clear_inode_bitmap(inode_loop_detect);
-       while (p) {
-               /*
-                * If we find a parent which we've already checked,
-                * then stop; we know it's either already connected to
-                * the directory tree, or it isn't but the user has
-                * already told us he doesn't want us to reconnect the
-                * disconnected subtree.
-                */
-               if (ext2fs_test_inode_bitmap(inode_done_map, p->ino))
-                       goto check_dot_dot;
+
+       /*
+        * Keep going until we find a parent which we've already
+        * checked.  We know it's either already connected to the
+        * directory tree, or it isn't but the user has already told
+        * us he doesn't want us to reconnect the disconnected
+        * subtree.
+        */
+       while (!ext2fs_test_inode_bitmap(inode_done_map, p->ino)) {
                /*
                 * Mark this inode as being "done"; by the time we
                 * return from this function, the inode we either be
@@ -240,6 +287,7 @@ static void check_directory(ext2_filsys fs, struct dir_info *dir,
                 * lost+found.
                 */
                ext2fs_mark_inode_bitmap(inode_done_map, p->ino);
+
                /*
                 * If this directory doesn't have a parent, or we've
                 * seen the parent once already, then offer to
@@ -247,23 +295,25 @@ static void check_directory(ext2_filsys fs, struct dir_info *dir,
                 */
                if (!p->parent ||
                    (ext2fs_test_inode_bitmap(inode_loop_detect,
-                                             p->parent)))
+                                             p->parent))) {
+                       pctx->ino = p->ino;
+                       if (fix_problem(ctx, PR_3_UNCONNECTED_DIR, pctx)) {
+                               if (e2fsck_reconnect_file(ctx, p->ino))
+                                       ext2fs_unmark_valid(fs);
+                               else {
+                                       p->parent = lost_and_found;
+                                       fix_dotdot(ctx, p, lost_and_found);
+                               }
+                       }
                        break;
+               }
                ext2fs_mark_inode_bitmap(inode_loop_detect,
                                         p->parent);
-               p = get_dir_info(p->parent);
-       }
-       /*
-        * If we've reached here, we've hit a detached directory
-        * inode; offer to reconnect it to lost+found.
-        */
-       pctx->ino = p->ino;
-       if (fix_problem(fs, PR_3_UNCONNECTED_DIR, pctx)) {
-               if (reconnect_file(fs, p->ino))
-                       ext2fs_unmark_valid(fs);
-               else {
-                       p->parent = lost_and_found;
-                       fix_dotdot(fs, p, lost_and_found);
+               pctx->ino = p->parent;
+               p = e2fsck_get_dir_info(ctx, p->parent);
+               if (!p) {
+                       fix_problem(ctx, PR_3_NO_DIRINFO, pctx);
+                       return;
                }
        }
 
@@ -271,13 +321,12 @@ static void check_directory(ext2_filsys fs, struct dir_info *dir,
         * Make sure that .. and the parent directory are the same;
         * offer to fix it if not.
         */
-check_dot_dot:
        if (dir->parent != dir->dotdot) {
                pctx->ino = dir->ino;
                pctx->ino2 = dir->dotdot;
                pctx->dir = dir->parent;
-               if (fix_problem(fs, PR_3_BAD_DOT_DOT, pctx))
-                       fix_dotdot(fs, dir, dir->parent);
+               if (fix_problem(ctx, PR_3_BAD_DOT_DOT, pctx))
+                       fix_dotdot(ctx, dir, dir->parent);
        }
 }      
 
@@ -285,56 +334,79 @@ check_dot_dot:
  * This routine gets the lost_and_found inode, making it a directory
  * if necessary
  */
-ino_t get_lost_and_found(ext2_filsys fs)
+ino_t get_lost_and_found(e2fsck_t ctx)
 {
+       ext2_filsys fs = ctx->fs;
        ino_t                   ino;
        blk_t                   blk;
        errcode_t               retval;
        struct ext2_inode       inode;
        char *                  block;
        const char              name[] = "lost+found";
+       struct  problem_context pctx;
+       struct dir_info         *dirinfo;
 
+       clear_problem_context(&pctx);
+       
        retval = ext2fs_lookup(fs, EXT2_ROOT_INO, name,
                               sizeof(name)-1, 0, &ino);
-       if (!retval)
-               return ino;
-       if (retval != ENOENT)
-               printf("Error while trying to find /lost+found: %s",
-                      error_message(retval));
-       if (!fix_problem(fs, PR_3_NO_LF_DIR, 0))
+       if (!retval) {
+               if (ext2fs_test_inode_bitmap(ctx->inode_dir_map, ino))
+                       return ino;
+               /* Lost+found isn't a directory! */
+               pctx.ino = ino;
+               if (!fix_problem(ctx, PR_3_LPF_NOTDIR, &pctx))
+                       return 0;
+
+               /* OK, unlink the old /lost+found file. */
+               pctx.errcode = ext2fs_unlink(fs, EXT2_ROOT_INO, name, ino, 0);
+               if (pctx.errcode) {
+                       pctx.str = "ext2fs_unlink";
+                       fix_problem(ctx, PR_3_CREATE_LPF_ERROR, &pctx);
+                       return 0;
+               }
+               dirinfo = e2fsck_get_dir_info(ctx, ino);
+               if (dirinfo)
+                       dirinfo->parent = 0;
+               adjust_inode_count(ctx, ino, -1);
+       } else if (retval != EXT2_ET_FILE_NOT_FOUND) {
+               pctx.errcode = retval;
+               fix_problem(ctx, PR_3_ERR_FIND_LPF, &pctx);
+       }
+       if (!fix_problem(ctx, PR_3_NO_LF_DIR, 0))
                return 0;
 
        /*
         * Read the inode and block bitmaps in; we'll be messing with
         * them.
         */
-       read_bitmaps(fs);
+       e2fsck_read_bitmaps(ctx);
        
        /*
         * First, find a free block
         */
-       retval = ext2fs_new_block(fs, 0, block_found_map, &blk);
+       retval = ext2fs_new_block(fs, 0, ctx->block_found_map, &blk);
        if (retval) {
-               com_err("ext2fs_new_block", retval,
-                       "while trying to create /lost+found directory");
+               pctx.errcode = retval;
+               fix_problem(ctx, PR_3_ERR_LPF_NEW_BLOCK, &pctx);
                return 0;
        }
-       ext2fs_mark_block_bitmap(block_found_map, blk);
+       ext2fs_mark_block_bitmap(ctx->block_found_map, blk);
        ext2fs_mark_block_bitmap(fs->block_map, blk);
        ext2fs_mark_bb_dirty(fs);
 
        /*
         * Next find a free inode.
         */
-       retval = ext2fs_new_inode(fs, EXT2_ROOT_INO, 040755, inode_used_map,
-                                 &ino);
+       retval = ext2fs_new_inode(fs, EXT2_ROOT_INO, 040755,
+                                 ctx->inode_used_map, &ino);
        if (retval) {
-               com_err("ext2fs_new_inode", retval,
-                       "while trying to create /lost+found directory");
+               pctx.errcode = retval;
+               fix_problem(ctx, PR_3_ERR_LPF_NEW_INODE, &pctx);
                return 0;
        }
-       ext2fs_mark_inode_bitmap(inode_used_map, ino);
-       ext2fs_mark_inode_bitmap(inode_dir_map, ino);
+       ext2fs_mark_inode_bitmap(ctx->inode_used_map, ino);
+       ext2fs_mark_inode_bitmap(ctx->inode_dir_map, ino);
        ext2fs_mark_inode_bitmap(fs->inode_map, ino);
        ext2fs_mark_ib_dirty(fs);
 
@@ -343,16 +415,16 @@ ino_t get_lost_and_found(ext2_filsys fs)
         */
        retval = ext2fs_new_dir_block(fs, ino, EXT2_ROOT_INO, &block);
        if (retval) {
-               com_err("ext2fs_new_dir_block", retval,
-                       "while creating new directory block");
+               pctx.errcode = retval;
+               fix_problem(ctx, PR_3_ERR_LPF_NEW_DIR_BLOCK, &pctx);
                return 0;
        }
 
        retval = ext2fs_write_dir_block(fs, blk, block);
-       free(block);
+       ext2fs_free_mem((void **) &block);
        if (retval) {
-               com_err("ext2fs_write_dir_block", retval,
-                       "while writing the directory block for /lost+found");
+               pctx.errcode = retval;
+               fix_problem(ctx, PR_3_ERR_LPF_WRITE_BLOCK, &pctx);
                return 0;
        }
 
@@ -370,28 +442,29 @@ ino_t get_lost_and_found(ext2_filsys fs)
        /*
         * Next, write out the inode.
         */
-       retval = ext2fs_write_inode(fs, ino, &inode);
-       if (retval) {
-               com_err("ext2fs_write_inode", retval,
-                       "While trying to create /lost+found");
+       pctx.errcode = ext2fs_write_inode(fs, ino, &inode);
+       if (pctx.errcode) {
+               pctx.str = "ext2fs_write_inode";
+               fix_problem(ctx, PR_3_CREATE_LPF_ERROR, &pctx);
                return 0;
        }
        /*
         * Finally, create the directory link
         */
-       retval = ext2fs_link(fs, EXT2_ROOT_INO, name, ino, 0);
-       if (retval) {
-               com_err("ext2fs_link", retval, "While creating /lost+found");
+       pctx.errcode = ext2fs_link(fs, EXT2_ROOT_INO, name, ino, 0);
+       if (pctx.errcode) {
+               pctx.str = "ext2fs_link";
+               fix_problem(ctx, PR_3_CREATE_LPF_ERROR, &pctx);
                return 0;
        }
 
        /*
         * Miscellaneous bookkeeping that needs to be kept straight.
         */
-       add_dir_info(fs, ino, EXT2_ROOT_INO);
-       adjust_inode_count(fs, EXT2_ROOT_INO, +1);
-       ext2fs_icount_store(inode_count, ino, 2);
-       ext2fs_icount_store(inode_link_info, ino, 2);
+       e2fsck_add_dir_info(ctx, ino, EXT2_ROOT_INO);
+       adjust_inode_count(ctx, EXT2_ROOT_INO, +1);
+       ext2fs_icount_store(ctx->inode_count, ino, 2);
+       ext2fs_icount_store(ctx->inode_link_info, ino, 2);
 #if 0
        printf("/lost+found created; inode #%lu\n", ino);
 #endif
@@ -401,44 +474,45 @@ ino_t get_lost_and_found(ext2_filsys fs)
 /*
  * This routine will connect a file to lost+found
  */
-int reconnect_file(ext2_filsys fs, ino_t inode)
+int e2fsck_reconnect_file(e2fsck_t ctx, ino_t inode)
 {
+       ext2_filsys fs = ctx->fs;
        errcode_t       retval;
        char            name[80];
-       
+       struct problem_context  pctx;
+
+       clear_problem_context(&pctx);
+       pctx.ino = inode;
+
+       if (!bad_lost_and_found && !lost_and_found) {
+               lost_and_found = get_lost_and_found(ctx);
+               if (!lost_and_found)
+                       bad_lost_and_found++;
+       }
        if (bad_lost_and_found) {
-               printf("Bad or nonexistent /lost+found.  Cannot reconnect.\n");
+               fix_problem(ctx, PR_3_NO_LPF, &pctx);
                return 1;
        }
-       if (!lost_and_found) {
-               lost_and_found = get_lost_and_found(fs);
-               if (!lost_and_found) {
-                       printf("Bad or nonexistent /lost+found.  Cannot reconnect.\n");
-                       bad_lost_and_found++;
-                       return 1;
-               }
-       }
-
+       
        sprintf(name, "#%lu", inode);
        retval = ext2fs_link(fs, lost_and_found, name, inode, 0);
        if (retval == EXT2_ET_DIR_NO_SPACE) {
-               if (!fix_problem(fs, PR_3_EXPAND_LF_DIR, 0))
+               if (!fix_problem(ctx, PR_3_EXPAND_LF_DIR, &pctx))
                        return 1;
-               retval = expand_directory(fs, lost_and_found);
+               retval = expand_directory(ctx, lost_and_found);
                if (retval) {
-                       printf("Could not expand /lost+found: %s\n",
-                              error_message(retval));
+                       pctx.errcode = retval;
+                       fix_problem(ctx, PR_3_CANT_EXPAND_LPF, &pctx);
                        return 1;
                }
                retval = ext2fs_link(fs, lost_and_found, name, inode, 0);
        }
        if (retval) {
-               printf("Could not reconnect %lu: %s\n", inode,
-                      error_message(retval));
+               pctx.errcode = retval;
+               fix_problem(ctx, PR_3_CANT_RECONNECT, &pctx);
                return 1;
        }
-
-       adjust_inode_count(fs, inode, +1);
+       adjust_inode_count(ctx, inode, +1);
 
        return 0;
 }
@@ -446,8 +520,9 @@ int reconnect_file(ext2_filsys fs, ino_t inode)
 /*
  * Utility routine to adjust the inode counts on an inode.
  */
-static errcode_t adjust_inode_count(ext2_filsys fs, ino_t ino, int adj)
+static errcode_t adjust_inode_count(e2fsck_t ctx, ino_t ino, int adj)
 {
+       ext2_filsys fs = ctx->fs;
        errcode_t               retval;
        struct ext2_inode       inode;
        
@@ -465,11 +540,11 @@ static errcode_t adjust_inode_count(ext2_filsys fs, ino_t ino, int adj)
 
        inode.i_links_count += adj;
        if (adj == 1) {
-               ext2fs_icount_increment(inode_count, ino, 0);
-               ext2fs_icount_increment(inode_link_info, ino, 0);
+               ext2fs_icount_increment(ctx->inode_count, ino, 0);
+               ext2fs_icount_increment(ctx->inode_link_info, ino, 0);
        } else {
-               ext2fs_icount_decrement(inode_count, ino, 0);
-               ext2fs_icount_decrement(inode_link_info, ino, 0);
+               ext2fs_icount_decrement(ctx->inode_count, ino, 0);
+               ext2fs_icount_decrement(ctx->inode_link_info, ino, 0);
        }
        
 
@@ -487,45 +562,53 @@ struct fix_dotdot_struct {
        ext2_filsys     fs;
        ino_t           parent;
        int             done;
+       e2fsck_t        ctx;
 };
 
 static int fix_dotdot_proc(struct ext2_dir_entry *dirent,
                           int  offset,
                           int  blocksize,
                           char *buf,
-                          void *private)
+                          void *priv_data)
 {
-       struct fix_dotdot_struct *fp = (struct fix_dotdot_struct *) private;
+       struct fix_dotdot_struct *fp = (struct fix_dotdot_struct *) priv_data;
        errcode_t       retval;
+       struct problem_context pctx;
 
-       if (dirent->name_len != 2)
+       if ((dirent->name_len & 0xFF) != 2)
                return 0;
        if (strncmp(dirent->name, "..", 2))
                return 0;
-       
-       retval = adjust_inode_count(fp->fs, dirent->inode, -1);
-       if (retval)
-               printf("Error while adjusting inode count on inode %u\n",
-                      dirent->inode);
-       retval = adjust_inode_count(fp->fs, fp->parent, 1);
-       if (retval)
-               printf("Error while adjusting inode count on inode %lu\n",
-                      fp->parent);
 
+       clear_problem_context(&pctx);
+       
+       retval = adjust_inode_count(fp->ctx, dirent->inode, -1);
+       if (retval) {
+               pctx.errcode = retval;
+               fix_problem(fp->ctx, PR_3_ADJUST_INODE, &pctx);
+       }
+       retval = adjust_inode_count(fp->ctx, fp->parent, 1);
+       if (retval) {
+               pctx.errcode = retval;
+               fix_problem(fp->ctx, PR_3_ADJUST_INODE, &pctx);
+       }
        dirent->inode = fp->parent;
 
        fp->done++;
        return DIRENT_ABORT | DIRENT_CHANGED;
 }
 
-static void fix_dotdot(ext2_filsys fs, struct dir_info *dir, ino_t parent)
+static void fix_dotdot(e2fsck_t ctx, struct dir_info *dir, ino_t parent)
 {
+       ext2_filsys fs = ctx->fs;
        errcode_t       retval;
        struct fix_dotdot_struct fp;
+       struct problem_context pctx;
 
        fp.fs = fs;
        fp.parent = parent;
        fp.done = 0;
+       fp.ctx = ctx;
 
 #if 0
        printf("Fixing '..' of inode %lu to be %lu...\n", dir->ino, parent);
@@ -534,9 +617,11 @@ static void fix_dotdot(ext2_filsys fs, struct dir_info *dir, ino_t parent)
        retval = ext2fs_dir_iterate(fs, dir->ino, DIRENT_FLAG_INCLUDE_EMPTY,
                                    0, fix_dotdot_proc, &fp);
        if (retval || !fp.done) {
-               printf("Couldn't fix parent of inode %lu: %s\n\n",
-                      dir->ino, retval ? error_message(retval) :
-                      "Couldn't find parent direntory entry");
+               clear_problem_context(&pctx);
+               pctx.ino = dir->ino;
+               pctx.errcode = retval;
+               fix_problem(ctx, retval ? PR_3_FIX_PARENT_ERR :
+                           PR_3_FIX_PARENT_NOFIND, &pctx);
                ext2fs_unmark_valid(fs);
        }
        dir->dotdot = parent;
@@ -552,24 +637,29 @@ static void fix_dotdot(ext2_filsys fs, struct dir_info *dir, ino_t parent)
 struct expand_dir_struct {
        int     done;
        errcode_t       err;
+       e2fsck_t        ctx;
 };
 
 static int expand_dir_proc(ext2_filsys fs,
                           blk_t        *blocknr,
                           int  blockcnt,
-                          void *private)
+                          void *priv_data)
 {
-       struct expand_dir_struct *es = (struct expand_dir_struct *) private;
+       struct expand_dir_struct *es = (struct expand_dir_struct *) priv_data;
        blk_t   new_blk;
        static blk_t    last_blk = 0;
        char            *block;
        errcode_t       retval;
+       e2fsck_t        ctx;
+
+       ctx = es->ctx;
        
        if (*blocknr) {
                last_blk = *blocknr;
                return 0;
        }
-       retval = ext2fs_new_block(fs, last_blk, block_found_map, &new_blk);
+       retval = ext2fs_new_block(fs, last_blk, ctx->block_found_map,
+                                 &new_blk);
        if (retval) {
                es->err = retval;
                return BLOCK_ABORT;
@@ -581,22 +671,23 @@ static int expand_dir_proc(ext2_filsys fs,
                        return BLOCK_ABORT;
                }
                es->done = 1;
+               retval = ext2fs_write_dir_block(fs, new_blk, block);
        } else {
-               block = malloc(fs->blocksize);
-               if (!block) {
-                       es->err = ENOMEM;
+               retval = ext2fs_get_mem(fs->blocksize, (void **) &block);
+               if (retval) {
+                       es->err = retval;
                        return BLOCK_ABORT;
                }
                memset(block, 0, fs->blocksize);
+               retval = io_channel_write_blk(fs->io, new_blk, 1, block);
        }       
-       retval = ext2fs_write_dir_block(fs, new_blk, block);
        if (retval) {
                es->err = retval;
                return BLOCK_ABORT;
        }
-       free(block);
+       ext2fs_free_mem((void **) &block);
        *blocknr = new_blk;
-       ext2fs_mark_block_bitmap(block_found_map, new_blk);
+       ext2fs_mark_block_bitmap(ctx->block_found_map, new_blk);
        ext2fs_mark_block_bitmap(fs->block_map, new_blk);
        ext2fs_mark_bb_dirty(fs);
        if (es->done)
@@ -605,8 +696,9 @@ static int expand_dir_proc(ext2_filsys fs,
                return BLOCK_CHANGED;
 }
 
-static errcode_t expand_directory(ext2_filsys fs, ino_t dir)
+static errcode_t expand_directory(e2fsck_t ctx, ino_t dir)
 {
+       ext2_filsys fs = ctx->fs;
        errcode_t       retval;
        struct expand_dir_struct es;
        struct ext2_inode       inode;
@@ -614,12 +706,19 @@ static errcode_t expand_directory(ext2_filsys fs, ino_t dir)
        if (!(fs->flags & EXT2_FLAG_RW))
                return EXT2_ET_RO_FILSYS;
 
+       /*
+        * Read the inode and block bitmaps in; we'll be messing with
+        * them.
+        */
+       e2fsck_read_bitmaps(ctx);
+       
        retval = ext2fs_check_directory(fs, dir);
        if (retval)
                return retval;
        
        es.done = 0;
        es.err = 0;
+       es.ctx = ctx;
        
        retval = ext2fs_block_iterate(fs, dir, BLOCK_FLAG_APPEND,
                                      0, expand_dir_proc, &es);
@@ -639,10 +738,7 @@ static errcode_t expand_directory(ext2_filsys fs, ino_t dir)
        inode.i_size += fs->blocksize;
        inode.i_blocks += fs->blocksize / 512;
 
-       e2fsck_write_inode(fs, dir, &inode, "expand_directory");
+       e2fsck_write_inode(ctx, dir, &inode, "expand_directory");
 
        return 0;
 }
-
-
-