Many files:

[tools/e2fsprogs.git] / e2fsck / badblocks.c

diff --git a/e2fsck/badblocks.c b/e2fsck/badblocks.c
index 6dff23d..c81baae 100644 (file)
--- a/e2fsck/badblocks.c
+++ b/e2fsck/badblocks.c
@@ -6,13 +6,20 @@
  */
 
 #include <time.h>
+#ifdef HAVE_ERRNO_H
+#include <errno.h>
+#endif
 
 #include <et/com_err.h>
 #include "e2fsck.h"
 
+static int check_bb_inode_blocks(ext2_filsys fs, blk_t *block_nr, int blockcnt,
+                                void *private);
+
+
 static void invalid_block(ext2_filsys fs, blk_t blk)
 {
-       printf("Bad block %lu out of range; ignored.\n", blk);
+       printf("Bad block %u out of range; ignored.\n", blk);
        return;
 }
 
@@ -22,8 +29,21 @@ void read_bad_blocks_file(ext2_filsys fs, const char *bad_blocks_file,
        errcode_t       retval;
        badblocks_list  bb_list = 0;
        FILE            *f;
+       char            buf[1024];
 
        read_bitmaps(fs);
+
+       /*
+        * Make sure the bad block inode is sane.  If there are any
+        * illegal blocks, clear them.
+        */
+       retval = ext2fs_block_iterate(fs, EXT2_BAD_INO, 0, 0,
+                                     check_bb_inode_blocks, 0);
+       if (retval) {
+               com_err("ext2fs_block_iterate", retval,
+                       "while sanity checking the bad blocks inode");
+               fatal_error(0);
+       }
        
        /*
         * If we're appending to the bad blocks inode, read in the
@@ -39,16 +59,33 @@ void read_bad_blocks_file(ext2_filsys fs, const char *bad_blocks_file,
        }
        
        /*
-        * Now read in the bad blocks from the file.
+        * Now read in the bad blocks from the file; if
+        * bad_blocks_file is null, then try to run the badblocks
+        * command.
         */
-       f = fopen(bad_blocks_file, "r");
-       if (!f) {
-               com_err("read_bad_blocks_file", errno,
-                       "while trying to open %s", bad_blocks_file);
-               fatal_error(0);
+       if (bad_blocks_file) {
+               f = fopen(bad_blocks_file, "r");
+               if (!f) {
+                       com_err("read_bad_blocks_file", errno,
+                               "while trying to open %s", bad_blocks_file);
+                       fatal_error(0);
+               }
+       } else {
+               sprintf(buf, "badblocks %s%s %d", preen ? "" : "-s ",
+                       fs->device_name,
+                       fs->super->s_blocks_count);
+               f = popen(buf, "r");
+               if (!f) {
+                       com_err("read_bad_blocks_file", errno,
+                               "while trying popen '%s'", buf);
+                       fatal_error(0);
+               }
        }
        retval = ext2fs_read_bb_FILE(fs, f, &bb_list, invalid_block);
-       fclose (f);
+       if (bad_blocks_file) 
+               fclose(f);
+       else
+               pclose(f);
        if (retval) {
                com_err("ext2fs_read_bb_FILE", retval,
                        "while reading in list of bad blocks from file");
@@ -71,56 +108,25 @@ void read_bad_blocks_file(ext2_filsys fs, const char *bad_blocks_file,
 
 void test_disk(ext2_filsys fs)
 {
-       errcode_t       retval;
-       badblocks_list  bb_list = 0;
-       FILE            *f;
-       char            buf[1024];
+       read_bad_blocks_file(fs, 0, 1);
+}
+
+static int check_bb_inode_blocks(ext2_filsys fs, blk_t *block_nr, int blockcnt,
+                                void *private)
+{
+       if (!*block_nr)
+               return 0;
 
-       read_bitmaps(fs);
-       
-       /*
-        * Always read in the current list of bad blocks.
-        */
-       retval = ext2fs_read_bb_inode(fs, &bb_list);
-       if (retval) {
-               com_err("ext2fs_read_bb_inode", retval,
-                       "while reading the bad blocks inode");
-               fatal_error(0);
-       }
-       
-       /*
-        * Now run the bad blocks program
-        */
-       sprintf(buf, "badblocks %s%s %ld", preen ? "" : "-s ",
-               fs->device_name,
-               fs->super->s_blocks_count);
-       if (verbose)
-               printf("Running command: %s\n", buf);
-       f = popen(buf, "r");
-       if (!f) {
-               com_err("popen", errno,
-                       "while trying to run %s", buf);
-               fatal_error(0);
-       }
-       retval = ext2fs_read_bb_FILE(fs, f, &bb_list, invalid_block);
-       fclose (f);
-       if (retval) {
-               com_err("ext2fs_read_bb_FILE", retval,
-                       "while processing list of bad blocks from program");
-               fatal_error(0);
-       }
-       
        /*
-        * Finally, update the bad blocks from the bad_block_map
+        * If the block number is outrageous, clear it and ignore it.
         */
-       retval = ext2fs_update_bb_inode(fs, bb_list);
-       if (retval) {
-               com_err("ext2fs_update_bb_inode", retval,
-                       "while updating bad block inode");
-               fatal_error(0);
+       if (*block_nr >= fs->super->s_blocks_count ||
+           *block_nr < fs->super->s_first_data_block) {
+               printf("Warning illegal block %u found in bad block inode.  Cleared.\n", *block_nr);
+               *block_nr = 0;
+               return BLOCK_CHANGED;
        }
 
-       badblocks_list_free(bb_list);
-       return;
+       return 0;
 }