Whamcloud - gitweb
AOSP: Android: run bpfmt on all bp files
[tools/e2fsprogs.git] / debugfs / set_fields.c
index 762e655..b001579 100644 (file)
@@ -30,6 +30,7 @@
 #ifdef HAVE_ERRNO_H
 #include <errno.h>
 #endif
+#include <assert.h>
 #if HAVE_STRINGS_H
 #include <strings.h>
 #endif
@@ -39,6 +40,7 @@
 #include "debugfs.h"
 #include "uuid/uuid.h"
 #include "e2p/e2p.h"
+#include "support/quotaio.h"
 
 static struct ext2_super_block set_sb;
 static struct ext2_inode_large set_inode;
@@ -50,6 +52,8 @@ static ext2_ino_t set_ino;
 static int array_idx;
 
 #define FLAG_ARRAY     0x0001
+#define FLAG_ALIAS     0x0002  /* Data intersects with other field */
+#define FLAG_CSUM      0x0004
 
 struct field_set_info {
        const char      *name;
@@ -66,12 +70,20 @@ static errcode_t parse_int(struct field_set_info *info, char *field, char *arg);
 static errcode_t parse_string(struct field_set_info *info, char *field, char *arg);
 static errcode_t parse_uuid(struct field_set_info *info, char *field, char *arg);
 static errcode_t parse_hashalg(struct field_set_info *info, char *field, char *arg);
+static errcode_t parse_encoding(struct field_set_info *info, char *field, char *arg);
 static errcode_t parse_time(struct field_set_info *info, char *field, char *arg);
 static errcode_t parse_bmap(struct field_set_info *info, char *field, char *arg);
 static errcode_t parse_gd_csum(struct field_set_info *info, char *field, char *arg);
+static errcode_t parse_inode_csum(struct field_set_info *info, char *field,
+                                 char *arg);
 static errcode_t parse_mmp_clear(struct field_set_info *info, char *field,
                                 char *arg);
 
+#if __GNUC_PREREQ (4, 6) || defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmissing-field-initializers"
+#endif
+
 static struct field_set_info super_fields[] = {
        { "inodes_count", &set_sb.s_inodes_count, NULL, 4, parse_uint },
        { "blocks_count", &set_sb.s_blocks_count, &set_sb.s_blocks_count_hi,
@@ -110,7 +122,6 @@ static struct field_set_info super_fields[] = {
        { "uuid", &set_sb.s_uuid, NULL, 16, parse_uuid },
        { "volume_name",  &set_sb.s_volume_name, NULL, 16, parse_string },
        { "last_mounted",  &set_sb.s_last_mounted, NULL, 64, parse_string },
-       { "lastcheck",  &set_sb.s_lastcheck, NULL, 4, parse_uint },
        { "algorithm_usage_bitmap", &set_sb.s_algorithm_usage_bitmap, NULL,
                  4, parse_uint },
        { "prealloc_blocks", &set_sb.s_prealloc_blocks, NULL, 1, parse_uint },
@@ -135,7 +146,6 @@ static struct field_set_info super_fields[] = {
        { "want_extra_isize", &set_sb.s_want_extra_isize, NULL, 2, parse_uint },
        { "flags", &set_sb.s_flags, NULL, 4, parse_uint },
        { "raid_stride", &set_sb.s_raid_stride, NULL, 2, parse_uint },
-       { "min_extra_isize", &set_sb.s_min_extra_isize, NULL, 4, parse_uint },
        { "mmp_interval", &set_sb.s_mmp_update_interval, NULL, 2, parse_uint },
        { "mmp_block", &set_sb.s_mmp_block, NULL, 8, parse_uint },
        { "raid_stripe_width", &set_sb.s_raid_stripe_width, NULL, 4, parse_uint },
@@ -149,24 +159,46 @@ static struct field_set_info super_fields[] = {
        { "mount_opts",  &set_sb.s_mount_opts, NULL, 64, parse_string },
        { "usr_quota_inum", &set_sb.s_usr_quota_inum, NULL, 4, parse_uint },
        { "grp_quota_inum", &set_sb.s_grp_quota_inum, NULL, 4, parse_uint },
-       { "overhead_blocks", &set_sb.s_overhead_blocks, NULL, 4, parse_uint },
+       { "prj_quota_inum", &set_sb.s_prj_quota_inum, NULL, 4, parse_uint },
+       { "overhead_clusters", &set_sb.s_overhead_clusters, NULL, 4, parse_uint },
        { "backup_bgs", &set_sb.s_backup_bgs[0], NULL, 4, parse_uint,
          FLAG_ARRAY, 2 },
        { "checksum", &set_sb.s_checksum, NULL, 4, parse_uint },
        { "checksum_type", &set_sb.s_checksum_type, NULL, 1, parse_uint },
+       { "encryption_level", &set_sb.s_encryption_level, NULL, 1, parse_uint },
+       { "error_count", &set_sb.s_error_count, NULL, 4, parse_uint },
+       { "first_error_time", &set_sb.s_first_error_time, NULL, 4, parse_time },
+       { "first_error_ino", &set_sb.s_first_error_ino, NULL, 4, parse_uint },
+       { "first_error_block", &set_sb.s_first_error_block, NULL, 8, parse_uint },
+       { "first_error_func", &set_sb.s_first_error_func, NULL, 32, parse_string },
+       { "first_error_line", &set_sb.s_first_error_line, NULL, 4, parse_uint },
+       { "last_error_time", &set_sb.s_last_error_time, NULL, 4, parse_time },
+       { "last_error_ino", &set_sb.s_last_error_ino, NULL, 4, parse_uint },
+       { "last_error_block", &set_sb.s_last_error_block, NULL, 8, parse_uint },
+       { "last_error_func", &set_sb.s_last_error_func, NULL, 32, parse_string },
+       { "last_error_line", &set_sb.s_last_error_line, NULL, 4, parse_uint },
+       { "encrypt_algos", &set_sb.s_encrypt_algos, NULL, 1, parse_uint,
+         FLAG_ARRAY, 4 },
+       { "encrypt_pw_salt", &set_sb.s_encrypt_pw_salt, NULL, 16, parse_uuid },
+       { "lpf_ino", &set_sb.s_lpf_ino, NULL, 4, parse_uint },
+       { "checksum_seed", &set_sb.s_checksum_seed, NULL, 4, parse_uint },
+       { "encoding", &set_sb.s_encoding, NULL, 2, parse_encoding },
        { 0, 0, 0, 0 }
 };
 
 static struct field_set_info inode_fields[] = {
-       { "inodes_count", &set_sb.s_inodes_count, NULL, 4, parse_uint },
        { "mode", &set_inode.i_mode, NULL, 2, parse_uint },
        { "uid", &set_inode.i_uid, &set_inode.osd2.linux2.l_i_uid_high,
                2, parse_uint },
        { "size", &set_inode.i_size, &set_inode.i_size_high, 4, parse_uint },
-       { "atime", &set_inode.i_atime, NULL, 4, parse_time },
-       { "ctime", &set_inode.i_ctime, NULL, 4, parse_time },
-       { "mtime", &set_inode.i_mtime, NULL, 4, parse_time },
-       { "dtime", &set_inode.i_dtime, NULL, 4, parse_time },
+       { "atime", &set_inode.i_atime, &set_inode.i_atime_extra,
+               4, parse_time },
+       { "ctime", &set_inode.i_ctime, &set_inode.i_ctime_extra,
+               4, parse_time },
+       { "mtime", &set_inode.i_mtime, &set_inode.i_mtime_extra,
+               4, parse_time },
+       { "dtime", &set_inode.i_dtime, NULL,
+               4, parse_time },
        { "gid", &set_inode.i_gid, &set_inode.osd2.linux2.l_i_gid_high,
                2, parse_uint },
        { "links_count", &set_inode.i_links_count, NULL, 2, parse_uint },
@@ -176,7 +208,8 @@ static struct field_set_info inode_fields[] = {
        { "flags", &set_inode.i_flags, NULL, 4, parse_uint },
        { "version", &set_inode.osd1.linux1.l_i_version,
                &set_inode.i_version_hi, 4, parse_uint },
-       { "translator", &set_inode.osd1.hurd1.h_i_translator, NULL, 4, parse_uint },
+       { "translator", &set_inode.osd1.hurd1.h_i_translator, NULL,
+               4, parse_uint, FLAG_ALIAS },
        { "block", &set_inode.i_block[0], NULL, 4, parse_uint, FLAG_ARRAY,
          EXT2_NDIR_BLOCKS },
        { "block[IND]", &set_inode.i_block[EXT2_IND_BLOCK], NULL, 4, parse_uint },
@@ -186,25 +219,26 @@ static struct field_set_info inode_fields[] = {
        /* Special case: i_file_acl_high is 2 bytes */
        { "file_acl", &set_inode.i_file_acl, 
                &set_inode.osd2.linux2.l_i_file_acl_high, 6, parse_uint },
-       { "dir_acl", &set_inode.i_dir_acl, NULL, 4, parse_uint },
        { "faddr", &set_inode.i_faddr, NULL, 4, parse_uint },
-       { "frag", &set_inode.osd2.hurd2.h_i_frag, NULL, 1, parse_uint },
+       { "frag", &set_inode.osd2.hurd2.h_i_frag, NULL, 1, parse_uint, FLAG_ALIAS },
        { "fsize", &set_inode.osd2.hurd2.h_i_fsize, NULL, 1, parse_uint },
        { "checksum", &set_inode.osd2.linux2.l_i_checksum_lo, 
-               &set_inode.i_checksum_hi, 2, parse_uint },
+               &set_inode.i_checksum_hi, 2, parse_inode_csum, FLAG_CSUM },
        { "author", &set_inode.osd2.hurd2.h_i_author, NULL,
-               4, parse_uint },
+               4, parse_uint, FLAG_ALIAS },
        { "extra_isize", &set_inode.i_extra_isize, NULL,
                2, parse_uint },
        { "ctime_extra", &set_inode.i_ctime_extra, NULL,
-               4, parse_uint },
+               4, parse_uint, FLAG_ALIAS },
        { "mtime_extra", &set_inode.i_mtime_extra, NULL,
-               4, parse_uint },
+               4, parse_uint, FLAG_ALIAS  },
        { "atime_extra", &set_inode.i_atime_extra, NULL,
-               4, parse_uint },
-       { "crtime", &set_inode.i_crtime, NULL, 4, parse_uint },
+               4, parse_uint, FLAG_ALIAS },
+       { "crtime", &set_inode.i_crtime, &set_inode.i_crtime_extra,
+               4, parse_time },
        { "crtime_extra", &set_inode.i_crtime_extra, NULL,
-               4, parse_uint },
+               4, parse_uint, FLAG_ALIAS },
+       { "projid", &set_inode.i_projid, NULL, 4, parse_uint },
        { "bmap", NULL, NULL, 4, parse_bmap, FLAG_ARRAY },
        { 0, 0, 0, 0 }
 };
@@ -249,7 +283,8 @@ static struct field_set_info ext4_bg_fields[] = {
 };
 
 static struct field_set_info mmp_fields[] = {
-       { "clear", &set_mmp.mmp_magic, NULL, sizeof(set_mmp), parse_mmp_clear },
+       { "clear", &set_mmp.mmp_magic, NULL, sizeof(set_mmp),
+               parse_mmp_clear, FLAG_ALIAS },
        { "magic", &set_mmp.mmp_magic, NULL, 4, parse_uint },
        { "seq", &set_mmp.mmp_seq, NULL, 4, parse_uint },
        { "time", &set_mmp.mmp_time, NULL, 8, parse_uint },
@@ -259,7 +294,63 @@ static struct field_set_info mmp_fields[] = {
                parse_string },
        { "check_interval", &set_mmp.mmp_check_interval, NULL, 2, parse_uint },
        { "checksum", &set_mmp.mmp_checksum, NULL, 4, parse_uint },
+       { 0, 0, 0, 0 }
 };
+#if __GNUC_PREREQ (4, 6)
+#pragma GCC diagnostic pop
+#endif
+
+#ifdef UNITTEST
+
+
+static void do_verify_field_set_info(struct field_set_info *fields,
+               const void *data, size_t size)
+{
+       struct field_set_info *ss, *ss2;
+       const char *begin = (char *)data;
+       const char *end = begin + size;
+
+       for (ss = fields ; ss->name ; ss++) {
+               const char *ptr;
+
+               /* Check pointers */
+               ptr = ss->ptr;
+               assert(!ptr || (ptr >= begin && ptr < end));
+               ptr = ss->ptr2;
+               assert(!ptr || (ptr >= begin && ptr < end));
+
+               /* Check function */
+               assert(ss->func);
+
+               for (ss2 = fields ; ss2 != ss ; ss2++) {
+                       /* Check duplicate names */
+                       assert(strcmp(ss->name, ss2->name));
+
+                       if (ss->flags & FLAG_ALIAS || ss2->flags & FLAG_ALIAS)
+                               continue;
+                       /* Check false aliases, might be copy-n-paste error */
+                       assert(!ss->ptr || (ss->ptr != ss2->ptr &&
+                                           ss->ptr != ss2->ptr2));
+                       assert(!ss->ptr2 || (ss->ptr2 != ss2->ptr &&
+                                            ss->ptr2 != ss2->ptr2));
+               }
+       }
+}
+
+int main(int argc, char **argv)
+{
+       do_verify_field_set_info(super_fields, &set_sb, sizeof(set_sb));
+       do_verify_field_set_info(inode_fields, &set_inode, sizeof(set_inode));
+       do_verify_field_set_info(ext2_bg_fields, &set_gd, sizeof(set_gd));
+       do_verify_field_set_info(ext4_bg_fields, &set_gd4, sizeof(set_gd4));
+       do_verify_field_set_info(mmp_fields, &set_mmp, sizeof(set_mmp));
+       return 0;
+}
+
+ext2_filsys current_fs;
+ext2_ino_t root, cwd;
+
+#endif /* UNITTEST */
 
 static int check_suffix(const char *field)
 {
@@ -312,8 +403,11 @@ static struct field_set_info *find_field(struct field_set_info *fields,
         */
        if (idx) {
                array_idx = strtol(idx, &tmp, 0);
-               if (*tmp)
+               if (*tmp) {
+                       *(--idx) = '[';
+                       *delim = ']';
                        idx = 0;
+               }
        }
 
        /*
@@ -344,7 +438,7 @@ static struct field_set_info *find_field(struct field_set_info *fields,
 
 /*
  * Note: info->size == 6 is special; this means a base size 4 bytes,
- * and secondiory (high) size of 2 bytes.  This is needed for the
+ * and secondary (high) size of 2 bytes.  This is needed for the
  * special case of i_blocks_high and i_file_acl_high.
  */
 static errcode_t parse_uint(struct field_set_info *info, char *field,
@@ -393,10 +487,7 @@ static errcode_t parse_uint(struct field_set_info *info, char *field,
        n = num & mask;
        switch (size) {
        case 8:
-               /* Should never get here */
-               fprintf(stderr, "64-bit field %s has a second 64-bit field\n"
-                       "defined; BUG?!?\n", info->name);
-               *u.ptr64 = 0;
+               *u.ptr64 = n;
                break;
        case 4:
                *u.ptr32 = n;
@@ -410,13 +501,16 @@ static errcode_t parse_uint(struct field_set_info *info, char *field,
        }
        if (!field2)
                return 0;
-       n = num >> (size*8);
+       n = (size == 8) ? 0 : (num >> (size*8));
        u.ptr8 = (__u8 *) field2;
        if (info->size == 6)
                size = 2;
        switch (size) {
        case 8:
-               *u.ptr64 = n;
+               /* Should never get here */
+               fprintf(stderr, "64-bit field %s has a second 64-bit field\n"
+                       "defined; BUG?!?\n", info->name);
+               *u.ptr64 = 0;
                break;
        case 4:
                *u.ptr32 = n;
@@ -478,21 +572,30 @@ static errcode_t parse_string(struct field_set_info *info,
 }
 
 static errcode_t parse_time(struct field_set_info *info,
-                           char *field EXT2FS_ATTR((unused)), char *arg)
+                           char *field, char *arg)
 {
-       time_t          t;
-       __u32           *ptr32;
+       __s64           t;
+       __u32           t_low, t_high;
+       __u32           *ptr_low, *ptr_high;
+
+       if (check_suffix(field))
+               return parse_uint(info, field, arg);
 
-       ptr32 = (__u32 *) info->ptr;
+       ptr_low  = (__u32 *) info->ptr;
+       ptr_high = (__u32 *) info->ptr2;
 
        t = string_to_time(arg);
 
-       if (t == ((time_t) -1)) {
+       if (t == -1) {
                fprintf(stderr, "Couldn't parse '%s' for field %s.\n",
                        arg, info->name);
                return EINVAL;
        }
-       *ptr32 = t;
+       t_low = (__u32) t;
+       t_high = ((t - (__s32)t) >> 32) & EXT4_EPOCH_MASK;
+       *ptr_low = t_low;
+       if (ptr_high)
+               *ptr_high = (*ptr_high & ~EXT4_EPOCH_MASK) | t_high;
        return 0;
 }
 
@@ -530,6 +633,19 @@ static errcode_t parse_hashalg(struct field_set_info *info,
        return 0;
 }
 
+static errcode_t parse_encoding(struct field_set_info *info,
+                               char *field EXT2FS_ATTR((unused)), char *arg)
+{
+       int     encoding;
+       unsigned char   *p = (unsigned char *) info->ptr;
+
+       encoding = e2p_str2encoding(arg);
+       if (encoding < 0)
+               return parse_uint(info, field, arg);
+       *p = encoding;
+       return 0;
+}
+
 static errcode_t parse_bmap(struct field_set_info *info,
                            char *field EXT2FS_ATTR((unused)), char *arg)
 {
@@ -545,8 +661,9 @@ static errcode_t parse_bmap(struct field_set_info *info,
        }
 
        retval = ext2fs_bmap2(current_fs, set_ino,
-                            (struct ext2_inode *) &set_inode,
-                            NULL, BMAP_SET, array_idx, NULL, &blk);
+                             (struct ext2_inode *) &set_inode,
+                             NULL, BMAP_ALLOC | BMAP_SET, array_idx, NULL,
+                             &blk);
        if (retval) {
                com_err("set_inode", retval, "while setting block map");
        }
@@ -556,18 +673,74 @@ static errcode_t parse_bmap(struct field_set_info *info,
 static errcode_t parse_gd_csum(struct field_set_info *info, char *field,
                               char *arg)
 {
+       __u16 *checksum = info->ptr;
 
        if (strcmp(arg, "calc") == 0) {
-               ext2fs_group_desc_csum_set(current_fs, set_bg);
-               memcpy(&set_gd, ext2fs_group_desc(current_fs,
-                                       current_fs->group_desc,
-                                       set_bg),
-                       sizeof(set_gd));
-               printf("Checksum set to 0x%04x\n",
-                      ext2fs_bg_checksum(current_fs, set_bg));
+               *checksum = ext2fs_group_desc_csum(current_fs, set_bg);
+               printf("Checksum set to 0x%04x\n", *checksum);
                return 0;
        }
+       return parse_uint(info, field, arg);
+}
+
+static errcode_t parse_inode_csum(struct field_set_info *info, char *field,
+                                 char *arg)
+{
+       errcode_t       retval = 0;
+       __u32           crc;
+       int             is_large_inode = 0;
 
+       if (strcmp(arg, "calc") == 0) {
+               size_t sz = EXT2_INODE_SIZE(current_fs->super);
+               struct ext2_inode_large *tmp_inode = NULL;
+
+               retval = ext2fs_get_mem(sz, &tmp_inode);
+               if (retval)
+                       goto out;
+
+               retval = ext2fs_read_inode_full(current_fs, set_ino,
+                                    (struct ext2_inode *) tmp_inode,
+                                    sz);
+               if (retval)
+                       goto out;
+
+#ifdef WORDS_BIGENDIAN
+               ext2fs_swap_inode_full(current_fs, tmp_inode,
+                                      tmp_inode, 1, sz);
+#endif
+
+               if (sz > EXT2_GOOD_OLD_INODE_SIZE)
+                       is_large_inode = 1;
+
+               retval = ext2fs_inode_csum_set(current_fs, set_ino,
+                                              tmp_inode);
+               if (retval)
+                       goto out;
+#ifdef WORDS_BIGENDIAN
+               crc = set_inode.i_checksum_lo =
+                       ext2fs_swab16(tmp_inode->i_checksum_lo);
+
+#else
+               crc = set_inode.i_checksum_lo = tmp_inode->i_checksum_lo;
+#endif
+               if (is_large_inode &&
+                   set_inode.i_extra_isize >=
+                               (offsetof(struct ext2_inode_large,
+                                         i_checksum_hi) -
+                                EXT2_GOOD_OLD_INODE_SIZE)) {
+#ifdef WORDS_BIGENDIAN
+                       set_inode.i_checksum_lo =
+                               ext2fs_swab16(tmp_inode->i_checksum_lo);
+#else
+                       set_inode.i_checksum_hi = tmp_inode->i_checksum_hi;
+#endif
+                       crc |= ((__u32)set_inode.i_checksum_hi) << 16;
+               }
+               printf("Checksum set to 0x%08x\n", crc);
+       out:
+               ext2fs_free_mem(&tmp_inode);
+               return retval;
+       }
        return parse_uint(info, field, arg);
 }
 
@@ -629,7 +802,8 @@ static void print_possible_fields(struct field_set_info *fields)
 }
 
 
-void do_set_super(int argc, char *argv[])
+void do_set_super(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+                 void *infop EXT2FS_ATTR((unused)))
 {
        const char *usage = "<field> <value>\n"
                "\t\"set_super_value -l\" will list the names of "
@@ -656,7 +830,8 @@ void do_set_super(int argc, char *argv[])
        }
 }
 
-void do_set_inode(int argc, char *argv[])
+void do_set_inode(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+                 void *infop EXT2FS_ATTR((unused)))
 {
        const char *usage = "<inode> <field> <value>\n"
                "\t\"set_inode_field -l\" will list the names of "
@@ -681,23 +856,28 @@ void do_set_inode(int argc, char *argv[])
        if (!set_ino)
                return;
 
-       if (debugfs_read_inode_full(set_ino,
-                       (struct ext2_inode *) &set_inode, argv[1],
-                                   sizeof(set_inode)))
+       if (debugfs_read_inode2(set_ino,
+                               (struct ext2_inode *) &set_inode, argv[1],
+                               sizeof(set_inode),
+                               (ss->flags & FLAG_CSUM) ?
+                               READ_INODE_NOCSUM : 0))
                return;
 
        if (ss->func(ss, argv[2], argv[3]) == 0) {
-               if (debugfs_write_inode_full(set_ino, 
-                            (struct ext2_inode *) &set_inode,
-                            argv[1], sizeof(set_inode)))
-                       return;
+               debugfs_write_inode2(set_ino,
+                                    (struct ext2_inode *) &set_inode,
+                                    argv[1], sizeof(set_inode),
+                                    (ss->flags & FLAG_CSUM) ?
+                                    WRITE_INODE_NOCSUM : 0);
        }
 }
 
-void do_set_block_group_descriptor(int argc, char *argv[])
+void do_set_block_group_descriptor(int argc, char *argv[],
+                                  int sci_idx EXT2FS_ATTR((unused)),
+                                  void *infop EXT2FS_ATTR((unused)))
 {
        const char *usage = "<bg number> <field> <value>\n"
-               "\t\"set_block_group_descriptor -l\" will list the names of "
+               "\t\"set_block_group -l\" will list the names of "
                "the fields in a block group descriptor\n\twhich can be set.";
        struct field_set_info   *table;
        struct field_set_info   *ss;
@@ -728,7 +908,7 @@ void do_set_block_group_descriptor(int argc, char *argv[])
                return;
        }
 
-       if (common_args_process(argc, argv, 4, 4, "set_block_group_descriptor",
+       if (common_args_process(argc, argv, 4, 4, "set_block_group",
                                usage, CHECK_FS_RW))
                return;
 
@@ -771,9 +951,10 @@ static errcode_t parse_mmp_clear(struct field_set_info *info,
        return 1; /* we don't need the MMP block written again */
 }
 
-void do_set_mmp_value(int argc, char *argv[])
-{
 #ifdef CONFIG_MMP
+void do_set_mmp_value(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+                     void *infop EXT2FS_ATTR((unused)))
+{
        const char *usage = "<field> <value>\n"
                "\t\"set_mmp_value -l\" will list the names of "
                "MMP fields\n\twhich can be set.";
@@ -828,9 +1009,15 @@ void do_set_mmp_value(int argc, char *argv[])
                                 &set_mmp);
                *mmp_s = set_mmp;
        }
+}
 #else
+void do_set_mmp_value(int argc EXT2FS_ATTR((unused)),
+                     char *argv[] EXT2FS_ATTR((unused)),
+                     int sci_idx EXT2FS_ATTR((unused)),
+                     void *infop EXT2FS_ATTR((unused)))
+{
        fprintf(stdout, "MMP is unsupported, please recompile with "
                        "--enable-mmp\n");
-#endif
 }
+#endif