Whamcloud - gitweb
Fix Debian rules files to support building non-Linux archs
[tools/e2fsprogs.git] / debugfs / debugfs.c
index 87867ff..6635471 100644 (file)
@@ -20,9 +20,6 @@
 extern int optind;
 extern char *optarg;
 #endif
-#ifdef HAVE_OPTRESET
-extern int optreset;           /* defined by BSD, but not others */
-#endif
 #ifdef HAVE_ERRNO_H
 #include <errno.h>
 #endif
@@ -34,35 +31,83 @@ extern int optreset;                /* defined by BSD, but not others */
 #include "ss/ss.h"
 #include "debugfs.h"
 #include "uuid/uuid.h"
+#include "e2p/e2p.h"
+
+#include <ext2fs/ext2_ext_attr.h>
 
 #include "../version.h"
 
 extern ss_request_table debug_cmds;
 
-ext2_filsys current_fs = NULL;
-ino_t  root, cwd;
+ext2_filsys    current_fs = NULL;
+ext2_ino_t     root, cwd;
 
-static void open_filesystem(char *device, int open_flags)
+static void open_filesystem(char *device, int open_flags, blk_t superblock,
+                           blk_t blocksize, int catastrophic, 
+                           char *data_filename)
 {
        int     retval;
+       io_channel data_io = 0;
+
+       if (superblock != 0 && blocksize == 0) {
+               com_err(device, 0, "if you specify the superblock, you must also specify the block size");
+               current_fs = NULL;
+               return;
+       }
+
+       if (data_filename) {
+               if ((open_flags & EXT2_FLAG_IMAGE_FILE) == 0) {
+                       com_err(device, 0, 
+                               "The -d option is only valid when reading an e2image file");
+                       current_fs = NULL;
+                       return;
+               }
+               retval = unix_io_manager->open(data_filename, 0, &data_io);
+               if (retval) {
+                       com_err(data_filename, 0, "while opening data source");
+                       current_fs = NULL;
+                       return;
+               }
+       }
+
+       if (catastrophic && (open_flags & EXT2_FLAG_RW)) {
+               com_err(device, 0,
+                       "opening read-only because of catastrophic mode");
+               open_flags &= ~EXT2_FLAG_RW;
+       }
        
-       retval = ext2fs_open(device, open_flags, 0, 0,
+       retval = ext2fs_open(device, open_flags, superblock, blocksize,
                             unix_io_manager, &current_fs);
        if (retval) {
                com_err(device, retval, "while opening filesystem");
                current_fs = NULL;
                return;
        }
-       retval = ext2fs_read_inode_bitmap(current_fs);
-       if (retval) {
-               com_err(device, retval, "while reading inode bitmap");
-               goto errout;
+
+       if (catastrophic)
+               com_err(device, 0, "catastrophic mode - not reading inode or group bitmaps");
+       else {
+               retval = ext2fs_read_inode_bitmap(current_fs);
+               if (retval) {
+                       com_err(device, retval, "while reading inode bitmap");
+                       goto errout;
+               }
+               retval = ext2fs_read_block_bitmap(current_fs);
+               if (retval) {
+                       com_err(device, retval, "while reading block bitmap");
+                       goto errout;
+               }
        }
-       retval = ext2fs_read_block_bitmap(current_fs);
-       if (retval) {
-               com_err(device, retval, "while reading block bitmap");
-               goto errout;
+
+       if (data_io) {
+               retval = ext2fs_set_data_io(current_fs, data_io);
+               if (retval) {
+                       com_err(device, retval, 
+                               "while setting data source");
+                       goto errout;
+               }
        }
+
        root = cwd = EXT2_ROOT_INO;
        return;
 
@@ -75,31 +120,78 @@ errout:
 
 void do_open_filesys(int argc, char **argv)
 {
-       const char      *usage = "Usage: open [-w] <device>";
-       int     c;
-       int open_flags = 0;
+       int     c, err;
+       int     catastrophic = 0;
+       blk_t   superblock = 0;
+       blk_t   blocksize = 0;
+       int     open_flags = EXT2_FLAG_SOFTSUPP_FEATURES;
+       char    *data_filename = 0;
        
-       optind = 0;
-#ifdef HAVE_OPTRESET
-       optreset = 1;           /* Makes BSD getopt happy */
-#endif
-       while ((c = getopt (argc, argv, "w")) != EOF) {
+       reset_getopt();
+       while ((c = getopt (argc, argv, "iwfecb:s:d:")) != EOF) {
                switch (c) {
+               case 'i':
+                       open_flags |= EXT2_FLAG_IMAGE_FILE;
+                       break;
                case 'w':
-                       open_flags = EXT2_FLAG_RW;
+                       open_flags |= EXT2_FLAG_RW;
+                       break;
+               case 'f':
+                       open_flags |= EXT2_FLAG_FORCE;
+                       break;
+               case 'e':
+                       open_flags |= EXT2_FLAG_EXCLUSIVE;
+                       break;
+               case 'c':
+                       catastrophic = 1;
+                       break;
+               case 'd':
+                       data_filename = optarg;
+                       break;
+               case 'b':
+                       blocksize = parse_ulong(optarg, argv[0],
+                                               "block size", &err);
+                       if (err)
+                               return;
+                       break;
+               case 's':
+                       superblock = parse_ulong(optarg, argv[0],
+                                                "superblock number", &err);
+                       if (err)
+                               return;
                        break;
                default:
-                       com_err(argv[0], 0, usage);
-                       return;
+                       goto print_usage;
                }
        }
        if (optind != argc-1) {
-               com_err(argv[0], 0, usage);
-               return;
+               goto print_usage;
        }
        if (check_fs_not_open(argv[0]))
                return;
-       open_filesystem(argv[optind], open_flags);
+       open_filesystem(argv[optind], open_flags,
+                       superblock, blocksize, catastrophic, 
+                       data_filename);
+       return;
+
+print_usage:
+       fprintf(stderr, "%s: Usage: open [-s superblock] [-b blocksize] "
+               "[-c] [-w] <device>\n", argv[0]);
+}
+
+void do_lcd(int argc, char **argv)
+{
+       if (argc != 2) {
+               com_err(argv[0], 0, "Usage: %s %s", argv[0], "<native dir>");
+               return;
+       }
+
+       if (chdir(argv[1]) == -1) {
+               com_err(argv[0], errno,
+                       "while trying to change native directory to %s",
+                       argv[1]);
+               return;
+       }
 }
 
 static void close_filesystem(NOARGS)
@@ -109,51 +201,42 @@ static void close_filesystem(NOARGS)
        if (current_fs->flags & EXT2_FLAG_IB_DIRTY) {
                retval = ext2fs_write_inode_bitmap(current_fs);
                if (retval)
-                       com_err("ext2fs_write_inode_bitmap", retval, "");
+                       com_err("ext2fs_write_inode_bitmap", retval, 0);
        }
        if (current_fs->flags & EXT2_FLAG_BB_DIRTY) {
                retval = ext2fs_write_block_bitmap(current_fs);
                if (retval)
-                       com_err("ext2fs_write_block_bitmap", retval, "");
+                       com_err("ext2fs_write_block_bitmap", retval, 0);
        }
        retval = ext2fs_close(current_fs);
        if (retval)
-               com_err("ext2fs_close", retval, "");
+               com_err("ext2fs_close", retval, 0);
        current_fs = NULL;
        return;
 }
 
 void do_close_filesys(int argc, char **argv)
 {
-       if (argc > 1) {
-               com_err(argv[0], 0, "Usage: close_filesys");
-               return;
-       }
-       if (check_fs_open(argv[0]))
+       if (common_args_process(argc, argv, 1, 1, "close_filesys", "", 0))
                return;
        close_filesystem();
 }
 
 void do_init_filesys(int argc, char **argv)
 {
-       const char      *usage = "Usage: initialize <device> <blocksize>";
        struct ext2_super_block param;
        errcode_t       retval;
-       char            *tmp;
+       int             err;
        
-       if (argc != 3) {
-               com_err(argv[0], 0, usage);
-               return;
-       }
-       if (check_fs_not_open(argv[0]))
+       if (common_args_process(argc, argv, 3, 3, "initialize",
+                               "<device> <blocksize>", CHECK_FS_NOTOPEN))
                return;
 
        memset(&param, 0, sizeof(struct ext2_super_block));
-       param.s_blocks_count = strtoul(argv[2], &tmp, 0);
-       if (*tmp) {
-               com_err(argv[0], 0, "Bad blocks count - %s", argv[2]);
+       param.s_blocks_count = parse_ulong(argv[2], argv[0],
+                                          "blocks count", &err);
+       if (err)
                return;
-       }
        retval = ext2fs_initialize(argv[1], 0, &param,
                                   unix_io_manager, &current_fs);
        if (retval) {
@@ -165,254 +248,423 @@ void do_init_filesys(int argc, char **argv)
        return;
 }
 
+static void print_features(struct ext2_super_block * s, FILE *f)
+{
+       int     i, j, printed=0;
+       __u32   *mask = &s->s_feature_compat, m;
+
+       fputs("Filesystem features:", f);
+       for (i=0; i <3; i++,mask++) {
+               for (j=0,m=1; j < 32; j++, m<<=1) {
+                       if (*mask & m) {
+                               fprintf(f, " %s", e2p_feature2string(i, m));
+                               printed++;
+                       }
+               }
+       }
+       if (printed == 0)
+               fputs("(none)", f);
+       fputs("\n", f);
+}
+
+static void print_bg_opts(struct ext2_group_desc *gdp, int mask,
+                         const char *str, int *first, FILE *f)
+{
+       if (gdp->bg_flags & mask) {
+               if (*first) {
+                       fputs("           [", f);
+                       *first = 0;
+               } else
+                       fputs(", ", f);
+               fputs(str, f);
+       }
+}
+
 void do_show_super_stats(int argc, char *argv[])
 {
-       int     i;
+       dgrp_t  i;
        FILE    *out;
-       struct ext2fs_sb *sb;
        struct ext2_group_desc *gdp;
-       char buf[80];
-       const char *none = "(none)";
+       int     c, header_only = 0;
+       int     numdirs = 0, first;
 
-       if (argc > 1) {
-               com_err(argv[0], 0, "Usage: show_super");
-               return;
+       reset_getopt();
+       while ((c = getopt (argc, argv, "h")) != EOF) {
+               switch (c) {
+               case 'h':
+                       header_only++;
+                       break;
+               default:
+                       goto print_usage;
+               }
+       }
+       if (optind != argc) {
+               goto print_usage;
        }
        if (check_fs_open(argv[0]))
                return;
        out = open_pager();
-       sb = (struct ext2fs_sb *) current_fs->super;
-       fprintf(out, "Filesystem is read-%s\n",
-               current_fs->flags & EXT2_FLAG_RW ? "write" : "only");
-       if (sb->s_volume_name[0]) {
-               memset(buf, 0, sizeof(buf));
-               strncpy(buf, sb->s_volume_name, sizeof(sb->s_volume_name));
-       } else
-               strcpy(buf, none);
-       fprintf(out, "Volume name = %s\n", buf);
-       if (sb->s_last_mounted[0]) {
-               memset(buf, 0, sizeof(buf));
-               strncpy(buf, sb->s_last_mounted, sizeof(sb->s_last_mounted));
-       } else
-               strcpy(buf, none);
-       fprintf(out, "Last mounted directory = %s\n", buf);
-       if (!uuid_is_null(sb->s_uuid))
-               uuid_unparse(sb->s_uuid, buf);
-       else
-               strcpy(buf, none);
-       fprintf(out, "Filesystem UUID = %s\n", buf);
-       fprintf(out, "Last mount time = %s", time_to_string(sb->s_mtime));
-       fprintf(out, "Last write time = %s", time_to_string(sb->s_wtime));
-       fprintf(out, "Mount counts = %d (maximal = %d)\n",
-               sb->s_mnt_count, sb->s_max_mnt_count);
-       fputs ("Filesystem OS type = ", out);
-       switch (sb->s_creator_os) {
-           case EXT2_OS_LINUX: fputs ("Linux\n", out); break;
-           case EXT2_OS_HURD:  fputs ("GNU\n", out); break;
-           case EXT2_OS_MASIX: fputs ("Masix\n", out); break;
-           default:            fputs ("unknown\n", out);
-       }
-       fprintf(out, "Superblock size = %d\n",
-               sizeof(struct ext2_super_block));
-       fprintf(out, "Block size = %d, fragment size = %d\n",
-               EXT2_BLOCK_SIZE(sb), EXT2_FRAG_SIZE(sb));
-       fprintf(out, "Inode size = %d\n", EXT2_INODE_SIZE(sb));
-       fprintf(out, "%d inodes, %d free\n", sb->s_inodes_count,
-               sb->s_free_inodes_count);
-       fprintf(out, "%d blocks, %d free, %d reserved, first block = %d\n",
-               sb->s_blocks_count, sb->s_free_blocks_count,
-               sb->s_r_blocks_count, sb->s_first_data_block);
-       fprintf(out, "%d blocks per group\n", sb->s_blocks_per_group);
-       fprintf(out, "%d fragments per group\n", sb->s_frags_per_group);
-       fprintf(out, "%d inodes per group\n", EXT2_INODES_PER_GROUP(sb));
-       fprintf(out, "%ld group%s (%ld descriptors block%s)\n",
-               current_fs->group_desc_count,
-               (current_fs->group_desc_count != 1) ? "s" : "",
-               current_fs->desc_blocks,
-               (current_fs->desc_blocks != 1) ? "s" : "");
+
+       list_super2(current_fs->super, out);
+       for (i=0; i < current_fs->group_desc_count; i++)
+               numdirs += current_fs->group_desc[i].bg_used_dirs_count;
+       fprintf(out, "Directories:              %d\n", numdirs);
+       
+       if (header_only) {
+               close_pager(out);
+               return;
+       }
        
        gdp = &current_fs->group_desc[0];
-       for (i = 0; i < current_fs->group_desc_count; i++, gdp++)
-               fprintf(out, " Group %2d: block bitmap at %d, "
-                       "inode bitmap at %d, "
-                       "inode table at %d\n"
-                       "           %d free block%s, "
-                       "%d free inode%s, "
-                       "%d used director%s\n",
+       for (i = 0; i < current_fs->group_desc_count; i++, gdp++) {
+               fprintf(out, " Group %2d: block bitmap at %u, "
+                       "inode bitmap at %u, "
+                       "inode table at %u\n"
+                       "           %d free %s, "
+                       "%d free %s, "
+                       "%d used %s\n",
                        i, gdp->bg_block_bitmap,
                        gdp->bg_inode_bitmap, gdp->bg_inode_table,
                        gdp->bg_free_blocks_count,
-                       gdp->bg_free_blocks_count != 1 ? "s" : "",
+                       gdp->bg_free_blocks_count != 1 ? "blocks" : "block",
                        gdp->bg_free_inodes_count,
-                       gdp->bg_free_inodes_count != 1 ? "s" : "",
+                       gdp->bg_free_inodes_count != 1 ? "inodes" : "inode",
                        gdp->bg_used_dirs_count,
-                       gdp->bg_used_dirs_count != 1 ? "ies" : "y");
+                       gdp->bg_used_dirs_count != 1 ? "directories"
+                               : "directory");
+               first = 1;
+               print_bg_opts(gdp, EXT2_BG_INODE_UNINIT, "Inode not init",
+                             &first, out);
+               print_bg_opts(gdp, EXT2_BG_BLOCK_UNINIT, "Block not init",
+                             &first, out);
+               if (!first)
+                       fputs("]\n", out);
+       }
        close_pager(out);
+       return;
+print_usage:
+       fprintf(stderr, "%s: Usage: show_super [-h]\n", argv[0]);
 }
 
-void do_dirty_filesys(int argc, char **argv)
+void do_dirty_filesys(int argc EXT2FS_ATTR((unused)), 
+                     char **argv EXT2FS_ATTR((unused)))
 {
        if (check_fs_open(argv[0]))
                return;
-       
+       if (check_fs_read_write(argv[0]))
+               return;
+
+       if (argv[1] && !strcmp(argv[1], "-clean"))
+               current_fs->super->s_state |= EXT2_VALID_FS;
+       else
+               current_fs->super->s_state &= ~EXT2_VALID_FS;
        ext2fs_mark_super_dirty(current_fs);
 }
 
 struct list_blocks_struct {
-       FILE    *f;
-       int     total;
+       FILE            *f;
+       e2_blkcnt_t     total;
+       blk_t           first_block, last_block;
+       e2_blkcnt_t     first_bcnt, last_bcnt;
+       e2_blkcnt_t     first;
 };
 
-static int list_blocks_proc(ext2_filsys fs, blk_t *blocknr, int blockcnt,
+static void finish_range(struct list_blocks_struct *lb)
+{
+       if (lb->first_block == 0)
+               return;
+       if (lb->first)
+               lb->first = 0;
+       else
+               fprintf(lb->f, ", ");
+       if (lb->first_block == lb->last_block)
+               fprintf(lb->f, "(%lld):%u",
+                       (long long)lb->first_bcnt, lb->first_block);
+       else
+               fprintf(lb->f, "(%lld-%lld):%u-%u",
+                       (long long)lb->first_bcnt, (long long)lb->last_bcnt,
+                       lb->first_block, lb->last_block);
+       lb->first_block = 0;
+}
+
+static int list_blocks_proc(ext2_filsys fs EXT2FS_ATTR((unused)), 
+                           blk_t *blocknr, e2_blkcnt_t blockcnt, 
+                           blk_t ref_block EXT2FS_ATTR((unused)),
+                           int ref_offset EXT2FS_ATTR((unused)), 
                            void *private)
 {
        struct list_blocks_struct *lb = (struct list_blocks_struct *) private;
 
-       fprintf(lb->f, "%d ", *blocknr);
        lb->total++;
+       if (blockcnt >= 0) {
+               /*
+                * See if we can add on to the existing range (if it exists)
+                */
+               if (lb->first_block &&
+                   (lb->last_block+1 == *blocknr) &&
+                   (lb->last_bcnt+1 == blockcnt)) {
+                       lb->last_block = *blocknr;
+                       lb->last_bcnt = blockcnt;
+                       return 0;
+               }
+               /*
+                * Start a new range.
+                */
+               finish_range(lb);
+               lb->first_block = lb->last_block = *blocknr;
+               lb->first_bcnt = lb->last_bcnt = blockcnt;
+               return 0;
+       }
+       /*
+        * Not a normal block.  Always force a new range.
+        */
+       finish_range(lb);
+       if (lb->first)
+               lb->first = 0;
+       else
+               fprintf(lb->f, ", ");
+       if (blockcnt == -1)
+               fprintf(lb->f, "(IND):%u", *blocknr);
+       else if (blockcnt == -2)
+               fprintf(lb->f, "(DIND):%u", *blocknr);
+       else if (blockcnt == -3)
+               fprintf(lb->f, "(TIND):%u", *blocknr);
        return 0;
 }
 
+static void dump_xattr_string(FILE *out, const char *str, int len)
+{
+       int printable = 1;
+       int i;
+       
+       /* check is string printable? */
+       for (i = 0; i < len; i++)
+               if (!isprint(str[i])) {
+                       printable = 0;
+                       break;
+               }
+
+       for (i = 0; i < len; i++)
+               if (printable)
+                       fprintf(out, "%c", (unsigned char)str[i]);
+               else
+                       fprintf(out, "%02x ", (unsigned char)str[i]);
+}
 
-static void dump_blocks(FILE *f, ino_t inode)
+static void internal_dump_inode_extra(FILE *out, 
+                                     const char *prefix EXT2FS_ATTR((unused)),
+                                     ext2_ino_t inode_num EXT2FS_ATTR((unused)), 
+                                     struct ext2_inode_large *inode)
+{
+       struct ext2_ext_attr_entry *entry;
+       __u32 *magic;
+       char *start, *end;
+       unsigned int storage_size;
+
+       fprintf(out, "Size of extra inode fields: %u\n", inode->i_extra_isize);
+       if (inode->i_extra_isize > EXT2_INODE_SIZE(current_fs->super) -
+                       EXT2_GOOD_OLD_INODE_SIZE) {
+               fprintf(stderr, "invalid inode->i_extra_isize (%u)\n",
+                               inode->i_extra_isize);
+               return;
+       }
+       storage_size = EXT2_INODE_SIZE(current_fs->super) -
+                       EXT2_GOOD_OLD_INODE_SIZE -
+                       inode->i_extra_isize;
+       magic = (__u32 *)((char *)inode + EXT2_GOOD_OLD_INODE_SIZE +
+                       inode->i_extra_isize);
+       if (*magic == EXT2_EXT_ATTR_MAGIC) {
+               fprintf(out, "Extended attributes stored in inode body: \n");
+               end = (char *) inode + EXT2_INODE_SIZE(current_fs->super);
+               start = (char *) magic + sizeof(__u32);
+               entry = (struct ext2_ext_attr_entry *) start;
+               while (!EXT2_EXT_IS_LAST_ENTRY(entry)) {
+                       struct ext2_ext_attr_entry *next =
+                               EXT2_EXT_ATTR_NEXT(entry);
+                       if (entry->e_value_size > storage_size ||
+                                       (char *) next >= end) {
+                               fprintf(out, "invalid EA entry in inode\n");
+                               return;
+                       }
+                       fprintf(out, "  ");
+                       dump_xattr_string(out, EXT2_EXT_ATTR_NAME(entry), 
+                                         entry->e_name_len);
+                       fprintf(out, " = \"");
+                       dump_xattr_string(out, start + entry->e_value_offs,
+                                               entry->e_value_size);
+                       fprintf(out, "\" (%u)\n", entry->e_value_size);
+                       entry = next;
+               }
+       }
+}
+
+static void dump_blocks(FILE *f, const char *prefix, ext2_ino_t inode)
 {
        struct list_blocks_struct lb;
 
-       fprintf(f, "BLOCKS:\n");
+       fprintf(f, "%sBLOCKS:\n%s", prefix, prefix);
        lb.total = 0;
+       lb.first_block = 0;
        lb.f = f;
-       ext2fs_block_iterate(current_fs, inode, 0, NULL,
+       lb.first = 1;
+       ext2fs_block_iterate2(current_fs, inode, 0, NULL,
                             list_blocks_proc, (void *)&lb);
+       finish_range(&lb);
        if (lb.total)
-               fprintf(f, "\nTOTAL: %d\n", lb.total);
+               fprintf(f, "\n%sTOTAL: %lld\n", prefix, (long long)lb.total);
        fprintf(f,"\n");
 }
 
 
-static void dump_inode(ino_t inode_num, struct ext2_inode inode)
+void internal_dump_inode(FILE *out, const char *prefix,
+                        ext2_ino_t inode_num, struct ext2_inode *inode,
+                        int do_dump_blocks)
 {
        const char *i_type;
-       FILE    *out;
        char frag, fsize;
        int os = current_fs->super->s_creator_os;
        
-       out = open_pager();
-       if (LINUX_S_ISDIR(inode.i_mode)) i_type = "directory";
-       else if (LINUX_S_ISREG(inode.i_mode)) i_type = "regular";
-       else if (LINUX_S_ISLNK(inode.i_mode)) i_type = "symlink";
-       else if (LINUX_S_ISBLK(inode.i_mode)) i_type = "block special";
-       else if (LINUX_S_ISCHR(inode.i_mode)) i_type = "character special";
-       else if (LINUX_S_ISFIFO(inode.i_mode)) i_type = "FIFO";
-       else if (LINUX_S_ISSOCK(inode.i_mode)) i_type = "socket";
+       if (LINUX_S_ISDIR(inode->i_mode)) i_type = "directory";
+       else if (LINUX_S_ISREG(inode->i_mode)) i_type = "regular";
+       else if (LINUX_S_ISLNK(inode->i_mode)) i_type = "symlink";
+       else if (LINUX_S_ISBLK(inode->i_mode)) i_type = "block special";
+       else if (LINUX_S_ISCHR(inode->i_mode)) i_type = "character special";
+       else if (LINUX_S_ISFIFO(inode->i_mode)) i_type = "FIFO";
+       else if (LINUX_S_ISSOCK(inode->i_mode)) i_type = "socket";
        else i_type = "bad type";
-       fprintf(out, "Inode: %ld   Type: %s    ", inode_num, i_type);
-#if defined(HAVE_EXT2_INODE_VERSION)
-       fprintf(out, "Mode:  %04o   Flags: 0x%x   Version: %d\n",
-               inode.i_mode & 0777, inode.i_flags, inode.i_version);
-#else
-       fprintf(out, "Mode:  %04o   Flags: 0x%x   Generation: %d\n",
-               inode.i_mode & 0777, inode.i_flags, inode.i_generation);
-#endif
-       fprintf(out, "User: %5d   Group: %5d   Size: ",
-               inode.i_uid, inode.i_gid);
-       if (LINUX_S_ISDIR(inode.i_mode))
-               fprintf(out, "%d\n", inode.i_size);
-       else {
-               __u64 i_size = (inode.i_size |
-                               ((unsigned long long)inode.i_size_high << 32));
-               
-               fprintf(out, "%lld\n", i_size);
-       }
-       if (current_fs->super->s_creator_os == EXT2_OS_HURD)
+       fprintf(out, "%sInode: %u   Type: %s    ", prefix, inode_num, i_type);
+       fprintf(out, "%sMode:  %04o   Flags: 0x%x   Generation: %u\n",
+               prefix, 
+               inode->i_mode & 0777, inode->i_flags, inode->i_generation);
+       fprintf(out, "%sUser: %5d   Group: %5d   Size: ",
+               prefix, inode_uid(*inode), inode_gid(*inode));
+       if (LINUX_S_ISREG(inode->i_mode)) {
+               unsigned long long i_size = (inode->i_size |
+                                   ((unsigned long long)inode->i_size_high << 32));
+
+               fprintf(out, "%llu\n", i_size);
+       } else
+               fprintf(out, "%d\n", inode->i_size);
+       if (os == EXT2_OS_HURD)
                fprintf(out,
-                       "File ACL: %d    Directory ACL: %d Translator: %d\n",
-                       inode.i_file_acl, LINUX_S_ISDIR(inode.i_mode) ? inode.i_dir_acl : 0,
-                       inode.osd1.hurd1.h_i_translator);
+                       "%sFile ACL: %d    Directory ACL: %d Translator: %d\n",
+                       prefix,
+                       inode->i_file_acl, LINUX_S_ISDIR(inode->i_mode) ? inode->i_dir_acl : 0,
+                       inode->osd1.hurd1.h_i_translator);
+       else
+               fprintf(out, "%sFile ACL: %d    Directory ACL: %d\n",
+                       prefix,
+                       inode->i_file_acl, LINUX_S_ISDIR(inode->i_mode) ? inode->i_dir_acl : 0);
+       if (os == EXT2_OS_LINUX) 
+               fprintf(out, "%sLinks: %d   Blockcount: %llu\n",
+                       prefix, inode->i_links_count, 
+                       (((unsigned long long) 
+                         inode->osd2.linux2.l_i_blocks_hi << 32)) + 
+                       inode->i_blocks);
        else
-               fprintf(out, "File ACL: %d    Directory ACL: %d\n",
-                       inode.i_file_acl, LINUX_S_ISDIR(inode.i_mode) ? inode.i_dir_acl : 0);
-       fprintf(out, "Links: %d   Blockcount: %d\n", inode.i_links_count,
-               inode.i_blocks);
+               fprintf(out, "%sLinks: %d   Blockcount: %u\n",
+                       prefix, inode->i_links_count, inode->i_blocks);
        switch (os) {
-           case EXT2_OS_LINUX:
-               frag = inode.osd2.linux2.l_i_frag;
-               fsize = inode.osd2.linux2.l_i_fsize;
-               break;
            case EXT2_OS_HURD:
-               frag = inode.osd2.hurd2.h_i_frag;
-               fsize = inode.osd2.hurd2.h_i_fsize;
+               frag = inode->osd2.hurd2.h_i_frag;
+               fsize = inode->osd2.hurd2.h_i_fsize;
                break;
            case EXT2_OS_MASIX:
-               frag = inode.osd2.masix2.m_i_frag;
-               fsize = inode.osd2.masix2.m_i_fsize;
+               frag = inode->osd2.masix2.m_i_frag;
+               fsize = inode->osd2.masix2.m_i_fsize;
                break;
            default:
                frag = fsize = 0;
        }
-       fprintf(out, "Fragment:  Address: %d    Number: %d    Size: %d\n",
-               inode.i_faddr, frag, fsize);
-       fprintf(out, "ctime: 0x%08x -- %s", inode.i_ctime,
-               time_to_string(inode.i_ctime));
-       fprintf(out, "atime: 0x%08x -- %s", inode.i_atime,
-               time_to_string(inode.i_atime));
-       fprintf(out, "mtime: 0x%08x -- %s", inode.i_mtime,
-               time_to_string(inode.i_mtime));
-       if (inode.i_dtime) 
-         fprintf(out, "dtime: 0x%08x -- %s", inode.i_dtime,
-                 time_to_string(inode.i_dtime));
-       if (LINUX_S_ISLNK(inode.i_mode) && inode.i_blocks == 0)
-               fprintf(out, "Fast_link_dest: %s\n", (char *)inode.i_block);
-       else
-               dump_blocks(out, inode_num);
-       close_pager(out);
+       fprintf(out, "%sFragment:  Address: %d    Number: %d    Size: %d\n",
+               prefix, inode->i_faddr, frag, fsize);
+       fprintf(out, "%sctime: 0x%08x -- %s", prefix, inode->i_ctime,
+               time_to_string(inode->i_ctime));
+       fprintf(out, "%satime: 0x%08x -- %s", prefix, inode->i_atime,
+               time_to_string(inode->i_atime));
+       fprintf(out, "%smtime: 0x%08x -- %s", prefix, inode->i_mtime,
+               time_to_string(inode->i_mtime));
+       if (inode->i_dtime) 
+         fprintf(out, "%sdtime: 0x%08x -- %s", prefix, inode->i_dtime,
+                 time_to_string(inode->i_dtime));
+       if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
+               internal_dump_inode_extra(out, prefix, inode_num,
+                                         (struct ext2_inode_large *) inode);
+       if (LINUX_S_ISLNK(inode->i_mode) && ext2fs_inode_data_blocks(current_fs,inode) == 0)
+               fprintf(out, "%sFast_link_dest: %.*s\n", prefix,
+                       (int) inode->i_size, (char *)inode->i_block);
+       else if (LINUX_S_ISBLK(inode->i_mode) || LINUX_S_ISCHR(inode->i_mode)) {
+               int major, minor;
+               const char *devnote;
+
+               if (inode->i_block[0]) {
+                       major = (inode->i_block[0] >> 8) & 255;
+                       minor = inode->i_block[0] & 255;
+                       devnote = "";
+               } else {
+                       major = (inode->i_block[1] & 0xfff00) >> 8;
+                       minor = ((inode->i_block[1] & 0xff) | 
+                                ((inode->i_block[1] >> 12) & 0xfff00));
+                       devnote = "(New-style) ";
+               }
+               fprintf(out, "%sDevice major/minor number: %02d:%02d (hex %02x:%02x)\n", 
+                       devnote, major, minor, major, minor);
+       }
+       else if (do_dump_blocks)
+               dump_blocks(out, prefix, inode_num);
 }
 
+static void dump_inode(ext2_ino_t inode_num, struct ext2_inode *inode)
+{
+       FILE    *out;
+       
+       out = open_pager();
+       internal_dump_inode(out, "", inode_num, inode, 1);
+       close_pager(out);
+}
 
 void do_stat(int argc, char *argv[])
 {
-       ino_t   inode;
-       struct ext2_inode inode_buf;
-       int retval;
+       ext2_ino_t      inode;
+       struct ext2_inode * inode_buf;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: stat <file>");
-               return;
-       }
        if (check_fs_open(argv[0]))
                return;
-       inode = string_to_inode(argv[1]);
-       if (!inode) 
+
+       inode_buf = (struct ext2_inode *)
+                       malloc(EXT2_INODE_SIZE(current_fs->super));
+       if (!inode_buf) {
+               fprintf(stderr, "do_stat: can't allocate buffer\n");
+               return;
+       }
+
+       if (common_inode_args_process(argc, argv, &inode, 0)) {
+               free(inode_buf);
                return;
+       }
 
-       retval = ext2fs_read_inode(current_fs, inode, &inode_buf);
-       if (retval) 
-         {
-           com_err(argv[0], retval, "while trying to read inode %d", inode);
-           return;
-         }
+       if (debugfs_read_inode_full(inode, inode_buf, argv[0],
+                                       EXT2_INODE_SIZE(current_fs->super))) {
+               free(inode_buf);
+               return;
+       }
 
-       dump_inode(inode,inode_buf);
+       dump_inode(inode, inode_buf);
+       free(inode_buf);
        return;
 }
 
 void do_chroot(int argc, char *argv[])
 {
-       ino_t inode;
+       ext2_ino_t inode;
        int retval;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: chroot <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-       inode = string_to_inode(argv[1]);
-       if (!inode) 
+       if (common_inode_args_process(argc, argv, &inode, 0))
                return;
 
        retval = ext2fs_check_directory(current_fs, inode);
        if (retval)  {
-               com_err(argv[1], retval, "");
+               com_err(argv[1], retval, 0);
                return;
        }
        root = inode;
@@ -420,51 +672,25 @@ void do_chroot(int argc, char *argv[])
 
 void do_clri(int argc, char *argv[])
 {
-       ino_t inode;
-       int retval;
+       ext2_ino_t inode;
        struct ext2_inode inode_buf;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: clri <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-       if (check_fs_read_write(argv[0]))
-               return;
-       inode = string_to_inode(argv[1]);
-       if (!inode) 
+       if (common_inode_args_process(argc, argv, &inode, CHECK_FS_RW))
                return;
 
-       retval = ext2fs_read_inode(current_fs, inode, &inode_buf);
-       if (retval) {
-               com_err(argv[0], retval, "while trying to read inode %d", 
-                       inode);
+       if (debugfs_read_inode(inode, &inode_buf, argv[0]))
                return;
-       }
        memset(&inode_buf, 0, sizeof(inode_buf));
-       retval = ext2fs_write_inode(current_fs, inode, &inode_buf);
-       if (retval) {
-               com_err(argv[0], retval, "while trying to write inode %d",
-                       inode);
+       if (debugfs_write_inode(inode, &inode_buf, argv[0]))
                return;
-       }
 }
 
 void do_freei(int argc, char *argv[])
 {
-       ino_t inode;
+       ext2_ino_t inode;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: freei <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-       if (check_fs_read_write(argv[0]))
-               return;
-       inode = string_to_inode(argv[1]);
-       if (!inode) 
+       if (common_inode_args_process(argc, argv, &inode,
+                                     CHECK_FS_RW | CHECK_FS_BITMAPS))
                return;
 
        if (!ext2fs_test_inode_bitmap(current_fs->inode_map,inode))
@@ -475,18 +701,10 @@ void do_freei(int argc, char *argv[])
 
 void do_seti(int argc, char *argv[])
 {
-       ino_t inode;
+       ext2_ino_t inode;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: seti <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-       if (check_fs_read_write(argv[0]))
-               return;
-       inode = string_to_inode(argv[1]);
-       if (!inode) 
+       if (common_inode_args_process(argc, argv, &inode,
+                                     CHECK_FS_RW | CHECK_FS_BITMAPS))
                return;
 
        if (ext2fs_test_inode_bitmap(current_fs->inode_map,inode))
@@ -497,92 +715,69 @@ void do_seti(int argc, char *argv[])
 
 void do_testi(int argc, char *argv[])
 {
-       ino_t inode;
+       ext2_ino_t inode;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: testi <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-       inode = string_to_inode(argv[1]);
-       if (!inode) 
+       if (common_inode_args_process(argc, argv, &inode, CHECK_FS_BITMAPS))
                return;
 
        if (ext2fs_test_inode_bitmap(current_fs->inode_map,inode))
-               printf("Inode %ld is marked in use\n", inode);
+               printf("Inode %u is marked in use\n", inode);
        else
-               printf("Inode %ld is not in use\n", inode);
+               printf("Inode %u is not in use\n", inode);
 }
 
-
 void do_freeb(int argc, char *argv[])
 {
        blk_t block;
-       char *tmp;
+       blk_t count = 1;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: freeb <block>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
+       if (common_block_args_process(argc, argv, &block, &count))
                return;
        if (check_fs_read_write(argv[0]))
                return;
-       block = strtoul(argv[1], &tmp, 0);
-       if (!block || *tmp) {
-               com_err(argv[0], 0, "No block 0");
-               return;
-       } 
-       if (!ext2fs_test_block_bitmap(current_fs->block_map,block))
-               com_err(argv[0], 0, "Warning: block already clear");
-       ext2fs_unmark_block_bitmap(current_fs->block_map,block);
+       while (count-- > 0) {
+               if (!ext2fs_test_block_bitmap(current_fs->block_map,block))
+                       com_err(argv[0], 0, "Warning: block %u already clear",
+                               block);
+               ext2fs_unmark_block_bitmap(current_fs->block_map,block);
+               block++;
+       }
        ext2fs_mark_bb_dirty(current_fs);
 }
 
 void do_setb(int argc, char *argv[])
 {
        blk_t block;
-       char *tmp;
+       blk_t count = 1;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: setb <block>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
+       if (common_block_args_process(argc, argv, &block, &count))
                return;
        if (check_fs_read_write(argv[0]))
                return;
-       block = strtoul(argv[1], &tmp, 0);
-       if (!block || *tmp) {
-               com_err(argv[0], 0, "No block 0");
-               return;
-       } 
-       if (ext2fs_test_block_bitmap(current_fs->block_map,block))
-               com_err(argv[0], 0, "Warning: block already set");
-       ext2fs_mark_block_bitmap(current_fs->block_map,block);
+       while (count-- > 0) {
+               if (ext2fs_test_block_bitmap(current_fs->block_map,block))
+                       com_err(argv[0], 0, "Warning: block %u already set",
+                               block);
+               ext2fs_mark_block_bitmap(current_fs->block_map,block);
+               block++;
+       }
        ext2fs_mark_bb_dirty(current_fs);
 }
 
 void do_testb(int argc, char *argv[])
 {
        blk_t block;
-       char *tmp;
+       blk_t count = 1;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: testb <block>");
+       if (common_block_args_process(argc, argv, &block, &count))
                return;
+       while (count-- > 0) {
+               if (ext2fs_test_block_bitmap(current_fs->block_map,block))
+                       printf("Block %u marked in use\n", block);
+               else
+                       printf("Block %u not in use\n", block);
+               block++;
        }
-       if (check_fs_open(argv[0]))
-               return;
-       block = strtoul(argv[1], &tmp, 0);
-       if (!block || *tmp) {
-               com_err(argv[0], 0, "No block 0");
-               return;
-       } 
-       if (ext2fs_test_block_bitmap(current_fs->block_map,block))
-               printf("Block %d marked in use\n", block);
-       else printf("Block %d not in use\n", block);
 }
 
 static void modify_u8(char *com, const char *prompt,
@@ -652,47 +847,39 @@ static void modify_u32(char *com, const char *prompt,
 void do_modify_inode(int argc, char *argv[])
 {
        struct ext2_inode inode;
-       ino_t inode_num;
-       int i;
-       errcode_t       retval;
-       unsigned char *frag, *fsize;
-       char    buf[80];
-       int os = current_fs->super->s_creator_os;
-       const char *hex_format = "0x%x";
-       const char *octal_format = "0%o";
-       const char *decimal_format = "%d";
+       ext2_ino_t      inode_num;
+       int             i;
+       unsigned char   *frag, *fsize;
+       char            buf[80];
+       int             os;
+       const char      *hex_format = "0x%x";
+       const char      *octal_format = "0%o";
+       const char      *decimal_format = "%d";
+       const char      *unsignedlong_format = "%lu";
        
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: modify_inode <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-       if (check_fs_read_write(argv[0]))
+       if (common_inode_args_process(argc, argv, &inode_num, CHECK_FS_RW))
                return;
 
-       inode_num = string_to_inode(argv[1]);
-       if (!inode_num) 
-               return;
+       os = current_fs->super->s_creator_os;
 
-       retval = ext2fs_read_inode(current_fs, inode_num, &inode);
-       if (retval) {
-               com_err(argv[1], retval, "while trying to read inode %d",
-                       inode_num);
+       if (debugfs_read_inode(inode_num, &inode, argv[1]))
                return;
-       }
        
        modify_u16(argv[0], "Mode", octal_format, &inode.i_mode);
        modify_u16(argv[0], "User ID", decimal_format, &inode.i_uid);
        modify_u16(argv[0], "Group ID", decimal_format, &inode.i_gid);
-       modify_u32(argv[0], "Size", decimal_format, &inode.i_size);
+       modify_u32(argv[0], "Size", unsignedlong_format, &inode.i_size);
        modify_u32(argv[0], "Creation time", decimal_format, &inode.i_ctime);
        modify_u32(argv[0], "Modification time", decimal_format, &inode.i_mtime);
        modify_u32(argv[0], "Access time", decimal_format, &inode.i_atime);
        modify_u32(argv[0], "Deletion time", decimal_format, &inode.i_dtime);
        modify_u16(argv[0], "Link count", decimal_format, &inode.i_links_count);
-       modify_u32(argv[0], "Block count", decimal_format, &inode.i_blocks);
+       if (os == EXT2_OS_LINUX)
+               modify_u16(argv[0], "Block count high", unsignedlong_format, 
+                          &inode.osd2.linux2.l_i_blocks_hi);
+       modify_u32(argv[0], "Block count", unsignedlong_format, &inode.i_blocks);
        modify_u32(argv[0], "File flags", hex_format, &inode.i_flags);
+       modify_u32(argv[0], "Generation", hex_format, &inode.i_generation);
 #if 0
        modify_u32(argv[0], "Reserved1", decimal_format, &inode.i_reserved1);
 #endif
@@ -702,16 +889,12 @@ void do_modify_inode(int argc, char *argv[])
        else
                modify_u32(argv[0], "High 32bits of size", decimal_format, &inode.i_size_high);
 
-       if (current_fs->super->s_creator_os == EXT2_OS_HURD)
+       if (os == EXT2_OS_HURD)
                modify_u32(argv[0], "Translator Block",
                            decimal_format, &inode.osd1.hurd1.h_i_translator);
        
        modify_u32(argv[0], "Fragment address", decimal_format, &inode.i_faddr);
        switch (os) {
-           case EXT2_OS_LINUX:
-               frag = &inode.osd2.linux2.l_i_frag;
-               fsize = &inode.osd2.linux2.l_i_fsize;
-               break;
            case EXT2_OS_HURD:
                frag = &inode.osd2.hurd2.h_i_frag;
                fsize = &inode.osd2.hurd2.h_i_fsize;
@@ -738,33 +921,21 @@ void do_modify_inode(int argc, char *argv[])
                    &inode.i_block[EXT2_DIND_BLOCK]);
        modify_u32(argv[0], "Triple Indirect Block", decimal_format,
                    &inode.i_block[EXT2_TIND_BLOCK]);
-       retval = ext2fs_write_inode(current_fs, inode_num, &inode);
-       if (retval) {
-               com_err(argv[1], retval, "while trying to write inode %d",
-                       inode_num);
+       if (debugfs_write_inode(inode_num, &inode, argv[1]))
                return;
-       }
 }
 
 void do_change_working_dir(int argc, char *argv[])
 {
-       ino_t   inode;
-       int     retval;
+       ext2_ino_t      inode;
+       int             retval;
        
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: cd <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-
-       inode = string_to_inode(argv[1]);
-       if (!inode) 
+       if (common_inode_args_process(argc, argv, &inode, 0))
                return;
 
        retval = ext2fs_check_directory(current_fs, inode);
        if (retval) {
-               com_err(argv[1], retval, "");
+               com_err(argv[1], retval, 0);
                return;
        }
        cwd = inode;
@@ -776,11 +947,8 @@ void do_print_working_directory(int argc, char *argv[])
        int     retval;
        char    *pathname = NULL;
        
-       if (argc > 1) {
-               com_err(argv[0], 0, "Usage: print_working_directory");
-               return;
-       }
-       if (check_fs_open(argv[0]))
+       if (common_args_process(argc, argv, 1, 1,
+                               "print_working_directory", "", 0))
                return;
 
        retval = ext2fs_get_pathname(current_fs, cwd, 0, &pathname);
@@ -788,30 +956,68 @@ void do_print_working_directory(int argc, char *argv[])
                com_err(argv[0], retval,
                        "while trying to get pathname of cwd");
        }
-       printf("[pwd]   INODE: %6ld  PATH: %s\n", cwd, pathname);
-       free(pathname);
+       printf("[pwd]   INODE: %6u  PATH: %s\n",
+              cwd, pathname ? pathname : "NULL");
+        if (pathname) {
+               free(pathname);
+               pathname = NULL;
+        }
        retval = ext2fs_get_pathname(current_fs, root, 0, &pathname);
        if (retval) {
                com_err(argv[0], retval,
                        "while trying to get pathname of root");
        }
-       printf("[root]  INODE: %6ld  PATH: %s\n", root, pathname);
-       free(pathname);
+       printf("[root]  INODE: %6u  PATH: %s\n",
+              root, pathname ? pathname : "NULL");
+       if (pathname) {
+               free(pathname);
+               pathname = NULL;
+       }
        return;
 }
 
+/*
+ * Given a mode, return the ext2 file type
+ */
+static int ext2_file_type(unsigned int mode)
+{
+       if (LINUX_S_ISREG(mode))
+               return EXT2_FT_REG_FILE;
+
+       if (LINUX_S_ISDIR(mode))
+               return EXT2_FT_DIR;
+       
+       if (LINUX_S_ISCHR(mode))
+               return EXT2_FT_CHRDEV;
+       
+       if (LINUX_S_ISBLK(mode))
+               return EXT2_FT_BLKDEV;
+       
+       if (LINUX_S_ISLNK(mode))
+               return EXT2_FT_SYMLINK;
+
+       if (LINUX_S_ISFIFO(mode))
+               return EXT2_FT_FIFO;
+       
+       if (LINUX_S_ISSOCK(mode))
+               return EXT2_FT_SOCK;
+       
+       return 0;
+}
+
 static void make_link(char *sourcename, char *destname)
 {
-       ino_t   inode;
-       int     retval;
-       ino_t   dir;
-       char    *dest, *cp, *basename;
+       ext2_ino_t      ino;
+       struct ext2_inode inode;
+       int             retval;
+       ext2_ino_t      dir;
+       char            *dest, *cp, *basename;
 
        /*
         * Get the source inode
         */
-       inode = string_to_inode(sourcename);
-       if (!inode)
+       ino = string_to_inode(sourcename);
+       if (!ino)
                return;
        basename = strrchr(sourcename, '/');
        if (basename)
@@ -841,31 +1047,83 @@ static void make_link(char *sourcename, char *destname)
                        dest = destname;
                }
        }
+
+       if (debugfs_read_inode(ino, &inode, sourcename))
+               return;
        
-       retval = ext2fs_link(current_fs, dir, dest, inode, 0);
+       retval = ext2fs_link(current_fs, dir, dest, ino, 
+                            ext2_file_type(inode.i_mode));
        if (retval)
-               com_err("make_link", retval, "");
+               com_err("make_link", retval, 0);
        return;
 }
 
 
 void do_link(int argc, char *argv[])
 {
-       if (argc != 3) {
-               com_err(argv[0], 0, "Usage: link <source_file> <dest_name>");
+       if (common_args_process(argc, argv, 3, 3, "link",
+                               "<source file> <dest_name>", CHECK_FS_RW))
+               return;
+
+       make_link(argv[1], argv[2]);
+}
+
+static int mark_blocks_proc(ext2_filsys fs, blk_t *blocknr,
+                           int blockcnt EXT2FS_ATTR((unused)), 
+                           void *private EXT2FS_ATTR((unused)))
+{
+       blk_t   block;
+
+       block = *blocknr;
+       ext2fs_block_alloc_stats(fs, block, +1);
+       return 0;
+}
+
+void do_undel(int argc, char *argv[])
+{
+       ext2_ino_t      ino;
+       struct ext2_inode inode;
+
+       if (common_args_process(argc, argv, 3, 3, "undelete",
+                               "<inode_num> <dest_name>",
+                               CHECK_FS_RW | CHECK_FS_BITMAPS))
+               return;
+
+       ino = string_to_inode(argv[1]);
+       if (!ino)
+               return;
+
+       if (debugfs_read_inode(ino, &inode, argv[1]))
+               return;
+
+       if (ext2fs_test_inode_bitmap(current_fs->inode_map, ino)) {
+               com_err(argv[1], 0, "Inode is not marked as deleted");
                return;
        }
-       if (check_fs_open(argv[0]))
+
+       /*
+        * XXX this function doesn't handle changing the links count on the
+        * parent directory when undeleting a directory.  
+        */
+       inode.i_links_count = LINUX_S_ISDIR(inode.i_mode) ? 2 : 1;
+       inode.i_dtime = 0;
+
+       if (debugfs_write_inode(ino, &inode, argv[0]))
                return;
 
+       ext2fs_block_iterate(current_fs, ino, 0, NULL,
+                            mark_blocks_proc, NULL);
+
+       ext2fs_inode_alloc_stats2(current_fs, ino, +1, 0);
+
        make_link(argv[1], argv[2]);
 }
 
 static void unlink_file_by_name(char *filename)
 {
-       int     retval;
-       ino_t   dir;
-       char    *basename;
+       int             retval;
+       ext2_ino_t      dir;
+       char            *basename;
        
        basename = strrchr(filename, '/');
        if (basename) {
@@ -879,17 +1137,14 @@ static void unlink_file_by_name(char *filename)
        }
        retval = ext2fs_unlink(current_fs, dir, basename, 0, 0);
        if (retval)
-               com_err("unlink_file_by_name", retval, "");
+               com_err("unlink_file_by_name", retval, 0);
        return;
 }
 
 void do_unlink(int argc, char *argv[])
 {
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: unlink <pathname>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
+       if (common_args_process(argc, argv, 2, 2, "link",
+                               "<pathname>", CHECK_FS_RW))
                return;
 
        unlink_file_by_name(argv[1]);
@@ -898,18 +1153,28 @@ void do_unlink(int argc, char *argv[])
 void do_find_free_block(int argc, char *argv[])
 {
        blk_t   free_blk, goal;
+       int             count;
        errcode_t       retval;
        char            *tmp;
        
-       if ((argc > 2) || (argc==2 && *argv[1] == '?')) {
-               com_err(argv[0], 0, "Usage: find_free_block [goal]");
+       if ((argc > 3) || (argc==2 && *argv[1] == '?')) {
+               com_err(argv[0], 0, "Usage: find_free_block [count [goal]]");
                return;
        }
        if (check_fs_open(argv[0]))
                return;
 
        if (argc > 1) {
-               goal = strtol(argv[1], &tmp, 0);
+               count = strtol(argv[1],&tmp,0);
+               if (*tmp) {
+                       com_err(argv[0], 0, "Bad count - %s", argv[1]);
+                       return;
+               }
+       } else
+               count = 1;
+
+       if (argc > 2) {
+               goal = strtol(argv[2], &tmp, 0);
                if (*tmp) {
                        com_err(argv[0], 0, "Bad goal - %s", argv[1]);
                        return;
@@ -918,20 +1183,26 @@ void do_find_free_block(int argc, char *argv[])
        else
                goal = current_fs->super->s_first_data_block;
 
-       retval = ext2fs_new_block(current_fs, goal, 0, &free_blk);
-       if (retval)
-               com_err("ext2fs_new_block", retval, "");
-       else
-               printf("Free block found: %d\n", free_blk);
-
+       printf("Free blocks found: ");
+       free_blk = goal - 1;    
+       while (count-- > 0) {
+               retval = ext2fs_new_block(current_fs, free_blk + 1, 0,
+                                         &free_blk);
+               if (retval) {
+                       com_err("ext2fs_new_block", retval, 0);
+                       return;
+               } else
+                       printf("%u ", free_blk);
+       }
+       printf("\n");
 }
 
 void do_find_free_inode(int argc, char *argv[])
 {
-       ino_t   free_inode, dir;
-       int     mode;
-       int     retval;
-       char    *tmp;
+       ext2_ino_t      free_inode, dir;
+       int             mode;
+       int             retval;
+       char            *tmp;
        
        if (argc > 3 || (argc>1 && *argv[1] == '?')) {
                com_err(argv[0], 0, "Usage: find_free_inode [dir] [mode]");
@@ -960,16 +1231,17 @@ void do_find_free_inode(int argc, char *argv[])
 
        retval = ext2fs_new_inode(current_fs, dir, mode, 0, &free_inode);
        if (retval)
-               com_err("ext2fs_new_inode", retval, "");
+               com_err("ext2fs_new_inode", retval, 0);
        else
-               printf("Free inode found: %ld\n", free_inode);
+               printf("Free inode found: %u\n", free_inode);
 }
 
-static errcode_t copy_file(int fd, ino_t newfile)
+static errcode_t copy_file(int fd, ext2_ino_t newfile)
 {
        ext2_file_t     e2_file;
        errcode_t       retval;
-       unsigned int    got, written;
+       int             got;
+       unsigned int    written;
        char            buf[8192];
        char            *ptr;
 
@@ -998,7 +1270,6 @@ static errcode_t copy_file(int fd, ino_t newfile)
                }
        }
        retval = ext2fs_file_close(e2_file);
-
        return retval;
 
 fail:
@@ -1009,84 +1280,90 @@ fail:
 
 void do_write(int argc, char *argv[])
 {
-       int     fd;
-       struct stat statbuf;
-       ino_t   newfile;
-       errcode_t retval;
+       int             fd;
+       struct stat     statbuf;
+       ext2_ino_t      newfile;
+       errcode_t       retval;
        struct ext2_inode inode;
-       dgrp_t group;
 
-       if (check_fs_open(argv[0]))
-               return;
-       if (argc != 3) {
-               com_err(argv[0], 0, "Usage: write <nativefile> <newfile>");
-               return;
-       }
-       if (check_fs_read_write(argv[0]))
+       if (common_args_process(argc, argv, 3, 3, "write",
+                               "<native file> <new file>", CHECK_FS_RW))
                return;
+
        fd = open(argv[1], O_RDONLY);
        if (fd < 0) {
-               com_err(argv[1], fd, "");
+               com_err(argv[1], errno, 0);
                return;
        }
        if (fstat(fd, &statbuf) < 0) {
-               com_err(argv[1], errno, "");
+               com_err(argv[1], errno, 0);
+               close(fd);
+               return;
+       }
+
+       retval = ext2fs_namei(current_fs, root, cwd, argv[2], &newfile);
+       if (retval == 0) {
+               com_err(argv[0], 0, "The file '%s' already exists\n", argv[2]);
                close(fd);
                return;
        }
 
        retval = ext2fs_new_inode(current_fs, cwd, 010755, 0, &newfile);
        if (retval) {
-               com_err(argv[0], retval, "");
+               com_err(argv[0], retval, 0);
                close(fd);
                return;
        }
-       group = ext2fs_group_of_ino(current_fs, newfile);
-       current_fs->group_desc[group].bg_free_inodes_count--;
-       current_fs->super->s_free_inodes_count--;
-       ext2fs_mark_super_dirty(current_fs);
-       printf("Allocated inode: %ld\n", newfile);
-       retval = ext2fs_link(current_fs, cwd, argv[2], newfile, 0);
+       printf("Allocated inode: %u\n", newfile);
+       retval = ext2fs_link(current_fs, cwd, argv[2], newfile,
+                            EXT2_FT_REG_FILE);
+       if (retval == EXT2_ET_DIR_NO_SPACE) {
+               retval = ext2fs_expand_dir(current_fs, cwd);
+               if (retval) {
+                       com_err(argv[0], retval, "while expanding directory");
+                       return;
+               }
+               retval = ext2fs_link(current_fs, cwd, argv[2], newfile,
+                                    EXT2_FT_REG_FILE);
+       }
        if (retval) {
-               com_err(argv[2], retval, "");
+               com_err(argv[2], retval, 0);
                close(fd);
                return;
        }
         if (ext2fs_test_inode_bitmap(current_fs->inode_map,newfile))
                com_err(argv[0], 0, "Warning: inode already set");
-       ext2fs_mark_inode_bitmap(current_fs->inode_map,newfile);
-       ext2fs_mark_ib_dirty(current_fs);
+       ext2fs_inode_alloc_stats2(current_fs, newfile, +1, 0);
        memset(&inode, 0, sizeof(inode));
-       inode.i_mode = statbuf.st_mode;
-       inode.i_atime = inode.i_ctime = inode.i_mtime = time(NULL);
+       inode.i_mode = (statbuf.st_mode & ~LINUX_S_IFMT) | LINUX_S_IFREG;
+       inode.i_atime = inode.i_ctime = inode.i_mtime = 
+               current_fs->now ? current_fs->now : time(0);
        inode.i_links_count = 1;
        inode.i_size = statbuf.st_size;
-       ext2fs_write_inode(current_fs, newfile, &inode);
-       retval = ext2fs_write_inode(current_fs, newfile, &inode);
-       if (retval) {
-               com_err(argv[0], retval, "while trying to write inode %d", 
-                       inode);
+       if (debugfs_write_new_inode(newfile, &inode, argv[0])) {
                close(fd);
                return;
        }
        if (LINUX_S_ISREG(inode.i_mode)) {
                retval = copy_file(fd, newfile);
                if (retval)
-                       com_err("copy_file", retval, "");
+                       com_err("copy_file", retval, 0);
        }
        close(fd);
 }
 
 void do_mknod(int argc, char *argv[])
 {
-       unsigned long mode, major, minor, nr;
-       ino_t   newfile;
-       errcode_t retval;
+       unsigned long   mode, major, minor;
+       ext2_ino_t      newfile;
+       errcode_t       retval;
        struct ext2_inode inode;
+       int             filetype, nr;
 
        if (check_fs_open(argv[0]))
                return;
        if (argc < 3 || argv[2][1]) {
+       usage:
                com_err(argv[0], 0, "Usage: mknod <name> [p| [c|b] <major> <minor>]");
                return;
        }
@@ -1094,49 +1371,52 @@ void do_mknod(int argc, char *argv[])
        switch (argv[2][0]) {
                case 'p':
                        mode = LINUX_S_IFIFO;
+                       filetype = EXT2_FT_FIFO;
                        nr = 3;
                        break;
                case 'c':
                        mode = LINUX_S_IFCHR;
+                       filetype = EXT2_FT_CHRDEV;
                        nr = 5;
                        break;
                case 'b':
                        mode = LINUX_S_IFBLK;
+                       filetype = EXT2_FT_BLKDEV;
                        nr = 5;
                        break;
                default:
+                       filetype = 0;
                        nr = 0;
        }
        if (nr == 5) {
                major = strtoul(argv[3], argv+3, 0);
                minor = strtoul(argv[4], argv+4, 0);
-               if (major > 255 || minor > 255 || argv[3][0] || argv[4][0])
+               if (major > 65535 || minor > 65535 || argv[3][0] || argv[4][0])
                        nr = 0;
        }
-       if (argc != nr) {
-               com_err(argv[0], 0, "Usage: mknod <name> [p| [c|b] <major> <minor>]");
-               return;
-       }
+       if (argc != nr)
+               goto usage;
        if (check_fs_read_write(argv[0]))
                return;
        retval = ext2fs_new_inode(current_fs, cwd, 010755, 0, &newfile);
        if (retval) {
-               com_err(argv[0], retval, "");
+               com_err(argv[0], retval, 0);
                return;
        }
-       printf("Allocated inode: %ld\n", newfile);
-       retval = ext2fs_link(current_fs, cwd, argv[1], newfile, 0);
-       if (retval) {
-               if (retval == EXT2_ET_DIR_NO_SPACE) {
-                       retval = ext2fs_expand_dir(current_fs, cwd);
-                       if (!retval)
-                               retval = ext2fs_link(current_fs, cwd,
-                                                    argv[1], newfile, 0);
-               }
+       printf("Allocated inode: %u\n", newfile);
+       retval = ext2fs_link(current_fs, cwd, argv[1], newfile, filetype);
+       if (retval == EXT2_ET_DIR_NO_SPACE) {
+               retval = ext2fs_expand_dir(current_fs, cwd);
                if (retval) {
-                       com_err(argv[1], retval, "");
+                       com_err(argv[0], retval, "while expanding directory");
                        return;
                }
+               retval = ext2fs_link(current_fs, cwd, argv[1], newfile,
+                                    filetype);
+       }
+       if (retval) {
+               com_err(argv[1], retval, 0);
+               return;
        }
         if (ext2fs_test_inode_bitmap(current_fs->inode_map,newfile))
                com_err(argv[0], 0, "Warning: inode already set");
@@ -1144,38 +1424,37 @@ void do_mknod(int argc, char *argv[])
        ext2fs_mark_ib_dirty(current_fs);
        memset(&inode, 0, sizeof(inode));
        inode.i_mode = mode;
-       inode.i_atime = inode.i_ctime = inode.i_mtime = time(NULL);
-       inode.i_block[0] = major*256+minor;
+       inode.i_atime = inode.i_ctime = inode.i_mtime = 
+               current_fs->now ? current_fs->now : time(0);
+       if ((major < 256) && (minor < 256)) {
+               inode.i_block[0] = major*256+minor;
+               inode.i_block[1] = 0;
+       } else {
+               inode.i_block[0] = 0;
+               inode.i_block[1] = (minor & 0xff) | (major << 8) | ((minor & ~0xff) << 12);
+       }
        inode.i_links_count = 1;
-       ext2fs_write_inode(current_fs, newfile, &inode);
-       retval = ext2fs_write_inode(current_fs, newfile, &inode);
-       if (retval) {
-               com_err(argv[0], retval, "while trying to write inode %d", inode);
+       if (debugfs_write_new_inode(newfile, &inode, argv[0]))
                return;
-       }
 }
 
 void do_mkdir(int argc, char *argv[])
 {
        char    *cp;
-       ino_t   parent;
+       ext2_ino_t      parent;
        char    *name;
        errcode_t retval;
 
-       if (check_fs_open(argv[0]))
+       if (common_args_process(argc, argv, 2, 2, "mkdir",
+                               "<filename>", CHECK_FS_RW))
                return;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: mkdir <file>");
-               return;
-       }
-
        cp = strrchr(argv[1], '/');
        if (cp) {
                *cp = 0;
                parent = string_to_inode(argv[1]);
                if (!parent) {
-                       com_err(argv[1], ENOENT, "");
+                       com_err(argv[1], ENOENT, 0);
                        return;
                }
                name = cp+1;
@@ -1184,78 +1463,72 @@ void do_mkdir(int argc, char *argv[])
                name = argv[1];
        }
 
-
+try_again:
        retval = ext2fs_mkdir(current_fs, parent, 0, name);
+       if (retval == EXT2_ET_DIR_NO_SPACE) {
+               retval = ext2fs_expand_dir(current_fs, parent);
+               if (retval) {
+                       com_err("argv[0]", retval, "while expanding directory");
+                       return;
+               }
+               goto try_again;
+       }
        if (retval) {
-               com_err("ext2fs_mkdir", retval, "");
+               com_err("ext2fs_mkdir", retval, 0);
                return;
        }
 
 }
 
-void do_rmdir(int argc, char *argv[])
-{
-       printf("Unimplemented\n");
-}
-
-
 static int release_blocks_proc(ext2_filsys fs, blk_t *blocknr,
-                              int blockcnt, void *private)
+                              int blockcnt EXT2FS_ATTR((unused)), 
+                              void *private EXT2FS_ATTR((unused)))
 {
-       printf("%d ", *blocknr);
-       ext2fs_unmark_block_bitmap(fs->block_map,*blocknr);
+       blk_t   block;
+
+       block = *blocknr;
+       ext2fs_block_alloc_stats(fs, block, -1);
        return 0;
 }
 
-static void kill_file_by_inode(ino_t inode)
+static void kill_file_by_inode(ext2_ino_t inode)
 {
        struct ext2_inode inode_buf;
 
-       ext2fs_read_inode(current_fs, inode, &inode_buf);
-       inode_buf.i_dtime = time(NULL);
-       ext2fs_write_inode(current_fs, inode, &inode_buf);
+       if (debugfs_read_inode(inode, &inode_buf, 0))
+               return;
+       inode_buf.i_dtime = current_fs->now ? current_fs->now : time(0);
+       if (debugfs_write_inode(inode, &inode_buf, 0))
+               return;
+       if (!ext2fs_inode_has_valid_blocks(&inode_buf))
+               return;
 
-       printf("Kill file by inode %ld\n", inode);
        ext2fs_block_iterate(current_fs, inode, 0, NULL,
                             release_blocks_proc, NULL);
        printf("\n");
-       ext2fs_unmark_inode_bitmap(current_fs->inode_map, inode);
-
-       ext2fs_mark_bb_dirty(current_fs);
-       ext2fs_mark_ib_dirty(current_fs);
+       ext2fs_inode_alloc_stats2(current_fs, inode, -1,
+                                 LINUX_S_ISDIR(inode_buf.i_mode));
 }
 
 
 void do_kill_file(int argc, char *argv[])
 {
-       ino_t inode_num;
+       ext2_ino_t inode_num;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: kill_file <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
+       if (common_inode_args_process(argc, argv, &inode_num, CHECK_FS_RW))
                return;
 
-       inode_num = string_to_inode(argv[1]);
-       if (!inode_num) {
-               com_err(argv[0], 0, "Cannot find file");
-               return;
-       }
        kill_file_by_inode(inode_num);
 }
 
 void do_rm(int argc, char *argv[])
 {
        int retval;
-       ino_t inode_num;
+       ext2_ino_t inode_num;
        struct ext2_inode inode;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: rm <filename>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
+       if (common_args_process(argc, argv, 2, 2, "rm",
+                               "<filename>", CHECK_FS_RW))
                return;
 
        retval = ext2fs_namei(current_fs, root, cwd, argv[1], &inode_num);
@@ -1264,11 +1537,8 @@ void do_rm(int argc, char *argv[])
                return;
        }
 
-       retval = ext2fs_read_inode(current_fs,inode_num,&inode);
-       if (retval) {
-               com_err(argv[0], retval, "while reading file's inode");
+       if (debugfs_read_inode(inode_num, &inode, argv[0]))
                return;
-       }
 
        if (LINUX_S_ISDIR(inode.i_mode)) {
                com_err(argv[0], 0, "file is a directory");
@@ -1276,18 +1546,100 @@ void do_rm(int argc, char *argv[])
        }
 
        --inode.i_links_count;
-       retval = ext2fs_write_inode(current_fs,inode_num,&inode);
-       if (retval) {
-               com_err(argv[0], retval, "while writing inode");
+       if (debugfs_write_inode(inode_num, &inode, argv[0]))
                return;
-       }
 
        unlink_file_by_name(argv[1]);
        if (inode.i_links_count == 0)
                kill_file_by_inode(inode_num);
 }
 
-void do_show_debugfs_params(int argc, char *argv[])
+struct rd_struct {
+       ext2_ino_t      parent;
+       int             empty;
+};
+
+static int rmdir_proc(ext2_ino_t dir EXT2FS_ATTR((unused)),
+                     int       entry EXT2FS_ATTR((unused)),
+                     struct ext2_dir_entry *dirent,
+                     int       offset EXT2FS_ATTR((unused)),
+                     int       blocksize EXT2FS_ATTR((unused)),
+                     char      *buf EXT2FS_ATTR((unused)),
+                     void      *private)
+{
+       struct rd_struct *rds = (struct rd_struct *) private;
+
+       if (dirent->inode == 0)
+               return 0;
+       if (((dirent->name_len&0xFF) == 1) && (dirent->name[0] == '.'))
+               return 0;
+       if (((dirent->name_len&0xFF) == 2) && (dirent->name[0] == '.') &&
+           (dirent->name[1] == '.')) {
+               rds->parent = dirent->inode;
+               return 0;
+       }
+       rds->empty = 0;
+       return 0;
+}
+       
+void do_rmdir(int argc, char *argv[])
+{
+       int retval;
+       ext2_ino_t inode_num;
+       struct ext2_inode inode;
+       struct rd_struct rds;
+
+       if (common_args_process(argc, argv, 2, 2, "rmdir",
+                               "<filename>", CHECK_FS_RW))
+               return;
+
+       retval = ext2fs_namei(current_fs, root, cwd, argv[1], &inode_num);
+       if (retval) {
+               com_err(argv[0], retval, "while trying to resolve filename");
+               return;
+       }
+
+       if (debugfs_read_inode(inode_num, &inode, argv[0]))
+               return;
+
+       if (!LINUX_S_ISDIR(inode.i_mode)) {
+               com_err(argv[0], 0, "file is not a directory");
+               return;
+       }
+
+       rds.parent = 0;
+       rds.empty = 1;
+
+       retval = ext2fs_dir_iterate2(current_fs, inode_num, 0,
+                                   0, rmdir_proc, &rds);
+       if (retval) {
+               com_err(argv[0], retval, "while iterating over directory");
+               return;
+       }
+       if (rds.empty == 0) {
+               com_err(argv[0], 0, "directory not empty");
+               return;
+       }
+
+       inode.i_links_count = 0;
+       if (debugfs_write_inode(inode_num, &inode, argv[0]))
+               return;
+
+       unlink_file_by_name(argv[1]);
+       kill_file_by_inode(inode_num);
+
+       if (rds.parent) {
+               if (debugfs_read_inode(rds.parent, &inode, argv[0]))
+                       return;
+               if (inode.i_links_count > 1)
+                       inode.i_links_count--;
+               if (debugfs_write_inode(rds.parent, &inode, argv[0]))
+                       return;
+       }
+}
+
+void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)), 
+                           char *argv[] EXT2FS_ATTR((unused)))
 {
        FILE *out = stdout;
 
@@ -1300,25 +1652,114 @@ void do_show_debugfs_params(int argc, char *argv[])
 
 void do_expand_dir(int argc, char *argv[])
 {
-       ino_t inode;
+       ext2_ino_t inode;
        int retval;
 
-       if (argc != 2) {
-               com_err(argv[0], 0, "Usage: expand_dir <file>");
-               return;
-       }
-       if (check_fs_open(argv[0]))
-               return;
-       inode = string_to_inode(argv[1]);
-       if (!inode)
+       if (common_inode_args_process(argc, argv, &inode, CHECK_FS_RW))
                return;
 
        retval = ext2fs_expand_dir(current_fs, inode);
        if (retval)
-               com_err("ext2fs_expand_dir", retval, "");
+               com_err("ext2fs_expand_dir", retval, 0);
        return;
 }
 
+void do_features(int argc, char *argv[])
+{
+       int     i;
+       
+       if (check_fs_open(argv[0]))
+               return;
+
+       if ((argc != 1) && check_fs_read_write(argv[0]))
+               return;
+       for (i=1; i < argc; i++) {
+               if (e2p_edit_feature(argv[i],
+                                    &current_fs->super->s_feature_compat, 0))
+                       com_err(argv[0], 0, "Unknown feature: %s\n",
+                               argv[i]);
+               else
+                       ext2fs_mark_super_dirty(current_fs);
+       }
+       print_features(current_fs->super, stdout);
+}
+
+void do_bmap(int argc, char *argv[])
+{
+       ext2_ino_t      ino;
+       blk_t           blk, pblk;
+       int             err;
+       errcode_t       errcode;
+       
+       if (common_args_process(argc, argv, 3, 3, argv[0],
+                               "<file> logical_blk", 0))
+               return;
+
+       ino = string_to_inode(argv[1]);
+       if (!ino)
+               return;
+       blk = parse_ulong(argv[2], argv[0], "logical_block", &err);
+
+       errcode = ext2fs_bmap(current_fs, ino, 0, 0, 0, blk, &pblk);
+       if (errcode) {
+               com_err("argv[0]", errcode,
+                       "while mapping logical block %u\n", blk);
+               return;
+       }
+       printf("%u\n", pblk);
+}
+
+void do_imap(int argc, char *argv[])
+{
+       ext2_ino_t      ino;
+       unsigned long   group, block, block_nr, offset;
+
+       if (common_args_process(argc, argv, 2, 2, argv[0],
+                               "<file>", 0))
+               return;
+       ino = string_to_inode(argv[1]);
+       if (!ino)
+               return;
+
+       group = (ino - 1) / EXT2_INODES_PER_GROUP(current_fs->super);
+       offset = ((ino - 1) % EXT2_INODES_PER_GROUP(current_fs->super)) *
+               EXT2_INODE_SIZE(current_fs->super);
+       block = offset >> EXT2_BLOCK_SIZE_BITS(current_fs->super);
+       if (!current_fs->group_desc[(unsigned)group].bg_inode_table) {
+               com_err(argv[0], 0, "Inode table for group %lu is missing\n",
+                       group);
+               return;
+       }
+       block_nr = current_fs->group_desc[(unsigned)group].bg_inode_table + 
+               block;
+       offset &= (EXT2_BLOCK_SIZE(current_fs->super) - 1);
+
+       printf("Inode %d is part of block group %lu\n"
+              "\tlocated at block %lu, offset 0x%04lx\n", ino, group,
+              block_nr, offset);
+
+}
+
+void do_set_current_time(int argc, char *argv[])
+{
+       time_t now;
+
+       if (common_args_process(argc, argv, 2, 2, argv[0],
+                               "<time>", 0))
+               return;
+
+       now = string_to_time(argv[1]);
+       if (now == ((time_t) -1)) {
+               com_err(argv[0], 0, "Couldn't parse argument as a time: %s\n",
+                       argv[1]);
+               return;
+
+       } else {
+               printf("Setting current time to %s\n", time_to_string(now));
+               current_fs->now = now;
+       }
+}
+
 static int source_file(const char *cmd_file, int sci_idx)
 {
        FILE            *f;
@@ -1361,19 +1802,22 @@ int main(int argc, char **argv)
 {
        int             retval;
        int             sci_idx;
-       const char      *usage = "Usage: debugfs [-f cmd_file] [-R request] [-V] [[-w] device]";
+       const char      *usage = "Usage: debugfs [-b blocksize] [-s superblock] [-f cmd_file] [-R request] [-V] [[-w] [-c] device]";
        int             c;
-       int             open_flags = 0;
+       int             open_flags = EXT2_FLAG_SOFTSUPP_FEATURES;
        char            *request = 0;
        int             exit_status = 0;
        char            *cmd_file = 0;
+       blk_t           superblock = 0;
+       blk_t           blocksize = 0;
+       int             catastrophic = 0;
+       char            *data_filename = 0;
        
-       initialize_ext2_error_table();
-       fprintf (stderr, "debugfs %s, %s for EXT2 FS %s, %s\n",
-                E2FSPROGS_VERSION, E2FSPROGS_DATE,
-                EXT2FS_VERSION, EXT2FS_DATE);
+       add_error_table(&et_ext2_error_table);
+       fprintf (stderr, "debugfs %s (%s)\n", E2FSPROGS_VERSION,
+                E2FSPROGS_DATE);
 
-       while ((c = getopt (argc, argv, "wR:f:V")) != EOF) {
+       while ((c = getopt (argc, argv, "iwcR:f:b:s:Vd:")) != EOF) {
                switch (c) {
                case 'R':
                        request = optarg;
@@ -1381,8 +1825,25 @@ int main(int argc, char **argv)
                case 'f':
                        cmd_file = optarg;
                        break;
+               case 'd':
+                       data_filename = optarg;
+                       break;
+               case 'i':
+                       open_flags |= EXT2_FLAG_IMAGE_FILE;
+                       break;
                case 'w':
-                       open_flags = EXT2_FLAG_RW;
+                       open_flags |= EXT2_FLAG_RW;
+                       break;
+               case 'b':
+                       blocksize = parse_ulong(optarg, argv[0], 
+                                               "block size", 0);
+                       break;
+               case 's':
+                       superblock = parse_ulong(optarg, argv[0], 
+                                                "superblock number", 0);
+                       break;
+               case 'c':
+                       catastrophic = 1;
                        break;
                case 'V':
                        /* Print version number and exit */
@@ -1395,7 +1856,9 @@ int main(int argc, char **argv)
                }
        }
        if (optind < argc)
-               open_filesystem(argv[optind], open_flags);
+               open_filesystem(argv[optind], open_flags,
+                               superblock, blocksize, catastrophic,
+                               data_filename);
        
        sci_idx = ss_create_invocation("debugfs", "0.0", (char *) NULL,
                                       &debug_cmds, &retval);
@@ -1403,6 +1866,7 @@ int main(int argc, char **argv)
                ss_perror(sci_idx, retval, "creating invocation");
                exit(1);
        }
+       ss_get_readline(sci_idx);
 
        (void) ss_add_request_table (sci_idx, &ss_std_requests, 1, &retval);
        if (retval) {
@@ -1425,6 +1889,6 @@ int main(int argc, char **argv)
        if (current_fs)
                close_filesystem();
        
-       exit(exit_status);
+       remove_error_table(&et_ext2_error_table);
+       return exit_status;
 }
-