Whamcloud - gitweb
Align function prototypes for libss's request handler function
[tools/e2fsprogs.git] / debugfs / debugfs.c
index 132c5f9..16a03d4 100644 (file)
@@ -50,7 +50,7 @@ int journal_enable_debug = -1;
 
 /*
  * There must be only one definition if we're hooking in extra commands or
- * chaging default prompt. Use -DSKIP_GLOBDEF for that.
+ * changing default prompt. Use -DSKIP_GLOBDEF for that.
  */
 #ifndef SKIP_GLOBDEFS
 ss_request_table *extra_cmds;
@@ -195,9 +195,7 @@ try_open_again:
        }
        current_fs->default_bitmap_type = EXT2FS_BMAP64_RBTREE;
 
-       if (catastrophic)
-               com_err(device, 0, "catastrophic mode - not reading inode or group bitmaps");
-       else {
+       if (!catastrophic) {
                retval = ext2fs_read_bitmaps(current_fs);
                if (retval) {
                        com_err(device, retval,
@@ -224,7 +222,7 @@ errout:
                com_err(device, retval, "while trying to close filesystem");
 }
 
-void do_open_filesys(int argc, char **argv, int sci_idx EXT2FS_ATTR((unused)),
+void do_open_filesys(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                     void *infop EXT2FS_ATTR((unused)))
 {
        int     c, err;
@@ -307,7 +305,7 @@ print_usage:
                "<device>\n", argv[0]);
 }
 
-void do_lcd(int argc, char **argv, int sci_idx EXT2FS_ATTR((unused)),
+void do_lcd(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
            void *infop EXT2FS_ATTR((unused)))
 {
        if (argc != 2) {
@@ -345,7 +343,7 @@ static void close_filesystem(NOARGS)
        return;
 }
 
-void do_close_filesys(int argc, char **argv, int sci_idx EXT2FS_ATTR((unused)),
+void do_close_filesys(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                      void *infop EXT2FS_ATTR((unused)))
 {
        int     c;
@@ -374,7 +372,7 @@ void do_close_filesys(int argc, char **argv, int sci_idx EXT2FS_ATTR((unused)),
 }
 
 #ifndef READ_ONLY
-void do_init_filesys(int argc, char **argv, int sci_idx EXT2FS_ATTR((unused)),
+void do_init_filesys(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                     void *infop EXT2FS_ATTR((unused)))
 {
        struct ext2_super_block param;
@@ -435,7 +433,7 @@ static void print_bg_opts(ext2_filsys fs, dgrp_t group, int mask,
        }
 }
 
-void do_show_super_stats(int argc, char *argv[],
+void do_show_super_stats(int argc, ss_argv_t argv,
                         int sci_idx EXT2FS_ATTR((unused)),
                         void *infop EXT2FS_ATTR((unused)))
 {
@@ -493,11 +491,12 @@ void do_show_super_stats(int argc, char *argv[],
                        "inode table at %llu\n"
                        "           %u free %s%s, "
                        "%u free %s, "
-                       "%u used %s%s",
-                       i, ext2fs_block_bitmap_loc(current_fs, i),
-                       ext2fs_inode_bitmap_loc(current_fs, i),
-                       ext2fs_inode_table_loc(current_fs, i),
-                       ext2fs_bg_free_blocks_count(current_fs, i), units,
+                       "%u used %s%s", i,
+                       (unsigned long long) ext2fs_block_bitmap_loc(current_fs, i),
+                       (unsigned long long) ext2fs_inode_bitmap_loc(current_fs, i),
+                       (unsigned long long) ext2fs_inode_table_loc(current_fs, i),
+                       ext2fs_bg_free_blocks_count(current_fs, i),
+                       units,
                        ext2fs_bg_free_blocks_count(current_fs, i) != 1 ?
                        "s" : "",
                        ext2fs_bg_free_inodes_count(current_fs, i),
@@ -532,7 +531,7 @@ print_usage:
 
 #ifndef READ_ONLY
 void do_dirty_filesys(int argc EXT2FS_ATTR((unused)),
-                     char **argv EXT2FS_ATTR((unused)),
+                     ss_argv_t argv EXT2FS_ATTR((unused)),
                      int sci_idx EXT2FS_ATTR((unused)),
                      void *infop EXT2FS_ATTR((unused)))
 {
@@ -567,11 +566,13 @@ static void finish_range(struct list_blocks_struct *lb)
                fprintf(lb->f, ", ");
        if (lb->first_block == lb->last_block)
                fprintf(lb->f, "(%lld):%llu",
-                       (long long)lb->first_bcnt, lb->first_block);
+                       (long long)lb->first_bcnt,
+                       (unsigned long long) lb->first_block);
        else
                fprintf(lb->f, "(%lld-%lld):%llu-%llu",
                        (long long)lb->first_bcnt, (long long)lb->last_bcnt,
-                       lb->first_block, lb->last_block);
+                       (unsigned long long) lb->first_block,
+                       (unsigned long long) lb->last_block);
        lb->first_block = 0;
 }
 
@@ -721,18 +722,18 @@ static void dump_extents(FILE *f, const char *prefix, ext2_ino_t ino,
                                        info.curr_level, info.max_depth,
                                        info.curr_entry, info.num_entries,
                                        logical_width,
-                                       extent.e_lblk,
+                                       (unsigned long long) extent.e_lblk,
                                        logical_width,
-                                       extent.e_lblk + (extent.e_len - 1),
+                                       (unsigned long long) extent.e_lblk + (extent.e_len - 1),
                                        physical_width,
-                                       extent.e_pblk,
+                                       (unsigned long long) extent.e_pblk,
                                        physical_width+3, "", extent.e_len);
                                continue;
                        }
 
                        fprintf(f, "%s(ETB%d):%llu",
                                printed ? ", " : "", info.curr_level,
-                               extent.e_pblk);
+                               (unsigned long long) extent.e_pblk);
                        printed = 1;
                        continue;
                }
@@ -743,13 +744,13 @@ static void dump_extents(FILE *f, const char *prefix, ext2_ino_t ino,
                                info.curr_level, info.max_depth,
                                info.curr_entry, info.num_entries,
                                logical_width,
-                               extent.e_lblk,
+                               (unsigned long long) extent.e_lblk,
                                logical_width,
-                               extent.e_lblk + (extent.e_len - 1),
+                               (unsigned long long) extent.e_lblk + (extent.e_len - 1),
                                physical_width,
-                               extent.e_pblk,
+                               (unsigned long long) extent.e_pblk,
                                physical_width,
-                               extent.e_pblk + (extent.e_len - 1),
+                               (unsigned long long) extent.e_pblk + (extent.e_len - 1),
                                extent.e_len,
                                extent.e_flags & EXT2_EXTENT_FLAGS_UNINIT ?
                                        "Uninit" : "");
@@ -762,20 +763,20 @@ static void dump_extents(FILE *f, const char *prefix, ext2_ino_t ino,
                        fprintf(f,
                                "%s(%lld%s):%lld",
                                printed ? ", " : "",
-                               extent.e_lblk,
+                               (unsigned long long) extent.e_lblk,
                                extent.e_flags & EXT2_EXTENT_FLAGS_UNINIT ?
                                "[u]" : "",
-                               extent.e_pblk);
+                               (unsigned long long) extent.e_pblk);
                else
                        fprintf(f,
                                "%s(%lld-%lld%s):%lld-%lld",
                                printed ? ", " : "",
-                               extent.e_lblk,
-                               extent.e_lblk + (extent.e_len - 1),
+                               (unsigned long long) extent.e_lblk,
+                               (unsigned long long) extent.e_lblk + (extent.e_len - 1),
                                extent.e_flags & EXT2_EXTENT_FLAGS_UNINIT ?
                                        "[u]" : "",
-                               extent.e_pblk,
-                               extent.e_pblk + (extent.e_len - 1));
+                               (unsigned long long) extent.e_pblk,
+                               (unsigned long long) extent.e_pblk + (extent.e_len - 1));
                printed = 1;
        }
        if (printed)
@@ -830,11 +831,13 @@ void internal_dump_inode(FILE *out, const char *prefix,
        char frag, fsize;
        int os = current_fs->super->s_creator_os;
        struct ext2_inode_large *large_inode;
-       int is_large_inode = 0;
+       size_t inode_size;
 
-       if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
-               is_large_inode = 1;
        large_inode = (struct ext2_inode_large *) inode;
+       if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
+               inode_size = ext2fs_inode_actual_size(large_inode);
+       else
+               inode_size = EXT2_GOOD_OLD_INODE_SIZE;
 
        if (LINUX_S_ISDIR(inode->i_mode)) i_type = "directory";
        else if (LINUX_S_ISREG(inode->i_mode)) i_type = "regular";
@@ -847,7 +850,7 @@ void internal_dump_inode(FILE *out, const char *prefix,
        fprintf(out, "%sInode: %u   Type: %s    ", prefix, inode_num, i_type);
        fprintf(out, "%sMode:  0%03o   Flags: 0x%x\n",
                prefix, inode->i_mode & 07777, inode->i_flags);
-       if (is_large_inode && large_inode->i_extra_isize >= 24) {
+       if (ext2fs_inode_includes(inode_size, i_version_hi)) {
                fprintf(out, "%sGeneration: %u    Version: 0x%08x:%08x\n",
                        prefix, inode->i_generation, large_inode->i_version_hi,
                        inode->osd1.linux1.l_i_version);
@@ -857,11 +860,11 @@ void internal_dump_inode(FILE *out, const char *prefix,
        }
        fprintf(out, "%sUser: %5d   Group: %5d",
                prefix, inode_uid(*inode), inode_gid(*inode));
-       if (is_large_inode && large_inode->i_extra_isize >= 32)
+       if (ext2fs_inode_includes(inode_size, i_projid))
                fprintf(out, "   Project: %5d", large_inode->i_projid);
        fputs("   Size: ", out);
        if (LINUX_S_ISREG(inode->i_mode) || LINUX_S_ISDIR(inode->i_mode))
-               fprintf(out, "%llu\n", EXT2_I_SIZE(inode));
+               fprintf(out, "%llu\n", (unsigned long long) EXT2_I_SIZE(inode));
        else
                fprintf(out, "%u\n", inode->i_size);
        if (os == EXT2_OS_HURD)
@@ -894,39 +897,51 @@ void internal_dump_inode(FILE *out, const char *prefix,
        }
        fprintf(out, "%sFragment:  Address: %u    Number: %u    Size: %u\n",
                prefix, inode->i_faddr, frag, fsize);
-       if (is_large_inode && large_inode->i_extra_isize >= 24) {
+       if (ext2fs_inode_includes(inode_size, i_ctime_extra))
                fprintf(out, "%s ctime: 0x%08x:%08x -- %s", prefix,
                        inode->i_ctime, large_inode->i_ctime_extra,
-                       inode_time_to_string(inode->i_ctime,
-                                            large_inode->i_ctime_extra));
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_ctime)));
+       else
+               fprintf(out, "%sctime: 0x%08x -- %s", prefix, inode->i_ctime,
+                       time_to_string((__s32) inode->i_ctime));
+       if (ext2fs_inode_includes(inode_size, i_atime_extra))
                fprintf(out, "%s atime: 0x%08x:%08x -- %s", prefix,
                        inode->i_atime, large_inode->i_atime_extra,
-                       inode_time_to_string(inode->i_atime,
-                                            large_inode->i_atime_extra));
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_atime)));
+       else
+               fprintf(out, "%satime: 0x%08x -- %s", prefix, inode->i_atime,
+                       time_to_string((__s32) inode->i_atime));
+       if (ext2fs_inode_includes(inode_size, i_mtime_extra))
                fprintf(out, "%s mtime: 0x%08x:%08x -- %s", prefix,
                        inode->i_mtime, large_inode->i_mtime_extra,
-                       inode_time_to_string(inode->i_mtime,
-                                            large_inode->i_mtime_extra));
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_mtime)));
+       else
+               fprintf(out, "%smtime: 0x%08x -- %s", prefix, inode->i_mtime,
+                       time_to_string((__s32) inode->i_mtime));
+       if (ext2fs_inode_includes(inode_size, i_crtime_extra))
                fprintf(out, "%scrtime: 0x%08x:%08x -- %s", prefix,
                        large_inode->i_crtime, large_inode->i_crtime_extra,
-                       inode_time_to_string(large_inode->i_crtime,
-                                            large_inode->i_crtime_extra));
-               if (inode->i_dtime)
+                       time_to_string(ext2fs_inode_xtime_get(large_inode,
+                                                             i_crtime)));
+       if (inode->i_dtime) {
+               if (ext2fs_inode_includes(inode_size, i_ctime_extra)) {
+                       time_t tm;
+
+                       /* dtime doesn't have its own i_dtime_extra field, so
+                        * approximate this with i_ctime_extra instead. */
+                       tm = __decode_extra_sec(inode->i_dtime,
+                                               large_inode->i_ctime_extra);
                        fprintf(out, "%s dtime: 0x%08x:(%08x) -- %s", prefix,
-                               large_inode->i_dtime, large_inode->i_ctime_extra,
-                               inode_time_to_string(inode->i_dtime,
-                                                    large_inode->i_ctime_extra));
-       } else {
-               fprintf(out, "%sctime: 0x%08x -- %s", prefix, inode->i_ctime,
-                       time_to_string((__s32) inode->i_ctime));
-               fprintf(out, "%satime: 0x%08x -- %s", prefix, inode->i_atime,
-                       time_to_string((__s32) inode->i_atime));
-               fprintf(out, "%smtime: 0x%08x -- %s", prefix, inode->i_mtime,
-                       time_to_string((__s32) inode->i_mtime));
-               if (inode->i_dtime)
+                               inode->i_dtime, large_inode->i_ctime_extra,
+                               time_to_string(tm));
+               } else {
                        fprintf(out, "%sdtime: 0x%08x -- %s", prefix,
                                inode->i_dtime,
                                time_to_string((__s32) inode->i_dtime));
+               }
        }
        if (EXT2_INODE_SIZE(current_fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
                internal_dump_inode_extra(out, prefix, inode_num,
@@ -934,11 +949,7 @@ void internal_dump_inode(FILE *out, const char *prefix,
        dump_inode_attributes(out, inode_num);
        if (ext2fs_has_feature_metadata_csum(current_fs->super)) {
                __u32 crc = inode->i_checksum_lo;
-               if (is_large_inode &&
-                   large_inode->i_extra_isize >=
-                               (offsetof(struct ext2_inode_large,
-                                         i_checksum_hi) -
-                                EXT2_GOOD_OLD_INODE_SIZE))
+               if (ext2fs_inode_includes(inode_size, i_checksum_hi))
                        crc |= ((__u32)large_inode->i_checksum_hi) << 16;
                fprintf(out, "Inode checksum: 0x%08x\n", crc);
        }
@@ -985,7 +996,7 @@ static void dump_inode(ext2_ino_t inode_num, struct ext2_inode *inode)
        close_pager(out);
 }
 
-void do_stat(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_stat(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
             void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      inode;
@@ -1017,7 +1028,7 @@ void do_stat(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        return;
 }
 
-void do_dump_extents(int argc, char **argv, int sci_idx EXT2FS_ATTR((unused)),
+void do_dump_extents(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                     void *infop EXT2FS_ATTR((unused)))
 {
        struct ext2_inode inode;
@@ -1085,11 +1096,11 @@ static int print_blocks_proc(ext2_filsys fs EXT2FS_ATTR((unused)),
                             int ref_offset EXT2FS_ATTR((unused)),
                             void *private EXT2FS_ATTR((unused)))
 {
-       printf("%llu ", *blocknr);
+       printf("%llu ", (unsigned long long) *blocknr);
        return 0;
 }
 
-void do_blocks(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_blocks(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
               void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      inode;
@@ -1107,7 +1118,7 @@ void do_blocks(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        return;
 }
 
-void do_chroot(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_chroot(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
               void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
@@ -1125,7 +1136,7 @@ void do_chroot(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 }
 
 #ifndef READ_ONLY
-void do_clri(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_clri(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
             void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
@@ -1141,7 +1152,7 @@ void do_clri(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
                return;
 }
 
-void do_freei(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_freei(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        unsigned int    len = 1;
@@ -1172,7 +1183,7 @@ void do_freei(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        ext2fs_mark_ib_dirty(current_fs);
 }
 
-void do_seti(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_seti(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
             void *infop EXT2FS_ATTR((unused)))
 {
        unsigned int    len = 1;
@@ -1204,7 +1215,7 @@ void do_seti(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 }
 #endif /* READ_ONLY */
 
-void do_testi(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_testi(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
@@ -1219,7 +1230,7 @@ void do_testi(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 }
 
 #ifndef READ_ONLY
-void do_freeb(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_freeb(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        blk64_t block;
@@ -1232,14 +1243,14 @@ void do_freeb(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        while (count-- > 0) {
                if (!ext2fs_test_block_bitmap2(current_fs->block_map,block))
                        com_err(argv[0], 0, "Warning: block %llu already clear",
-                               block);
+                               (unsigned long long) block);
                ext2fs_unmark_block_bitmap2(current_fs->block_map,block);
                block++;
        }
        ext2fs_mark_bb_dirty(current_fs);
 }
 
-void do_setb(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_setb(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
             void *infop EXT2FS_ATTR((unused)))
 {
        blk64_t block;
@@ -1252,7 +1263,7 @@ void do_setb(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        while (count-- > 0) {
                if (ext2fs_test_block_bitmap2(current_fs->block_map,block))
                        com_err(argv[0], 0, "Warning: block %llu already set",
-                               block);
+                               (unsigned long long) block);
                ext2fs_mark_block_bitmap2(current_fs->block_map,block);
                block++;
        }
@@ -1260,7 +1271,7 @@ void do_setb(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 }
 #endif /* READ_ONLY */
 
-void do_testb(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_testb(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        blk64_t block;
@@ -1270,9 +1281,11 @@ void do_testb(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
                return;
        while (count-- > 0) {
                if (ext2fs_test_block_bitmap2(current_fs->block_map,block))
-                       printf("Block %llu marked in use\n", block);
+                       printf("Block %llu marked in use\n",
+                              (unsigned long long) block);
                else
-                       printf("Block %llu not in use\n", block);
+                       printf("Block %llu not in use\n",
+                              (unsigned long long) block);
                block++;
        }
 }
@@ -1345,7 +1358,7 @@ static void modify_u32(char *com, const char *prompt,
 }
 
 
-void do_modify_inode(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_modify_inode(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                     void *infop EXT2FS_ATTR((unused)))
 {
        struct ext2_inode inode;
@@ -1423,7 +1436,7 @@ void do_modify_inode(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 }
 #endif /* READ_ONLY */
 
-void do_change_working_dir(int argc, char *argv[],
+void do_change_working_dir(int argc, ss_argv_t argv,
                           int sci_idx EXT2FS_ATTR((unused)),
                           void *infop EXT2FS_ATTR((unused)))
 {
@@ -1442,7 +1455,7 @@ void do_change_working_dir(int argc, char *argv[],
        return;
 }
 
-void do_print_working_directory(int argc, char *argv[],
+void do_print_working_directory(int argc, ss_argv_t argv,
                                int sci_idx EXT2FS_ATTR((unused)),
                                void *infop EXT2FS_ATTR((unused)))
 {
@@ -1533,7 +1546,7 @@ static void make_link(char *sourcename, char *destname)
 }
 
 
-void do_link(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_link(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
             void *infop EXT2FS_ATTR((unused)))
 {
        if (common_args_process(argc, argv, 3, 3, "link",
@@ -1556,7 +1569,7 @@ static int mark_blocks_proc(ext2_filsys fs, blk64_t *blocknr,
        return 0;
 }
 
-void do_undel(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_undel(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
@@ -1620,7 +1633,7 @@ static void unlink_file_by_name(char *filename)
        return;
 }
 
-void do_unlink(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_unlink(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
               void *infop EXT2FS_ATTR((unused)))
 {
        if (common_args_process(argc, argv, 2, 2, "link",
@@ -1630,7 +1643,7 @@ void do_unlink(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        unlink_file_by_name(argv[1]);
 }
 
-void do_copy_inode(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_copy_inode(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                   void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      src_ino, dest_ino;
@@ -1659,7 +1672,7 @@ void do_copy_inode(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 
 #endif /* READ_ONLY */
 
-void do_find_free_block(int argc, char *argv[],
+void do_find_free_block(int argc, ss_argv_t argv,
                        int sci_idx EXT2FS_ATTR((unused)),
                        void *infop EXT2FS_ATTR((unused)))
 {
@@ -1708,12 +1721,12 @@ void do_find_free_block(int argc, char *argv[],
                        com_err("ext2fs_new_block", retval, 0);
                        return;
                } else
-                       printf("%llu ", free_blk);
+                       printf("%llu ", (unsigned long long) free_blk);
        }
        printf("\n");
 }
 
-void do_find_free_inode(int argc, char *argv[],
+void do_find_free_inode(int argc, ss_argv_t argv,
                        int sci_idx EXT2FS_ATTR((unused)),
                        void *infop EXT2FS_ATTR((unused)))
 {
@@ -1755,7 +1768,7 @@ void do_find_free_inode(int argc, char *argv[],
 }
 
 #ifndef READ_ONLY
-void do_write(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_write(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        errcode_t       retval;
@@ -1769,7 +1782,7 @@ void do_write(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
                com_err(argv[0], retval, 0);
 }
 
-void do_mknod(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_mknod(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        unsigned long   major, minor;
@@ -1804,9 +1817,12 @@ void do_mknod(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        }
 
        if (nr == 5) {
-               major = strtoul(argv[3], argv+3, 0);
-               minor = strtoul(argv[4], argv+4, 0);
-               if (major > 65535 || minor > 65535 || argv[3][0] || argv[4][0])
+               char *end1 = NULL, *end2 = NULL;
+
+               major = strtoul(argv[3], &end1, 0);
+               minor = strtoul(argv[4], &end2, 0);
+               if (major > 65535 || minor > 65535 ||
+                   (end1 && *end1) || (end2 && *end2))
                        nr = 0;
        }
 
@@ -1820,7 +1836,7 @@ void do_mknod(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
                com_err(argv[0], retval, 0);
 }
 
-void do_mkdir(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_mkdir(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        errcode_t retval;
@@ -1874,7 +1890,7 @@ static void kill_file_by_inode(ext2_ino_t inode)
 }
 
 
-void do_kill_file(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_kill_file(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                  void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode_num;
@@ -1885,7 +1901,7 @@ void do_kill_file(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        kill_file_by_inode(inode_num);
 }
 
-void do_rm(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_rm(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
           void *infop EXT2FS_ATTR((unused)))
 {
        int retval;
@@ -1947,7 +1963,7 @@ static int rmdir_proc(ext2_ino_t dir EXT2FS_ATTR((unused)),
        return 0;
 }
 
-void do_rmdir(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_rmdir(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        int retval;
@@ -2006,7 +2022,7 @@ void do_rmdir(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 #endif /* READ_ONLY */
 
 void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
-                           char *argv[] EXT2FS_ATTR((unused)),
+                           ss_argv_t argv EXT2FS_ATTR((unused)),
                            int sci_idx EXT2FS_ATTR((unused)),
                            void *infop EXT2FS_ATTR((unused)))
 {
@@ -2018,7 +2034,7 @@ void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
 }
 
 #ifndef READ_ONLY
-void do_expand_dir(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_expand_dir(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                    void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t inode;
@@ -2033,7 +2049,7 @@ void do_expand_dir(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        return;
 }
 
-void do_features(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_features(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                 void *infop EXT2FS_ATTR((unused)))
 {
        int     i;
@@ -2055,7 +2071,7 @@ void do_features(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 }
 #endif /* READ_ONLY */
 
-void do_bmap(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_bmap(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
             void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
@@ -2110,16 +2126,17 @@ void do_bmap(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
                               &ret_flags, &pblk);
        if (errcode) {
                com_err(argv[0], errcode,
-                       "while mapping logical block %llu\n", blk);
+                       "while mapping logical block %llu\n",
+                       (unsigned long long) blk);
                return;
        }
-       printf("%llu", pblk);
+       printf("%llu", (unsigned long long) pblk);
        if (ret_flags & BMAP_RET_UNINIT)
                fputs(" (uninit)", stdout);
        fputc('\n', stdout);
 }
 
-void do_imap(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_imap(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
             void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
@@ -2151,7 +2168,7 @@ void do_imap(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 
 }
 
-void do_idump(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_idump(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        struct ext2_inode_large *inode;
@@ -2222,7 +2239,7 @@ err:
 }
 
 #ifndef READ_ONLY
-void do_set_current_time(int argc, char *argv[],
+void do_set_current_time(int argc, ss_argv_t argv,
                         int sci_idx EXT2FS_ATTR((unused)),
                         void *infop EXT2FS_ATTR((unused)))
 {
@@ -2283,7 +2300,7 @@ static int find_supp_feature(__u32 *supp, int feature_type, char *name)
        return 0;
 }
 
-void do_supported_features(int argc, char *argv[],
+void do_supported_features(int argc, ss_argv_t argv,
                           int sci_idx EXT2FS_ATTR((unused)),
                           void *infop EXT2FS_ATTR((unused)))
 {
@@ -2313,7 +2330,7 @@ void do_supported_features(int argc, char *argv[],
 }
 
 #ifndef READ_ONLY
-void do_punch(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_punch(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
              void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
@@ -2349,7 +2366,7 @@ void do_punch(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        }
 }
 
-void do_fallocate(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_fallocate(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                  void *infop EXT2FS_ATTR((unused)))
 {
        ext2_ino_t      ino;
@@ -2386,7 +2403,7 @@ void do_fallocate(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
        }
 }
 
-void do_symlink(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
+void do_symlink(int argc, ss_argv_t argv, int sci_idx EXT2FS_ATTR((unused)),
                void *infop EXT2FS_ATTR((unused)))
 {
        errcode_t       retval;
@@ -2403,7 +2420,7 @@ void do_symlink(int argc, char *argv[], int sci_idx EXT2FS_ATTR((unused)),
 #endif /* READ_ONLY */
 
 #if CONFIG_MMP
-void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[],
+void do_dump_mmp(int argc EXT2FS_ATTR((unused)), ss_argv_t argv,
                 int sci_idx EXT2FS_ATTR((unused)),
                 void *infop EXT2FS_ATTR((unused)))
 {
@@ -2447,17 +2464,19 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[],
        retval = ext2fs_mmp_read(current_fs, mmp_block, current_fs->mmp_buf);
        if (retval) {
                com_err(argv[0], retval, "reading MMP block %llu.\n",
-                       mmp_block);
+                       (unsigned long long) mmp_block);
                return;
        }
 
        t = mmp_s->mmp_time;
-       fprintf(stdout, "block_number: %llu\n", current_fs->super->s_mmp_block);
+       fprintf(stdout, "block_number: %llu\n",
+               (unsigned long long) current_fs->super->s_mmp_block);
        fprintf(stdout, "update_interval: %d\n",
                current_fs->super->s_mmp_update_interval);
        fprintf(stdout, "check_interval: %d\n", mmp_s->mmp_check_interval);
        fprintf(stdout, "sequence: %08x\n", mmp_s->mmp_seq);
-       fprintf(stdout, "time: %lld -- %s", mmp_s->mmp_time, ctime(&t));
+       fprintf(stdout, "time: %llu -- %s",
+               (unsigned long long) mmp_s->mmp_time, ctime(&t));
        fprintf(stdout, "node_name: %.*s\n",
                EXT2_LEN_STR(mmp_s->mmp_nodename));
        fprintf(stdout, "device_name: %.*s\n",
@@ -2467,7 +2486,7 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[],
 }
 #else
 void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
-                char *argv[] EXT2FS_ATTR((unused)),
+                ss_argv_t argv EXT2FS_ATTR((unused)),
                 int sci_idx EXT2FS_ATTR((unused)),
                 void *infop EXT2FS_ATTR((unused)))
 {