Whamcloud - gitweb
Change pkg-config files so that both <et/com_err.h> and <com_err.h> work
authorTheodore Ts'o <tytso@mit.edu>
Mon, 14 May 2012 16:45:54 +0000 (12:45 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 14 May 2012 16:45:54 +0000 (12:45 -0400)
Change the include path in the Cflags field so that #include
<lib/foo.h> and <foo.h> will work.  We had originally used a C flags
which allowed <foo.h> to work, but many applications (especially those
not using pkg-config) had been using the <lob/foo.h> formulation which
didn't require an explicit -I{$includedir} option to the C compiler.

If those applications then converted over to pkg-config, and the
e2fsprogs libraries were installed with a prefix other than /usr, so
that the header files were in some directory such as
/usr/local/include, a program that used #include <lib/foo.h> would
fail to compile.

So change the pkg-config files to include both -I{$includedir} and
-I{$includir}/lib.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
lib/blkid/blkid.pc.in
lib/e2p/e2p.pc.in
lib/et/com_err.pc.in
lib/ext2fs/ext2fs.pc.in
lib/quota/quota.pc.in
lib/ss/ss.pc.in
lib/uuid/uuid.pc.in

index b984f6d..808fe22 100644 (file)
@@ -7,5 +7,5 @@ Name: blkid
 Description: Block device id library
 Version: @E2FSPROGS_VERSION@
 Requires.private: uuid
-Cflags: -I${includedir}/blkid
+Cflags: -I${includedir}/blkid -I${includedir}
 Libs: -L${libdir} -lblkid
index 98ee9fb..c171ae6 100644 (file)
@@ -7,5 +7,5 @@ Name: e2p
 Description: Ext2fs userpace programs utility library
 Version: @E2FSPROGS_VERSION@
 Requires: 
-Cflags: -I${includedir}/e2p
+Cflags: -I${includedir}/e2p -I${includedir}
 Libs: -L${libdir} -le2p
index cb47ce1..86df8a2 100644 (file)
@@ -7,6 +7,6 @@ Name: com_err
 Description: Common error description library
 Version: @E2FSPROGS_VERSION@
 Requires:
-Cflags: -I${includedir}
+Cflags: -I${includedir}/et -I${includedir}
 Libs: -L${libdir} -lcom_err
 Libs.private: @SEM_INIT_LIB@
index 8db8663..efac85e 100644 (file)
@@ -7,5 +7,5 @@ Name: ext2fs
 Description: Ext2fs library
 Version: @E2FSPROGS_VERSION@
 Requires.private: com_err
-Cflags: -I${includedir}/ext2fs
+Cflags: -I${includedir}/ext2fs -I${includedir}
 Libs: -L${libdir} -lext2fs
index bcc3c44..1e4b887 100644 (file)
@@ -7,5 +7,5 @@ Name: quota
 Description: Quota management library
 Version: @E2FSPROGS_VERSION@
 Requires:
-Cflags: -I${includedir}/quota
+Cflags: -I${includedir}/quota -I${includedir}
 Libs: -L${libdir} -lquota
index cf89361..5c9eccb 100644 (file)
@@ -7,6 +7,6 @@ Name: ss
 Description: Subsystem command parsing library
 Version: @E2FSPROGS_VERSION@
 Requires.private: com_err
-Cflags: -I${includedir}/ss
+Cflags: -I${includedir}/ss -I${includedir}
 Libs: -L${libdir} -lss
 Libs.private: @DLOPEN_LIB@
index 9e38a32..eaa4e4d 100644 (file)
@@ -7,5 +7,5 @@ Name: uuid
 Description: Universally unique id library
 Version: @E2FSPROGS_VERSION@
 Requires: 
-Cflags: -I${includedir}/uuid
+Cflags: -I${includedir}/uuid -I${includedir}
 Libs: -L${libdir} -luuid