Whamcloud - gitweb
LU-17683 lnet: ksocknal_startup() leaks iface table 90/54590/6
authorAlex Zhuravlev <bzzz@whamcloud.com>
Wed, 27 Mar 2024 17:19:03 +0000 (20:19 +0300)
committerOleg Drokin <green@whamcloud.com>
Mon, 8 Apr 2024 15:44:12 +0000 (15:44 +0000)
which is allocated in lnet_inet_enumerate()

Signed-off-by: Alex Zhuravlev <bzzz@whamcloud.com>
Change-Id: Ib25402bb82a33c5f4838fc5bd9e9a22c806df89a
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54590
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lnet/klnds/o2iblnd/o2iblnd.c
lnet/klnds/socklnd/socklnd.c

index be69163..993525d 100644 (file)
@@ -3794,6 +3794,7 @@ kiblnd_startup(struct lnet_ni *ni)
        write_unlock_irqrestore(&kiblnd_data.kib_global_lock, flags);
 
        net->ibn_init = IBLND_INIT_ALL;
+       kfree(ifaces);
 
        return 0;
 
index d22249b..cbcfeb7 100644 (file)
@@ -2649,6 +2649,7 @@ ksocknal_startup(struct lnet_ni *ni)
        list_add(&net->ksnn_list, &ksocknal_data.ksnd_nets);
        net->ksnn_ni = ni;
        ksocknal_data.ksnd_nnets++;
+       kfree(ifaces);
 
        return 0;
 
@@ -2657,6 +2658,7 @@ out_net:
 out_base:
        if (ksocknal_data.ksnd_nnets == 0)
                ksocknal_base_shutdown();
+       kfree(ifaces);
 
        return -ENETDOWN;
 }