Whamcloud - gitweb
LU-13437 lmv: check stripe FID sanity 60/38560/2
authorLai Siyao <lai.siyao@whamcloud.com>
Fri, 8 May 2020 14:53:47 +0000 (22:53 +0800)
committerOleg Drokin <green@whamcloud.com>
Tue, 2 Jun 2020 04:42:21 +0000 (04:42 +0000)
Striped directory layout may be broken, if some stripe FID is insane,
return -ENODEV.

Signed-off-by: Lai Siyao <lai.siyao@whamcloud.com>
Change-Id: I7ed8c7c561e34625e2cb29bfd14bc0ecf3fce46c
Reviewed-on: https://review.whamcloud.com/38560
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Hongchao Zhang <hongchao@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/lmv/lmv_obd.c

index 062a44a..3a2db46 100644 (file)
@@ -1569,6 +1569,10 @@ lmv_locate_tgt_by_name(struct lmv_obd *lmv, struct lmv_stripe_md *lsm,
                        return ERR_CAST(oinfo);
        }
 
+       /* check stripe FID is sane */
+       if (!fid_is_sane(&oinfo->lmo_fid))
+               return ERR_PTR(-ENODEV);
+
        *fid = oinfo->lmo_fid;
        *mds = oinfo->lmo_mds;
        tgt = lmv_tgt(lmv, oinfo->lmo_mds);