Whamcloud - gitweb
LU-3892 ofd: setattr doesn't need to return attributes 72/7672/2
authorAlex Zhuravlev <alexey.zhuravlev@intel.com>
Mon, 16 Sep 2013 17:11:09 +0000 (21:11 +0400)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 24 Sep 2013 03:57:05 +0000 (03:57 +0000)
the root cause of the problem is that getattr finds the
object being already destroyed, so we have transno from
preceeding setattr and -ENOENT from getattr and this
confuses OSP.

there is actually no need in attributes in the reply.

Signed-off-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Change-Id: Ib059a443af164d0def58fdfbf41ab545c057cd10
Reviewed-on: http://review.whamcloud.com/7672
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
lustre/ofd/ofd_obd.c

index fd1f6e0..aa2c48a 100644 (file)
@@ -894,12 +894,6 @@ int ofd_setattr(const struct lu_env *env, struct obd_export *exp,
                ldlm_resource_putref(res);
        }
 
-       oinfo->oi_oa->o_valid = OBD_MD_FLID;
-
-       /* Quota release needs uid/gid info */
-       rc = ofd_attr_get(env, fo, &info->fti_attr);
-       obdo_from_la(oinfo->oi_oa, &info->fti_attr,
-                    OFD_VALID_FLAGS | LA_UID | LA_GID);
        ofd_info2oti(info, oti);
 
        ofd_counter_incr(exp, LPROC_OFD_STATS_SETATTR, oti->oti_jobid, 1);