Whamcloud - gitweb
LU-16439 socklnd: clarify error message on timeout 40/49540/3
authorAurelien Degremont <degremoa@amazon.com>
Mon, 2 Jan 2023 16:26:15 +0000 (16:26 +0000)
committerOleg Drokin <green@whamcloud.com>
Sat, 7 Jan 2023 07:59:30 +0000 (07:59 +0000)
When the local peer times out when writing
to another peer, prints an explicit error message
rather than a generic one. This is make it clearer
for admins and easier to debug.

Add port to help determining if this is always
the same one or not.

Test-Parameters: trivial
Change-Id: Iaefbc601963b50293743a22ff9329018e8a5fc4f
Signed-off-by: Aurelien Degremont <degremoa@amazon.com>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/49540
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Chris Horn <chris.horn@hpe.com>
Reviewed-by: Cyril Bordage <cbordage@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/klnds/socklnd/socklnd_cb.c

index 1ebf327..043a655 100644 (file)
@@ -605,11 +605,15 @@ simulate_error:
        if (!conn->ksnc_closing) {
                switch (rc) {
                case -ECONNRESET:
-                       LCONSOLE_WARN("Host %pISc reset our connection while we were sending data; it may have rebooted.\n",
-                                     &conn->ksnc_peeraddr);
+                       LCONSOLE_WARN("Host %pISc reset our connection while we were sending data; it may have rebooted: rc = %d\n",
+                                     &conn->ksnc_peeraddr, rc);
+                       break;
+               case -ETIMEDOUT:
+                       LCONSOLE_WARN("Timeout error while writing to %pISp. Closing socket: rc = %d\n",
+                                     &conn->ksnc_peeraddr, rc);
                        break;
                default:
-                       LCONSOLE_WARN("There was an unexpected network error while writing to %pISc: %d.\n",
+                       LCONSOLE_WARN("There was an unexpected network error while writing to %pISc: rc = %d\n",
                                      &conn->ksnc_peeraddr, rc);
                        break;
                }