Whamcloud - gitweb
LU-17555 ptlrpc: removed unused lm_repsize accessors 89/54089/6
authorShaun Tancheff <shaun.tancheff@hpe.com>
Sat, 24 Feb 2024 03:00:58 +0000 (10:00 +0700)
committerOleg Drokin <green@whamcloud.com>
Sat, 23 Mar 2024 05:55:01 +0000 (05:55 +0000)
ptlrpc_req_get_repsize() and ptlrpc_req_set_repsize() are unused.

ptlrpc_req_set_repsize() is superseded by
ptlrpc_request_set_replen() so remove the unused variants.

Test-Parameters: trivial
Signed-off-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Change-Id: Ib89a57c00605b110ec28040614aecba9826f5ffa
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54089
Reviewed-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lustre/include/lustre_net.h
lustre/ptlrpc/pack_generic.c

index 1a72add..5a52a50 100644 (file)
@@ -2362,8 +2362,6 @@ void lustre_msg_set_versions(struct lustre_msg *msg, __u64 *versions);
 void lustre_msg_set_transno(struct lustre_msg *msg, __u64 transno);
 void lustre_msg_set_status(struct lustre_msg *msg, __u32 status);
 void lustre_msg_set_conn_cnt(struct lustre_msg *msg, __u32 conn_cnt);
-void ptlrpc_req_set_repsize(struct ptlrpc_request *req, int count,
-                           __u32 *sizes);
 void ptlrpc_request_set_replen(struct ptlrpc_request *req);
 void lustre_msg_set_timeout(struct lustre_msg *msg, timeout_t timeout);
 void lustre_msg_set_service_timeout(struct lustre_msg *msg,
@@ -2544,18 +2542,6 @@ static inline __u32 lustre_request_magic(struct ptlrpc_request *req)
        return lustre_msg_get_magic(req->rq_reqmsg);
 }
 
-static inline int ptlrpc_req_get_repsize(struct ptlrpc_request *req)
-{
-       switch (req->rq_reqmsg->lm_magic) {
-       case LUSTRE_MSG_MAGIC_V2:
-               return req->rq_reqmsg->lm_repsize;
-       default:
-               LASSERTF(0, "incorrect message magic: %08x\n",
-                        req->rq_reqmsg->lm_magic);
-               return -EFAULT;
-       }
-}
-
 static inline int ptlrpc_send_limit_expired(struct ptlrpc_request *req)
 {
        if (req->rq_delay_limit != 0 &&
index 5d491b3..91cf24b 100644 (file)
@@ -1707,13 +1707,6 @@ void ptlrpc_request_set_replen(struct ptlrpc_request *req)
 }
 EXPORT_SYMBOL(ptlrpc_request_set_replen);
 
-void ptlrpc_req_set_repsize(struct ptlrpc_request *req, int count, __u32 *lens)
-{
-       req->rq_replen = lustre_msg_size(req->rq_reqmsg->lm_magic, count, lens);
-       if (req->rq_reqmsg->lm_magic == LUSTRE_MSG_MAGIC_V2)
-               req->rq_reqmsg->lm_repsize = req->rq_replen;
-}
-
 /**
  * Send a remote set_info_async.
  *