Whamcloud - gitweb
LU-12610 obd: delete OBD_ -> CFS_ redefinitions 40/35640/7
authorTimothy Day <timday@amazon.com>
Mon, 23 Oct 2023 15:50:23 +0000 (11:50 -0400)
committerOleg Drokin <green@whamcloud.com>
Fri, 3 Nov 2023 04:04:38 +0000 (04:04 +0000)
commitb4ec4dd10a7d0109e931e0490daddd98105457c3
treed816a26fee37470f4d6c6b77ad318e6111911053
parent250c6195fbe748d7c8f4c55888ed749de4cb95ce
LU-12610 obd: delete OBD_ -> CFS_ redefinitions

With all consumers of the OBD macros fixed, finally
remove OBD macros that are simply redefinitions of CFS
macros.

Remove:
OBD_FAIL_PRECHECK(id)
OBD_FAIL_CHECK(id)
OBD_FAIL_CHECK_VALUE(id, value)
OBD_FAIL_CHECK_ORSET(id, value)
OBD_FAIL_CHECK_RESET(id, value)
OBD_FAIL_RETURN(id, ret)
OBD_FAIL_TIMEOUT(id, secs)
OBD_FAIL_TIMEOUT_MS(id, ms)
OBD_FAIL_TIMEOUT_ORSET(id, value, secs)
OBD_RACE(id)
OBD_FAIL_ONCE
OBD_FAILED

Avoid losing the unlikely optimization with OBD_FAIL_PRECHECK by
adding unlikely to CFS_FAIL_PRECHECK. For libcfs_private.h not
all callers of CFS_FAIL_PRECHECK had unlikely so this is fixed
as well.

Test-Parameters: trivial
Signed-off-by: Timothy Day <timday@amazon.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Change-Id: I6620bae389a9e29da2c0258b07f0ca2a7f67c14a
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/35640
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Neil Brown <neilb@suse.de>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
libcfs/include/libcfs/libcfs_fail.h
lustre/include/obd_support.h