profile_create_node: set magic before strdup(name) to avoid memory leak

If new->magic != PROF_MAGIC_NODE, profile_free_node() don't free node.
This will cause the node to be unable to be released correctly and
a memory leak will occur.

Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Reviewed-by: Wu Bo <wubo40@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/lib/support/profile.c b/lib/support/profile.c
index 585ed59..f54739e 100644 (file)
--- a/lib/support/profile.c
+++ b/lib/support/profile.c
@@ -1093,6 +1093,7 @@ errcode_t profile_create_node(const char *name, const char *value,
        if (!new)
                return ENOMEM;
        memset(new, 0, sizeof(struct profile_node));
+       new->magic = PROF_MAGIC_NODE;
        new->name = strdup(name);
        if (new->name == 0) {
            profile_free_node(new);
@@ -1105,7 +1106,6 @@ errcode_t profile_create_node(const char *name, const char *value,
                    return ENOMEM;
                }
        }
-       new->magic = PROF_MAGIC_NODE;
 
        *ret_node = new;
        return 0;