Whamcloud - gitweb
libext2fs: avoid dereferencing beyond allocated memory in xattr code
authorTheodore Ts'o <tytso@mit.edu>
Fri, 11 Nov 2016 23:38:20 +0000 (18:38 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 11 Nov 2016 23:38:20 +0000 (18:38 -0500)
Detected by ASAN.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/ext2fs/ext_attr.c

index e8fd10c..5eeb940 100644 (file)
@@ -308,7 +308,7 @@ static int find_ea_index(char *fullname, char **name, int *index)
        struct ea_name_index *e;
 
        for (e = ea_names; e->name; e++) {
-               if (memcmp(fullname, e->name, strlen(e->name)) == 0) {
+               if (strncmp(fullname, e->name, strlen(e->name)) == 0) {
                        *name = (char *)fullname + strlen(e->name);
                        *index = e->index;
                        return 1;