Whamcloud - gitweb
tune2fs: fix resource leak in handle_quota_options()
authorTheodore Ts'o <tytso@mit.edu>
Thu, 21 Jan 2021 21:07:25 +0000 (16:07 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 21 Jan 2021 21:07:25 +0000 (16:07 -0500)
Addresses-Coverity-Bug: 1467672
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
misc/tune2fs.c

index a481d8f..48b8ce8 100644 (file)
@@ -1619,6 +1619,8 @@ static int handle_quota_options(ext2_filsys fs)
                                        com_err(program_name, retval,
                                                _("while updating quota limits (%d)"),
                                                qtype);
+                               quota_errout:
+                                       quota_release_context(&qctx);
                                        return 1;
                                }
                        }
@@ -1627,7 +1629,7 @@ static int handle_quota_options(ext2_filsys fs)
                                com_err(program_name, retval,
                                        _("while writing quota file (%d)"),
                                        qtype);
-                               return 1;
+                               goto quota_errout;
                        }
                        /* Enable Quota feature if one of quota enabled */
                        if (!ext2fs_has_feature_quota(fs->super)) {
@@ -1645,7 +1647,7 @@ static int handle_quota_options(ext2_filsys fs)
                                com_err(program_name, retval,
                                        _("while removing quota file (%d)"),
                                        qtype);
-                               return 1;
+                               goto quota_errout;
                        }
                        if (qtype == PRJQUOTA) {
                                ext2fs_clear_feature_project(fs->super);