Whamcloud - gitweb
tune2fs: quiet llvm build warning
authorAndreas Dilger <adilger@dilger.ca>
Wed, 30 Aug 2017 05:56:08 +0000 (01:56 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 30 Aug 2017 05:56:08 +0000 (01:56 -0400)
Quiet a relatively harmless build warning:

tune2fs.c:928:18: warning: '&&' within '||' [-Wlogical-op-parentheses]
if (pass == 1 && (inode->i_flags & EXT4_EA_INODE_FL) ||
    ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
tune2fs.c:928:18: place parentheses around '&&' to silence warning

Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
misc/tune2fs.c

index 18cea52..ecba2ea 100644 (file)
@@ -929,8 +929,10 @@ static void rewrite_inodes(ext2_filsys fs)
                        if (!ino)
                                break;
 
-                       if (pass == 1 && (inode->i_flags & EXT4_EA_INODE_FL) ||
-                           pass == 2 && !(inode->i_flags & EXT4_EA_INODE_FL))
+                       if (((pass == 1) &&
+                            (inode->i_flags & EXT4_EA_INODE_FL)) ||
+                           ((pass == 2) &&
+                            !(inode->i_flags & EXT4_EA_INODE_FL)))
                                rewrite_one_inode(&ctx, ino, inode);
                } while (ino);