From 3b888d00da1a92b7c872c5de1fab8e8a3d6363b8 Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Wed, 5 Jun 2024 02:46:13 -0400 Subject: [PATCH] LU-17000 utils: Initialize var 'gw' and 'net' before using Although this is called at "sequence end" and most likely 'gw' and 'net' will be populated by then. It is still good to be defensive and make them initialize Test-Parameters: trivial testlist=sanity-lnet CoverityID: 410246 ("Uninitialized scalar variable") CoverityID: 410240 ("Uninitialized scalar variable") Signed-off-by: Arshad Hussain Change-Id: I2f47df431eea0e0344043ac22806865e87435c6e Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55316 Tested-by: jenkins Tested-by: Maloo Reviewed-by: James Simmons Reviewed-by: Serguei Smirnov Reviewed-by: Oleg Drokin --- lustre/utils/portals.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lustre/utils/portals.c b/lustre/utils/portals.c index 37ee203..0f259bc 100644 --- a/lustre/utils/portals.c +++ b/lustre/utils/portals.c @@ -1833,7 +1833,7 @@ jt_ptl_fail_nid(int argc, char **argv) static int ptl_yaml_route_display(yaml_parser_t *reply) { - char gw[LNET_MAX_STR_LEN], net[18]; + char gw[LNET_MAX_STR_LEN] = "", net[18] = ""; bool done = false, alive = false; int hops = -1, prio = -1; yaml_event_t event; -- 1.8.3.1