From b6ebc92a899dcfeb76d343a22814343acd726592 Mon Sep 17 00:00:00 2001 From: "John L. Hammond" Date: Fri, 29 Jun 2018 16:11:05 -0500 Subject: [PATCH] LU-11108 mdt: propagate errors in mdt_getxattr() In mdt_getxattr(), if mo_xattr_get() fails then return that error value rather than letting mdt_nodemap_map_acl() mangle it. Signed-off-by: John L. Hammond Change-Id: I967bcc5ad6edf30b43f373e85f22fc922647c435 Reviewed-on: https://review.whamcloud.com/32743 Reviewed-by: Andreas Dilger Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Andrew Perepechko Reviewed-by: Emoly Liu Reviewed-by: James Simmons Reviewed-by: Oleg Drokin --- lustre/mdt/mdt_xattr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lustre/mdt/mdt_xattr.c b/lustre/mdt/mdt_xattr.c index 3f02599..481883c 100644 --- a/lustre/mdt/mdt_xattr.c +++ b/lustre/mdt/mdt_xattr.c @@ -262,6 +262,9 @@ int mdt_getxattr(struct mdt_thread_info *info) const char *xattr_name = req_capsule_client_get(info->mti_pill, &RMF_NAME); rc = mo_xattr_get(info->mti_env, next, buf, xattr_name); + if (rc < 0) + GOTO(out, rc); + rc = mdt_nodemap_map_acl(info, buf->lb_buf, rc, xattr_name, NODEMAP_FS_TO_CLIENT); } else if (valid == OBD_MD_FLXATTRLS) { -- 1.8.3.1