From f7a138c9afe9ac8a7273bdb622dd00eacd252bcc Mon Sep 17 00:00:00 2001 From: Emoly Liu Date: Thu, 19 Sep 2019 18:26:31 +0800 Subject: [PATCH] LU-12229 tests: fix "bad substitution" error In newer bash version, the special characters is invalid in the usage of indirect variable expansion {!word}. For example, # a=lustre,pool # echo ${!a} -bash: lustre,pool: bad substitution To avoid "bad sustitution" error, pool_new command is used in test_1j and test_1k directly. Lustre-change: https://review.whamcloud.com/36243 Lustre-commit: ac426d6f17b80ed36052f11b9780fa444cfa24aa Test-Parameters:trivial clientdistro=el8 testlist=ost-pools Signed-off-by: Emoly Liu Change-Id: Ifce4616cd7f314416fe5fa09f8fba846ae45bcef Reviewed-by: Li Xi Reviewed-by: Jian Yu Reviewed-by: James Nunez Signed-off-by: Minh Diep Reviewed-on: https://review.whamcloud.com/36377 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Oleg Drokin --- lustre/tests/ost-pools.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lustre/tests/ost-pools.sh b/lustre/tests/ost-pools.sh index 1a97cef..450ac96 100755 --- a/lustre/tests/ost-pools.sh +++ b/lustre/tests/ost-pools.sh @@ -281,14 +281,14 @@ test_1i() { run_test 1i "pool_new should fail if poolname and fs-name are missing" test_1j() { - create_pool ${FSNAME},$POOL + do_facet mgs lctl pool_new ${FSNAME},$POOL [[ $? -ne 0 ]] || error "pool_new did not fail even if poolname format was wrong" } run_test 1j "pool_new should fail if poolname format is wrong" test_1k() { - create_pool ${FSNAME}/$POOL + do_facet mgs lctl pool_new ${FSNAME}/$POOL [[ $? -ne 0 ]] || error "pool_new did not fail even if poolname format was wrong" } -- 1.8.3.1