From f7244080286ed986ed8c31b3fc0ae498e876b9e5 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Thu, 11 Jul 2024 17:05:26 -0400 Subject: [PATCH] LU-12511 llite: use mapping_set_error instead of opencoded set_bit The mapping_set_error() helper sets the correct AS_ flag for the mapping so there is no reason to open code it. Use the helper directly. [akpm@linux-foundation.org: be honest about conversion from -ENXIO to -EIO] Link: http://lkml.kernel.org/r/20160912111608.2588-2-mhocko@kernel.org Linux-commit: 5114a97a8bce7f4ead29a32b67dee85438699b9e Lustre-change: https://review.whamcloud.com/51372 Lustre-commit: aac625055e50e83d7716bdfc6ecfab3282eb0ad2 Change-Id: I153bc04d4745a20013820ba81572cadb37ab8f39 Signed-off-by: Michal Hocko Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51372 Reviewed-by: Neil Brown Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55553 Tested-by: jenkins Tested-by: Maloo Reviewed-by: James Simmons --- lustre/llite/vvp_page.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lustre/llite/vvp_page.c b/lustre/llite/vvp_page.c index 5ee33e5..3b4a934 100644 --- a/lustre/llite/vvp_page.c +++ b/lustre/llite/vvp_page.c @@ -252,10 +252,7 @@ static void vvp_vmpage_error(struct inode *inode, struct page *vmpage, obj->vob_discard_page_warned = 0; } else { SetPageError(vmpage); - if (ioret == -ENOSPC) - set_bit(AS_ENOSPC, &inode->i_mapping->flags); - else - set_bit(AS_EIO, &inode->i_mapping->flags); + mapping_set_error(inode->i_mapping, ioret); if ((ioret == -ESHUTDOWN || ioret == -EINTR || ioret == -EIO) && obj->vob_discard_page_warned == 0) { -- 1.8.3.1