From a704a3def6512934c817d495f9a589bb795a5548 Mon Sep 17 00:00:00 2001 From: Jian Yu Date: Mon, 20 Mar 2023 22:32:03 -0700 Subject: [PATCH] LU-16589 tests: fix hard-link failure in sanityn/55d Since coreutils version 8.31, the stat() and lstat() operations were removed from ln by commit 571f63f5010b, which caused the following dir hard-link failure in sanityn/55d: ln: failed to create hard link '/mnt/lustre2/d55d.sanityn/d55d.sanityn/' => '/mnt/lustre2/d55d.sanityn/f1': No such file or directory This actually reveals a kernel issue which is fixed by commit v5.18-rc2-188-gb3d4650d82c7. To avoid the kernel issue and keep the test effective, this patch appends the target filename to the $tdir/ so as to fix the hard-link failure. Lustre-change: https://review.whamcloud.com/50127 Lustre-commit: TBD (from 6dea4fabe02ebd90bc6e4dbb8641003a9a66c967) Test-Parameters: trivial env=ONLY=55d testlist=sanityn Test-Parameters: trivial clientdistro=el9.1 env=ONLY=55d testlist=sanityn Test-Parameters: trivial clientdistro=el9.0 env=ONLY=55d testlist=sanityn Test-Parameters: trivial clientdistro=sles15sp4 env=ONLY=55d testlist=sanityn Test-Parameters: trivial clientdistro=sles15sp3 env=ONLY=55d testlist=sanityn Change-Id: I42313e43eaea3d94007d534bf38efdeacf2ede43 Signed-off-by: Jian Yu Reviewed-on: https://review.whamcloud.com/c/ex/lustre-release/+/50350 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger --- lustre/tests/sanityn.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lustre/tests/sanityn.sh b/lustre/tests/sanityn.sh index 8a634b7..fedbe16 100755 --- a/lustre/tests/sanityn.sh +++ b/lustre/tests/sanityn.sh @@ -3512,9 +3512,9 @@ test_55d() mkdir -p $DIR2/$tdir/$tdir || error "(1) mkdir failed" # link in reverse locking order - ln $DIR2/$tdir/f1 $DIR2/$tdir/$tdir/ + ln $DIR2/$tdir/f1 $DIR2/$tdir/$tdir/f1 || error "(2) ln failed" - wait $PID1 && error "(2) mv succeeded" + ! wait $PID1 || error "(3) mv succeeded" rm -rf $DIR/$tdir } run_test 55d "rename file vs link" -- 1.8.3.1