From 6c1f7d3177057f91ece1a6ee02753d6b40024268 Mon Sep 17 00:00:00 2001 From: Ulka Vaze Date: Wed, 20 May 2015 16:36:16 +0530 Subject: [PATCH] LU-6524 llog: Incorrect use of ERR_PTR This issue is raised by smatch as below description llog_osd_destroy incorrectly tried to use ERR_PTR pointer Resolution is changed rc value to ENOENT Incorporated code review comments. Removed ENOENT of earlier commit and updated ot path. Signed-off-by: Ulka Vaze Change-Id: I010c21763ac7fc3664214eda93ea18e1c2d35de6 Signed-off-by: Ulka Vaze Reviewed-on: http://review.whamcloud.com/14876 Tested-by: Jenkins Reviewed-by: Dmitry Eremin Tested-by: Maloo Reviewed-by: Bob Glossman Reviewed-by: Oleg Drokin --- lustre/obdclass/llog_osd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lustre/obdclass/llog_osd.c b/lustre/obdclass/llog_osd.c index f0e904b..e81fb9e 100644 --- a/lustre/obdclass/llog_osd.c +++ b/lustre/obdclass/llog_osd.c @@ -1548,7 +1548,7 @@ out_unlock: dt_write_unlock(env, o); out_trans: dt_trans_stop(env, d, th); - if (llog_dir != NULL) + if (!(IS_ERR_OR_NULL(llog_dir))) lu_object_put(env, &llog_dir->do_lu); RETURN(rc); } -- 1.8.3.1