From 54beb93ee9b52ea331eba911a3436a50d618debe Mon Sep 17 00:00:00 2001 From: Oleg Drokin Date: Wed, 21 Jul 2021 16:03:10 -0400 Subject: [PATCH] LU-14877 llite: Remove inode locking in ll_fsync It does not appear to be necessary Lustre-change: https://review.whamcloud.com/44368 Lustre-commit: e8d76d1090e912ee5d916284ca5c8ba9195ddd9b Change-Id: I0142a9dca4ecc6893521275b69a0a46012eab0b0 Fixes: 8f3ef1e961 ("LU-812 llite: 3.0+ kernel fsync should call write") Signed-off-by: Oleg Drokin Reviewed-by: Andreas Dilger Reviewed-on: https://review.whamcloud.com/44921 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Patrick Farrell --- lustre/llite/file.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lustre/llite/file.c b/lustre/llite/file.c index 6694738..b86f3ca 100644 --- a/lustre/llite/file.c +++ b/lustre/llite/file.c @@ -4425,7 +4425,6 @@ int ll_fsync(struct file *file, loff_t start, loff_t end, int datasync) /* fsync's caller has already called _fdata{sync,write}, we want * that IO to finish before calling the osc and mdc sync methods */ rc = filemap_write_and_wait_range(inode->i_mapping, start, end); - inode_lock(inode); /* catch async errors that were recorded back when async writeback * failed for pages in this mapping. */ @@ -4466,8 +4465,6 @@ int ll_fsync(struct file *file, loff_t start, loff_t end, int datasync) fd->fd_write_failed = false; } - inode_unlock(inode); - if (!rc) ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_FSYNC, ktime_us_delta(ktime_get(), kstart)); -- 1.8.3.1