From 4b59352edb5ce783ba578d708de1fda981acfec6 Mon Sep 17 00:00:00 2001 From: Frank Sorenson Date: Fri, 4 Jul 2014 15:31:50 -0400 Subject: [PATCH] mke2fs: prevent creation of filesystem with unsupported revision It's a bit strange to accept revision levels higher than the code creating the filesystem can understand, so don't allow it. At least the kernel will mount the fs readonly if it's too high, but no other utility will touch it, so you can't fix the error. Just reject anything > EXT2_MAX_SUPP_REV at mkfs time. Signed-off-by: Frank Sorenson [sandeen@redhat.com: Add more verbose commit log] Signed-off-by: Eric Sandeen Signed-off-by: Theodore Ts'o --- misc/mke2fs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/misc/mke2fs.c b/misc/mke2fs.c index da4ddac..883b8f2 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -1659,6 +1659,11 @@ profile_error: _("bad revision level - %s"), optarg); exit(1); } + if (r_opt > EXT2_MAX_SUPP_REV) { + com_err(program_name, EXT2_ET_REV_TOO_HIGH, + _("while trying to create revision %d"), r_opt); + exit(1); + } fs_param.s_rev_level = r_opt; break; case 's': /* deprecated */ -- 1.8.3.1