From 40cc9697fa0b0ccec43d9e519805fb4c13c70490 Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Mon, 3 Jun 2024 06:01:04 -0400 Subject: [PATCH] LU-17000 obdclass: Initialize var 'bufsize' before using This patch initialize variable bufsize before using. This is because bufsize is left uninitialized if obd_page_dif_generate_buffer() calls fails. Once bufsize is initialize calling cfs_crypto_hash_final() becomes safe. Test-Parameters: trivial CoverityID: 397224 ("Uninitialized scalar variable") Signed-off-by: Arshad Hussain Change-Id: I933cc3746d107acb308bd0060b7648a82410711c Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55291 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: Li Dongyang Reviewed-by: Oleg Drokin --- lustre/obdclass/integrity.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lustre/obdclass/integrity.c b/lustre/obdclass/integrity.c index 81b9d11..54906b8 100644 --- a/lustre/obdclass/integrity.c +++ b/lustre/obdclass/integrity.c @@ -90,7 +90,7 @@ static int __obd_t10_performance_test(const char *obd_name, unsigned char cfs_alg = cksum_obd2cfs(OBD_CKSUM_T10_TOP); struct ahash_request *req; obd_dif_csum_fn *fn = NULL; - unsigned int bufsize; + unsigned int bufsize = 0; unsigned char *buffer; struct page *__page; __be16 *guard_start; @@ -123,8 +123,7 @@ static int __obd_t10_performance_test(const char *obd_name, guard_start = (__be16 *)buffer; guard_number = PAGE_SIZE / sizeof(*guard_start); for (i = 0; i < repeat_number; i++) { - /* - * The left guard number should be able to hold checksums of a + /* The left guard number should be able to hold checksums of a * whole page */ rc = obd_page_dif_generate_buffer(obd_name, data_page, 0, -- 1.8.3.1