From 0d719bad862a6b900089cb9bd4e34d99d4c84746 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Fri, 10 Jan 2014 22:09:45 -0500 Subject: [PATCH] libblkid: add error checking for rename() while saving the blkid cache Addresses-Coverity-Id: #1049141 Signed-off-by: "Theodore Ts'o" --- lib/blkid/save.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/blkid/save.c b/lib/blkid/save.c index c55e043..a6538db 100644 --- a/lib/blkid/save.c +++ b/lib/blkid/save.c @@ -136,7 +136,7 @@ int blkid_flush_cache(blkid_cache cache) fclose(file); if (opened != filename) { if (ret < 0) { - unlink(opened); + (void) unlink(opened); DBG(DEBUG_SAVE, printf("unlinked temp cache %s\n", opened)); } else { @@ -149,7 +149,8 @@ int blkid_flush_cache(blkid_cache cache) link(filename, backup); free(backup); } - rename(opened, filename); + if (rename(opened, filename) < 0) + (void) unlink(opened); DBG(DEBUG_SAVE, printf("moved temp cache %s\n", opened)); } -- 1.8.3.1