From: Theodore Ts'o <tytso@mit.edu>
Date: Tue, 10 Dec 2024 04:48:50 +0000 (-0500)
Subject: libext2fs: fix compiler warning in ext2fs_orphan_file_block_csum_set()
X-Git-Tag: v1.47.2-wc1~118
X-Git-Url: https://git.whamcloud.com/gitweb?a=commitdiff_plain;h=c1e0fa3231d3639c79f4460bc9e38d6c91cafa6c;p=tools%2Fe2fsprogs.git

libext2fs: fix compiler warning in ext2fs_orphan_file_block_csum_set()

Fixes: daf2d1c830d9 ("libext2fs: fix ext2fs_orphan_file_block_csum_set()")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/lib/ext2fs/orphan.c b/lib/ext2fs/orphan.c
index d910f3c..14ac356 100644
--- a/lib/ext2fs/orphan.c
+++ b/lib/ext2fs/orphan.c
@@ -251,13 +251,15 @@ errcode_t ext2fs_orphan_file_block_csum_set(ext2_filsys fs, ext2_ino_t ino,
 {
 	struct ext4_orphan_block_tail *tail;
 	errcode_t ret;
-	__u32 crc;
+	__u32 crc = 0;
 
 	if (!ext2fs_has_feature_metadata_csum(fs->super))
 		return 0;
 
 	tail = ext2fs_orphan_block_tail(fs, buf);
 	ret = ext2fs_orphan_file_block_csum(fs, ino, blk, buf, &crc);
+	if (ret)
+		return 0;
 	tail->ob_checksum = ext2fs_cpu_to_le32(crc);
 	return ret;
 }