From: Doug Oucharek Date: Fri, 2 Sep 2016 01:15:09 +0000 (-0700) Subject: LU-7650 o2iblnd: Put back work queue check previously removed X-Git-Tag: 2.8.58~19 X-Git-Url: https://git.whamcloud.com/gitweb?a=commitdiff_plain;h=bde1da1ec098450f40887587b0a46c9eb86a4f6c;p=fs%2Flustre-release.git LU-7650 o2iblnd: Put back work queue check previously removed The previous patch, http://review.whamcloud.com/21304/, removed a check needed until LU-5718 is properly addressed. With the check, LU-5718 results in an error message and a lost RDMA operation. Without it, we have memory corruption and a crash (much harder to debug). Putting the check back in case LU-5718 is not fixed soon. Signed-off-by: Doug Oucharek Change-Id: I2efcc4e60a80794b38174da707d2a7fc27f81b6a Reviewed-on: http://review.whamcloud.com/22281 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: James Simmons Reviewed-by: Olaf Weber Reviewed-by: Oleg Drokin --- diff --git a/lnet/klnds/o2iblnd/o2iblnd_cb.c b/lnet/klnds/o2iblnd/o2iblnd_cb.c index 2a4e92a..5f13912 100644 --- a/lnet/klnds/o2iblnd/o2iblnd_cb.c +++ b/lnet/klnds/o2iblnd/o2iblnd_cb.c @@ -1094,6 +1094,17 @@ kiblnd_init_rdma(kib_conn_t *conn, kib_tx_t *tx, int type, break; } + if (tx->tx_nwrq >= IBLND_MAX_RDMA_FRAGS) { + CERROR("RDMA has too many fragments for peer %s (%d), " + "src idx/frags: %d/%d dst idx/frags: %d/%d\n", + libcfs_nid2str(conn->ibc_peer->ibp_nid), + IBLND_MAX_RDMA_FRAGS, + srcidx, srcrd->rd_nfrags, + dstidx, dstrd->rd_nfrags); + rc = -EMSGSIZE; + break; + } + wrknob = MIN(MIN(kiblnd_rd_frag_size(srcrd, srcidx), kiblnd_rd_frag_size(dstrd, dstidx)), resid);