From: Mr NeilBrown Date: Thu, 1 Dec 2022 17:53:01 +0000 (-0800) Subject: LU-16353 config: enable_foo variables mustn't contains space X-Git-Url: https://git.whamcloud.com/gitweb?a=commitdiff_plain;h=942741e9e784a26e503db6a85512cb2bc0124b5d;p=fs%2Flustre-release.git LU-16353 config: enable_foo variables mustn't contains space $enable_crypto is in some circumstances set to "embedded llcrypt" which contains a space. When the code from lustre-build.m4 then tests the value with: if test x$enablecrypto = xyes we get a syntax error from ./configure We could add quotes to this comment, but for consistency we would need to add quotes to ever other test for an enable_foo variable. It is simpler just to ensure we don't add spaces. So change the space to a hyphen. Lustre-change: https://review.whamcloud.com/49282 Lustre-commit: c8a33e5322b0675680f8d737f04259799d30aa0e Test-Parameters: trivial Signed-off-by: Mr NeilBrown Change-Id: I097e857409d6ec48a765ccda1cc470d28b90e601 Reviewed-on: https://review.whamcloud.com/c/ex/lustre-release/+/49295 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Sebastien Buisson Reviewed-by: Andreas Dilger --- diff --git a/lustre/autoconf/lustre-core.m4 b/lustre/autoconf/lustre-core.m4 index 5d61829..ae125ba 100644 --- a/lustre/autoconf/lustre-core.m4 +++ b/lustre/autoconf/lustre-core.m4 @@ -2998,7 +2998,7 @@ AS_IF([test "x$enable_crypto" = xin-kernel], [ [AS_IF([test "x$has_is_encrypted" = xyes], [ AC_DEFINE(HAVE_LUSTRE_CRYPTO, 1, [Enable Lustre client crypto via embedded llcrypt]) AC_DEFINE(CONFIG_LL_ENCRYPTION, 1, [embedded llcrypt]) - enable_crypto="embedded llcrypt" + enable_crypto="embedded-llcrypt" enable_llcrypt=yes], [ AS_IF([test "x$enable_crypto" = xyes], [AC_MSG_ERROR([Lustre client crypto cannot be enabled because of lack of encryption support in your kernel.])])