From: Sergey Cheremencev Date: Fri, 2 Feb 2024 20:07:00 +0000 (+0300) Subject: LU-17500 qmt: avoid "enforced bit set, but neither" X-Git-Tag: 2.15.62~185 X-Git-Url: https://git.whamcloud.com/gitweb?a=commitdiff_plain;h=7498e7c38dffe23752b03bf168f3b5419855b10b;p=fs%2Flustre-release.git LU-17500 qmt: avoid "enforced bit set, but neither" Don't call qmt_revalidate_qunit in qmt_set_with_lqe as it is possible that lqe_enforced bit is not cleared in case when hard and soft limits are setting to 0. No reasons to recalculate qunit and edquot when we set limits to 0. For the case when limits are changed, qunit and edquot will be calculated below in "dirtied" branch. So not reasons to do this 2 times. Patch helps to avoid following error: LustreError: 21362:0:(qmt_entry.c:746:qmt_adjust_qunit()) $$$ enforced bit set, but neither hard nor soft limit are set Signed-off-by: Sergey Cheremencev Change-Id: I8f5d9630f43b66ae7ea2be0bf2c735a02e1f6299 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53893 Reviewed-by: Oleg Drokin Reviewed-by: Andreas Dilger Reviewed-by: Hongchao Zhang Tested-by: jenkins Tested-by: Maloo --- diff --git a/lustre/quota/qmt_handler.c b/lustre/quota/qmt_handler.c index 2d38a8d..116d01d 100644 --- a/lustre/quota/qmt_handler.c +++ b/lustre/quota/qmt_handler.c @@ -212,10 +212,6 @@ int qmt_set_with_lqe(const struct lu_env *env, struct qmt_device *qmt, } quota_set: - /* recompute qunit in case it was never initialized */ - if (qmt_revalidate(env, lqe)) - need_id_notify = true; - /* clear grace time */ if (lqe->lqe_softlimit == 0 || lqe->lqe_granted <= lqe->lqe_softlimit)