From: Theodore Ts'o Date: Sat, 16 Apr 2016 00:51:36 +0000 (-0400) Subject: e2fsck: don't try to set a UUID on metadata_csum file systems X-Git-Tag: v1.43-WIP-2016-05-12~27 X-Git-Url: https://git.whamcloud.com/gitweb?a=commitdiff_plain;h=24b8916a6204e3f129b8bf84dfa275820e5e9775;p=tools%2Fe2fsprogs.git e2fsck: don't try to set a UUID on metadata_csum file systems If the UUID field is NULL, e2fsck will try to generate and set a new UUID. This will cause massive problems if the metadata_csum feature is set, so avoid doing so in that case. Signed-off-by: Theodore Ts'o --- diff --git a/e2fsck/super.c b/e2fsck/super.c index e09c14c..dec70bd 100644 --- a/e2fsck/super.c +++ b/e2fsck/super.c @@ -756,6 +756,7 @@ void check_super_block(e2fsck_t ctx) * if the id changes under the kernel remounting rw may fail. */ if (!(ctx->options & E2F_OPT_READONLY) && uuid_is_null(sb->s_uuid) && + !ext2fs_has_feature_metadata_csum(ctx->fs->super) && (!csum_flag || !(ctx->mount_flags & EXT2_MF_MOUNTED))) { if (fix_problem(ctx, PR_0_ADD_UUID, &pctx)) { uuid_generate(sb->s_uuid);