From: Darrick J. Wong <darrick.wong@oracle.com>
Date: Thu, 12 Dec 2013 18:17:58 +0000 (-0500)
Subject: libext2fs: fix a broken close() test
X-Git-Tag: v1.42.9~66
X-Git-Url: https://git.whamcloud.com/gitweb?a=commitdiff_plain;h=13b48a0ae1b4556fdddbc3742022137302498300;p=tools%2Fe2fsprogs.git

libext2fs: fix a broken close() test

Zero is a valid file descriptor, so close it.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/lib/ext2fs/mkjournal.c b/lib/ext2fs/mkjournal.c
index 09ca412..69ac135 100644
--- a/lib/ext2fs/mkjournal.c
+++ b/lib/ext2fs/mkjournal.c
@@ -595,7 +595,7 @@ errcode_t ext2fs_add_journal_inode(ext2_filsys fs, blk_t num_blocks, int flags)
 	ext2fs_mark_super_dirty(fs);
 	return 0;
 errout:
-	if (fd > 0)
+	if (fd >= 0)
 		close(fd);
 	return retval;
 }