Whamcloud - gitweb
LU-6142 lov: don't use inline for operations functions. 76/39376/2
authorMr NeilBrown <neilb@suse.de>
Wed, 15 Jul 2020 04:06:10 +0000 (14:06 +1000)
committerOleg Drokin <green@whamcloud.com>
Sat, 12 Sep 2020 15:44:27 +0000 (15:44 +0000)
These functions have their address taken and stored in an 'operations'
structure.  So they cannot possibly be compiled "inline".
So remove the "inline" declaration.

Test-Parameters: trivial
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Change-Id: Ie6712048bd40a4518adaa510dd7da0202b394c1f
Reviewed-on: https://review.whamcloud.com/39376
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Lai Siyao <lai.siyao@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/lov/lov_ea.c

index 1498c78..f07419e 100644 (file)
@@ -344,7 +344,7 @@ out_lsme:
        return ERR_PTR(rc);
 }
 
-static inline struct lov_stripe_md *
+static struct lov_stripe_md *
 lsm_unpackmd_v1(struct lov_obd *lov, void *buf, size_t buf_size)
 {
        struct lov_mds_md_v1 *lmm = buf;
@@ -353,12 +353,11 @@ lsm_unpackmd_v1(struct lov_obd *lov, void *buf, size_t buf_size)
 }
 
 const struct lsm_operations lsm_v1_ops = {
-        .lsm_unpackmd           = lsm_unpackmd_v1,
+       .lsm_unpackmd           = lsm_unpackmd_v1,
 };
 
-static inline
-struct lov_stripe_md *lsm_unpackmd_v3(struct lov_obd *lov, void *buf,
-                                     size_t buf_size)
+static struct lov_stripe_md *
+lsm_unpackmd_v3(struct lov_obd *lov, void *buf, size_t buf_size)
 {
        struct lov_mds_md_v3 *lmm = buf;
 
@@ -367,7 +366,7 @@ struct lov_stripe_md *lsm_unpackmd_v3(struct lov_obd *lov, void *buf,
 }
 
 const struct lsm_operations lsm_v3_ops = {
-       .lsm_unpackmd           = lsm_unpackmd_v3,
+       .lsm_unpackmd           = lsm_unpackmd_v3,
 };
 
 static int lsm_verify_comp_md_v1(struct lov_comp_md_v1 *lcm,