LU-17000 coverity: Fix Dereference after null under client.c

This patch fixes Dereference after null check reported
by coverity run.

CoverityID: 404748 ("Dereference after null check")

Fixes: 0f2bc318d7 ("LU-15246 ptlrpc: per-device adaptive timeout parameters")
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: Id26de5e700b0a420168b359b050d739222574bd2
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52901
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>

diff --git a/lustre/ptlrpc/client.c b/lustre/ptlrpc/client.c
index f0e1546..a1bf146 100644 (file)
--- a/lustre/ptlrpc/client.c
+++ b/lustre/ptlrpc/client.c
@@ -387,13 +387,17 @@ static void ptlrpc_at_adj_service(struct ptlrpc_request *req,
        }
 }
 
-/* Expected network latency per remote node (secs) */
+/**
+ * Returns Expected network latency per remote node (secs).
+ *
+ * \param[in] req      ptlrpc request
+ *
+ * \retval     0 if AT(Adaptive Timeout) is off
+ * \retval     >0 (iat_net_latency) latency per node
+ */
 int ptlrpc_at_get_net_latency(struct ptlrpc_request *req)
 {
-       struct obd_device *obd = NULL;
-
-       if (req->rq_import)
-               obd = req->rq_import->imp_obd;
+       struct obd_device *obd = req->rq_import->imp_obd;
 
        return obd_at_off(obd) ?
               0 : obd_at_get(obd, &req->rq_import->imp_at.iat_net_latency);