Whamcloud - gitweb
libext2fs: support devices w/ non-512 byte block size on Apple Darwin
authorFedor Uporov <thisisadrgreenthumb@gmail.com>
Sun, 19 Mar 2017 19:29:26 +0000 (22:29 +0300)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 11 Aug 2018 18:01:56 +0000 (14:01 -0400)
Signed-off-by: Fedor Uporov <thisisadrgreenthumb@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/blkid/getsize.c
lib/ext2fs/getsize.c

index 4e2835f..75f21d5 100644 (file)
@@ -78,12 +78,15 @@ blkid_loff_t blkid_get_dev_size(int fd)
        unsigned long long size64;
        blkid_loff_t high, low;
 
-#ifdef DKIOCGETBLOCKCOUNT      /* For Apple Darwin */
-       if (ioctl(fd, DKIOCGETBLOCKCOUNT, &size64) >= 0) {
+#if defined DKIOCGETBLOCKCOUNT && defined DKIOCGETBLOCKSIZE    /* For Apple Darwin */
+       unsigned int size;
+
+       if (ioctl(fd, DKIOCGETBLOCKCOUNT, &size64) >= 0 &&
+           ioctl(fd, DKIOCGETBLOCKSIZE, &size) >= 0) {
                if (sizeof(blkid_loff_t) < sizeof(unsigned long long) &&
-                   (size64 << 9) > 0xFFFFFFFF)
+                   (size64 * size) > 0xFFFFFFFF)
                        return 0; /* EFBIG */
-               return (blkid_loff_t)size64 << 9;
+               return (blkid_loff_t)size64 * size;
        }
 #endif
 
index f3839ba..be06775 100644 (file)
@@ -151,9 +151,12 @@ errcode_t ext2fs_get_device_size2(const char *file, int blocksize,
        if (fd < 0)
                return errno;
 
-#ifdef DKIOCGETBLOCKCOUNT      /* For Apple Darwin */
-       if (ioctl(fd, DKIOCGETBLOCKCOUNT, &size64) >= 0) {
-               *retblocks = size64 / (blocksize / 512);
+#if defined DKIOCGETBLOCKCOUNT && defined DKIOCGETBLOCKSIZE    /* For Apple Darwin */
+       unsigned int size;
+
+       if (ioctl(fd, DKIOCGETBLOCKCOUNT, &size64) >= 0 &&
+           ioctl(fd, DKIOCGETBLOCKSIZE, &size) >= 0) {
+               *retblocks = size64 * size / blocksize;
                goto out;
        }
 #endif