ext2fs: fix error checking in dx_link()

dx_lookup() uses errcode_t return values. As such anything non-zero is
an error, not values less than zero. Fix the error checking to avoid
crashes on corrupted filesystems.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/lib/ext2fs/link.c b/lib/ext2fs/link.c
index 6f523ae..7b5bb02 100644 (file)
--- a/lib/ext2fs/link.c
+++ b/lib/ext2fs/link.c
@@ -571,7 +571,7 @@ static errcode_t dx_link(ext2_filsys fs, ext2_ino_t dir,
        dx_info.namelen = strlen(name);
 again:
        retval = dx_lookup(fs, dir, diri, &dx_info);
-       if (retval < 0)
+       if (retval)
                goto free_buf;
 
        retval = add_dirent_to_buf(fs,