Whamcloud - gitweb
e2image: don't leak progress info to stdout
authorEric Sandeen <sandeen@redhat.com>
Fri, 15 Apr 2016 03:20:46 +0000 (22:20 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 15 Apr 2016 14:59:02 +0000 (10:59 -0400)
Commit c8ee0d60 fixed most of these, but missed this one.

# e2image -r -p <device> - > imagefile

leads to a corrupted image due to the "Scanning inodes..."
printf going to stdout.

Reported-by: Alex Markley <alex@malexmedia.net>
Addresses-Red-Hat-Bugzilla: #1327329
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
misc/e2image.c

index 82fe3e8..a32df00 100644 (file)
@@ -1282,7 +1282,7 @@ static void write_raw_image_file(ext2_filsys fs, int fd, int type, int flags)
 
        mark_table_blocks(fs);
        if (show_progress)
-               printf("%s", _("Scanning inodes...\n"));
+               fprintf(stderr, "%s", _("Scanning inodes...\n"));
 
        retval = ext2fs_open_inode_scan(fs, 0, &scan);
        if (retval) {